From: Wolfram Sang <wsa@kernel.org>
To: kernel test robot <lkp@intel.com>
Cc: Piyush Malgujar <pmalgujar@marvell.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, kbuild-all@lists.01.org,
sgarapati@marvell.com, sbalcerak@marvell.com,
cchavva@marvell.com
Subject: Re: [PATCH 1/3] drivers: i2c: thunderx: octeontx2 clock divisor logic changes
Date: Sat, 21 May 2022 13:44:35 +0200 [thread overview]
Message-ID: <YojQozzCK3Sh1Aqd@shikoro> (raw)
In-Reply-To: <202205170856.ko6UxqWi-lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 409 bytes --]
> In file included from drivers/i2c/busses/i2c-octeon-platdrv.c:27:
> >> drivers/i2c/busses/i2c-octeon-core.h:223:21: error: incomplete definition of type 'struct pci_dev'
> u32 chip_id = (pdev->subsystem_device >> 12) & 0xF;
I guess this needs some fixing?
Other than that, you should really add Robert Richter to CC when
resending. He is at least mentioned for 'Odd fixes' in MAINTAINERS.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@kernel.org>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 1/3] drivers: i2c: thunderx: octeontx2 clock divisor logic changes
Date: Sat, 21 May 2022 13:44:35 +0200 [thread overview]
Message-ID: <YojQozzCK3Sh1Aqd@shikoro> (raw)
In-Reply-To: <202205170856.ko6UxqWi-lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 419 bytes --]
> In file included from drivers/i2c/busses/i2c-octeon-platdrv.c:27:
> >> drivers/i2c/busses/i2c-octeon-core.h:223:21: error: incomplete definition of type 'struct pci_dev'
> u32 chip_id = (pdev->subsystem_device >> 12) & 0xF;
I guess this needs some fixing?
Other than that, you should really add Robert Richter to CC when
resending. He is at least mentioned for 'Odd fixes' in MAINTAINERS.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-05-21 11:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 13:36 [PATCH 0/3] drivers: i2c: thunderx: Marvell thunderx i2c changes Piyush Malgujar
2022-05-11 13:36 ` [PATCH 1/3] drivers: i2c: thunderx: octeontx2 clock divisor logic changes Piyush Malgujar
2022-05-17 1:00 ` kernel test robot
2022-05-21 11:44 ` Wolfram Sang [this message]
2022-05-21 11:44 ` Wolfram Sang
2022-05-11 13:36 ` [PATCH 2/3] drivers: i2c: thunderx: Add support for High speed mode Piyush Malgujar
2022-05-11 13:36 ` [PATCH 3/3] drivers: i2c: thunderx: Allow driver to work with ACPI defined TWSI controllers Piyush Malgujar
2022-05-21 11:40 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YojQozzCK3Sh1Aqd@shikoro \
--to=wsa@kernel.org \
--cc=cchavva@marvell.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=pmalgujar@marvell.com \
--cc=sbalcerak@marvell.com \
--cc=sgarapati@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.