From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Vinod Koul <vkoul@kernel.org>,
dmaengine@vger.kernel.org,
Milan Stevanovic <milan.stevanovic@se.com>,
Jimmy Lalande <jimmy.lalande@se.com>,
Pascal Eberhard <pascal.eberhard@se.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Herve Codina <herve.codina@bootlin.com>,
Clement Leger <clement.leger@bootlin.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2 2/2] dmaengine: dw: dmamux: Fix build without CONFIG_OF
Date: Tue, 7 Jun 2022 21:50:20 +0300 [thread overview]
Message-ID: <Yp+d7PFFUBFKXwDm@smile.fi.intel.com> (raw)
In-Reply-To: <20220607191759.7e3a2fcc@xps-13>
On Tue, Jun 07, 2022 at 07:17:59PM +0200, Miquel Raynal wrote:
> andriy.shevchenko@linux.intel.com wrote on Tue, 7 Jun 2022 19:32:47
> +0300:
> > On Tue, Jun 07, 2022 at 05:22:15PM +0200, Miquel Raynal wrote:
...
> > No, what I asked is the opposite.
>
> I don't get what you want. Can you please explain what you mean by
> "simply drop CONFIG_OF"?
The below code changes shouldn't be present in this patch, that's all.
...
> > > +#ifdef CONFIG_OF
> > > static const struct of_device_id rzn1_dmamux_match[] = {
> > > { .compatible = "renesas,rzn1-dmamux" },
> > > {}
> > > };
> > > MODULE_DEVICE_TABLE(of, rzn1_dmamux_match);
> > > +#endif
> > >
> > > static struct platform_driver rzn1_dmamux_driver = {
> > > .driver = {
> > > .name = "renesas,rzn1-dmamux",
> > > - .of_match_table = rzn1_dmamux_match,
> > > + .of_match_table = of_match_ptr(rzn1_dmamux_match),
> > > },
> > > .probe = rzn1_dmamux_probe,
> > > };
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-06-07 21:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 15:22 [PATCH v2 1/2] dmaengine: dw: dmamux: Export the module device table Miquel Raynal
2022-06-07 15:22 ` [PATCH v2 2/2] dmaengine: dw: dmamux: Fix build without CONFIG_OF Miquel Raynal
2022-06-07 16:32 ` Andy Shevchenko
2022-06-07 17:17 ` Miquel Raynal
2022-06-07 18:50 ` Andy Shevchenko [this message]
2022-06-07 22:01 ` Miquel Raynal
2022-06-07 16:33 ` [PATCH v2 1/2] dmaengine: dw: dmamux: Export the module device table Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yp+d7PFFUBFKXwDm@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=clement.leger@bootlin.com \
--cc=dmaengine@vger.kernel.org \
--cc=herve.codina@bootlin.com \
--cc=jimmy.lalande@se.com \
--cc=lkp@intel.com \
--cc=milan.stevanovic@se.com \
--cc=miquel.raynal@bootlin.com \
--cc=pascal.eberhard@se.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.