From: Qian Cai <quic_qiancai@quicinc.com> To: Vasily Averin <vvs@openvz.org> Cc: "Andrew Morton" <akpm@linux-foundation.org>, kernel@openvz.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, "Shakeel Butt" <shakeelb@google.com>, "Roman Gushchin" <roman.gushchin@linux.dev>, "Michal Koutný" <mkoutny@suse.com>, "Vlastimil Babka" <vbabka@suse.cz>, "Michal Hocko" <mhocko@suse.com>, "Florian Westphal" <fw@strlen.de>, "David S. Miller" <davem@davemloft.net>, "Jakub Kicinski" <kuba@kernel.org>, "Paolo Abeni" <pabeni@redhat.com>, "Eric Dumazet" <edumazet@google.com>, cgroups@vger.kernel.org Subject: Re: [PATCH memcg v6] net: set proper memcg for net_init hooks allocations Date: Mon, 6 Jun 2022 09:49:30 -0400 [thread overview] Message-ID: <Yp4F6n2Ie32re7Ed@qian> (raw) In-Reply-To: <f9394752-e272-9bf9-645f-a18c56d1c4ec@openvz.org> On Fri, Jun 03, 2022 at 07:19:43AM +0300, Vasily Averin wrote: > __register_pernet_operations() executes init hook of registered > pernet_operation structure in all existing net namespaces. > > Typically, these hooks are called by a process associated with > the specified net namespace, and all __GFP_ACCOUNT marked > allocation are accounted for corresponding container/memcg. > > However __register_pernet_operations() calls the hooks in the same > context, and as a result all marked allocations are accounted > to one memcg for all processed net namespaces. > > This patch adjusts active memcg for each net namespace and helps > to account memory allocated inside ops_init() into the proper memcg. > > Signed-off-by: Vasily Averin <vvs@openvz.org> > Acked-by: Roman Gushchin <roman.gushchin@linux.dev> > Acked-by: Shakeel Butt <shakeelb@google.com> > --- ... > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index 9ecead1042b9..dad16b484cd5 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -1755,6 +1755,42 @@ static inline void count_objcg_event(struct obj_cgroup *objcg, > rcu_read_unlock(); > } > > +/** > + * get_mem_cgroup_from_obj - get a memcg associated with passed kernel object. > + * @p: pointer to object from which memcg should be extracted. It can be NULL. > + * > + * Retrieves the memory group into which the memory of the pointed kernel > + * object is accounted. If memcg is found, its reference is taken. > + * If a passed kernel object is uncharged, or if proper memcg cannot be found, > + * as well as if mem_cgroup is disabled, NULL is returned. > + * > + * Return: valid memcg pointer with taken reference or NULL. > + */ > +static inline struct mem_cgroup *get_mem_cgroup_from_obj(void *p) > +{ > + struct mem_cgroup *memcg; > + > + rcu_read_lock(); > + do { > + memcg = mem_cgroup_from_obj(p); > + } while (memcg && !css_tryget(&memcg->css)); > + rcu_read_unlock(); > + return memcg; > +} ... > diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c > index 0ec2f5906a27..6b9f19122ec1 100644 > --- a/net/core/net_namespace.c > +++ b/net/core/net_namespace.c > @@ -18,6 +18,7 @@ > #include <linux/user_namespace.h> > #include <linux/net_namespace.h> > #include <linux/sched/task.h> > +#include <linux/sched/mm.h> > #include <linux/uidgid.h> > #include <linux/cookie.h> > > @@ -1143,7 +1144,13 @@ static int __register_pernet_operations(struct list_head *list, > * setup_net() and cleanup_net() are not possible. > */ > for_each_net(net) { > + struct mem_cgroup *old, *memcg; > + > + memcg = mem_cgroup_or_root(get_mem_cgroup_from_obj(net)); > + old = set_active_memcg(memcg); > error = ops_init(ops, net); > + set_active_memcg(old); > + mem_cgroup_put(memcg); > if (error) > goto out_undo; > list_add_tail(&net->exit_list, &net_exit_list); > -- > 2.36.1 This triggers a few boot warnings like those. virt_to_phys used for non-linear address: ffffd8efe2d2fe00 (init_net) WARNING: CPU: 87 PID: 3170 at arch/arm64/mm/physaddr.c:12 __virt_to_phys CPU: 87 PID: 3170 Comm: modprobe Tainted: G B W 5.19.0-rc1-next-20220606 #138 pstate: 60400009 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) pc : __virt_to_phys lr : __virt_to_phys sp : ffff800051cc76b0 x29: ffff800051cc76b0 x28: ffffd8efb5ba6ab8 x27: ffffd8efb5ba6b2c x26: ffffd8efb1bccb20 x25: ffffd8efbaaf8200 x24: ffff800051cc77f0 x23: ffffd8efb744a000 x22: ffffd8efbb1bc000 x21: 0000600000000000 x20: 0000d8efe2d2fe00 x19: ffffd8efe2d2fe00 x18: 0000000000000443 x17: 0000000000000000 x16: 0000000000000002 x15: ffffd8efb9db2000 x14: 0000000000000001 x13: 0000000000000000 x12: ffff6806c88f8986 x11: 1fffe806c88f8985 x10: ffff6806c88f8985 x9 : dfff800000000000 x8 : ffff4036447c4c2b x7 : 0000000000000001 x6 : ffff6806c88f8985 x5 : ffff4036447c4c28 x4 : ffff6806c88f8986 x3 : ffffd8efb34b3850 x2 : 0000000000000000 x1 : 0000000000000000 x0 : ffff400335f99a80 Call trace: __virt_to_phys mem_cgroup_from_obj __register_pernet_operations register_pernet_operations register_pernet_subsys nfnetlink_init [nfnetlink] load_module __do_sys_finit_module __arm64_sys_finit_module invoke_syscall el0_svc_common.constprop.0 do_el0_svc el0_svc el0t_64_sync_handler el0t_64_sync irq event stamp: 0 hardirqs last enabled at (0): 0x0 hardirqs last disabled at (0): copy_process softirqs last enabled at (0): copy_process softirqs last disabled at (0): 0x0 virt_to_phys used for non-linear address: ffffd8efe2d2fe00 (init_net) WARNING: CPU: 156 PID: 3176 at arch/arm64/mm/physaddr.c:12 __virt_to_phys CPU: 156 PID: 3176 Comm: modprobe Tainted: G B W 5.19.0-rc1-next-20220606 #138 pstate: 60400009 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) pc : __virt_to_phys lr : __virt_to_phys sp : ffff800051b376e0 x29: ffff800051b376e0 x28: ffffd8efb5ba6ab8 x27: ffffd8efb5ba6b2c x26: ffffd8efb286e910 x25: ffffd8efbaaf8200 x24: ffff800051b37820 x23: ffffd8efb744a000 x22: ffffd8efbb1bc000 x21: 0000600000000000 x20: 0000d8efe2d2fe00 x19: ffffd8efe2d2fe00 x18: 00000000000001cb x17: 0000000000000000 x16: 0000000000000002 x15: ffffd8efb9db2000 x14: 0000000000000001 x13: 0000000000000000 x12: ffff6806c8a03f86 x8 : ffff40364501fc2b x7 : 0000000000000001 x6 : ffff6806c8a03f85 x5 : ffff40364501fc28 x4 : ffff6806c8a03f86 x3 : ffffd8efb34b3850 x2 : 0000000000000000 x1 : 0000000000000000 x0 : ffff40033376b4c0 Call trace: __virt_to_phys mem_cgroup_from_obj __register_pernet_operations register_pernet_operations register_pernet_subsys nf_tables_module_init [nf_tables] do_one_initcall do_init_module load_module __do_sys_finit_module __arm64_sys_finit_module invoke_syscall el0_svc_common.constprop.0 do_el0_svc el0_svc el0t_64_sync_handler el0t_64_sync irq event stamp: 0 hardirqs last enabled at (0): 0x0 hardirqs last disabled at (0): copy_process softirqs last enabled at (0): copy_process softirqs last disabled at (0): 0x0
WARNING: multiple messages have this Message-ID (diff)
From: Qian Cai <quic_qiancai-jfJNa2p1gH1BDgjK7y7TUQ@public.gmane.org> To: Vasily Averin <vvs-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org> Cc: "Andrew Morton" <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>, kernel-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, "Shakeel Butt" <shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>, "Roman Gushchin" <roman.gushchin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org>, "Michal Koutný" <mkoutny-IBi9RG/b67k@public.gmane.org>, "Vlastimil Babka" <vbabka-AlSwsSmVLrQ@public.gmane.org>, "Michal Hocko" <mhocko-IBi9RG/b67k@public.gmane.org>, "Florian Westphal" <fw-HFFVJYpyMKqzQB+pC5nmwQ@public.gmane.org>, "David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>, "Jakub Kicinski" <kuba-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, "Paolo Abeni" <pabeni-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, "Eric Dumazet" <edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH memcg v6] net: set proper memcg for net_init hooks allocations Date: Mon, 6 Jun 2022 09:49:30 -0400 [thread overview] Message-ID: <Yp4F6n2Ie32re7Ed@qian> (raw) In-Reply-To: <f9394752-e272-9bf9-645f-a18c56d1c4ec-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org> On Fri, Jun 03, 2022 at 07:19:43AM +0300, Vasily Averin wrote: > __register_pernet_operations() executes init hook of registered > pernet_operation structure in all existing net namespaces. > > Typically, these hooks are called by a process associated with > the specified net namespace, and all __GFP_ACCOUNT marked > allocation are accounted for corresponding container/memcg. > > However __register_pernet_operations() calls the hooks in the same > context, and as a result all marked allocations are accounted > to one memcg for all processed net namespaces. > > This patch adjusts active memcg for each net namespace and helps > to account memory allocated inside ops_init() into the proper memcg. > > Signed-off-by: Vasily Averin <vvs-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org> > Acked-by: Roman Gushchin <roman.gushchin-fxUVXftIFDnyG1zEObXtfA@public.gmane.org> > Acked-by: Shakeel Butt <shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> > --- ... > diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h > index 9ecead1042b9..dad16b484cd5 100644 > --- a/include/linux/memcontrol.h > +++ b/include/linux/memcontrol.h > @@ -1755,6 +1755,42 @@ static inline void count_objcg_event(struct obj_cgroup *objcg, > rcu_read_unlock(); > } > > +/** > + * get_mem_cgroup_from_obj - get a memcg associated with passed kernel object. > + * @p: pointer to object from which memcg should be extracted. It can be NULL. > + * > + * Retrieves the memory group into which the memory of the pointed kernel > + * object is accounted. If memcg is found, its reference is taken. > + * If a passed kernel object is uncharged, or if proper memcg cannot be found, > + * as well as if mem_cgroup is disabled, NULL is returned. > + * > + * Return: valid memcg pointer with taken reference or NULL. > + */ > +static inline struct mem_cgroup *get_mem_cgroup_from_obj(void *p) > +{ > + struct mem_cgroup *memcg; > + > + rcu_read_lock(); > + do { > + memcg = mem_cgroup_from_obj(p); > + } while (memcg && !css_tryget(&memcg->css)); > + rcu_read_unlock(); > + return memcg; > +} ... > diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c > index 0ec2f5906a27..6b9f19122ec1 100644 > --- a/net/core/net_namespace.c > +++ b/net/core/net_namespace.c > @@ -18,6 +18,7 @@ > #include <linux/user_namespace.h> > #include <linux/net_namespace.h> > #include <linux/sched/task.h> > +#include <linux/sched/mm.h> > #include <linux/uidgid.h> > #include <linux/cookie.h> > > @@ -1143,7 +1144,13 @@ static int __register_pernet_operations(struct list_head *list, > * setup_net() and cleanup_net() are not possible. > */ > for_each_net(net) { > + struct mem_cgroup *old, *memcg; > + > + memcg = mem_cgroup_or_root(get_mem_cgroup_from_obj(net)); > + old = set_active_memcg(memcg); > error = ops_init(ops, net); > + set_active_memcg(old); > + mem_cgroup_put(memcg); > if (error) > goto out_undo; > list_add_tail(&net->exit_list, &net_exit_list); > -- > 2.36.1 This triggers a few boot warnings like those. virt_to_phys used for non-linear address: ffffd8efe2d2fe00 (init_net) WARNING: CPU: 87 PID: 3170 at arch/arm64/mm/physaddr.c:12 __virt_to_phys CPU: 87 PID: 3170 Comm: modprobe Tainted: G B W 5.19.0-rc1-next-20220606 #138 pstate: 60400009 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) pc : __virt_to_phys lr : __virt_to_phys sp : ffff800051cc76b0 x29: ffff800051cc76b0 x28: ffffd8efb5ba6ab8 x27: ffffd8efb5ba6b2c x26: ffffd8efb1bccb20 x25: ffffd8efbaaf8200 x24: ffff800051cc77f0 x23: ffffd8efb744a000 x22: ffffd8efbb1bc000 x21: 0000600000000000 x20: 0000d8efe2d2fe00 x19: ffffd8efe2d2fe00 x18: 0000000000000443 x17: 0000000000000000 x16: 0000000000000002 x15: ffffd8efb9db2000 x14: 0000000000000001 x13: 0000000000000000 x12: ffff6806c88f8986 x11: 1fffe806c88f8985 x10: ffff6806c88f8985 x9 : dfff800000000000 x8 : ffff4036447c4c2b x7 : 0000000000000001 x6 : ffff6806c88f8985 x5 : ffff4036447c4c28 x4 : ffff6806c88f8986 x3 : ffffd8efb34b3850 x2 : 0000000000000000 x1 : 0000000000000000 x0 : ffff400335f99a80 Call trace: __virt_to_phys mem_cgroup_from_obj __register_pernet_operations register_pernet_operations register_pernet_subsys nfnetlink_init [nfnetlink] load_module __do_sys_finit_module __arm64_sys_finit_module invoke_syscall el0_svc_common.constprop.0 do_el0_svc el0_svc el0t_64_sync_handler el0t_64_sync irq event stamp: 0 hardirqs last enabled at (0): 0x0 hardirqs last disabled at (0): copy_process softirqs last enabled at (0): copy_process softirqs last disabled at (0): 0x0 virt_to_phys used for non-linear address: ffffd8efe2d2fe00 (init_net) WARNING: CPU: 156 PID: 3176 at arch/arm64/mm/physaddr.c:12 __virt_to_phys CPU: 156 PID: 3176 Comm: modprobe Tainted: G B W 5.19.0-rc1-next-20220606 #138 pstate: 60400009 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) pc : __virt_to_phys lr : __virt_to_phys sp : ffff800051b376e0 x29: ffff800051b376e0 x28: ffffd8efb5ba6ab8 x27: ffffd8efb5ba6b2c x26: ffffd8efb286e910 x25: ffffd8efbaaf8200 x24: ffff800051b37820 x23: ffffd8efb744a000 x22: ffffd8efbb1bc000 x21: 0000600000000000 x20: 0000d8efe2d2fe00 x19: ffffd8efe2d2fe00 x18: 00000000000001cb x17: 0000000000000000 x16: 0000000000000002 x15: ffffd8efb9db2000 x14: 0000000000000001 x13: 0000000000000000 x12: ffff6806c8a03f86 x8 : ffff40364501fc2b x7 : 0000000000000001 x6 : ffff6806c8a03f85 x5 : ffff40364501fc28 x4 : ffff6806c8a03f86 x3 : ffffd8efb34b3850 x2 : 0000000000000000 x1 : 0000000000000000 x0 : ffff40033376b4c0 Call trace: __virt_to_phys mem_cgroup_from_obj __register_pernet_operations register_pernet_operations register_pernet_subsys nf_tables_module_init [nf_tables] do_one_initcall do_init_module load_module __do_sys_finit_module __arm64_sys_finit_module invoke_syscall el0_svc_common.constprop.0 do_el0_svc el0_svc el0t_64_sync_handler el0t_64_sync irq event stamp: 0 hardirqs last enabled at (0): 0x0 hardirqs last disabled at (0): copy_process softirqs last enabled at (0): copy_process softirqs last disabled at (0): 0x0
next prev parent reply other threads:[~2022-06-06 13:49 UTC|newest] Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-02-28 7:17 [PATCH RFC] net: memcg accounting for veth devices Vasily Averin 2022-02-28 14:36 ` Luis Chamberlain 2022-03-01 18:09 ` Shakeel Butt 2022-03-01 18:28 ` Luis Chamberlain 2022-03-01 20:50 ` Eric W. Biederman 2022-03-01 21:25 ` Luis Chamberlain 2022-03-01 21:31 ` Luis Chamberlain 2022-03-02 14:43 ` Eric W. Biederman 2022-03-02 21:52 ` Luis Chamberlain 2022-03-02 13:30 ` King, Colin 2022-04-11 9:40 ` problem with accounting of allocations called from __net_init hooks Vasily Averin 2022-04-17 6:39 ` [PATCH memcg RFC] net: set proper memcg for net_init hooks allocations Vasily Averin 2022-04-21 15:56 ` Shakeel Butt 2022-04-22 20:01 ` Vasily Averin 2022-04-22 20:09 ` Vasily Averin 2022-04-22 20:22 ` Shakeel Butt 2022-04-23 7:56 ` [PATCH] " Vasily Averin 2022-04-23 7:56 ` Vasily Averin 2022-04-23 9:39 ` kernel test robot 2022-04-23 9:39 ` kernel test robot 2022-04-23 9:39 ` kernel test robot 2022-04-23 9:39 ` kernel test robot 2022-04-23 10:31 ` kernel test robot 2022-04-23 15:38 ` [PATCH memcg v2] " Vasily Averin 2022-04-24 14:46 ` [net] 3b379e5391: BUG:kernel_NULL_pointer_dereference,address kernel test robot 2022-04-24 14:46 ` kernel test robot 2022-04-25 10:56 ` [PATCH memcg v3] net: set proper memcg for net_init hooks allocations Vasily Averin 2022-04-25 10:56 ` Vasily Averin 2022-04-26 2:50 ` Roman Gushchin 2022-04-26 5:58 ` Vasily Averin 2022-04-26 5:58 ` Vasily Averin 2022-04-26 6:43 ` [PATCH memcg v4] " Vasily Averin 2022-04-26 22:13 ` Roman Gushchin 2022-04-26 22:13 ` Roman Gushchin 2022-04-27 5:23 ` Shakeel Butt 2022-04-27 12:22 ` Michal Koutný 2022-04-27 12:22 ` Michal Koutný 2022-04-27 15:06 ` Shakeel Butt 2022-04-27 15:06 ` Shakeel Butt 2022-04-27 22:16 ` Vasily Averin 2022-04-27 22:16 ` Vasily Averin 2022-04-27 22:36 ` Roman Gushchin 2022-04-28 4:37 ` Vasily Averin 2022-04-28 4:37 ` Vasily Averin 2022-04-27 22:47 ` Shakeel Butt 2022-04-27 22:47 ` Shakeel Butt 2022-05-01 13:44 ` Vasily Averin 2022-05-01 13:44 ` Vasily Averin 2022-05-01 21:09 ` Roman Gushchin 2022-05-01 21:09 ` Roman Gushchin 2022-05-02 0:10 ` [PATCH memcg v5] " Vasily Averin 2022-05-30 8:57 ` Vasily Averin 2022-05-30 8:57 ` Vasily Averin 2022-06-03 4:19 ` [PATCH memcg v6] " Vasily Averin 2022-06-03 4:19 ` Vasily Averin 2022-06-06 13:49 ` Qian Cai [this message] 2022-06-06 13:49 ` Qian Cai 2022-06-06 17:37 ` Vasily Averin 2022-06-06 18:43 ` Qian Cai 2022-06-06 18:43 ` Qian Cai 2022-06-06 18:45 ` Vasily Averin 2022-06-06 18:45 ` Vasily Averin 2022-06-07 5:58 ` Shakeel Butt 2022-06-07 5:58 ` Shakeel Butt 2022-06-07 12:37 ` Vasily Averin 2022-06-07 12:37 ` Vasily Averin 2022-06-07 14:10 ` Shakeel Butt 2022-06-07 14:10 ` Shakeel Butt 2022-09-18 9:28 ` [sparc64] fails to boot, (was: Re: [PATCH memcg v6] net: set proper memcg for net_init hooks allocations) Anatoly Pugachev 2022-09-21 14:41 ` Anatoly Pugachev 2022-09-21 14:44 ` Anatoly Pugachev 2022-09-21 14:44 ` Anatoly Pugachev 2022-09-21 17:02 ` Michal Koutný 2022-09-21 17:02 ` Michal Koutný 2022-09-26 13:06 ` Anatoly Pugachev 2022-09-26 13:06 ` Anatoly Pugachev 2022-09-26 17:28 ` Jakub Kicinski 2022-09-26 17:28 ` Jakub Kicinski 2022-09-26 17:32 ` Shakeel Butt 2022-09-26 17:32 ` Shakeel Butt 2022-09-26 17:36 ` Andrew Morton 2022-09-26 17:36 ` Andrew Morton 2022-09-26 19:00 ` Shakeel Butt 2022-09-27 9:54 ` Vlastimil Babka 2022-09-27 9:54 ` Vlastimil Babka 2022-09-28 7:54 ` Thorsten Leemhuis 2022-09-28 7:21 ` [sparc64] fails to boot, (was: Re: [PATCH memcg v6] net: set proper memcg for net_init hooks allocations) #forregzbot Thorsten Leemhuis
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Yp4F6n2Ie32re7Ed@qian \ --to=quic_qiancai@quicinc.com \ --cc=akpm@linux-foundation.org \ --cc=cgroups@vger.kernel.org \ --cc=davem@davemloft.net \ --cc=edumazet@google.com \ --cc=fw@strlen.de \ --cc=kernel@openvz.org \ --cc=kuba@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mhocko@suse.com \ --cc=mkoutny@suse.com \ --cc=pabeni@redhat.com \ --cc=roman.gushchin@linux.dev \ --cc=shakeelb@google.com \ --cc=vbabka@suse.cz \ --cc=vvs@openvz.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.