From: Bjorn Andersson <bjorn.andersson@linaro.org> To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Cc: Andy Gross <agross@kernel.org>, Vinod Koul <vkoul@kernel.org>, Kishon Vijay Abraham I <kishon@ti.com>, Philipp Zabel <p.zabel@pengutronix.de>, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org Subject: Re: [RFC PATCH v3 00/30] phy: qcom-qmp: split the QMP PHY driver Date: Mon, 6 Jun 2022 13:56:36 -0700 [thread overview] Message-ID: <Yp5qBJUh3T/qTne0@ripper> (raw) In-Reply-To: <20220602070909.1666068-1-dmitry.baryshkov@linaro.org> On Thu 02 Jun 00:08 PDT 2022, Dmitry Baryshkov wrote: > While adding support for the PCIe EP mode support to the QMP driver I > couldn't help but notice that the QMP PHY driver has slowly become the a > beast with tons of conditions and corner cases being inserted here and > there.r > > This an RFC for an attempt to to cleanup the QMP driver by splitting the > QMP PHY driver into five smaller drivers, each targeting a particular > family of PHY backends (DP/combo, PCIe, UFS, USB and a separate driver > for the MSM8996 PCIe PHY). Yes, this results in some code duplication, > but I hope that the end result is still better than the current > situation. > With the MODULE_DEVICE_TABLE of the combo PHY corrected, this looks good to me. Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org> Tested-by: Bjorn Andersson <bjorn.andersson@linaro.org> # UFS, PCIe and USB on SC8180X Regards, Bjorn > Changes since RFC v2: > - After dicussion with Vinod, revert back to the approach from RFC v1: > copy the source and clean it up rather than creating new drivers from > the blank space. This lowers the risc of breaking any of the platforms. > - Drop common phy-qcom-qmp-lib.c for now. The goal of this patchseries > is to be merged early during the development cycle to unblock further > QMP driver development. Additional cleanups and code unification can > come up later. > > Changes since RFC v1: > - Split the patchset to be able to get through the email size > limitations > - Minor correcions to the split drivers > > Dmitry Baryshkov (30): > phy: qcom-qmp: create copies of QMP PHY driver > phy: qcom-qmp-combo: drop all non-combo compatibles support > phy: qcom-qmp-pcie: drop all non-PCIe compatibles support > phy: qcom-qmp-pcie-msm8996: drop all compatibles except > msm8996-pcie-phy > phy: qcom-qmp-ufs: drop all non-UFS compatibles support > phy: qcom-qmp-usb: drop all non-USB compatibles support > phy: qcom-qmp-combo: change symbol prefix to qcom_qmp_phy_combo > phy: qcom-qmp-pcie: change symbol prefix to qcom_qmp_phy_pcie > phy: qcom-qmp-pcie: change symbol prefix to qcom_qmp_phy_pcie_msm8996 > phy: qcom-qmp-ufs: change symbol prefix to qcom_qmp_phy_ufs > phy: qcom-qmp-usb: change symbol prefix to qcom_qmp_phy_usb > phy: qcom-qmp: switch to new split QMP PHY driver > phy: qcom-qmp: drop old QMP PHY driver source > phy: qcom-qmp-combo: drop support for PCIe,UFS PHY types > phy: qcom-qmp-pcie: drop support for non-PCIe PHY types > phy: qcom-qmp-pcie-msm8996: drop support for non-PCIe PHY types > phy: qcom-qmp-ufs: drop support for non-UFS PHY types > phy: qcom-qmp-usb: drop support for non-USB PHY types > phy: qcom-qmp-combo: cleanup the driver > phy: qcom-qmp-pcie: cleanup the driver > phy: qcom-qmp-pcie-msm8996: cleanup the driver > phy: qcom-qmp-ufs: cleanup the driver > phy: qcom-qmp-usb: cleanup the driver > phy: qcom-qmp-pcie: drop multi-PHY support > phy: qcom-qmp-ufs: drop multi-PHY support > phy: qcom-qmp-usb: drop multi-PHY support > phy: qcom-qmp-combo: use bulk reset_control API > phy: qcom-qmp-pcie: use bulk reset_control API > phy: qcom-qmp-pcie-msm8996: use bulk reset_control API > phy: qcom-qmp-usb: use bulk reset_control API > > drivers/phy/qualcomm/Makefile | 8 +- > drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 2579 +++++++ > .../phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c | 1081 +++ > drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 2404 +++++++ > drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 1390 ++++ > drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 2751 +++++++ > drivers/phy/qualcomm/phy-qcom-qmp.c | 6350 ----------------- > 7 files changed, 10212 insertions(+), 6351 deletions(-) > create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-combo.c > create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c > create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-pcie.c > create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-ufs.c > create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-usb.c > delete mode 100644 drivers/phy/qualcomm/phy-qcom-qmp.c > > -- > 2.35.1 > -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <bjorn.andersson@linaro.org> To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Cc: Andy Gross <agross@kernel.org>, Vinod Koul <vkoul@kernel.org>, Kishon Vijay Abraham I <kishon@ti.com>, Philipp Zabel <p.zabel@pengutronix.de>, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org Subject: Re: [RFC PATCH v3 00/30] phy: qcom-qmp: split the QMP PHY driver Date: Mon, 6 Jun 2022 13:56:36 -0700 [thread overview] Message-ID: <Yp5qBJUh3T/qTne0@ripper> (raw) In-Reply-To: <20220602070909.1666068-1-dmitry.baryshkov@linaro.org> On Thu 02 Jun 00:08 PDT 2022, Dmitry Baryshkov wrote: > While adding support for the PCIe EP mode support to the QMP driver I > couldn't help but notice that the QMP PHY driver has slowly become the a > beast with tons of conditions and corner cases being inserted here and > there.r > > This an RFC for an attempt to to cleanup the QMP driver by splitting the > QMP PHY driver into five smaller drivers, each targeting a particular > family of PHY backends (DP/combo, PCIe, UFS, USB and a separate driver > for the MSM8996 PCIe PHY). Yes, this results in some code duplication, > but I hope that the end result is still better than the current > situation. > With the MODULE_DEVICE_TABLE of the combo PHY corrected, this looks good to me. Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org> Tested-by: Bjorn Andersson <bjorn.andersson@linaro.org> # UFS, PCIe and USB on SC8180X Regards, Bjorn > Changes since RFC v2: > - After dicussion with Vinod, revert back to the approach from RFC v1: > copy the source and clean it up rather than creating new drivers from > the blank space. This lowers the risc of breaking any of the platforms. > - Drop common phy-qcom-qmp-lib.c for now. The goal of this patchseries > is to be merged early during the development cycle to unblock further > QMP driver development. Additional cleanups and code unification can > come up later. > > Changes since RFC v1: > - Split the patchset to be able to get through the email size > limitations > - Minor correcions to the split drivers > > Dmitry Baryshkov (30): > phy: qcom-qmp: create copies of QMP PHY driver > phy: qcom-qmp-combo: drop all non-combo compatibles support > phy: qcom-qmp-pcie: drop all non-PCIe compatibles support > phy: qcom-qmp-pcie-msm8996: drop all compatibles except > msm8996-pcie-phy > phy: qcom-qmp-ufs: drop all non-UFS compatibles support > phy: qcom-qmp-usb: drop all non-USB compatibles support > phy: qcom-qmp-combo: change symbol prefix to qcom_qmp_phy_combo > phy: qcom-qmp-pcie: change symbol prefix to qcom_qmp_phy_pcie > phy: qcom-qmp-pcie: change symbol prefix to qcom_qmp_phy_pcie_msm8996 > phy: qcom-qmp-ufs: change symbol prefix to qcom_qmp_phy_ufs > phy: qcom-qmp-usb: change symbol prefix to qcom_qmp_phy_usb > phy: qcom-qmp: switch to new split QMP PHY driver > phy: qcom-qmp: drop old QMP PHY driver source > phy: qcom-qmp-combo: drop support for PCIe,UFS PHY types > phy: qcom-qmp-pcie: drop support for non-PCIe PHY types > phy: qcom-qmp-pcie-msm8996: drop support for non-PCIe PHY types > phy: qcom-qmp-ufs: drop support for non-UFS PHY types > phy: qcom-qmp-usb: drop support for non-USB PHY types > phy: qcom-qmp-combo: cleanup the driver > phy: qcom-qmp-pcie: cleanup the driver > phy: qcom-qmp-pcie-msm8996: cleanup the driver > phy: qcom-qmp-ufs: cleanup the driver > phy: qcom-qmp-usb: cleanup the driver > phy: qcom-qmp-pcie: drop multi-PHY support > phy: qcom-qmp-ufs: drop multi-PHY support > phy: qcom-qmp-usb: drop multi-PHY support > phy: qcom-qmp-combo: use bulk reset_control API > phy: qcom-qmp-pcie: use bulk reset_control API > phy: qcom-qmp-pcie-msm8996: use bulk reset_control API > phy: qcom-qmp-usb: use bulk reset_control API > > drivers/phy/qualcomm/Makefile | 8 +- > drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 2579 +++++++ > .../phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c | 1081 +++ > drivers/phy/qualcomm/phy-qcom-qmp-pcie.c | 2404 +++++++ > drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 1390 ++++ > drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 2751 +++++++ > drivers/phy/qualcomm/phy-qcom-qmp.c | 6350 ----------------- > 7 files changed, 10212 insertions(+), 6351 deletions(-) > create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-combo.c > create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c > create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-pcie.c > create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-ufs.c > create mode 100644 drivers/phy/qualcomm/phy-qcom-qmp-usb.c > delete mode 100644 drivers/phy/qualcomm/phy-qcom-qmp.c > > -- > 2.35.1 >
next prev parent reply other threads:[~2022-06-06 20:54 UTC|newest] Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-02 7:08 [RFC PATCH v3 00/30] phy: qcom-qmp: split the QMP PHY driver Dmitry Baryshkov 2022-06-02 7:08 ` Dmitry Baryshkov 2022-06-02 7:08 ` [RFC PATCH v3 01/30] phy: qcom-qmp: create copies of " Dmitry Baryshkov 2022-06-02 7:08 ` Dmitry Baryshkov 2022-06-02 7:08 ` [RFC PATCH v3 02/30] phy: qcom-qmp-combo: drop all non-combo compatibles support Dmitry Baryshkov 2022-06-06 13:54 ` Bjorn Andersson 2022-06-06 13:54 ` Bjorn Andersson 2022-06-06 14:19 ` Dmitry Baryshkov 2022-06-06 14:19 ` Dmitry Baryshkov 2022-06-06 20:55 ` Bjorn Andersson 2022-06-06 20:55 ` Bjorn Andersson 2022-06-02 7:08 ` [RFC PATCH v3 03/30] phy: qcom-qmp-pcie: drop all non-PCIe " Dmitry Baryshkov 2022-06-02 7:08 ` [RFC PATCH v3 04/30] phy: qcom-qmp-pcie-msm8996: drop all compatibles except msm8996-pcie-phy Dmitry Baryshkov 2022-06-02 7:08 ` [RFC PATCH v3 05/30] phy: qcom-qmp-ufs: drop all non-UFS compatibles support Dmitry Baryshkov 2022-06-02 7:08 ` [RFC PATCH v3 06/30] phy: qcom-qmp-usb: drop all non-USB " Dmitry Baryshkov 2022-06-02 7:08 ` [RFC PATCH v3 07/30] phy: qcom-qmp-combo: change symbol prefix to qcom_qmp_phy_combo Dmitry Baryshkov 2022-06-02 7:08 ` Dmitry Baryshkov 2022-06-02 7:08 ` [RFC PATCH v3 08/30] phy: qcom-qmp-pcie: change symbol prefix to qcom_qmp_phy_pcie Dmitry Baryshkov 2022-06-02 7:08 ` Dmitry Baryshkov 2022-06-02 7:08 ` [RFC PATCH v3 09/30] phy: qcom-qmp-pcie: change symbol prefix to qcom_qmp_phy_pcie_msm8996 Dmitry Baryshkov 2022-06-02 7:08 ` Dmitry Baryshkov 2022-06-02 7:08 ` [RFC PATCH v3 10/30] phy: qcom-qmp-ufs: change symbol prefix to qcom_qmp_phy_ufs Dmitry Baryshkov 2022-06-02 7:08 ` Dmitry Baryshkov 2022-06-02 7:08 ` [RFC PATCH v3 11/30] phy: qcom-qmp-usb: change symbol prefix to qcom_qmp_phy_usb Dmitry Baryshkov 2022-06-02 7:08 ` Dmitry Baryshkov 2022-06-02 7:08 ` [RFC PATCH v3 12/30] phy: qcom-qmp: switch to new split QMP PHY driver Dmitry Baryshkov 2022-06-02 7:08 ` Dmitry Baryshkov 2022-06-02 7:08 ` [RFC PATCH v3 13/30] phy: qcom-qmp: drop old QMP PHY driver source Dmitry Baryshkov 2022-06-02 7:08 ` [RFC PATCH v3 14/30] phy: qcom-qmp-combo: drop support for PCIe,UFS PHY types Dmitry Baryshkov 2022-06-02 7:08 ` Dmitry Baryshkov 2022-06-02 7:08 ` [RFC PATCH v3 15/30] phy: qcom-qmp-pcie: drop support for non-PCIe " Dmitry Baryshkov 2022-06-02 7:08 ` Dmitry Baryshkov 2022-06-02 7:08 ` [RFC PATCH v3 16/30] phy: qcom-qmp-pcie-msm8996: " Dmitry Baryshkov 2022-06-02 7:08 ` Dmitry Baryshkov 2022-06-02 7:08 ` [RFC PATCH v3 17/30] phy: qcom-qmp-ufs: drop support for non-UFS " Dmitry Baryshkov 2022-06-02 7:08 ` Dmitry Baryshkov 2022-06-02 7:08 ` [RFC PATCH v3 18/30] phy: qcom-qmp-usb: drop support for non-USB " Dmitry Baryshkov 2022-06-02 7:08 ` Dmitry Baryshkov 2022-06-02 7:08 ` [RFC PATCH v3 19/30] phy: qcom-qmp-combo: cleanup the driver Dmitry Baryshkov 2022-06-02 7:08 ` Dmitry Baryshkov 2022-06-02 7:08 ` [RFC PATCH v3 20/30] phy: qcom-qmp-pcie: " Dmitry Baryshkov 2022-06-02 7:08 ` Dmitry Baryshkov 2022-06-02 7:09 ` [RFC PATCH v3 21/30] phy: qcom-qmp-pcie-msm8996: " Dmitry Baryshkov 2022-06-02 7:09 ` Dmitry Baryshkov 2022-06-02 7:09 ` [RFC PATCH v3 22/30] phy: qcom-qmp-ufs: " Dmitry Baryshkov 2022-06-02 7:09 ` Dmitry Baryshkov 2022-06-02 7:09 ` [RFC PATCH v3 23/30] phy: qcom-qmp-usb: " Dmitry Baryshkov 2022-06-02 7:09 ` Dmitry Baryshkov 2022-06-02 7:09 ` [RFC PATCH v3 24/30] phy: qcom-qmp-pcie: drop multi-PHY support Dmitry Baryshkov 2022-06-02 7:09 ` Dmitry Baryshkov 2022-06-02 7:09 ` [RFC PATCH v3 25/30] phy: qcom-qmp-ufs: " Dmitry Baryshkov 2022-06-02 7:09 ` Dmitry Baryshkov 2022-06-02 7:09 ` [RFC PATCH v3 26/30] phy: qcom-qmp-usb: " Dmitry Baryshkov 2022-06-02 7:09 ` Dmitry Baryshkov 2022-06-02 7:09 ` [RFC PATCH v3 27/30] phy: qcom-qmp-combo: use bulk reset_control API Dmitry Baryshkov 2022-06-02 7:09 ` Dmitry Baryshkov 2022-06-02 7:09 ` [RFC PATCH v3 28/30] phy: qcom-qmp-pcie: " Dmitry Baryshkov 2022-06-02 7:09 ` Dmitry Baryshkov 2022-06-02 7:09 ` [RFC PATCH v3 29/30] phy: qcom-qmp-pcie-msm8996: " Dmitry Baryshkov 2022-06-02 7:09 ` Dmitry Baryshkov 2022-06-02 7:09 ` [RFC PATCH v3 30/30] phy: qcom-qmp-usb: " Dmitry Baryshkov 2022-06-02 7:09 ` Dmitry Baryshkov 2022-06-06 20:56 ` Bjorn Andersson [this message] 2022-06-06 20:56 ` [RFC PATCH v3 00/30] phy: qcom-qmp: split the QMP PHY driver Bjorn Andersson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Yp5qBJUh3T/qTne0@ripper \ --to=bjorn.andersson@linaro.org \ --cc=agross@kernel.org \ --cc=dmitry.baryshkov@linaro.org \ --cc=kishon@ti.com \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-phy@lists.infradead.org \ --cc=p.zabel@pengutronix.de \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.