From: Catalin Marinas <catalin.marinas@arm.com>
To: Peter Xu <peterx@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Will Deacon <will@kernel.org>, Matt Turner <mattst88@gmail.com>,
linux-s390@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Brian Cain <bcain@quicinc.com>, Borislav Petkov <bp@alien8.de>,
linux-alpha@vger.kernel.org, Alistair Popple <apopple@nvidia.com>,
Jonas Bonn <jonas@southpole.se>,
linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org,
Michael Ellerman <mpe@ellerman.id.au>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
linux-snps-arc@lists.infradead.org,
Vineet Gupta <vgupta@kernel.org>,
Vasily Gorbik <gor@linux.ibm.com>,
Vlastimil Babka <vbabka@suse.cz>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Rich Felker <dalias@libc.org>,
sparclinux@vger.kernel.org, Russell King <linux@armlinux.org.uk>,
David Hildenbrand <david@redhat.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Nicholas Piggin <npiggin@gmail.com>,
"James E . J . Bottomley" <James.Bottomley@hansenpartnership.com>,
linux-xtensa@linux-xtensa.org, linux-sh@vger.kernel.org,
Paul Walmsley <paul.walmsley@sifive.com>,
linux-m68k@lists.linux-m68k.org, linuxppc-dev@lists.ozlabs.org,
Richard Henderson <rth@twiddle.net>, Guo Ren <guoren@kernel.org>,
linux-parisc@vger.kernel.org,
Andrea Arcangeli <aarcange@redhat.com>,
Helge Deller <deller@gmx.de>, Al Viro <viro@zeniv.linux.org.uk>,
Albert Ou <aou@eecs.berkeley.edu>,
linux-um@lists.infradead.org, "H . Peter Anvin" <hpa@zytor.com>,
Janosch Frank <frankja@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
openrisc@lists.librecores.org,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-hexagon@vger.kernel.org, Andy Lutomirski <luto@kernel.org>,
Stafford Horne <shorne@gmail.com>,
linux-csky@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-mips@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Dinh Nguyen <dinguyen@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
"David S . Miller" <davem@davemloft.net>,
Johannes Weiner <hannes@cmpxchg.org>,
Hugh Dickins <hughd@google.com>, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-riscv@lists.infradead.org,
Max Filippov <jcmvbkbc@gmail.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Johannes Berg <johannes@sipsolutions.net>,
Chris Zankel <chris@zankel.net>, Michal Simek <monstr@monstr.eu>,
x86@kernel.org, Yoshinori Sato <ysato@users.sourceforge.jp>,
Dave Hansen <dave.hansen@linux.intel.com>,
Richard Weinberger <richard@nod.at>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH v4] mm: Avoid unnecessary page fault retires on shared memory types
Date: Mon, 30 May 2022 14:31:52 +0100 [thread overview]
Message-ID: <YpTHSNQxzQxwJ4vQ@arm.com> (raw)
In-Reply-To: <20220527193936.30678-1-peterx@redhat.com>
On Fri, May 27, 2022 at 03:39:36PM -0400, Peter Xu wrote:
> diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c
> index 77341b160aca..e401d416bbd6 100644
> --- a/arch/arm64/mm/fault.c
> +++ b/arch/arm64/mm/fault.c
> @@ -607,6 +607,10 @@ static int __kprobes do_page_fault(unsigned long far, unsigned int esr,
> return 0;
> }
>
> + /* The fault is fully completed (including releasing mmap lock) */
> + if (fault & VM_FAULT_COMPLETED)
> + return 0;
> +
> if (fault & VM_FAULT_RETRY) {
> mm_flags |= FAULT_FLAG_TRIED;
> goto retry;
For arm64:
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Peter Xu <peterx@redhat.com>
Cc: Christian Borntraeger <borntraeger@linux.ibm.com>,
Rich Felker <dalias@libc.org>,
linux-ia64@vger.kernel.org, David Hildenbrand <david@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, linux-mips@vger.kernel.org,
"James E . J . Bottomley" <James.Bottomley@hansenpartnership.com>,
linux-mm@kvack.org, Guo Ren <guoren@kernel.org>,
"H . Peter Anvin" <hpa@zytor.com>,
sparclinux@vger.kernel.org, linux-hexagon@vger.kernel.org,
Alexander Gordeev <agordeev@linux.ibm.com>,
Will Deacon <will@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Paul Mackerras <paulus@samba.org>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Jonas Bonn <jonas@southpole.se>,
linux-s390@vger.kernel.org, Janosch Frank <frankja@linux.ibm.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
linux-sh@vger.kernel.org, Michael Ellerman <mpe@ellerman.id.au>,
Helge Deller <deller@gmx.de>,
Alistair Popple <apopple@nvidia.com>,
Hugh Dickins <hughd@google.com>,
Russell King <linux@armlinux.org.uk>,
linux-csky@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Andrea Arcangeli <aarcange@redhat.com>,
linux-arm-kernel@lists.infradead.org,
Vineet Gupta <vgupta@kernel.org>,
Matt Turner <mattst88@gmail.com>,
linux-snps-arc@lists.infradead.org,
linux-xtensa@linux-xtensa.org, Albert Ou <aou@eecs.berkeley.edu>,
Vasily Gorbik <gor@linux.ibm.com>,
Chris Zankel <chris@zankel.net>,
Heiko Carstens <hca@linux.ibm.com>,
Johannes Weiner <hannes@cmpxchg.org>,
linux-um@lists.infradead.org, Nicholas Piggin <npiggin@gmail.com>,
Richard Weinberger <richard@nod.at>,
linux-m68k@lists.linux-m68k.org, openrisc@lists.librecores.org,
Borislav Petkov <bp@alien8.de>, Al Viro <viro@zeniv.linux.org.uk>,
Andy Lutomirski <luto@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Ingo Molnar <mingo@redhat.com>, Vlastimil Babka <vbabka@suse.cz>,
Richard Henderson <rth@twiddle.net>,
Brian Cain <bcain@quicinc.com>, Michal Simek <monstr@monstr.eu>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-parisc@vger.kernel.org, Max Filippov <jcmvbkbc@gmail.com>,
linux-kernel@vger.kernel.org,
Johannes Berg <johannes@sipsolutions.net>,
Dinh Nguyen <dinguyen@kernel.org>,
linux-riscv@lists.infradead.org,
Palmer Dabbelt <palmer@dabbelt.com>,
Sven Schnelle <svens@linux.ibm.com>,
linux-alpha@vger.kernel.org,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH v4] mm: Avoid unnecessary page fault retires on shared memory types
Date: Mon, 30 May 2022 14:31:52 +0100 [thread overview]
Message-ID: <YpTHSNQxzQxwJ4vQ@arm.com> (raw)
In-Reply-To: <20220527193936.30678-1-peterx@redhat.com>
On Fri, May 27, 2022 at 03:39:36PM -0400, Peter Xu wrote:
> diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c
> index 77341b160aca..e401d416bbd6 100644
> --- a/arch/arm64/mm/fault.c
> +++ b/arch/arm64/mm/fault.c
> @@ -607,6 +607,10 @@ static int __kprobes do_page_fault(unsigned long far, unsigned int esr,
> return 0;
> }
>
> + /* The fault is fully completed (including releasing mmap lock) */
> + if (fault & VM_FAULT_COMPLETED)
> + return 0;
> +
> if (fault & VM_FAULT_RETRY) {
> mm_flags |= FAULT_FLAG_TRIED;
> goto retry;
For arm64:
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Peter Xu <peterx@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Will Deacon <will@kernel.org>, Matt Turner <mattst88@gmail.com>,
linux-s390@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Brian Cain <bcain@quicinc.com>, Borislav Petkov <bp@alien8.de>,
linux-alpha@vger.kernel.org, Alistair Popple <apopple@nvidia.com>,
Jonas Bonn <jonas@southpole.se>,
linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org,
Michael Ellerman <mpe@ellerman.id.au>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
linux-snps-arc@lists.infradead.org,
Vineet Gupta <vgupta@kernel.org>,
Vasily Gorbik <gor@linux.ibm.com>,
Vlastimil Babka <vbabka@suse.cz>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Rich Felker <dalias@libc.org>,
sparclinux@vger.kernel.org, Russell King <linux@armlinux.org.uk>,
David Hildenbrand <david@redhat.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Nicholas Piggin <npiggin@gmail.com>,
"James E . J . Bottomley" <James.Bottomley@hansenpartnership.com>,
linux-xtensa@linux-xtensa.org, linux-sh@vger.kernel.org,
Paul Walmsley <paul.walmsley@sifive.com>,
linux-m68k@lists.linux-m68k.org, linuxppc-dev@lists.ozlabs.org,
Richard Henderson <rth@twiddle.net>, Guo Ren <guoren@kernel.org>,
linux-parisc@vger.kernel.org,
Andrea Arcangeli <aarcange@redhat.com>,
Helge Deller <deller@gmx.de>, Al Viro <viro@zeniv.linux.org.uk>,
Albert Ou <aou@eecs.berkeley.edu>,
linux-um@lists.infradead.org, "H . Peter Anvin" <hpa@zytor.com>,
Janosch Frank <frankja@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
openrisc@lists.librecores.org,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-hexagon@vger.kernel.org, Andy Lutomirski <luto@kernel.org>,
Stafford Horne <shorne@gmail.com>,
linux-csky@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-mips@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Dinh Nguyen <dinguyen@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
"David S . Miller" <davem@davemloft.net>,
Johannes Weiner <hannes@cmpxchg.org>,
Hugh Dickins <hughd@google.com>, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-riscv@lists.infradead.org,
Max Filippov <jcmvbkbc@gmail.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Johannes Berg <johannes@sipsolutions.net>,
Chris Zankel <chris@zankel.net>, Michal Simek <monstr@monstr.eu>,
x86@kernel.org, Yoshinori Sato <ysato@users.sourceforge.jp>,
Dave Hansen <dave.hansen@linux.intel.com>,
Richard Weinberger <richard@nod.at>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH v4] mm: Avoid unnecessary page fault retires on shared memory types
Date: Mon, 30 May 2022 14:31:52 +0100 [thread overview]
Message-ID: <YpTHSNQxzQxwJ4vQ@arm.com> (raw)
In-Reply-To: <20220527193936.30678-1-peterx@redhat.com>
On Fri, May 27, 2022 at 03:39:36PM -0400, Peter Xu wrote:
> diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c
> index 77341b160aca..e401d416bbd6 100644
> --- a/arch/arm64/mm/fault.c
> +++ b/arch/arm64/mm/fault.c
> @@ -607,6 +607,10 @@ static int __kprobes do_page_fault(unsigned long far, unsigned int esr,
> return 0;
> }
>
> + /* The fault is fully completed (including releasing mmap lock) */
> + if (fault & VM_FAULT_COMPLETED)
> + return 0;
> +
> if (fault & VM_FAULT_RETRY) {
> mm_flags |= FAULT_FLAG_TRIED;
> goto retry;
For arm64:
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Peter Xu <peterx@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Will Deacon <will@kernel.org>, Matt Turner <mattst88@gmail.com>,
linux-s390@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Brian Cain <bcain@quicinc.com>, Borislav Petkov <bp@alien8.de>,
linux-alpha@vger.kernel.org, Alistair Popple <apopple@nvidia.com>,
Jonas Bonn <jonas@southpole.se>,
linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org,
Michael Ellerman <mpe@ellerman.id.au>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
linux-snps-arc@lists.infradead.org,
Vineet Gupta <vgupta@kernel.org>,
Vasily Gorbik <gor@linux.ibm.com>,
Vlastimil Babka <vbabka@suse.cz>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Rich Felker <dalias@libc.org>,
sparclinux@vger.kernel.org, Russell King <linux@armlinux.org.uk>,
David Hildenbrand <david@redhat.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Nicholas Piggin <npiggin@gmail.com>,
"James E . J . Bottomley" <James.Bottomley@hansenpartnership.com>,
linux-xtensa@linux-xtensa.org, linux-sh@vger.kernel.org,
Paul Walmsley <paul.walmsley@sifive.com>,
linux-m68k@lists.linux-m68k.org, linuxppc-dev@lists.ozlabs.org,
Richard Henderson <rth@twiddle.net>, Guo Ren <guoren@kernel.org>,
linux-parisc@vger.kernel.org,
Andrea Arcangeli <aarcange@redhat.com>,
Helge Deller <deller@gmx.de>, Al Viro <viro@zeniv.linux.org.uk>,
Albert Ou <aou@eecs.berkeley.edu>,
linux-um@lists.infradead.org, "H . Peter Anvin" <hpa@zytor.com>,
Janosch Frank <frankja@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
openrisc@lists.librecores.org,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-hexagon@vger.kernel.org, Andy Lutomirski <luto@kernel.org>,
Stafford Horne <shorne@gmail.com>,
linux-csky@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-mips@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Dinh Nguyen <dinguyen@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
"David S . Miller" <davem@davemloft.net>,
Johannes Weiner <hannes@cmpxchg.org>,
Hugh Dickins <hughd@google.com>, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-riscv@lists.infradead.org,
Max Filippov <jcmvbkbc@gmail.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Johannes Berg <johannes@sipsolutions.net>,
Chris Zankel <chris@zankel.net>, Michal Simek <monstr@monstr.eu>,
x86@kernel.org, Yoshinori Sato <ysato@users.sourceforge.jp>,
Dave Hansen <dave.hansen@linux.intel.com>,
Richard Weinberger <richard@nod.at>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH v4] mm: Avoid unnecessary page fault retires on shared memory types
Date: Mon, 30 May 2022 14:31:52 +0100 [thread overview]
Message-ID: <YpTHSNQxzQxwJ4vQ@arm.com> (raw)
In-Reply-To: <20220527193936.30678-1-peterx@redhat.com>
On Fri, May 27, 2022 at 03:39:36PM -0400, Peter Xu wrote:
> diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c
> index 77341b160aca..e401d416bbd6 100644
> --- a/arch/arm64/mm/fault.c
> +++ b/arch/arm64/mm/fault.c
> @@ -607,6 +607,10 @@ static int __kprobes do_page_fault(unsigned long far, unsigned int esr,
> return 0;
> }
>
> + /* The fault is fully completed (including releasing mmap lock) */
> + if (fault & VM_FAULT_COMPLETED)
> + return 0;
> +
> if (fault & VM_FAULT_RETRY) {
> mm_flags |= FAULT_FLAG_TRIED;
> goto retry;
For arm64:
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Peter Xu <peterx@redhat.com>
Cc: Christian Borntraeger <borntraeger@linux.ibm.com>,
Rich Felker <dalias@libc.org>,
linux-ia64@vger.kernel.org, David Hildenbrand <david@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, linux-mips@vger.kernel.org,
"James E . J . Bottomley" <James.Bottomley@hansenpartnership.com>,
linux-mm@kvack.org, Guo Ren <guoren@kernel.org>,
"H . Peter Anvin" <hpa@zytor.com>,
sparclinux@vger.kernel.org, linux-hexagon@vger.kernel.org,
Alexander Gordeev <agordeev@linux.ibm.com>,
Will Deacon <will@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Paul Mackerras <paulus@samba.org>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
Jonas Bonn <jonas@southpole.se>,
linux-s390@vger.kernel.org, Janosch Frank <frankja@linux.ibm.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
linux-sh@vger.kernel.org, Helge Deller <deller@gmx.de>,
Alistair Popple <apopple@nvidia.com>,
Hugh Dickins <hughd@google.com>,
Russell King <linux@armlinux.org.uk>,
linu x-csky@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-arm-kernel@lists.infradead.org,
Vineet Gupta <vgupta@kernel.org>,
Matt Turner <mattst88@gmail.com>,
linux-snps-arc@lists.infradead.org,
linux-xtensa@linux-xtensa.org, Albert Ou <aou@eecs.berkeley.edu>,
Vasily Gorbik <gor@linux.ibm.com>,
Chris Zankel <chris@zankel.net>,
Heiko Carstens <hca@linux.ibm.com>,
Johannes Weiner <hannes@cmpxchg.org>,
linux-um@lists.infradead.org, Nicholas Piggin <npiggin@gmail.com>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
Richard Weinberger <richard@nod.at>,
linux-m68k@lists.linux-m68k.org, openrisc@lists.librecores.org,
Borislav Petkov <bp@alien8.de>, Al Viro <viro@zeniv.linux.org.uk>,
Andy Lutomirski <luto@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Stafford Horne <shorne@gmail.com>, Ingo Molnar <mingo@redhat.com>,
Vlastimil Babka <vbabka@suse.cz>,
Richard Henderson <rth@twiddle.net>,
B rian Cain <bcain@quicinc.com>,
Michal Simek <monstr@m
Subject: Re: [PATCH v4] mm: Avoid unnecessary page fault retires on shared memory types
Date: Mon, 30 May 2022 14:31:52 +0100 [thread overview]
Message-ID: <YpTHSNQxzQxwJ4vQ@arm.com> (raw)
In-Reply-To: <20220527193936.30678-1-peterx@redhat.com>
onstr.eu>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, linux-parisc@vger.kernel.org, Max Filippov <jcmvbkbc@gmail.com>, linux-kernel@vger.kernel.org, Johannes Berg <johannes@sipsolutions.net>, Dinh Nguyen <dinguyen@kernel.org>, linux-riscv@lists.infradead.org, Palmer Dabbelt <palmer@dabbelt.com>, Sven Schnelle <svens@linux.ibm.com>, linux-alpha@vger.kernel.org, Ivan Kokshaysky <ink@jurassic.park.msu.ru>, Andrew Morton <akpm@linux-foundation.org>, linuxppc-dev@lists.ozlabs.org, "David S . Miller" <davem@davemloft.net>
Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org
Sender: "Linuxppc-dev" <linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org>
On Fri, May 27, 2022 at 03:39:36PM -0400, Peter Xu wrote:
> diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c
> index 77341b160aca..e401d416bbd6 100644
> --- a/arch/arm64/mm/fault.c
> +++ b/arch/arm64/mm/fault.c
> @@ -607,6 +607,10 @@ static int __kprobes do_page_fault(unsigned long far, unsigned int esr,
> return 0;
> }
>
> + /* The fault is fully completed (including releasing mmap lock) */
> + if (fault & VM_FAULT_COMPLETED)
> + return 0;
> +
> if (fault & VM_FAULT_RETRY) {
> mm_flags |= FAULT_FLAG_TRIED;
> goto retry;
For arm64:
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Peter Xu <peterx@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Will Deacon <will@kernel.org>, Matt Turner <mattst88@gmail.com>,
linux-s390@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Brian Cain <bcain@quicinc.com>, Borislav Petkov <bp@alien8.de>,
linux-alpha@vger.kernel.org, Alistair Popple <apopple@nvidia.com>,
Jonas Bonn <jonas@southpole.se>,
linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org,
Michael Ellerman <mpe@ellerman.id.au>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
linux-snps-arc@lists.infradead.org,
Vineet Gupta <vgupta@kernel.org>,
Vasily Gorbik <gor@linux.ibm.com>,
Vlastimil Babka <vbabka@suse.cz>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Rich Felker <dalias@libc.org>,
sparclinux@vger.kernel.org, Russell King <linux@armlinux.org.uk>,
David Hildenbrand <david@redhat.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Nicholas Piggin <npiggin@gmail.com>,
"James E . J . Bottomley" <James.Bottomley@hansenpartnership.com>,
linux-xtensa@linux-xtensa.org, linux-sh@vger.kernel.org,
Paul Walmsley <paul.walmsley@sifive.com>,
linux-m68k@lists.linux-m68k.org, linuxppc-dev@lists.ozlabs.org,
Richard Henderson <rth@twiddle.net>, Guo Ren <guoren@kernel.org>,
linux-parisc@vger.kernel.org,
Andrea Arcangeli <aarcange@redhat.com>,
Helge Deller <deller@gmx.de>, Al Viro <viro@zeniv.linux.org.uk>,
Albert Ou <aou@eecs.berkeley.edu>,
linux-um@lists.infradead.org, "H . Peter Anvin" <hpa@zytor.com>,
Janosch Frank <frankja@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Anton Ivanov <anton.ivanov@cambridgegreys.com>,
openrisc@lists.librecores.org,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-hexagon@vger.kernel.org, Andy Lutomirski <luto@kernel.org>,
Stafford Horne <shorne@gmail.com>,
linux-csky@vger.kernel.org, Heiko Carstens <hca@linux.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-mips@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Dinh Nguyen <dinguyen@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
"David S . Miller" <davem@davemloft.net>,
Johannes Weiner <hannes@cmpxchg.org>,
Hugh Dickins <hughd@google.com>, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-riscv@lists.infradead.org,
Max Filippov <jcmvbkbc@gmail.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Johannes Berg <johannes@sipsolutions.net>,
Chris Zankel <chris@zankel.net>, Michal Simek <monstr@monstr.eu>,
x86@kernel.org, Yoshinori Sato <ysato@users.sourceforge.jp>,
Dave Hansen <dave.hansen@linux.intel.com>,
Richard Weinberger <richard@nod.at>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH v4] mm: Avoid unnecessary page fault retires on shared memory types
Date: Mon, 30 May 2022 13:31:52 +0000 [thread overview]
Message-ID: <YpTHSNQxzQxwJ4vQ@arm.com> (raw)
In-Reply-To: <20220527193936.30678-1-peterx@redhat.com>
On Fri, May 27, 2022 at 03:39:36PM -0400, Peter Xu wrote:
> diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c
> index 77341b160aca..e401d416bbd6 100644
> --- a/arch/arm64/mm/fault.c
> +++ b/arch/arm64/mm/fault.c
> @@ -607,6 +607,10 @@ static int __kprobes do_page_fault(unsigned long far, unsigned int esr,
> return 0;
> }
>
> + /* The fault is fully completed (including releasing mmap lock) */
> + if (fault & VM_FAULT_COMPLETED)
> + return 0;
> +
> if (fault & VM_FAULT_RETRY) {
> mm_flags |= FAULT_FLAG_TRIED;
> goto retry;
For arm64:
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Peter Xu <peterx@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Will Deacon <will@kernel.org>, Matt Turner <mattst88@gmail.com>,
linux-s390@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Brian Cain <bcain@quicinc.com>, Borislav Petkov <bp@alien8.de>,
linux-alpha@vger.kernel.org, Alistair Popple <apopple@nvidia.com>,
Jonas Bonn <jonas@southpole.se>,
linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org,
Michael Ellerman <mpe@ellerman.id.au>,
Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
linux-snps-arc@lists.infradead.org,
Vineet Gupta <vgupta@kernel.org>,
Vasily Gorbik <gor@linux.ibm.com>,
Vlastimil Babka <vbabka@suse.cz>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Rich Felker <dalias@libc.org>,
sparclinux@vger.kernel.org, Russell King <linux@armlinux.org.uk>,
David Hildenbrand <david@redhat.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH v4] mm: Avoid unnecessary page fault retires on shared memory types
Date: Mon, 30 May 2022 14:31:52 +0100 [thread overview]
Message-ID: <YpTHSNQxzQxwJ4vQ@arm.com> (raw)
In-Reply-To: <20220527193936.30678-1-peterx@redhat.com>
On Fri, May 27, 2022 at 03:39:36PM -0400, Peter Xu wrote:
> diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c
> index 77341b160aca..e401d416bbd6 100644
> --- a/arch/arm64/mm/fault.c
> +++ b/arch/arm64/mm/fault.c
> @@ -607,6 +607,10 @@ static int __kprobes do_page_fault(unsigned long far, unsigned int esr,
> return 0;
> }
>
> + /* The fault is fully completed (including releasing mmap lock) */
> + if (fault & VM_FAULT_COMPLETED)
> + return 0;
> +
> if (fault & VM_FAULT_RETRY) {
> mm_flags |= FAULT_FLAG_TRIED;
> goto retry;
For arm64:
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
next prev parent reply other threads:[~2022-05-30 13:47 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 19:39 [PATCH v4] mm: Avoid unnecessary page fault retires on shared memory types Peter Xu
2022-05-27 19:39 ` Peter Xu
2022-05-27 19:39 ` Peter Xu
2022-05-27 19:39 ` Peter Xu
2022-05-27 19:39 ` Peter Xu
2022-05-27 19:39 ` Peter Xu
2022-05-27 19:39 ` Peter Xu
2022-05-29 20:33 ` Heiko Carstens
2022-05-29 20:33 ` Heiko Carstens
2022-05-29 20:33 ` Heiko Carstens
2022-05-29 20:33 ` Heiko Carstens
2022-05-29 20:33 ` Heiko Carstens
2022-05-29 20:33 ` Heiko Carstens
2022-05-29 20:33 ` Heiko Carstens
2022-05-30 9:35 ` Christian Borntraeger
2022-05-30 9:35 ` Christian Borntraeger
2022-05-30 9:35 ` Christian Borntraeger
2022-05-30 9:35 ` Christian Borntraeger
2022-05-30 9:35 ` Christian Borntraeger
2022-05-30 9:35 ` Christian Borntraeger
2022-05-30 9:35 ` Christian Borntraeger
2022-05-30 15:52 ` Peter Xu
2022-05-30 15:52 ` Peter Xu
2022-05-30 15:52 ` Peter Xu
2022-05-30 15:52 ` Peter Xu
2022-05-30 15:52 ` Peter Xu
2022-05-30 15:52 ` Peter Xu
2022-05-30 15:52 ` Peter Xu
2022-05-30 16:00 ` Peter Xu
2022-05-30 16:00 ` Peter Xu
2022-05-30 16:00 ` Peter Xu
2022-05-30 16:00 ` Peter Xu
2022-05-30 16:00 ` Peter Xu
2022-05-30 16:00 ` Peter Xu
2022-05-30 16:00 ` Peter Xu
2022-05-30 17:03 ` Heiko Carstens
2022-05-30 17:03 ` Heiko Carstens
2022-05-30 17:03 ` Heiko Carstens
2022-05-30 17:03 ` Heiko Carstens
2022-05-30 17:03 ` Heiko Carstens
2022-05-30 17:03 ` Heiko Carstens
2022-05-30 17:03 ` Heiko Carstens
2022-05-30 18:29 ` Peter Xu
2022-05-30 18:29 ` Peter Xu
2022-05-30 18:29 ` Peter Xu
2022-05-30 18:29 ` Peter Xu
2022-05-30 18:29 ` Peter Xu
2022-05-30 18:29 ` Peter Xu
2022-05-30 18:29 ` Peter Xu
2022-05-30 18:29 ` Christian Borntraeger
2022-05-30 18:29 ` Christian Borntraeger
2022-05-30 18:29 ` Christian Borntraeger
2022-05-30 18:29 ` Christian Borntraeger
2022-05-30 18:29 ` Christian Borntraeger
2022-05-30 18:29 ` Christian Borntraeger
2022-05-30 18:29 ` Christian Borntraeger
2022-05-30 4:04 ` Michael Ellerman
2022-05-30 13:31 ` Catalin Marinas [this message]
2022-05-30 13:31 ` Catalin Marinas
2022-05-30 13:31 ` Catalin Marinas
2022-05-30 13:31 ` Catalin Marinas
2022-05-30 13:31 ` Catalin Marinas
2022-05-30 13:31 ` Catalin Marinas
2022-05-30 13:31 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YpTHSNQxzQxwJ4vQ@arm.com \
--to=catalin.marinas@arm.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=aarcange@redhat.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=anton.ivanov@cambridgegreys.com \
--cc=aou@eecs.berkeley.edu \
--cc=apopple@nvidia.com \
--cc=bcain@quicinc.com \
--cc=benh@kernel.crashing.org \
--cc=borntraeger@linux.ibm.com \
--cc=bp@alien8.de \
--cc=chris@zankel.net \
--cc=dalias@libc.org \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=david@redhat.com \
--cc=deller@gmx.de \
--cc=dinguyen@kernel.org \
--cc=frankja@linux.ibm.com \
--cc=geert@linux-m68k.org \
--cc=gor@linux.ibm.com \
--cc=guoren@kernel.org \
--cc=hannes@cmpxchg.org \
--cc=hca@linux.ibm.com \
--cc=hpa@zytor.com \
--cc=hughd@google.com \
--cc=ink@jurassic.park.msu.ru \
--cc=jcmvbkbc@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=jonas@southpole.se \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux-um@lists.infradead.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=luto@kernel.org \
--cc=mattst88@gmail.com \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=monstr@monstr.eu \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=openrisc@lists.librecores.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=paulus@samba.org \
--cc=peterx@redhat.com \
--cc=peterz@infradead.org \
--cc=richard@nod.at \
--cc=rth@twiddle.net \
--cc=shorne@gmail.com \
--cc=sparclinux@vger.kernel.org \
--cc=stefan.kristiansson@saunalahti.fi \
--cc=svens@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=vbabka@suse.cz \
--cc=vgupta@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.