All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>,
	agross@kernel.org, bjorn.andersson@linaro.org,
	lgirdwood@gmail.com, quic_plai@quicinc.com, bgoswami@quicinc.com,
	perex@perex.cz, tiwai@suse.com, srinivas.kandagatla@linaro.org,
	quic_rohkumar@quicinc.com, linux-arm-msm@vger.kernel.org,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	swboyd@chromium.org, judyhsiao@chromium.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: dt-bindings: lpass-cpu: Update external mclck0 name
Date: Thu, 2 Jun 2022 16:40:29 +0200	[thread overview]
Message-ID: <YpjL3X73LyefYjI7@sirena.org.uk> (raw)
In-Reply-To: <20220602143245.GA2256965-robh@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

On Thu, Jun 02, 2022 at 09:32:45AM -0500, Rob Herring wrote:
> On Thu, Jun 02, 2022 at 04:56:45PM +0530, Srinivasa Rao Mandadapu wrote:
> > Update "audio_cc_ext_mclk0" name to "core_cc_ext_mclk0",
> > as MI2S mclk is being used is from lpass core cc.

> This is safe to change breaking the ABI because ...

The driver was only just merged so didn't make it into a full
release.

> Names are supposed to be local to the module, not based on their source. 

Indeed.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
	quic_rohkumar@quicinc.com, linux-arm-msm@vger.kernel.org,
	swboyd@chromium.org, tiwai@suse.com, lgirdwood@gmail.com,
	bjorn.andersson@linaro.org, agross@kernel.org,
	srinivas.kandagatla@linaro.org, bgoswami@quicinc.com,
	quic_plai@quicinc.com, judyhsiao@chromium.org,
	linux-kernel@vger.kernel.org,
	Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Subject: Re: [PATCH 1/2] ASoC: dt-bindings: lpass-cpu: Update external mclck0 name
Date: Thu, 2 Jun 2022 16:40:29 +0200	[thread overview]
Message-ID: <YpjL3X73LyefYjI7@sirena.org.uk> (raw)
In-Reply-To: <20220602143245.GA2256965-robh@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

On Thu, Jun 02, 2022 at 09:32:45AM -0500, Rob Herring wrote:
> On Thu, Jun 02, 2022 at 04:56:45PM +0530, Srinivasa Rao Mandadapu wrote:
> > Update "audio_cc_ext_mclk0" name to "core_cc_ext_mclk0",
> > as MI2S mclk is being used is from lpass core cc.

> This is safe to change breaking the ABI because ...

The driver was only just merged so didn't make it into a full
release.

> Names are supposed to be local to the module, not based on their source. 

Indeed.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2022-06-02 14:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-02 11:26 [PATCH 0/2] Update external mclk name Srinivasa Rao Mandadapu
2022-06-02 11:26 ` [PATCH 1/2] ASoC: dt-bindings: lpass-cpu: Update external mclck0 name Srinivasa Rao Mandadapu
2022-06-02 14:32   ` Rob Herring
2022-06-02 14:32     ` Rob Herring
2022-06-02 14:40     ` Mark Brown [this message]
2022-06-02 14:40       ` Mark Brown
2022-06-13 10:55       ` Srinivasa Rao Mandadapu
2022-06-13 10:55         ` Srinivasa Rao Mandadapu
2022-06-02 11:26 ` [PATCH 2/2] ASoC: qcom: lpass-sc7280: Update external mclk0 name Srinivasa Rao Mandadapu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YpjL3X73LyefYjI7@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=agross@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=bgoswami@quicinc.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=judyhsiao@chromium.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=quic_plai@quicinc.com \
    --cc=quic_rohkumar@quicinc.com \
    --cc=quic_srivasam@quicinc.com \
    --cc=robh@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=swboyd@chromium.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.