All of lore.kernel.org
 help / color / mirror / Atom feed
* Re: Re: [PATCH] i2c: npcm7xx: barco-p50-gpio: Add check for platform_driver_register
@ 2022-06-09  8:14 ` Jiasheng Jiang
  0 siblings, 0 replies; 4+ messages in thread
From: Jiasheng Jiang @ 2022-06-09  8:14 UTC (permalink / raw)
  To: wsa
  Cc: avifishman70, tmaimon77, tali.perry1, venture, yuenn,
	benjaminfair, openbmc, linux-i2c, linux-kernel, Jiasheng Jiang

On Thu, June 9, 2022 at 04:17:11AM +0800, Wolfram Sang wrote:
>> As platform_driver_register() could fail, it should be better
>> to deal with the return value in order to maintain the code
>> consisitency.
>> 
>> Fixes: 56a1485b102e ("i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver")
>> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> 
> Applied to for-current, thanks! But what is with the "barco-p50-gpio:"
> in the $subject?

Sorry, that's my fault.
The title should be "i2c: npcm7xx: Add check for platform_driver_register".
Need I submit a v2 to change the patch?

Thanks,
Jiang


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Re: [PATCH] i2c: npcm7xx: barco-p50-gpio: Add check for platform_driver_register
@ 2022-06-09  8:14 ` Jiasheng Jiang
  0 siblings, 0 replies; 4+ messages in thread
From: Jiasheng Jiang @ 2022-06-09  8:14 UTC (permalink / raw)
  To: wsa
  Cc: benjaminfair, avifishman70, venture, openbmc, Jiasheng Jiang,
	linux-kernel, tali.perry1, linux-i2c, tmaimon77

On Thu, June 9, 2022 at 04:17:11AM +0800, Wolfram Sang wrote:
>> As platform_driver_register() could fail, it should be better
>> to deal with the return value in order to maintain the code
>> consisitency.
>> 
>> Fixes: 56a1485b102e ("i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver")
>> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> 
> Applied to for-current, thanks! But what is with the "barco-p50-gpio:"
> in the $subject?

Sorry, that's my fault.
The title should be "i2c: npcm7xx: Add check for platform_driver_register".
Need I submit a v2 to change the patch?

Thanks,
Jiang


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Re: [PATCH] i2c: npcm7xx: barco-p50-gpio: Add check for platform_driver_register
  2022-06-09  8:14 ` Jiasheng Jiang
@ 2022-06-09  8:38   ` Wolfram Sang
  -1 siblings, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2022-06-09  8:38 UTC (permalink / raw)
  To: Jiasheng Jiang
  Cc: avifishman70, tmaimon77, tali.perry1, venture, yuenn,
	benjaminfair, openbmc, linux-i2c, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]


> Sorry, that's my fault.
> The title should be "i2c: npcm7xx: Add check for platform_driver_register".
> Need I submit a v2 to change the patch?

Not needed, I already fixed it.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Re: [PATCH] i2c: npcm7xx: barco-p50-gpio: Add check for platform_driver_register
@ 2022-06-09  8:38   ` Wolfram Sang
  0 siblings, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2022-06-09  8:38 UTC (permalink / raw)
  To: Jiasheng Jiang
  Cc: benjaminfair, avifishman70, venture, openbmc, linux-kernel,
	tali.perry1, linux-i2c, tmaimon77

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]


> Sorry, that's my fault.
> The title should be "i2c: npcm7xx: Add check for platform_driver_register".
> Need I submit a v2 to change the patch?

Not needed, I already fixed it.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-06-09  8:39 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-09  8:14 Re: [PATCH] i2c: npcm7xx: barco-p50-gpio: Add check for platform_driver_register Jiasheng Jiang
2022-06-09  8:14 ` Jiasheng Jiang
2022-06-09  8:38 ` Wolfram Sang
2022-06-09  8:38   ` Wolfram Sang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.