From: Mark Brown <broonie@kernel.org>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: conor.dooley@microchip.com, lewis.hanly@microchip.com,
linux-riscv@lists.infradead.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next 1/2] spi: Remove unnecessary print function dev_err()
Date: Thu, 9 Jun 2022 11:55:17 +0100 [thread overview]
Message-ID: <YqHRlaqy/UD0vDKU@sirena.org.uk> (raw)
In-Reply-To: <20220609055533.95866-2-yang.lee@linux.alibaba.com>
[-- Attachment #1: Type: text/plain, Size: 300 bytes --]
On Thu, Jun 09, 2022 at 01:55:33PM +0800, Yang Li wrote:
> The function platform_get_irq() never returns 0, and the print function
> dev_err() is redundant because platform_get_irq() already prints an error.
Are you sure it never returns 0? Note that 0 is a valid IRQ number on
some architectures.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: conor.dooley@microchip.com, lewis.hanly@microchip.com,
linux-riscv@lists.infradead.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next 1/2] spi: Remove unnecessary print function dev_err()
Date: Thu, 9 Jun 2022 11:55:17 +0100 [thread overview]
Message-ID: <YqHRlaqy/UD0vDKU@sirena.org.uk> (raw)
In-Reply-To: <20220609055533.95866-2-yang.lee@linux.alibaba.com>
[-- Attachment #1.1: Type: text/plain, Size: 300 bytes --]
On Thu, Jun 09, 2022 at 01:55:33PM +0800, Yang Li wrote:
> The function platform_get_irq() never returns 0, and the print function
> dev_err() is redundant because platform_get_irq() already prints an error.
Are you sure it never returns 0? Note that 0 is a valid IRQ number on
some architectures.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-06-09 10:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-09 5:55 [PATCH -next 2/2] spi: fix platform_no_drv_owner.cocci warning Yang Li
2022-06-09 5:55 ` Yang Li
2022-06-09 5:55 ` [PATCH -next 1/2] spi: Remove unnecessary print function dev_err() Yang Li
2022-06-09 5:55 ` Yang Li
2022-06-09 10:55 ` Mark Brown [this message]
2022-06-09 10:55 ` Mark Brown
2022-06-09 15:15 ` Conor.Dooley
2022-06-09 15:15 ` Conor.Dooley
2022-06-09 14:13 ` (subset) " Mark Brown
2022-06-09 14:13 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqHRlaqy/UD0vDKU@sirena.org.uk \
--to=broonie@kernel.org \
--cc=abaci@linux.alibaba.com \
--cc=conor.dooley@microchip.com \
--cc=lewis.hanly@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.