Re: [PATCH] crypto: atmel-ecc - Remove duplicated error reporting in .remove()

From: Herbert Xu <herbert@gondor.apana.org.au>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: tudor.ambarus@microchip.com, alexandre.belloni@bootlin.com,
	nicolas.ferre@microchip.com, linux-crypto@vger.kernel.org,
	kernel@pengutronix.de, claudiu.beznea@microchip.com,
	linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH] crypto: atmel-ecc - Remove duplicated error reporting in .remove()
Date: Fri, 10 Jun 2022 17:14:57 +0800	[thread overview]
Message-ID: <YqMLkVCB9DRr/LD6@gondor.apana.org.au> (raw)
In-Reply-To: <20220520172100.773730-1-u.kleine-koenig@pengutronix.de>

Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> Returning an error value in an i2c remove callback results in an error
> message being emitted by the i2c core, but otherwise it doesn't make a
> difference. The device goes away anyhow and the devm cleanups are
> called.
> 
> As atmel_ecc_remove() already emits an error message on failure and the
> additional error message by the i2c core doesn't add any useful
> information, change the return value to zero to suppress this message.
> 
> Also make the error message a bit more drastical because when the device
> is still busy on remove, it's likely that it will access freed memory
> soon.
> 
> This patch is a preparation for making i2c remove callbacks return void.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/crypto/atmel-ecc.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt