* [PATCH] dmaengine: apple-admac: Fix compile warning
@ 2022-06-09 18:43 ` Martin Povišer
0 siblings, 0 replies; 4+ messages in thread
From: Martin Povišer @ 2022-06-09 18:43 UTC (permalink / raw)
To: Vinod Koul
Cc: Hector Martin, Sven Peter, Alyssa Rosenzweig, linux-arm-kernel,
dmaengine, linux-kernel, asahi, Martin Povišer
Fix a warning of bad format specifier:
drivers/dma/apple-admac.c: In function 'admac_cyclic_write_one_desc':
drivers/dma/apple-admac.c:209:26: warning: format '%x' expects argument of type 'unsigned int', but argument 7 has type 'long unsigned int' [-Wformat=]
209 | dev_dbg(ad->dev, "ch%d descriptor: addr=0x%pad len=0x%zx flags=0x%x\n",
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Martin Povišer <povik+lin@cutebit.org>
---
Follow-up to the recent ADMAC series, feel free to squash:
https://lore.kernel.org/asahi/20220531213615.7822-1-povik+lin@cutebit.org/T/#t
drivers/dma/apple-admac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/apple-admac.c b/drivers/dma/apple-admac.c
index 2425069c186d..c502f8c3aca7 100644
--- a/drivers/dma/apple-admac.c
+++ b/drivers/dma/apple-admac.c
@@ -206,7 +206,7 @@ static void admac_cyclic_write_one_desc(struct admac_data *ad, int channo,
/* If happens means we have buggy code */
WARN_ON_ONCE(addr + tx->period_len > tx->buf_end);
- dev_dbg(ad->dev, "ch%d descriptor: addr=0x%pad len=0x%zx flags=0x%x\n",
+ dev_dbg(ad->dev, "ch%d descriptor: addr=0x%pad len=0x%zx flags=0x%lx\n",
channo, &addr, tx->period_len, FLAG_DESC_NOTIFY);
writel_relaxed(addr, ad->base + REG_DESC_WRITE(channo));
--
2.33.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] dmaengine: apple-admac: Fix compile warning
@ 2022-06-09 18:43 ` Martin Povišer
0 siblings, 0 replies; 4+ messages in thread
From: Martin Povišer @ 2022-06-09 18:43 UTC (permalink / raw)
To: Vinod Koul
Cc: Hector Martin, Sven Peter, Alyssa Rosenzweig, linux-arm-kernel,
dmaengine, linux-kernel, asahi, Martin Povišer
Fix a warning of bad format specifier:
drivers/dma/apple-admac.c: In function 'admac_cyclic_write_one_desc':
drivers/dma/apple-admac.c:209:26: warning: format '%x' expects argument of type 'unsigned int', but argument 7 has type 'long unsigned int' [-Wformat=]
209 | dev_dbg(ad->dev, "ch%d descriptor: addr=0x%pad len=0x%zx flags=0x%x\n",
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Martin Povišer <povik+lin@cutebit.org>
---
Follow-up to the recent ADMAC series, feel free to squash:
https://lore.kernel.org/asahi/20220531213615.7822-1-povik+lin@cutebit.org/T/#t
drivers/dma/apple-admac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/apple-admac.c b/drivers/dma/apple-admac.c
index 2425069c186d..c502f8c3aca7 100644
--- a/drivers/dma/apple-admac.c
+++ b/drivers/dma/apple-admac.c
@@ -206,7 +206,7 @@ static void admac_cyclic_write_one_desc(struct admac_data *ad, int channo,
/* If happens means we have buggy code */
WARN_ON_ONCE(addr + tx->period_len > tx->buf_end);
- dev_dbg(ad->dev, "ch%d descriptor: addr=0x%pad len=0x%zx flags=0x%x\n",
+ dev_dbg(ad->dev, "ch%d descriptor: addr=0x%pad len=0x%zx flags=0x%lx\n",
channo, &addr, tx->period_len, FLAG_DESC_NOTIFY);
writel_relaxed(addr, ad->base + REG_DESC_WRITE(channo));
--
2.33.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dmaengine: apple-admac: Fix compile warning
2022-06-09 18:43 ` Martin Povišer
@ 2022-06-10 11:46 ` Vinod Koul
-1 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2022-06-10 11:46 UTC (permalink / raw)
To: Martin Povišer
Cc: Hector Martin, Sven Peter, Alyssa Rosenzweig, linux-arm-kernel,
dmaengine, linux-kernel, asahi
On 09-06-22, 20:43, Martin Povišer wrote:
> Fix a warning of bad format specifier:
Patch title should describe the change and not the effect..
>
> drivers/dma/apple-admac.c: In function 'admac_cyclic_write_one_desc':
> drivers/dma/apple-admac.c:209:26: warning: format '%x' expects argument of type 'unsigned int', but argument 7 has type 'long unsigned int' [-Wformat=]
> 209 | dev_dbg(ad->dev, "ch%d descriptor: addr=0x%pad len=0x%zx flags=0x%x\n",
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Martin Povišer <povik+lin@cutebit.org>
> ---
>
> Follow-up to the recent ADMAC series, feel free to squash:
> https://lore.kernel.org/asahi/20220531213615.7822-1-povik+lin@cutebit.org/T/#t
>
> drivers/dma/apple-admac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/apple-admac.c b/drivers/dma/apple-admac.c
> index 2425069c186d..c502f8c3aca7 100644
> --- a/drivers/dma/apple-admac.c
> +++ b/drivers/dma/apple-admac.c
> @@ -206,7 +206,7 @@ static void admac_cyclic_write_one_desc(struct admac_data *ad, int channo,
> /* If happens means we have buggy code */
> WARN_ON_ONCE(addr + tx->period_len > tx->buf_end);
>
> - dev_dbg(ad->dev, "ch%d descriptor: addr=0x%pad len=0x%zx flags=0x%x\n",
> + dev_dbg(ad->dev, "ch%d descriptor: addr=0x%pad len=0x%zx flags=0x%lx\n",
> channo, &addr, tx->period_len, FLAG_DESC_NOTIFY);
>
> writel_relaxed(addr, ad->base + REG_DESC_WRITE(channo));
> --
> 2.33.0
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dmaengine: apple-admac: Fix compile warning
@ 2022-06-10 11:46 ` Vinod Koul
0 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2022-06-10 11:46 UTC (permalink / raw)
To: Martin Povišer
Cc: Hector Martin, Sven Peter, Alyssa Rosenzweig, linux-arm-kernel,
dmaengine, linux-kernel, asahi
On 09-06-22, 20:43, Martin Povišer wrote:
> Fix a warning of bad format specifier:
Patch title should describe the change and not the effect..
>
> drivers/dma/apple-admac.c: In function 'admac_cyclic_write_one_desc':
> drivers/dma/apple-admac.c:209:26: warning: format '%x' expects argument of type 'unsigned int', but argument 7 has type 'long unsigned int' [-Wformat=]
> 209 | dev_dbg(ad->dev, "ch%d descriptor: addr=0x%pad len=0x%zx flags=0x%x\n",
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Martin Povišer <povik+lin@cutebit.org>
> ---
>
> Follow-up to the recent ADMAC series, feel free to squash:
> https://lore.kernel.org/asahi/20220531213615.7822-1-povik+lin@cutebit.org/T/#t
>
> drivers/dma/apple-admac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/apple-admac.c b/drivers/dma/apple-admac.c
> index 2425069c186d..c502f8c3aca7 100644
> --- a/drivers/dma/apple-admac.c
> +++ b/drivers/dma/apple-admac.c
> @@ -206,7 +206,7 @@ static void admac_cyclic_write_one_desc(struct admac_data *ad, int channo,
> /* If happens means we have buggy code */
> WARN_ON_ONCE(addr + tx->period_len > tx->buf_end);
>
> - dev_dbg(ad->dev, "ch%d descriptor: addr=0x%pad len=0x%zx flags=0x%x\n",
> + dev_dbg(ad->dev, "ch%d descriptor: addr=0x%pad len=0x%zx flags=0x%lx\n",
> channo, &addr, tx->period_len, FLAG_DESC_NOTIFY);
>
> writel_relaxed(addr, ad->base + REG_DESC_WRITE(channo));
> --
> 2.33.0
--
~Vinod
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-06-10 11:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-09 18:43 [PATCH] dmaengine: apple-admac: Fix compile warning Martin Povišer
2022-06-09 18:43 ` Martin Povišer
2022-06-10 11:46 ` Vinod Koul
2022-06-10 11:46 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.