All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Xin Ji <xji@analogixsemi.com>, Guenter Roeck <linux@roeck-us.net>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	bliang@analogixsemi.com, qwen@analogixsemi.com,
	jli@analogixsemi.com, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v9 1/3] usb: typec: tcpci: move tcpci.h to include/linux/usb/
Date: Fri, 10 Jun 2022 15:02:13 +0300	[thread overview]
Message-ID: <YqMyxQGzPSs/HwVi@kuha.fi.intel.com> (raw)
In-Reply-To: <YqMaUroS87rjnCny@kroah.com>

On Fri, Jun 10, 2022 at 12:17:54PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Mar 09, 2022 at 10:34:01AM +0800, Xin Ji wrote:
> > USB PD controllers which consisting of a microcontroller (acting as the TCPM)
> > and a port controller (TCPC) - may require that the driver for the PD
> > controller accesses directly also the on-chip port controller in some cases.
> > 
> > Move tcpci.h to include/linux/usb/ is convenience access TCPC registers.
> > 
> > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > 
> > ---
> > V8 -> V9: Add more commit message
> > V7 -> V8: Fix Guanter's comment, remove unnecessary explain
> > 
> > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > ---
> >  drivers/usb/typec/tcpm/tcpci.c                        | 3 +--
> >  drivers/usb/typec/tcpm/tcpci_maxim.c                  | 3 +--
> >  drivers/usb/typec/tcpm/tcpci_mt6360.c                 | 3 +--
> >  drivers/usb/typec/tcpm/tcpci_rt1711h.c                | 2 +-
> >  {drivers/usb/typec/tcpm => include/linux/usb}/tcpci.h | 1 +
> >  5 files changed, 5 insertions(+), 7 deletions(-)
> >  rename {drivers/usb/typec/tcpm => include/linux/usb}/tcpci.h (99%)
> 
> I need an ack by the typec maintainers/developers before I can take this
> (hint...)

I'm sorry for the delayed response.

Xin, you need to rebase this. It does not apply cleanly anymore.

thanks,

-- 
heikki

WARNING: multiple messages have this Message-ID (diff)
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Xin Ji <xji@analogixsemi.com>, Guenter Roeck <linux@roeck-us.net>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	bliang@analogixsemi.com, qwen@analogixsemi.com,
	jli@analogixsemi.com, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v9 1/3] usb: typec: tcpci: move tcpci.h to include/linux/usb/
Date: Fri, 10 Jun 2022 15:02:13 +0300	[thread overview]
Message-ID: <YqMyxQGzPSs/HwVi@kuha.fi.intel.com> (raw)
In-Reply-To: <YqMaUroS87rjnCny@kroah.com>

On Fri, Jun 10, 2022 at 12:17:54PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Mar 09, 2022 at 10:34:01AM +0800, Xin Ji wrote:
> > USB PD controllers which consisting of a microcontroller (acting as the TCPM)
> > and a port controller (TCPC) - may require that the driver for the PD
> > controller accesses directly also the on-chip port controller in some cases.
> > 
> > Move tcpci.h to include/linux/usb/ is convenience access TCPC registers.
> > 
> > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > 
> > ---
> > V8 -> V9: Add more commit message
> > V7 -> V8: Fix Guanter's comment, remove unnecessary explain
> > 
> > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > ---
> >  drivers/usb/typec/tcpm/tcpci.c                        | 3 +--
> >  drivers/usb/typec/tcpm/tcpci_maxim.c                  | 3 +--
> >  drivers/usb/typec/tcpm/tcpci_mt6360.c                 | 3 +--
> >  drivers/usb/typec/tcpm/tcpci_rt1711h.c                | 2 +-
> >  {drivers/usb/typec/tcpm => include/linux/usb}/tcpci.h | 1 +
> >  5 files changed, 5 insertions(+), 7 deletions(-)
> >  rename {drivers/usb/typec/tcpm => include/linux/usb}/tcpci.h (99%)
> 
> I need an ack by the typec maintainers/developers before I can take this
> (hint...)

I'm sorry for the delayed response.

Xin, you need to rebase this. It does not apply cleanly anymore.

thanks,

-- 
heikki

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Xin Ji <xji@analogixsemi.com>, Guenter Roeck <linux@roeck-us.net>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	bliang@analogixsemi.com, qwen@analogixsemi.com,
	jli@analogixsemi.com, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v9 1/3] usb: typec: tcpci: move tcpci.h to include/linux/usb/
Date: Fri, 10 Jun 2022 15:02:13 +0300	[thread overview]
Message-ID: <YqMyxQGzPSs/HwVi@kuha.fi.intel.com> (raw)
In-Reply-To: <YqMaUroS87rjnCny@kroah.com>

On Fri, Jun 10, 2022 at 12:17:54PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Mar 09, 2022 at 10:34:01AM +0800, Xin Ji wrote:
> > USB PD controllers which consisting of a microcontroller (acting as the TCPM)
> > and a port controller (TCPC) - may require that the driver for the PD
> > controller accesses directly also the on-chip port controller in some cases.
> > 
> > Move tcpci.h to include/linux/usb/ is convenience access TCPC registers.
> > 
> > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > 
> > ---
> > V8 -> V9: Add more commit message
> > V7 -> V8: Fix Guanter's comment, remove unnecessary explain
> > 
> > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > ---
> >  drivers/usb/typec/tcpm/tcpci.c                        | 3 +--
> >  drivers/usb/typec/tcpm/tcpci_maxim.c                  | 3 +--
> >  drivers/usb/typec/tcpm/tcpci_mt6360.c                 | 3 +--
> >  drivers/usb/typec/tcpm/tcpci_rt1711h.c                | 2 +-
> >  {drivers/usb/typec/tcpm => include/linux/usb}/tcpci.h | 1 +
> >  5 files changed, 5 insertions(+), 7 deletions(-)
> >  rename {drivers/usb/typec/tcpm => include/linux/usb}/tcpci.h (99%)
> 
> I need an ack by the typec maintainers/developers before I can take this
> (hint...)

I'm sorry for the delayed response.

Xin, you need to rebase this. It does not apply cleanly anymore.

thanks,

-- 
heikki

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-06-10 12:02 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-09  2:34 [PATCH v9 1/3] usb: typec: tcpci: move tcpci.h to include/linux/usb/ Xin Ji
2022-03-09  2:34 ` Xin Ji
2022-03-09  2:34 ` Xin Ji
2022-03-09  2:34 ` [PATCH v9 2/3] dt-bindings: usb: Add analogix anx7411 PD binding Xin Ji
2022-03-09  2:34 ` [PATCH v9 3/3] usb: typec: anx7411: Add Analogix PD ANX7411 support Xin Ji
2022-06-10 12:49   ` Heikki Krogerus
2022-06-10 10:17 ` [PATCH v9 1/3] usb: typec: tcpci: move tcpci.h to include/linux/usb/ Greg Kroah-Hartman
2022-06-10 10:17   ` Greg Kroah-Hartman
2022-06-10 10:17   ` Greg Kroah-Hartman
2022-06-10 12:02   ` Heikki Krogerus [this message]
2022-06-10 12:02     ` Heikki Krogerus
2022-06-10 12:02     ` Heikki Krogerus
2022-06-13  9:39     ` Xin Ji
2022-06-13  9:39       ` Xin Ji
2022-06-13  9:39       ` Xin Ji
2022-06-13 10:05       ` Heikki Krogerus
2022-06-13 10:05         ` Heikki Krogerus
2022-06-13 10:05         ` Heikki Krogerus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YqMyxQGzPSs/HwVi@kuha.fi.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=bliang@analogixsemi.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jli@analogixsemi.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=matthias.bgg@gmail.com \
    --cc=qwen@analogixsemi.com \
    --cc=xji@analogixsemi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.