All of lore.kernel.org
 help / color / mirror / Atom feed
* [usb:usb-testing 39/44] drivers/usb/dwc3/dwc3-qcom.c:301:23: warning: no previous prototype for 'dwc3_qcom_read_usb2_speed'
@ 2022-06-11  0:55 kernel test robot
  2022-06-12  4:47   ` Greg Kroah-Hartman
  0 siblings, 1 reply; 6+ messages in thread
From: kernel test robot @ 2022-06-11  0:55 UTC (permalink / raw)
  To: Sandeep Maheswaram
  Cc: kbuild-all, linux-usb, Greg Kroah-Hartman, Pavankumar Kondeti,
	Krishna Kurapati

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
head:   477122a1eec325621cefd62da8bd8ac20a66fb8e
commit: 4387ea43e3a9dac058adfe5fc68e0e82750201e5 [39/44] usb: dwc3: qcom: Configure wakeup interrupts during suspend
config: riscv-allyesconfig (https://download.01.org/0day-ci/archive/20220611/202206110832.2zOQ2T8f-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?id=4387ea43e3a9dac058adfe5fc68e0e82750201e5
        git remote add usb https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
        git fetch --no-tags usb usb-testing
        git checkout 4387ea43e3a9dac058adfe5fc68e0e82750201e5
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/usb/dwc3/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/usb/dwc3/dwc3-qcom.c:301:23: warning: no previous prototype for 'dwc3_qcom_read_usb2_speed' [-Wmissing-prototypes]
     301 | enum usb_device_speed dwc3_qcom_read_usb2_speed(struct dwc3_qcom *qcom)
         |                       ^~~~~~~~~~~~~~~~~~~~~~~~~


vim +/dwc3_qcom_read_usb2_speed +301 drivers/usb/dwc3/dwc3-qcom.c

   300	
 > 301	enum usb_device_speed dwc3_qcom_read_usb2_speed(struct dwc3_qcom *qcom)
   302	{
   303		struct dwc3 *dwc = platform_get_drvdata(qcom->dwc3);
   304		struct usb_hcd *hcd = platform_get_drvdata(dwc->xhci);
   305		struct usb_device *udev;
   306	
   307		/*
   308		 * It is possible to query the speed of all children of
   309		 * USB2.0 root hub via usb_hub_for_each_child(). DWC3 code
   310		 * currently supports only 1 port per controller. So
   311		 * this is sufficient.
   312		 */
   313		udev = usb_hub_find_child(hcd->self.root_hub, 1);
   314	
   315		if (!udev)
   316			return USB_SPEED_UNKNOWN;
   317	
   318		return udev->speed;
   319	}
   320	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [usb:usb-testing 39/44] drivers/usb/dwc3/dwc3-qcom.c:301:23: warning: no previous prototype for 'dwc3_qcom_read_usb2_speed'
  2022-06-11  0:55 [usb:usb-testing 39/44] drivers/usb/dwc3/dwc3-qcom.c:301:23: warning: no previous prototype for 'dwc3_qcom_read_usb2_speed' kernel test robot
@ 2022-06-12  4:47   ` Greg Kroah-Hartman
  0 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2022-06-12  4:47 UTC (permalink / raw)
  To: kernel test robot
  Cc: Sandeep Maheswaram, kbuild-all, linux-usb, Pavankumar Kondeti,
	Krishna Kurapati

On Sat, Jun 11, 2022 at 08:55:47AM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
> head:   477122a1eec325621cefd62da8bd8ac20a66fb8e
> commit: 4387ea43e3a9dac058adfe5fc68e0e82750201e5 [39/44] usb: dwc3: qcom: Configure wakeup interrupts during suspend
> config: riscv-allyesconfig (https://download.01.org/0day-ci/archive/20220611/202206110832.2zOQ2T8f-lkp@intel.com/config)
> compiler: riscv64-linux-gcc (GCC) 11.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?id=4387ea43e3a9dac058adfe5fc68e0e82750201e5
>         git remote add usb https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
>         git fetch --no-tags usb usb-testing
>         git checkout 4387ea43e3a9dac058adfe5fc68e0e82750201e5
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/usb/dwc3/
> 
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All warnings (new ones prefixed by >>):
> 
> >> drivers/usb/dwc3/dwc3-qcom.c:301:23: warning: no previous prototype for 'dwc3_qcom_read_usb2_speed' [-Wmissing-prototypes]
>      301 | enum usb_device_speed dwc3_qcom_read_usb2_speed(struct dwc3_qcom *qcom)
>          |                       ^~~~~~~~~~~~~~~~~~~~~~~~~

I will go drop this commit now, please send a fixed up version if you
still want it accepted.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [usb:usb-testing 39/44] drivers/usb/dwc3/dwc3-qcom.c:301:23: warning: no previous prototype for 'dwc3_qcom_read_usb2_speed'
@ 2022-06-12  4:47   ` Greg Kroah-Hartman
  0 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2022-06-12  4:47 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 1807 bytes --]

On Sat, Jun 11, 2022 at 08:55:47AM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
> head:   477122a1eec325621cefd62da8bd8ac20a66fb8e
> commit: 4387ea43e3a9dac058adfe5fc68e0e82750201e5 [39/44] usb: dwc3: qcom: Configure wakeup interrupts during suspend
> config: riscv-allyesconfig (https://download.01.org/0day-ci/archive/20220611/202206110832.2zOQ2T8f-lkp(a)intel.com/config)
> compiler: riscv64-linux-gcc (GCC) 11.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?id=4387ea43e3a9dac058adfe5fc68e0e82750201e5
>         git remote add usb https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
>         git fetch --no-tags usb usb-testing
>         git checkout 4387ea43e3a9dac058adfe5fc68e0e82750201e5
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/usb/dwc3/
> 
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All warnings (new ones prefixed by >>):
> 
> >> drivers/usb/dwc3/dwc3-qcom.c:301:23: warning: no previous prototype for 'dwc3_qcom_read_usb2_speed' [-Wmissing-prototypes]
>      301 | enum usb_device_speed dwc3_qcom_read_usb2_speed(struct dwc3_qcom *qcom)
>          |                       ^~~~~~~~~~~~~~~~~~~~~~~~~

I will go drop this commit now, please send a fixed up version if you
still want it accepted.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [usb:usb-testing 39/44] drivers/usb/dwc3/dwc3-qcom.c:301:23: warning: no previous prototype for 'dwc3_qcom_read_usb2_speed'
  2022-06-12  4:47   ` Greg Kroah-Hartman
@ 2022-06-12  4:52     ` Greg Kroah-Hartman
  -1 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2022-06-12  4:52 UTC (permalink / raw)
  To: Sandeep Maheswaram
  Cc: kernel test robot, kbuild-all, linux-usb, Pavankumar Kondeti,
	Krishna Kurapati

On Sun, Jun 12, 2022 at 06:47:56AM +0200, Greg Kroah-Hartman wrote:
> On Sat, Jun 11, 2022 at 08:55:47AM +0800, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
> > head:   477122a1eec325621cefd62da8bd8ac20a66fb8e
> > commit: 4387ea43e3a9dac058adfe5fc68e0e82750201e5 [39/44] usb: dwc3: qcom: Configure wakeup interrupts during suspend
> > config: riscv-allyesconfig (https://download.01.org/0day-ci/archive/20220611/202206110832.2zOQ2T8f-lkp@intel.com/config)
> > compiler: riscv64-linux-gcc (GCC) 11.3.0
> > reproduce (this is a W=1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?id=4387ea43e3a9dac058adfe5fc68e0e82750201e5
> >         git remote add usb https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
> >         git fetch --no-tags usb usb-testing
> >         git checkout 4387ea43e3a9dac058adfe5fc68e0e82750201e5
> >         # save the config file
> >         mkdir build_dir && cp config build_dir/.config
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/usb/dwc3/
> > 
> > If you fix the issue, kindly add following tag where applicable
> > Reported-by: kernel test robot <lkp@intel.com>
> > 
> > All warnings (new ones prefixed by >>):
> > 
> > >> drivers/usb/dwc3/dwc3-qcom.c:301:23: warning: no previous prototype for 'dwc3_qcom_read_usb2_speed' [-Wmissing-prototypes]
> >      301 | enum usb_device_speed dwc3_qcom_read_usb2_speed(struct dwc3_qcom *qcom)
> >          |                       ^~~~~~~~~~~~~~~~~~~~~~~~~
> 
> I will go drop this commit now, please send a fixed up version if you
> still want it accepted.

I've dropped the whole 5 patch series now.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [usb:usb-testing 39/44] drivers/usb/dwc3/dwc3-qcom.c:301:23: warning: no previous prototype for 'dwc3_qcom_read_usb2_speed'
@ 2022-06-12  4:52     ` Greg Kroah-Hartman
  0 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2022-06-12  4:52 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 1955 bytes --]

On Sun, Jun 12, 2022 at 06:47:56AM +0200, Greg Kroah-Hartman wrote:
> On Sat, Jun 11, 2022 at 08:55:47AM +0800, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
> > head:   477122a1eec325621cefd62da8bd8ac20a66fb8e
> > commit: 4387ea43e3a9dac058adfe5fc68e0e82750201e5 [39/44] usb: dwc3: qcom: Configure wakeup interrupts during suspend
> > config: riscv-allyesconfig (https://download.01.org/0day-ci/archive/20220611/202206110832.2zOQ2T8f-lkp(a)intel.com/config)
> > compiler: riscv64-linux-gcc (GCC) 11.3.0
> > reproduce (this is a W=1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?id=4387ea43e3a9dac058adfe5fc68e0e82750201e5
> >         git remote add usb https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
> >         git fetch --no-tags usb usb-testing
> >         git checkout 4387ea43e3a9dac058adfe5fc68e0e82750201e5
> >         # save the config file
> >         mkdir build_dir && cp config build_dir/.config
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/usb/dwc3/
> > 
> > If you fix the issue, kindly add following tag where applicable
> > Reported-by: kernel test robot <lkp@intel.com>
> > 
> > All warnings (new ones prefixed by >>):
> > 
> > >> drivers/usb/dwc3/dwc3-qcom.c:301:23: warning: no previous prototype for 'dwc3_qcom_read_usb2_speed' [-Wmissing-prototypes]
> >      301 | enum usb_device_speed dwc3_qcom_read_usb2_speed(struct dwc3_qcom *qcom)
> >          |                       ^~~~~~~~~~~~~~~~~~~~~~~~~
> 
> I will go drop this commit now, please send a fixed up version if you
> still want it accepted.

I've dropped the whole 5 patch series now.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [usb:usb-testing 39/44] drivers/usb/dwc3/dwc3-qcom.c:301:23: warning: no previous prototype for 'dwc3_qcom_read_usb2_speed'
  2022-06-12  4:52     ` Greg Kroah-Hartman
  (?)
@ 2022-06-13  4:44     ` Krishna Kurapati PSSNV
  -1 siblings, 0 replies; 6+ messages in thread
From: Krishna Kurapati PSSNV @ 2022-06-13  4:44 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 2279 bytes --]

Hi Greg,

Sorry for the inconvenience. I fixed my scripts to emit warnings (W=1) 
so that i can catch these warnings much earlier. I have also submitted 
the V21 patch series, can you please include them for the next release 
if possible.

Thanks,
Krishna


On 6/12/2022 10:22 AM, Greg Kroah-Hartman wrote:
> On Sun, Jun 12, 2022 at 06:47:56AM +0200, Greg Kroah-Hartman wrote:
>> On Sat, Jun 11, 2022 at 08:55:47AM +0800, kernel test robot wrote:
>>> tree:https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git  usb-testing
>>> head:   477122a1eec325621cefd62da8bd8ac20a66fb8e
>>> commit: 4387ea43e3a9dac058adfe5fc68e0e82750201e5 [39/44] usb: dwc3: qcom: Configure wakeup interrupts during suspend
>>> config: riscv-allyesconfig (https://download.01.org/0day-ci/archive/20220611/202206110832.2zOQ2T8f-lkp(a)intel.com/config)
>>> compiler: riscv64-linux-gcc (GCC) 11.3.0
>>> reproduce (this is a W=1 build):
>>>          wgethttps://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross  -O ~/bin/make.cross
>>>          chmod +x ~/bin/make.cross
>>>          #https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?id=4387ea43e3a9dac058adfe5fc68e0e82750201e5
>>>          git remote add usbhttps://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
>>>          git fetch --no-tags usb usb-testing
>>>          git checkout 4387ea43e3a9dac058adfe5fc68e0e82750201e5
>>>          # save the config file
>>>          mkdir build_dir && cp config build_dir/.config
>>>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/usb/dwc3/
>>>
>>> If you fix the issue, kindly add following tag where applicable
>>> Reported-by: kernel test robot<lkp@intel.com>
>>>
>>> All warnings (new ones prefixed by >>):
>>>
>>>>> drivers/usb/dwc3/dwc3-qcom.c:301:23: warning: no previous prototype for 'dwc3_qcom_read_usb2_speed' [-Wmissing-prototypes]
>>>       301 | enum usb_device_speed dwc3_qcom_read_usb2_speed(struct dwc3_qcom *qcom)
>>>           |                       ^~~~~~~~~~~~~~~~~~~~~~~~~
>> I will go drop this commit now, please send a fixed up version if you
>> still want it accepted.
> I've dropped the whole 5 patch series now.

[-- Attachment #2: attachment.htm --]
[-- Type: text/html, Size: 4668 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-06-13  4:44 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-11  0:55 [usb:usb-testing 39/44] drivers/usb/dwc3/dwc3-qcom.c:301:23: warning: no previous prototype for 'dwc3_qcom_read_usb2_speed' kernel test robot
2022-06-12  4:47 ` Greg Kroah-Hartman
2022-06-12  4:47   ` Greg Kroah-Hartman
2022-06-12  4:52   ` Greg Kroah-Hartman
2022-06-12  4:52     ` Greg Kroah-Hartman
2022-06-13  4:44     ` Krishna Kurapati PSSNV

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.