[igt-dev] [PATCH i-g-t 0/2] HAX add description to gem_close_race

[igt-dev] [PATCH i-g-t 0/2] HAX add description to gem_close_race

[priyanka.dandamudi]

From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>

Add test description to gem_close_race.

Priyanka Dandamudi (2):
  i915/gem_close_race: added description for test case
  HAX: don't do full run

 tests/i915/gem_close_race.c           |  11 ++
 tests/intel-ci/fast-feedback.testlist | 183 +-------------------------
 2 files changed, 12 insertions(+), 182 deletions(-)

-- 
2.25.1

[igt-dev] [PATCH i-g-t 1/2] i915/gem_close_race: added description for test case

[priyanka.dandamudi]

From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>

Added description for subtests.

v2: Added global description and modified others.

Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
---
 tests/i915/gem_close_race.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/tests/i915/gem_close_race.c b/tests/i915/gem_close_race.c
index 93ae07ed6..271e88f9a 100644
--- a/tests/i915/gem_close_race.c
+++ b/tests/i915/gem_close_race.c
@@ -53,6 +53,8 @@
 #define BLT_WRITE_ALPHA		(1<<21)
 #define BLT_WRITE_RGB		(1<<20)
 
+IGT_TEST_DESCRIPTION("Test try to race gem_close against workload submission.");
+
 static uint32_t devid;
 static bool has_64bit_relocations;
 static bool has_softpin;
@@ -289,6 +291,7 @@ igt_main
 		close(fd);
 	}
 
+	igt_describe("Basic workload submission.");
 	igt_subtest("basic-process") {
 		int fd = drm_open_driver(DRIVER_INTEL);
 
@@ -300,9 +303,13 @@ igt_main
 		close(fd);
 	}
 
+	igt_describe("Share buffer handle across different drm fd's and trying to race "
+		     " gem_close against continuous workload with minimum timeout.");
 	igt_subtest("basic-threads")
 		threads(1, 0);
 
+	igt_describe("Test try to race gem close against submission of continuous"
+		     " workload.");
 	igt_subtest("process-exit") {
 		int fd = drm_open_driver(DRIVER_INTEL);
 
@@ -314,9 +321,13 @@ igt_main
 		close(fd);
 	}
 
+	igt_describe("Share buffer handle across different drm fd's and trying to race"
+		     " gem_close against continuous workload in other contexts.");
 	igt_subtest("contexts")
 		threads(30, CONTEXTS);
 
+	igt_describe("Share buffer handle across different drm fd's and trying to race of"
+		     " gem_close against continuous workload.");
 	igt_subtest("gem-close-race")
 		threads(150, 0);
 
-- 
2.25.1

[igt-dev] [PATCH i-g-t 2/2] HAX: don't do full run

[priyanka.dandamudi]

From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>

Just for test description, no full run is necessary.

Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
---
 tests/intel-ci/fast-feedback.testlist | 183 +-------------------------
 1 file changed, 1 insertion(+), 182 deletions(-)

diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index b579c20a7..1d57372d3 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -1,184 +1,3 @@
 # Keep alphabetically sorted by default
 
-igt@core_auth@basic-auth
-igt@debugfs_test@read_all_entries
-igt@fbdev@eof
-igt@fbdev@info
-igt@fbdev@nullptr
-igt@fbdev@read
-igt@fbdev@write
-igt@gem_basic@bad-close
-igt@gem_basic@create-close
-igt@gem_basic@create-fd-close
-igt@gem_busy@busy@all
-igt@gem_close_race@basic-process
-igt@gem_close_race@basic-threads
-igt@gem_ctx_create@basic
-igt@gem_ctx_create@basic-files
-igt@gem_ctx_exec@basic
-igt@gem_exec_basic@basic
-igt@gem_exec_create@basic
-igt@gem_exec_fence@basic-busy
-igt@gem_exec_fence@basic-wait
-igt@gem_exec_fence@basic-await
-igt@gem_exec_fence@nb-await
-igt@gem_exec_gttfill@basic
-igt@gem_exec_parallel@engines
-igt@gem_exec_store@basic
-igt@gem_flink_basic@bad-flink
-igt@gem_flink_basic@bad-open
-igt@gem_flink_basic@basic
-igt@gem_flink_basic@double-flink
-igt@gem_flink_basic@flink-lifetime
-igt@gem_huc_copy@huc-copy
-igt@gem_linear_blits@basic
-igt@gem_mmap@basic
-igt@gem_mmap_gtt@basic
-igt@gem_render_linear_blits@basic
-igt@gem_render_tiled_blits@basic
-igt@gem_ringfill@basic-all
-igt@gem_softpin@allocator-basic
-igt@gem_softpin@allocator-basic-reserve
-igt@gem_softpin@safe-alignment
-igt@gem_sync@basic-all
-igt@gem_sync@basic-each
-igt@gem_tiled_blits@basic
-igt@gem_tiled_fence_blits@basic
-igt@gem_tiled_pread_basic
-igt@gem_wait@busy@all
-igt@gem_wait@wait@all
-igt@i915_getparams_basic@basic-eu-total
-igt@i915_getparams_basic@basic-subslice-total
-igt@i915_hangman@error-state-basic
-igt@kms_addfb_basic@addfb25-bad-modifier
-igt@kms_addfb_basic@addfb25-framebuffer-vs-set-tiling
-igt@kms_addfb_basic@addfb25-modifier-no-flag
-igt@kms_addfb_basic@addfb25-x-tiled-legacy
-igt@kms_addfb_basic@addfb25-x-tiled-mismatch-legacy
-igt@kms_addfb_basic@addfb25-yf-tiled-legacy
-igt@kms_addfb_basic@addfb25-y-tiled-legacy
-igt@kms_addfb_basic@addfb25-y-tiled-small-legacy
-igt@kms_addfb_basic@bad-pitch-0
-igt@kms_addfb_basic@bad-pitch-1024
-igt@kms_addfb_basic@bad-pitch-128
-igt@kms_addfb_basic@bad-pitch-256
-igt@kms_addfb_basic@bad-pitch-32
-igt@kms_addfb_basic@bad-pitch-63
-igt@kms_addfb_basic@bad-pitch-65536
-igt@kms_addfb_basic@bad-pitch-999
-igt@kms_addfb_basic@basic
-igt@kms_addfb_basic@basic-x-tiled-legacy
-igt@kms_addfb_basic@basic-y-tiled-legacy
-igt@kms_addfb_basic@bo-too-small
-igt@kms_addfb_basic@bo-too-small-due-to-tiling
-igt@kms_addfb_basic@clobberred-modifier
-igt@kms_addfb_basic@framebuffer-vs-set-tiling
-igt@kms_addfb_basic@invalid-get-prop
-igt@kms_addfb_basic@invalid-get-prop-any
-igt@kms_addfb_basic@invalid-set-prop
-igt@kms_addfb_basic@invalid-set-prop-any
-igt@kms_addfb_basic@no-handle
-igt@kms_addfb_basic@size-max
-igt@kms_addfb_basic@small-bo
-igt@kms_addfb_basic@tile-pitch-mismatch
-igt@kms_addfb_basic@too-high
-igt@kms_addfb_basic@too-wide
-igt@kms_addfb_basic@unused-handle
-igt@kms_addfb_basic@unused-modifier
-igt@kms_addfb_basic@unused-offsets
-igt@kms_addfb_basic@unused-pitches
-igt@kms_busy@basic
-igt@kms_chamelium@dp-hpd-fast
-igt@kms_chamelium@dp-edid-read
-igt@kms_chamelium@dp-crc-fast
-igt@kms_chamelium@hdmi-hpd-fast
-igt@kms_chamelium@hdmi-edid-read
-igt@kms_chamelium@hdmi-crc-fast
-igt@kms_chamelium@vga-hpd-fast
-igt@kms_chamelium@vga-edid-read
-igt@kms_prop_blob@basic
-igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic
-igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy
-igt@kms_cursor_legacy@basic-flip-after-cursor-atomic
-igt@kms_cursor_legacy@basic-flip-after-cursor-legacy
-igt@kms_cursor_legacy@basic-flip-after-cursor-varying-size
-igt@kms_cursor_legacy@basic-flip-before-cursor-atomic
-igt@kms_cursor_legacy@basic-flip-before-cursor-legacy
-igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size
-igt@kms_flip@basic-flip-vs-dpms
-igt@kms_flip@basic-flip-vs-modeset
-igt@kms_flip@basic-flip-vs-wf_vblank
-igt@kms_flip@basic-plain-flip
-igt@kms_force_connector_basic@force-connector-state
-igt@kms_force_connector_basic@force-edid
-igt@kms_force_connector_basic@force-load-detect
-igt@kms_force_connector_basic@prune-stale-modes
-igt@kms_frontbuffer_tracking@basic
-igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-a
-igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-b
-igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c
-igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d
-igt@kms_pipe_crc_basic@hang-read-crc-pipe-a
-igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a
-igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence
-igt@kms_pipe_crc_basic@read-crc-pipe-a
-igt@kms_pipe_crc_basic@read-crc-pipe-b
-igt@kms_pipe_crc_basic@read-crc-pipe-c
-igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence
-igt@kms_psr@primary_page_flip
-igt@kms_psr@cursor_plane_move
-igt@kms_psr@sprite_plane_onoff
-igt@kms_psr@primary_mmap_gtt
-igt@kms_setmode@basic-clone-single-crtc
-igt@i915_pm_backlight@basic-brightness
-igt@i915_pm_rpm@basic-pci-d3-state
-igt@i915_pm_rpm@basic-rte
-igt@i915_pm_rps@basic-api
-igt@prime_self_import@basic-llseek-bad
-igt@prime_self_import@basic-llseek-size
-igt@prime_self_import@basic-with_fd_dup
-igt@prime_self_import@basic-with_one_bo
-igt@prime_self_import@basic-with_one_bo_two_files
-igt@prime_self_import@basic-with_two_bos
-igt@prime_vgem@basic-fence-flip
-igt@prime_vgem@basic-fence-mmap
-igt@prime_vgem@basic-fence-read
-igt@prime_vgem@basic-gtt
-igt@prime_vgem@basic-read
-igt@prime_vgem@basic-write
-igt@prime_vgem@basic-userptr
-igt@vgem_basic@setversion
-igt@vgem_basic@create
-igt@vgem_basic@debugfs
-igt@vgem_basic@dmabuf-export
-igt@vgem_basic@dmabuf-fence
-igt@vgem_basic@dmabuf-fence-before
-igt@vgem_basic@dmabuf-mmap
-igt@vgem_basic@mmap
-igt@vgem_basic@second-client
-igt@vgem_basic@sysfs
-
-# All tests that do module unloading and reloading are executed last.
-# They will sometimes reveal issues of earlier tests leaving the
-# driver in a broken state that is not otherwise noticed in that test.
-
-igt@core_hotunplug@unbind-rebind
-igt@vgem_basic@unload
-igt@i915_module_load@reload
-igt@gem_lmem_swapping@basic
-igt@gem_lmem_swapping@parallel-random-engines
-igt@gem_lmem_swapping@random-engines
-igt@gem_lmem_swapping@verify-random
-igt@i915_pm_rpm@module-reload
-
-# Kernel selftests
-igt@i915_selftest@live
-igt@dmabuf@all
-
-# System wide suspend tests
-igt@i915_suspend@basic-s2idle-without-i915
-igt@i915_suspend@basic-s3-without-i915
-igt@gem_exec_suspend@basic-s0
-igt@gem_exec_suspend@basic-s3
-igt@kms_chamelium@common-hpd-after-suspend
-igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a
+igt@meta_test@fail-result
-- 
2.25.1

[igt-dev] ✗ Fi.CI.BUILD: failure for HAX add description to gem_close_race (rev3)

[Patchwork]

== Series Details ==

Series: HAX add description to gem_close_race (rev3)
URL   : https://patchwork.freedesktop.org/series/104408/
State : failure

== Summary ==

Applying: i915/gem_close_race: added description for test case
Applying: HAX: don't do full run
Using index info to reconstruct a base tree...
M	tests/intel-ci/fast-feedback.testlist
Falling back to patching base and 3-way merge...
Auto-merging tests/intel-ci/fast-feedback.testlist
CONFLICT (content): Merge conflict in tests/intel-ci/fast-feedback.testlist
Patch failed at 0002 HAX: don't do full run
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Re: [igt-dev] [PATCH i-g-t 1/2] i915/gem_close_race: added description for test case

[Kamil Konieczny]

Hi Priyanka,

On 2022-06-15 at 11:21:46 +0530, priyanka.dandamudi@intel.com wrote:
> From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> 
> Added description for subtests.
> 
> v2: Added global description and modified others.
> 
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> ---
>  tests/i915/gem_close_race.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/tests/i915/gem_close_race.c b/tests/i915/gem_close_race.c
> index 93ae07ed6..271e88f9a 100644
> --- a/tests/i915/gem_close_race.c
> +++ b/tests/i915/gem_close_race.c
> @@ -53,6 +53,8 @@
>  #define BLT_WRITE_ALPHA		(1<<21)
>  #define BLT_WRITE_RGB		(1<<20)
>  
> +IGT_TEST_DESCRIPTION("Test try to race gem_close against workload submission.");
> +
>  static uint32_t devid;
>  static bool has_64bit_relocations;
>  static bool has_softpin;
> @@ -289,6 +291,7 @@ igt_main
>  		close(fd);
>  	}
>  
> +	igt_describe("Basic workload submission.");
>  	igt_subtest("basic-process") {
>  		int fd = drm_open_driver(DRIVER_INTEL);
>  
> @@ -300,9 +303,13 @@ igt_main
>  		close(fd);
>  	}
>  
> +	igt_describe("Share buffer handle across different drm fd's and trying to race "
> +		     " gem_close against continuous workload with minimum timeout.");
>  	igt_subtest("basic-threads")
>  		threads(1, 0);
>  
> +	igt_describe("Test try to race gem close against submission of continuous"
----------------------------------------- ^
s/gem close/gem_close/

With that fixed,
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

> +		     " workload.");
>  	igt_subtest("process-exit") {
>  		int fd = drm_open_driver(DRIVER_INTEL);
>  
> @@ -314,9 +321,13 @@ igt_main
>  		close(fd);
>  	}
>  
> +	igt_describe("Share buffer handle across different drm fd's and trying to race"
> +		     " gem_close against continuous workload in other contexts.");
>  	igt_subtest("contexts")
>  		threads(30, CONTEXTS);
>  
> +	igt_describe("Share buffer handle across different drm fd's and trying to race of"
> +		     " gem_close against continuous workload.");
>  	igt_subtest("gem-close-race")
>  		threads(150, 0);
>  
> -- 
> 2.25.1
> 

[igt-dev] [PATCH i-g-t 1/2] i915/gem_close_race: added description for test case

[priyanka.dandamudi]

From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>

Added description for subtests.

v2: Added global description and modified others.

Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
---
 tests/i915/gem_close_race.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/tests/i915/gem_close_race.c b/tests/i915/gem_close_race.c
index 93ae07ed..ccc480cf 100644
--- a/tests/i915/gem_close_race.c
+++ b/tests/i915/gem_close_race.c
@@ -53,6 +53,8 @@
 #define BLT_WRITE_ALPHA		(1<<21)
 #define BLT_WRITE_RGB		(1<<20)
 
+IGT_TEST_DESCRIPTION("Test try to race gem_close against workload submission.");
+
 static uint32_t devid;
 static bool has_64bit_relocations;
 static bool has_softpin;
@@ -289,6 +291,7 @@ igt_main
 		close(fd);
 	}
 
+	igt_describe("Basic workload submission.");
 	igt_subtest("basic-process") {
 		int fd = drm_open_driver(DRIVER_INTEL);
 
@@ -300,9 +303,13 @@ igt_main
 		close(fd);
 	}
 
+	igt_describe("Share buffer handle across different drm fd's and trying to race "
+		     " gem close against continuous workload with minimum timeout.");
 	igt_subtest("basic-threads")
 		threads(1, 0);
 
+	igt_describe("Test try to race gem close against submission of continuous"
+		     " workload.");
 	igt_subtest("process-exit") {
 		int fd = drm_open_driver(DRIVER_INTEL);
 
@@ -314,9 +321,13 @@ igt_main
 		close(fd);
 	}
 
+	igt_describe("Share buffer handle across different drm fd's and trying to race"
+		     " gem close against continuous workload in other contexts.");
 	igt_subtest("contexts")
 		threads(30, CONTEXTS);
 
+	igt_describe("Share buffer handle across different drm fd's and trying to race of"
+		     " gem close against continuous workload.");
 	igt_subtest("gem-close-race")
 		threads(150, 0);
 
-- 
2.25.1

Re: [igt-dev] [PATCH i-g-t 1/2] i915/gem_close_race: added description for test case

[Kamil Konieczny]

Hi Priyanka,

On 2022-05-26 at 20:55:50 +0530, priyanka.dandamudi@intel.com wrote:
> From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> 
> Added description for subtests.
> 

Please see few comments below, also please add global
description. imho one of the commit messages tells about the
purpose ot this test, you can reuse it. You can check it with

git log tests/i915/gem_close_race.c

or

git log 741bf7064c467d -- tests/gem_close_race.c

> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> ---
>  tests/i915/gem_close_race.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/tests/i915/gem_close_race.c b/tests/i915/gem_close_race.c
> index 93ae07ed..ec520510 100644
> --- a/tests/i915/gem_close_race.c
> +++ b/tests/i915/gem_close_race.c
> @@ -289,6 +289,7 @@ igt_main
>  		close(fd);
>  	}
>  
> +	igt_describe("Basic check to verify race of gem close against workload submission.");

imho this test do not hit close, you can just call it
"Basic workload submission."

>  	igt_subtest("basic-process") {
>  		int fd = drm_open_driver(DRIVER_INTEL);
>  
> @@ -300,9 +301,13 @@ igt_main
>  		close(fd);
>  	}
>  
> +	igt_describe("Share buffer handle across different drmfd's and verify race of"
> +		     " gem close against continuous workload(selfcopy) with minimum timeout.");

s/drmfd's/drm fd's/
s/(selfcopy)//

Well, imho the purpose isn't verifing race by itself, test is
intentionally trying to race between workload and closing fd.
Please rewrite this and other descriptions below.

>  	igt_subtest("basic-threads")
>  		threads(1, 0);
>  
> +	igt_describe("Verify race of gem close against submission of continuous"
> +		     " workload(selfcopying).");
>  	igt_subtest("process-exit") {
>  		int fd = drm_open_driver(DRIVER_INTEL);
>  
> @@ -314,9 +319,13 @@ igt_main
>  		close(fd);
>  	}
>  
> +	igt_describe("Share buffer handle across different drmfd's and verify race of"
> +		     " gem close against continuous workload(selfcopy) in other contexts.");
>  	igt_subtest("contexts")
>  		threads(30, CONTEXTS);
>  
> +	igt_describe("Share buffer handle across different drmfd's and verify race of"
> +		     " gem close against continuous workload(selfcopy) with timeout of 150ms.");

There are two ways for test end, one is hitting break condition
in loop which later checks time, second is a timer. While that
break condition is in miliseconds, the other is in seconds. On
my test runs it takes over 150s, so I suggest to drop time from
descriptions.

--
Kamil

>  	igt_subtest("gem-close-race")
>  		threads(150, 0);
>  
> -- 
> 2.25.1
> 

[igt-dev] [PATCH i-g-t 1/2] i915/gem_close_race: added description for test case

[priyanka.dandamudi]

From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>

Added description for subtests.

Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
---
 tests/i915/gem_close_race.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/tests/i915/gem_close_race.c b/tests/i915/gem_close_race.c
index 93ae07ed..ec520510 100644
--- a/tests/i915/gem_close_race.c
+++ b/tests/i915/gem_close_race.c
@@ -289,6 +289,7 @@ igt_main
 		close(fd);
 	}
 
+	igt_describe("Basic check to verify race of gem close against workload submission.");
 	igt_subtest("basic-process") {
 		int fd = drm_open_driver(DRIVER_INTEL);
 
@@ -300,9 +301,13 @@ igt_main
 		close(fd);
 	}
 
+	igt_describe("Share buffer handle across different drmfd's and verify race of"
+		     " gem close against continuous workload(selfcopy) with minimum timeout.");
 	igt_subtest("basic-threads")
 		threads(1, 0);
 
+	igt_describe("Verify race of gem close against submission of continuous"
+		     " workload(selfcopying).");
 	igt_subtest("process-exit") {
 		int fd = drm_open_driver(DRIVER_INTEL);
 
@@ -314,9 +319,13 @@ igt_main
 		close(fd);
 	}
 
+	igt_describe("Share buffer handle across different drmfd's and verify race of"
+		     " gem close against continuous workload(selfcopy) in other contexts.");
 	igt_subtest("contexts")
 		threads(30, CONTEXTS);
 
+	igt_describe("Share buffer handle across different drmfd's and verify race of"
+		     " gem close against continuous workload(selfcopy) with timeout of 150ms.");
 	igt_subtest("gem-close-race")
 		threads(150, 0);
 
-- 
2.25.1