From: Nicolin Chen <nicolinc@nvidia.com>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: "joro@8bytes.org" <joro@8bytes.org>,
"will@kernel.org" <will@kernel.org>,
"marcan@marcan.st" <marcan@marcan.st>,
"sven@svenpeter.dev" <sven@svenpeter.dev>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
"robdclark@gmail.com" <robdclark@gmail.com>,
"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"orsonzhai@gmail.com" <orsonzhai@gmail.com>,
"baolin.wang7@gmail.com" <baolin.wang7@gmail.com>,
"zhang.lyra@gmail.com" <zhang.lyra@gmail.com>,
"jean-philippe@linaro.org" <jean-philippe@linaro.org>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"jgg@nvidia.com" <jgg@nvidia.com>,
"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
"alyssa@rosenzweig.io" <alyssa@rosenzweig.io>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"yong.wu@mediatek.com" <yong.wu@mediatek.com>,
"mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
"gerald.schaefer@linux.ibm.com" <gerald.schaefer@linux.ibm.com>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"vdumpa@nvidia.com" <vdumpa@nvidia.com>,
"jonathanh@nvidia.com" <jonathanh@nvidia.com>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"thunder.leizhen@huawei.com" <thunder.leizhen@huawei.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"christophe.jaillet@wanadoo.fr" <christophe.jaillet@wanadoo.fr>,
"john.garry@huawei.com" <john.garry@huawei.com>,
"chenxiang66@hisilicon.com" <chenxiang66@hisilicon.com>,
"saiprakash.ranjan@codeaurora.org"
<saiprakash.ranjan@codeaurora.org>,
"isaacm@codeaurora.org" <isaacm@codeaurora.org>,
"yangyingliang@huawei.com" <yangyingliang@huawei.com>,
"jordan@cosmicpenguin.net" <jordan@cosmicpenguin.net>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH v2 3/5] vfio/iommu_type1: Remove the domain->ops comparison
Date: Thu, 16 Jun 2022 15:23:30 -0700 [thread overview]
Message-ID: <YqutYjgtFOTXCF0+@Asurada-Nvidia> (raw)
In-Reply-To: <BL1PR11MB52717050DBDE29A81637BBFA8CAC9@BL1PR11MB5271.namprd11.prod.outlook.com>
On Thu, Jun 16, 2022 at 06:40:14AM +0000, Tian, Kevin wrote:
> > The domain->ops validation was added, as a precaution, for mixed-driver
> > systems. However, at this moment only one iommu driver is possible. So
> > remove it.
>
> It's true on a physical platform. But I'm not sure whether a virtual platform
> is allowed to include multiple e.g. one virtio-iommu alongside a virtual VT-d
> or a virtual smmu. It might be clearer to claim that (as Robin pointed out)
> there is plenty more significant problems than this to solve instead of simply
> saying that only one iommu driver is possible if we don't have explicit code
> to reject such configuration. 😊
Will edit this part. Thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen via iommu <iommu@lists.linux-foundation.org>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: "linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"jordan@cosmicpenguin.net" <jordan@cosmicpenguin.net>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"will@kernel.org" <will@kernel.org>,
"alyssa@rosenzweig.io" <alyssa@rosenzweig.io>,
"jean-philippe@linaro.org" <jean-philippe@linaro.org>,
"saiprakash.ranjan@codeaurora.org"
<saiprakash.ranjan@codeaurora.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"zhang.lyra@gmail.com" <zhang.lyra@gmail.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"jonathanh@nvidia.com" <jonathanh@nvidia.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"jgg@nvidia.com" <jgg@nvidia.com>,
"yangyingliang@huawei.com" <yangyingliang@huawei.com>,
"orsonzhai@gmail.com" <orsonzhai@gmail.com>,
"gerald.schaefer@linux.ibm.com" <gerald.schaefer@linux.ibm.com>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"christophe.jaillet@wanadoo.fr" <christophe.jaillet@wanadoo.fr>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"isaacm@codeaurora.org" <isaacm@codeaurora.org>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"marcan@marcan.st" <marcan@marcan.st>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"baolin.wang7@gmail.com" <baolin.wang7@gmail.com>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"robin.murphy@arm.com" <robin.murphy@arm.com>
Subject: Re: [PATCH v2 3/5] vfio/iommu_type1: Remove the domain->ops comparison
Date: Thu, 16 Jun 2022 15:23:30 -0700 [thread overview]
Message-ID: <YqutYjgtFOTXCF0+@Asurada-Nvidia> (raw)
In-Reply-To: <BL1PR11MB52717050DBDE29A81637BBFA8CAC9@BL1PR11MB5271.namprd11.prod.outlook.com>
On Thu, Jun 16, 2022 at 06:40:14AM +0000, Tian, Kevin wrote:
> > The domain->ops validation was added, as a precaution, for mixed-driver
> > systems. However, at this moment only one iommu driver is possible. So
> > remove it.
>
> It's true on a physical platform. But I'm not sure whether a virtual platform
> is allowed to include multiple e.g. one virtio-iommu alongside a virtual VT-d
> or a virtual smmu. It might be clearer to claim that (as Robin pointed out)
> there is plenty more significant problems than this to solve instead of simply
> saying that only one iommu driver is possible if we don't have explicit code
> to reject such configuration. 😊
Will edit this part. Thanks!
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <nicolinc@nvidia.com>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: "linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
"jordan@cosmicpenguin.net" <jordan@cosmicpenguin.net>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"will@kernel.org" <will@kernel.org>,
"alyssa@rosenzweig.io" <alyssa@rosenzweig.io>,
"jean-philippe@linaro.org" <jean-philippe@linaro.org>,
"saiprakash.ranjan@codeaurora.org"
<saiprakash.ranjan@codeaurora.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"zhang.lyra@gmail.com" <zhang.lyra@gmail.com>,
"joro@8bytes.org" <joro@8bytes.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"jonathanh@nvidia.com" <jonathanh@nvidia.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"jgg@nvidia.com" <jgg@nvidia.com>,
"yangyingliang@huawei.com" <yangyingliang@huawei.com>,
"orsonzhai@gmail.com" <orsonzhai@gmail.com>,
"gerald.schaefer@linux.ibm.com" <gerald.schaefer@linux.ibm.com>,
"sven@svenpeter.dev" <sven@svenpeter.dev>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"john.garry@huawei.com" <john.garry@huawei.com>,
"alex.williamson@redhat.com" <alex.williamson@redhat.com>,
"christophe.jaillet@wanadoo.fr" <christophe.jaillet@wanadoo.fr>,
"thunder.leizhen@huawei.com" <thunder.leizhen@huawei.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"yong.wu@mediatek.com" <yong.wu@mediatek.com>,
"isaacm@codeaurora.org" <isaacm@codeaurora.org>,
"chenxiang66@hisilicon.com" <chenxiang66@hisilicon.com>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"marcan@marcan.st" <marcan@marcan.st>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robdclark@gmail.com" <robdclark@gmail.com>,
"suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
"baolin.wang7@gmail.com" <baolin.wang7@gmail.com>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
Subject: Re: [PATCH v2 3/5] vfio/iommu_type1: Remove the domain->ops comparison
Date: Thu, 16 Jun 2022 15:23:30 -0700 [thread overview]
Message-ID: <YqutYjgtFOTXCF0+@Asurada-Nvidia> (raw)
In-Reply-To: <BL1PR11MB52717050DBDE29A81637BBFA8CAC9@BL1PR11MB5271.namprd11.prod.outlook.com>
On Thu, Jun 16, 2022 at 06:40:14AM +0000, Tian, Kevin wrote:
> > The domain->ops validation was added, as a precaution, for mixed-driver
> > systems. However, at this moment only one iommu driver is possible. So
> > remove it.
>
> It's true on a physical platform. But I'm not sure whether a virtual platform
> is allowed to include multiple e.g. one virtio-iommu alongside a virtual VT-d
> or a virtual smmu. It might be clearer to claim that (as Robin pointed out)
> there is plenty more significant problems than this to solve instead of simply
> saying that only one iommu driver is possible if we don't have explicit code
> to reject such configuration. 😊
Will edit this part. Thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-16 22:24 UTC|newest]
Thread overview: 101+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 0:02 [PATCH v2 0/5] Simplify vfio_iommu_type1 attach/detach routine Nicolin Chen
2022-06-16 0:02 ` Nicolin Chen
2022-06-16 0:02 ` Nicolin Chen via iommu
2022-06-16 0:03 ` [PATCH v2 1/5] iommu: Return -EMEDIUMTYPE for incompatible domain and device/group Nicolin Chen
2022-06-16 0:03 ` Nicolin Chen
2022-06-16 0:03 ` Nicolin Chen via iommu
2022-06-16 2:09 ` Baolu Lu
2022-06-16 2:09 ` Baolu Lu
2022-06-16 2:09 ` Baolu Lu
2022-06-16 2:40 ` Nicolin Chen
2022-06-16 2:40 ` Nicolin Chen
2022-06-16 2:40 ` Nicolin Chen via iommu
2022-06-16 6:28 ` Tian, Kevin
2022-06-16 6:28 ` Tian, Kevin
2022-06-16 6:28 ` Tian, Kevin
2022-06-16 6:28 ` Tian, Kevin
2022-06-16 0:03 ` [PATCH v2 2/5] vfio/iommu_type1: Prefer to reuse domains vs match enforced cache coherency Nicolin Chen
2022-06-16 0:03 ` Nicolin Chen
2022-06-16 0:03 ` Nicolin Chen via iommu
2022-06-16 6:29 ` Tian, Kevin
2022-06-16 6:29 ` Tian, Kevin
2022-06-16 6:29 ` Tian, Kevin
2022-06-16 6:29 ` Tian, Kevin
2022-06-21 22:46 ` Alex Williamson
2022-06-21 22:46 ` Alex Williamson
2022-06-21 22:46 ` Alex Williamson
2022-06-21 22:46 ` Alex Williamson
2022-06-21 23:47 ` Nicolin Chen
2022-06-21 23:47 ` Nicolin Chen
2022-06-21 23:47 ` Nicolin Chen via iommu
2022-06-16 0:03 ` [PATCH v2 3/5] vfio/iommu_type1: Remove the domain->ops comparison Nicolin Chen
2022-06-16 0:03 ` Nicolin Chen
2022-06-16 0:03 ` Nicolin Chen via iommu
2022-06-16 6:40 ` Tian, Kevin
2022-06-16 6:40 ` Tian, Kevin
2022-06-16 6:40 ` Tian, Kevin
2022-06-16 6:40 ` Tian, Kevin
2022-06-16 22:23 ` Nicolin Chen [this message]
2022-06-16 22:23 ` Nicolin Chen
2022-06-16 22:23 ` Nicolin Chen via iommu
2022-06-22 7:54 ` Robin Murphy
2022-06-22 7:54 ` Robin Murphy
2022-06-22 7:54 ` Robin Murphy
2022-06-22 7:54 ` Robin Murphy
2022-06-23 3:50 ` Tian, Kevin
2022-06-23 3:50 ` Tian, Kevin
2022-06-23 3:50 ` Tian, Kevin
2022-06-23 3:50 ` Tian, Kevin
2022-06-23 7:47 ` Nicolin Chen
2022-06-23 7:47 ` Nicolin Chen
2022-06-23 7:47 ` Nicolin Chen via iommu
2022-06-24 13:16 ` Jason Gunthorpe
2022-06-24 13:16 ` Jason Gunthorpe
2022-06-24 13:16 ` Jason Gunthorpe via iommu
2022-06-24 18:31 ` Robin Murphy
2022-06-24 18:31 ` Robin Murphy
2022-06-24 18:31 ` Robin Murphy
2022-06-24 18:31 ` Robin Murphy
2022-06-24 18:46 ` Jason Gunthorpe
2022-06-24 18:46 ` Jason Gunthorpe
2022-06-24 18:46 ` Jason Gunthorpe via iommu
2022-06-16 0:03 ` [PATCH v2 4/5] vfio/iommu_type1: Clean up update_dirty_scope in detach_group() Nicolin Chen
2022-06-16 0:03 ` Nicolin Chen
2022-06-16 0:03 ` Nicolin Chen via iommu
2022-06-16 6:45 ` Tian, Kevin
2022-06-16 6:45 ` Tian, Kevin
2022-06-16 6:45 ` Tian, Kevin
2022-06-16 6:45 ` Tian, Kevin
2022-06-16 22:26 ` Nicolin Chen
2022-06-16 22:26 ` Nicolin Chen
2022-06-16 22:26 ` Nicolin Chen via iommu
2022-06-16 0:03 ` [PATCH v2 5/5] vfio/iommu_type1: Simplify group attachment Nicolin Chen
2022-06-16 0:03 ` Nicolin Chen
2022-06-16 0:03 ` Nicolin Chen via iommu
2022-06-16 7:08 ` Tian, Kevin
2022-06-16 7:08 ` Tian, Kevin
2022-06-16 7:08 ` Tian, Kevin
2022-06-16 7:08 ` Tian, Kevin
2022-06-16 22:40 ` Nicolin Chen
2022-06-16 22:40 ` Nicolin Chen
2022-06-16 22:40 ` Nicolin Chen via iommu
2022-06-17 2:53 ` Tian, Kevin
2022-06-17 2:53 ` Tian, Kevin
2022-06-17 2:53 ` Tian, Kevin
2022-06-17 2:53 ` Tian, Kevin
2022-06-17 23:07 ` Nicolin Chen
2022-06-17 23:07 ` Nicolin Chen
2022-06-17 23:07 ` Nicolin Chen via iommu
2022-06-20 4:03 ` Jason Gunthorpe
2022-06-20 4:03 ` Jason Gunthorpe
2022-06-20 4:03 ` Jason Gunthorpe via iommu
2022-06-21 20:59 ` Nicolin Chen via iommu
2022-06-21 20:59 ` Nicolin Chen
2022-06-21 20:59 ` Nicolin Chen
2022-06-20 10:11 ` Robin Murphy
2022-06-20 10:11 ` Robin Murphy
2022-06-20 10:11 ` Robin Murphy
2022-06-20 10:11 ` Robin Murphy
2022-06-21 21:08 ` Nicolin Chen via iommu
2022-06-21 21:08 ` Nicolin Chen
2022-06-21 21:08 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqutYjgtFOTXCF0+@Asurada-Nvidia \
--to=nicolinc@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=alyssa@rosenzweig.io \
--cc=baolin.wang7@gmail.com \
--cc=baolu.lu@linux.intel.com \
--cc=chenxiang66@hisilicon.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=cohuck@redhat.com \
--cc=dwmw2@infradead.org \
--cc=gerald.schaefer@linux.ibm.com \
--cc=iommu@lists.linux-foundation.org \
--cc=isaacm@codeaurora.org \
--cc=jean-philippe@linaro.org \
--cc=jgg@nvidia.com \
--cc=john.garry@huawei.com \
--cc=jonathanh@nvidia.com \
--cc=jordan@cosmicpenguin.net \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=matthias.bgg@gmail.com \
--cc=mjrosato@linux.ibm.com \
--cc=orsonzhai@gmail.com \
--cc=robdclark@gmail.com \
--cc=robin.murphy@arm.com \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=suravee.suthikulpanit@amd.com \
--cc=sven@svenpeter.dev \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=thunder.leizhen@huawei.com \
--cc=vdumpa@nvidia.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=will@kernel.org \
--cc=yangyingliang@huawei.com \
--cc=yong.wu@mediatek.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.