From: Sebastian Andrzej Siewior <bigeasy@linutronix.de> To: Valentin Schneider <vschneid@redhat.com> Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org, linux-rt-users@vger.kernel.org, Eric Biederman <ebiederm@xmission.com>, Arnd Bergmann <arnd@arndb.de>, Petr Mladek <pmladek@suse.com>, Thomas Gleixner <tglx@linutronix.de>, Juri Lelli <jlelli@redhat.com>, "Luis Claudio R. Goncalves" <lgoncalv@redhat.com> Subject: Re: [PATCH] panic, kexec: Don't mutex_trylock() in __crash_kexec() Date: Fri, 17 Jun 2022 17:13:01 +0200 [thread overview] Message-ID: <YqyZ/Uf14qkYtMDX@linutronix.de> (raw) In-Reply-To: <20220616123709.347053-1-vschneid@redhat.com> On 2022-06-16 13:37:09 [+0100], Valentin Schneider wrote: > Regarding the original explanation for the WARN & return: > > I don't get why 2) is a problem - if the lock is acquired by the trylock > then the critical section will be run without interruption since it > cannot sleep, the interrupted task may get boosted but that will not > have any actual impact AFAICT. boosting an unrelated task is considered wrong. I don't know how bad it gets in terms of lock chains since a task is set as owner which did not actually ask for the lock. > Regardless, even if this doesn't sleep, the ->wait_lock in the slowpath > isn't NMI safe so this needs changing. This includes the unlock path which may wake a waiter and deboost. > I've thought about trying to defer the kexec out of an NMI (or IRQ) > context, but that pretty much means deferring the panic() which I'm > not sure is such a great idea. If we could defer it out of NMI on RT then it would work non-RT, too. If the system is "stuck" and the NMI is the only to respond then I guess that it is not a great idea. Sebastian
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de> To: Valentin Schneider <vschneid@redhat.com> Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org, linux-rt-users@vger.kernel.org, Eric Biederman <ebiederm@xmission.com>, Arnd Bergmann <arnd@arndb.de>, Petr Mladek <pmladek@suse.com>, Thomas Gleixner <tglx@linutronix.de>, Juri Lelli <jlelli@redhat.com>, "Luis Claudio R. Goncalves" <lgoncalv@redhat.com> Subject: Re: [PATCH] panic, kexec: Don't mutex_trylock() in __crash_kexec() Date: Fri, 17 Jun 2022 17:13:01 +0200 [thread overview] Message-ID: <YqyZ/Uf14qkYtMDX@linutronix.de> (raw) In-Reply-To: <20220616123709.347053-1-vschneid@redhat.com> On 2022-06-16 13:37:09 [+0100], Valentin Schneider wrote: > Regarding the original explanation for the WARN & return: > > I don't get why 2) is a problem - if the lock is acquired by the trylock > then the critical section will be run without interruption since it > cannot sleep, the interrupted task may get boosted but that will not > have any actual impact AFAICT. boosting an unrelated task is considered wrong. I don't know how bad it gets in terms of lock chains since a task is set as owner which did not actually ask for the lock. > Regardless, even if this doesn't sleep, the ->wait_lock in the slowpath > isn't NMI safe so this needs changing. This includes the unlock path which may wake a waiter and deboost. > I've thought about trying to defer the kexec out of an NMI (or IRQ) > context, but that pretty much means deferring the panic() which I'm > not sure is such a great idea. If we could defer it out of NMI on RT then it would work non-RT, too. If the system is "stuck" and the NMI is the only to respond then I guess that it is not a great idea. Sebastian _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2022-06-17 15:13 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-16 12:37 [PATCH] panic, kexec: Don't mutex_trylock() in __crash_kexec() Valentin Schneider 2022-06-16 12:37 ` Valentin Schneider 2022-06-17 10:42 ` Tao Zhou 2022-06-17 10:42 ` Tao Zhou 2022-06-17 11:52 ` Valentin Schneider 2022-06-17 11:52 ` Valentin Schneider 2022-06-17 13:52 ` Petr Mladek 2022-06-17 13:52 ` Petr Mladek 2022-06-17 14:46 ` Valentin Schneider 2022-06-17 14:46 ` Valentin Schneider 2022-06-17 15:13 ` Sebastian Andrzej Siewior [this message] 2022-06-17 15:13 ` Sebastian Andrzej Siewior 2022-06-17 16:09 ` Valentin Schneider 2022-06-17 16:09 ` Valentin Schneider 2022-06-17 16:53 ` Sebastian Andrzej Siewior 2022-06-17 16:53 ` Sebastian Andrzej Siewior 2022-06-22 15:34 ` kernel test robot 2022-06-22 15:34 ` kernel test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YqyZ/Uf14qkYtMDX@linutronix.de \ --to=bigeasy@linutronix.de \ --cc=arnd@arndb.de \ --cc=ebiederm@xmission.com \ --cc=jlelli@redhat.com \ --cc=kexec@lists.infradead.org \ --cc=lgoncalv@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rt-users@vger.kernel.org \ --cc=pmladek@suse.com \ --cc=tglx@linutronix.de \ --cc=vschneid@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.