Re: [PATCH 4/7] media: v4l2: Make colorspace validity checks more future-proof

From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	linux-media@vger.kernel.org, Jacopo Mondi <jacopo@jmondi.org>,
	Xavier Roumegue <xavier.roumegue@oss.nxp.com>,
	linux-imx@nxp.com, kernel@pengutronix.de
Subject: Re: [PATCH 4/7] media: v4l2: Make colorspace validity checks more future-proof
Date: Thu, 30 Jun 2022 12:48:10 +0300	[thread overview]
Message-ID: <Yr1xWpyR37kPcM0c@pendragon.ideasonboard.com> (raw)
In-Reply-To: <Yr1w6Pt7mGpz+XWv@valkosipuli.retiisi.eu>

On Thu, Jun 30, 2022 at 12:46:16PM +0300, Sakari Ailus wrote:
> On Wed, Jun 29, 2022 at 03:50:47PM +0200, Hans Verkuil wrote:
> > > @@ -585,8 +585,8 @@ static inline bool v4l2_is_hsv_enc_valid(__u8 hsv_enc)
> > >  
> > >  static inline bool v4l2_is_quant_valid(__u8 quantization)
> > >  {
> > > -	return quantization == V4L2_QUANTIZATION_FULL_RANGE ||
> > > -	       quantization == V4L2_QUANTIZATION_LIM_RANGE;
> > > +	return quantization > V4L2_QUANTIZATION_DEFAULT &&
> > > +	       quantization < V4L2_QUANTIZATION_LAST;
> > 
> > There are only two quantization ranges: full and limited. And I very sincerely
> > hope there will never be a third!
> 
> For consistency of the checks and definitions I prefer it how it's in the
> patch. There's no functional difference though.

I'm ready to send a pull request for this patch once you and Hans agree
on how this should be done :-) I also have a slight preference for
consistency. Hans, what do you think ?

-- 
Regards,

Laurent Pinchart