Re: [PATCH 3/7] media: vivid: Add support for the new YUVA and YUVX formats

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Hans,

On Wed, Jun 29, 2022 at 03:54:43PM +0200, Hans Verkuil wrote:
> On 16/06/2022 20:36, Laurent Pinchart wrote:
> > Extend vivid to support the newly added YUVA and YUVX pixel formats
> > through the TPG.
> > 
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> Note that v4l-utils should receive a patch adding support for these two
> new formats, esp. since the tpg and vivid uses them.
> 
> Basically just grep for V4L2_PIX_FMT_VUYX/A32 and add support for these
> two new formats.

This requires syncing with the kernel headers. What's the procedure
there, should I wait until the kernel patches get merged in a released
kernel first ?

> > ---
> >  .../media/test-drivers/vivid/vivid-vid-common.c   | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> > 
> > diff --git a/drivers/media/test-drivers/vivid/vivid-vid-common.c b/drivers/media/test-drivers/vivid/vivid-vid-common.c
> > index 19701fe72030..38d788b5cf19 100644
> > --- a/drivers/media/test-drivers/vivid/vivid-vid-common.c
> > +++ b/drivers/media/test-drivers/vivid/vivid-vid-common.c
> > @@ -198,6 +198,21 @@ struct vivid_fmt vivid_formats[] = {
> >  		.planes   = 1,
> >  		.buffers = 1,
> >  	},
> > +	{
> > +		.fourcc   = V4L2_PIX_FMT_YUVA32,
> > +		.vdownsampling = { 1 },
> > +		.bit_depth = { 32 },
> > +		.planes   = 1,
> > +		.buffers = 1,
> > +		.alpha_mask = 0xff000000,
> > +	},
> > +	{
> > +		.fourcc   = V4L2_PIX_FMT_YUVX32,
> > +		.vdownsampling = { 1 },
> > +		.bit_depth = { 32 },
> > +		.planes   = 1,
> > +		.buffers = 1,
> > +	},
> >  	{
> >  		.fourcc   = V4L2_PIX_FMT_GREY,
> >  		.vdownsampling = { 1 },

-- 
Regards,

Laurent Pinchart