[PATCH -next v2] staging: r8188eu: Use eth_broadcast_addr() to assign broadcast address

[PATCH -next v2] staging: r8188eu: Use eth_broadcast_addr() to assign broadcast address

[Huang Zetao]

Using eth_broadcast_addr() to assign broadcast address instead of memset().

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Huang Zetao <huangzetao1@huawei.com>
---
 drivers/staging/r8188eu/os_dep/ioctl_linux.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging/r8188eu/os_dep/ioctl_linux.c
index 047e9c7d38c3..b9c0b7ee05f1 100644
--- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c
+++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c
@@ -1823,7 +1823,7 @@ static int rtw_wx_set_enc_ext(struct net_device *dev,
 		return -ENOMEM;
 
 	param->cmd = IEEE_CMD_SET_ENCRYPTION;
-	memset(param->sta_addr, 0xff, ETH_ALEN);
+	eth_broadcast_addr(param->sta_addr);
 
 	switch (pext->alg) {
 	case IW_ENCODE_ALG_NONE:
-- 
2.17.1

Re: [PATCH -next v2] staging: r8188eu: Use eth_broadcast_addr() to assign broadcast address

[Greg KH]

On Fri, Jul 01, 2022 at 09:40:11AM +0000, Huang Zetao wrote:
> Using eth_broadcast_addr() to assign broadcast address instead of memset().
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>

Please follow the rules outlined in
Documentation/process/researcher-guidelines.rst when submitting patches
found by a random, private, unknown tool.

thanks,

greg k-h

答复: [PATCH -next v2] staging: r8188eu: Use eth_broadcast_addr() to assign broadcast address

[huangzetao]

Please disregard it.

-----邮件原件-----
发件人: Greg KH <gregkh@linuxfoundation.org> 
发送时间: 2022年7月1日 17:50
收件人: huangzetao <huangzetao1@huawei.com>
抄送: Larry.Finger@lwfinger.net; phil@philpotter.co.uk; paskripkin@gmail.com; straube.linux@gmail.com; martin@kaiser.cx; abdun.nihaal@gmail.com; linux-staging@lists.linux.dev; inux-kernel@vger.kernel.org
主题: Re: [PATCH -next v2] staging: r8188eu: Use eth_broadcast_addr() to assign broadcast address

On Fri, Jul 01, 2022 at 09:40:11AM +0000, Huang Zetao wrote:
> Using eth_broadcast_addr() to assign broadcast address instead of memset().
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>

Please follow the rules outlined in
Documentation/process/researcher-guidelines.rst when submitting patches found by a random, private, unknown tool.

thanks,

greg k-h

Re: 答复: [PATCH -next v2] staging: r8188eu: Use eth_broadcast_addr() to assign broadcast address

[Greg KH]

On Mon, Jul 04, 2022 at 02:45:45AM +0000, huangzetao wrote:
> Please disregard it.

Ok, I will now disregard all patches with the "reported-by: Hulk Robot".

greg k-h