* [PATCH] drm/xlnx: Fix build failure due to missing include
@ 2022-06-21 7:56 Ville Syrjala
2022-06-21 8:15 ` Laurent Pinchart
0 siblings, 1 reply; 3+ messages in thread
From: Ville Syrjala @ 2022-06-21 7:56 UTC (permalink / raw)
To: dri-devel; +Cc: Stephen Rothwell, Laurent Pinchart, Hyun Kwon
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Dropping drm_blend.h from drm_crtc.h broke the
xlnx driver. Make it build again by including
drm_blend.h from the driver directly.
My .config was missing some required dependencies so
I never build tested it :/
Cc: Hyun Kwon <hyun.kwon@xilinx.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Fixes: 90bb087f6674 ("drm: Drop drm_blend.h from drm_crtc.h")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/xlnx/zynqmp_disp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c
index 11c409cbc88e..cc32aa89cf8f 100644
--- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
+++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
@@ -12,6 +12,7 @@
#include <drm/drm_atomic.h>
#include <drm/drm_atomic_helper.h>
#include <drm/drm_atomic_uapi.h>
+#include <drm/drm_blend.h>
#include <drm/drm_crtc.h>
#include <drm/drm_device.h>
#include <drm/drm_fb_cma_helper.h>
--
2.35.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/xlnx: Fix build failure due to missing include
2022-06-21 7:56 [PATCH] drm/xlnx: Fix build failure due to missing include Ville Syrjala
@ 2022-06-21 8:15 ` Laurent Pinchart
2022-06-21 8:26 ` Ville Syrjälä
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Pinchart @ 2022-06-21 8:15 UTC (permalink / raw)
To: Ville Syrjala; +Cc: Stephen Rothwell, Hyun Kwon, dri-devel
Hi Ville,
Thank you for the patch.
On Tue, Jun 21, 2022 at 10:56:48AM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Dropping drm_blend.h from drm_crtc.h broke the
> xlnx driver. Make it build again by including
> drm_blend.h from the driver directly.
>
> My .config was missing some required dependencies so
> I never build tested it :/
>
> Cc: Hyun Kwon <hyun.kwon@xilinx.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Fixes: 90bb087f6674 ("drm: Drop drm_blend.h from drm_crtc.h")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/xlnx/zynqmp_disp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> index 11c409cbc88e..cc32aa89cf8f 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> @@ -12,6 +12,7 @@
> #include <drm/drm_atomic.h>
> #include <drm/drm_atomic_helper.h>
> #include <drm/drm_atomic_uapi.h>
> +#include <drm/drm_blend.h>
> #include <drm/drm_crtc.h>
> #include <drm/drm_device.h>
> #include <drm/drm_fb_cma_helper.h>
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/xlnx: Fix build failure due to missing include
2022-06-21 8:15 ` Laurent Pinchart
@ 2022-06-21 8:26 ` Ville Syrjälä
0 siblings, 0 replies; 3+ messages in thread
From: Ville Syrjälä @ 2022-06-21 8:26 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: Stephen Rothwell, Hyun Kwon, dri-devel
On Tue, Jun 21, 2022 at 11:15:35AM +0300, Laurent Pinchart wrote:
> Hi Ville,
>
> Thank you for the patch.
>
> On Tue, Jun 21, 2022 at 10:56:48AM +0300, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Dropping drm_blend.h from drm_crtc.h broke the
> > xlnx driver. Make it build again by including
> > drm_blend.h from the driver directly.
> >
> > My .config was missing some required dependencies so
> > I never build tested it :/
> >
> > Cc: Hyun Kwon <hyun.kwon@xilinx.com>
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> > Fixes: 90bb087f6674 ("drm: Drop drm_blend.h from drm_crtc.h")
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Thanks. Pushed to drm-misc-next.
>
> > ---
> > drivers/gpu/drm/xlnx/zynqmp_disp.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> > index 11c409cbc88e..cc32aa89cf8f 100644
> > --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
> > +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> > @@ -12,6 +12,7 @@
> > #include <drm/drm_atomic.h>
> > #include <drm/drm_atomic_helper.h>
> > #include <drm/drm_atomic_uapi.h>
> > +#include <drm/drm_blend.h>
> > #include <drm/drm_crtc.h>
> > #include <drm/drm_device.h>
> > #include <drm/drm_fb_cma_helper.h>
>
> --
> Regards,
>
> Laurent Pinchart
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-21 8:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-21 7:56 [PATCH] drm/xlnx: Fix build failure due to missing include Ville Syrjala
2022-06-21 8:15 ` Laurent Pinchart
2022-06-21 8:26 ` Ville Syrjälä
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.