From: Paul Kocialkowski <paul.kocialkowski@bootlin.com> To: Dan Carpenter <dan.carpenter@oracle.com> Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Maxime Ripard <mripard@kernel.org>, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] drm: logicvc: Fix uninitialized variable in probe Date: Fri, 24 Jun 2022 17:25:02 +0200 [thread overview] Message-ID: <YrXXTtOdAMex4UFc@aptenodytes> (raw) In-Reply-To: <YrXLrVUIavGWC4sx@aptenodytes> [-- Attachment #1: Type: text/plain, Size: 1466 bytes --] Hi, On Fri 24 Jun 22, 16:35, Paul Kocialkowski wrote: > Hi Dan, > > On Tue 14 Jun 22, 15:08, Dan Carpenter wrote: > > The "regmap" is supposed to be initialized to NULL but it's used > > without being initialized. > > > > Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display controller") > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > Nice catch, thanks a lot! > > Acked-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com> Pushed to drm-misc-next, thanks! Paul > Cheers, > > Paul > > > --- > > drivers/gpu/drm/logicvc/logicvc_drm.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/logicvc/logicvc_drm.c b/drivers/gpu/drm/logicvc/logicvc_drm.c > > index df1805cf0f95..0b983a33f9ff 100644 > > --- a/drivers/gpu/drm/logicvc/logicvc_drm.c > > +++ b/drivers/gpu/drm/logicvc/logicvc_drm.c > > @@ -298,7 +298,7 @@ static int logicvc_drm_probe(struct platform_device *pdev) > > struct logicvc_drm *logicvc; > > struct device *dev = &pdev->dev; > > struct drm_device *drm_dev; > > - struct regmap *regmap; > > + struct regmap *regmap = NULL; > > struct resource res; > > void __iomem *base; > > int irq; > > -- > > 2.35.1 > > > > -- > Paul Kocialkowski, Bootlin > Embedded Linux and kernel engineering > https://bootlin.com -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Paul Kocialkowski <paul.kocialkowski@bootlin.com> To: Dan Carpenter <dan.carpenter@oracle.com> Cc: David Airlie <airlied@linux.ie>, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm: logicvc: Fix uninitialized variable in probe Date: Fri, 24 Jun 2022 17:25:02 +0200 [thread overview] Message-ID: <YrXXTtOdAMex4UFc@aptenodytes> (raw) In-Reply-To: <YrXLrVUIavGWC4sx@aptenodytes> [-- Attachment #1: Type: text/plain, Size: 1466 bytes --] Hi, On Fri 24 Jun 22, 16:35, Paul Kocialkowski wrote: > Hi Dan, > > On Tue 14 Jun 22, 15:08, Dan Carpenter wrote: > > The "regmap" is supposed to be initialized to NULL but it's used > > without being initialized. > > > > Fixes: efeeaefe9be5 ("drm: Add support for the LogiCVC display controller") > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > Nice catch, thanks a lot! > > Acked-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com> Pushed to drm-misc-next, thanks! Paul > Cheers, > > Paul > > > --- > > drivers/gpu/drm/logicvc/logicvc_drm.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/logicvc/logicvc_drm.c b/drivers/gpu/drm/logicvc/logicvc_drm.c > > index df1805cf0f95..0b983a33f9ff 100644 > > --- a/drivers/gpu/drm/logicvc/logicvc_drm.c > > +++ b/drivers/gpu/drm/logicvc/logicvc_drm.c > > @@ -298,7 +298,7 @@ static int logicvc_drm_probe(struct platform_device *pdev) > > struct logicvc_drm *logicvc; > > struct device *dev = &pdev->dev; > > struct drm_device *drm_dev; > > - struct regmap *regmap; > > + struct regmap *regmap = NULL; > > struct resource res; > > void __iomem *base; > > int irq; > > -- > > 2.35.1 > > > > -- > Paul Kocialkowski, Bootlin > Embedded Linux and kernel engineering > https://bootlin.com -- Paul Kocialkowski, Bootlin Embedded Linux and kernel engineering https://bootlin.com [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-06-24 15:25 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-14 12:08 [PATCH] drm: logicvc: Fix uninitialized variable in probe Dan Carpenter 2022-06-14 12:08 ` Dan Carpenter 2022-06-24 14:35 ` Paul Kocialkowski 2022-06-24 14:35 ` Paul Kocialkowski 2022-06-24 14:37 ` Maxime Ripard 2022-06-24 14:37 ` Maxime Ripard 2022-06-24 14:46 ` Paul Kocialkowski 2022-06-24 14:46 ` Paul Kocialkowski 2022-06-24 15:06 ` Maxime Ripard 2022-06-24 15:06 ` Maxime Ripard 2022-06-27 8:53 ` Maxime Ripard 2022-06-27 8:53 ` Maxime Ripard 2022-06-24 15:25 ` Paul Kocialkowski [this message] 2022-06-24 15:25 ` Paul Kocialkowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YrXXTtOdAMex4UFc@aptenodytes \ --to=paul.kocialkowski@bootlin.com \ --cc=airlied@linux.ie \ --cc=dan.carpenter@oracle.com \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mripard@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.