All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Guo Hui <guohui@uniontech.com>
Cc: longman@redhat.com, jgross@suse.com, srivatsa@csail.mit.edu,
	amakhalov@vmware.com, pv-drivers@vmware.com, tglx@linutronix.de,
	mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
	x86@kernel.org, hpa@zytor.com, will@kernel.org,
	boqun.feng@gmail.com, virtualization@lists.linux-foundation.org,
	wangxiaohua@uniontech.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86/paravirt: useless assignment instructions cause Unixbench full core performance degradation
Date: Mon, 27 Jun 2022 11:30:18 +0200	[thread overview]
Message-ID: <Yrl4qoXcVj9Y6Cpa@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <3c020577-2045-fa12-9e33-65ece10bda30@uniontech.com>

On Mon, Jun 27, 2022 at 05:18:02PM +0800, Guo Hui wrote:
> Ok thanks Peter, your suggestion is very good, I will modify my patch as you
> suggested.

Because it messes up the order in which people normally read text.
Why is top-posting such a bad thing?
Top-posting.
What is the most annoying thing in e-mail?

WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Guo Hui <guohui@uniontech.com>
Cc: jgross@suse.com, x86@kernel.org, hpa@zytor.com,
	pv-drivers@vmware.com, boqun.feng@gmail.com,
	dave.hansen@linux.intel.com, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org, mingo@redhat.com,
	bp@alien8.de, amakhalov@vmware.com, longman@redhat.com,
	tglx@linutronix.de, will@kernel.org, wangxiaohua@uniontech.com
Subject: Re: [PATCH v2] x86/paravirt: useless assignment instructions cause Unixbench full core performance degradation
Date: Mon, 27 Jun 2022 11:30:18 +0200	[thread overview]
Message-ID: <Yrl4qoXcVj9Y6Cpa@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <3c020577-2045-fa12-9e33-65ece10bda30@uniontech.com>

On Mon, Jun 27, 2022 at 05:18:02PM +0800, Guo Hui wrote:
> Ok thanks Peter, your suggestion is very good, I will modify my patch as you
> suggested.

Because it messes up the order in which people normally read text.
Why is top-posting such a bad thing?
Top-posting.
What is the most annoying thing in e-mail?
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

  parent reply	other threads:[~2022-06-27  9:30 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-23 15:50 [PATCH] x86/paravirt: useless assignment instructions cause Unixbench full core performance degradation Guo Hui
2022-06-23 21:54 ` Waiman Long
2022-06-27  2:13   ` [PATCH v2] " Guo Hui
2022-06-27  3:02     ` Waiman Long
2022-06-27  3:02       ` Waiman Long
     [not found]       ` <62b94621.1c69fb81.3a378.57ccSMTPIN_ADDED_BROKEN@mx.google.com>
2022-06-27 13:25         ` Waiman Long
2022-06-27 13:25           ` Waiman Long
2022-06-27  5:57     ` Juergen Gross via Virtualization
2022-06-27  5:57       ` Juergen Gross
2022-06-27  7:07       ` [PATCH v3] " Guo Hui
2022-06-27  7:49     ` [PATCH v2] " Peter Zijlstra
2022-06-27  7:49       ` Peter Zijlstra
     [not found]       ` <3c020577-2045-fa12-9e33-65ece10bda30@uniontech.com>
2022-06-27  9:30         ` Peter Zijlstra [this message]
2022-06-27  9:30           ` Peter Zijlstra
2022-06-27 14:27       ` [PATCH v4] " Guo Hui
2022-06-27 15:42         ` Juergen Gross
2022-06-27 15:42           ` Juergen Gross via Virtualization
2022-06-27 15:58         ` Waiman Long
2022-06-27 15:58           ` Waiman Long
2022-06-28  4:31           ` [PATCH v5] " Guo Hui
2022-06-28 12:54           ` [PATCH v6] " Guo Hui
2022-06-28 14:15             ` Waiman Long
2022-06-28 14:15               ` Waiman Long
2022-06-28 16:12               ` [PATCH v7] " Guo Hui
2022-06-28 17:28                 ` Waiman Long
2022-06-28 17:28                   ` Waiman Long

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yrl4qoXcVj9Y6Cpa@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=amakhalov@vmware.com \
    --cc=boqun.feng@gmail.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=guohui@uniontech.com \
    --cc=hpa@zytor.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=mingo@redhat.com \
    --cc=pv-drivers@vmware.com \
    --cc=srivatsa@csail.mit.edu \
    --cc=tglx@linutronix.de \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=wangxiaohua@uniontech.com \
    --cc=will@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.