From: Mark Brown <broonie@kernel.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: lgirdwood@gmail.com, bjorn.andersson@linaro.org, perex@perex.cz,
tiwai@suse.com, srinivas.kandagatla@linaro.org,
robh+dt@kernel.org, krzk+dt@kernel.org,
alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/2] ASoC: qcom: lpass: Fix apq8016 compat string to match yaml
Date: Tue, 28 Jun 2022 11:54:47 +0100 [thread overview]
Message-ID: <Yrrd96ecPni13xq2@sirena.org.uk> (raw)
In-Reply-To: <20220628002858.2638442-2-bryan.odonoghue@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 628 bytes --]
On Tue, Jun 28, 2022 at 01:28:57AM +0100, Bryan O'Donoghue wrote:
> The documented yaml compat string for the apq8016 is
> "qcom,apq8016-lpass-cpu" not "qcom,lpass-cpu-apq8016". Looking at the other
> lpass compat strings the general form is "qcom,socnum-lpass-cpu".
>
> We need to fix both the driver and dts to match.
>
> Fixes: dc1ebd1811e9 ("ASoC: qcom: Add apq8016 lpass driver support")
This isn't really a fix and it's breaking an ABI which has been there
since 2015. By tagging this as a fix you're doubtless going to get the
stable people trying to backport it which will most likely break some
users.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
lgirdwood@gmail.com, linux-arm-msm@vger.kernel.org,
tiwai@suse.com, robh+dt@kernel.org,
srinivas.kandagatla@linaro.org, krzk+dt@kernel.org,
bjorn.andersson@linaro.org
Subject: Re: [PATCH v4 1/2] ASoC: qcom: lpass: Fix apq8016 compat string to match yaml
Date: Tue, 28 Jun 2022 11:54:47 +0100 [thread overview]
Message-ID: <Yrrd96ecPni13xq2@sirena.org.uk> (raw)
In-Reply-To: <20220628002858.2638442-2-bryan.odonoghue@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 628 bytes --]
On Tue, Jun 28, 2022 at 01:28:57AM +0100, Bryan O'Donoghue wrote:
> The documented yaml compat string for the apq8016 is
> "qcom,apq8016-lpass-cpu" not "qcom,lpass-cpu-apq8016". Looking at the other
> lpass compat strings the general form is "qcom,socnum-lpass-cpu".
>
> We need to fix both the driver and dts to match.
>
> Fixes: dc1ebd1811e9 ("ASoC: qcom: Add apq8016 lpass driver support")
This isn't really a fix and it's breaking an ABI which has been there
since 2015. By tagging this as a fix you're doubtless going to get the
stable people trying to backport it which will most likely break some
users.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-06-28 10:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 0:28 [PATCH v4 0/2] Fix apq8016 compat string Bryan O'Donoghue
2022-06-28 0:28 ` Bryan O'Donoghue
2022-06-28 0:28 ` [PATCH v4 1/2] ASoC: qcom: lpass: Fix apq8016 compat string to match yaml Bryan O'Donoghue
2022-06-28 0:28 ` Bryan O'Donoghue
2022-06-28 10:54 ` Mark Brown [this message]
2022-06-28 10:54 ` Mark Brown
2022-06-28 11:03 ` Mark Brown
2022-06-28 11:03 ` Mark Brown
2022-06-28 11:48 ` Bryan O'Donoghue
2022-06-28 11:48 ` Bryan O'Donoghue
2022-06-28 12:07 ` Mark Brown
2022-06-28 12:07 ` Mark Brown
2022-06-28 13:25 ` Bryan O'Donoghue
2022-06-28 0:28 ` [PATCH v4 2/2] arm64: dts: qcom: " Bryan O'Donoghue
2022-06-28 0:28 ` Bryan O'Donoghue
2022-06-28 13:25 ` (subset) [PATCH v4 0/2] Fix apq8016 compat string Mark Brown
2022-06-28 13:25 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yrrd96ecPni13xq2@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bjorn.andersson@linaro.org \
--cc=bryan.odonoghue@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.