[igt-dev] [PATCH i-g-t 0/2] HAX add description to gem_mmap_gtt

[igt-dev] [PATCH i-g-t 0/2] HAX add description to gem_mmap_gtt

[priyanka.dandamudi]

From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>

Add test description to gem_mmap_gtt.

Priyanka Dandamudi (2):
  i915/gem_mmap_gtt: added description for test case
  HAX: don't do full run

 tests/i915/gem_mmap_gtt.c             |  81 ++++++++++--
 tests/intel-ci/fast-feedback.testlist | 176 +-------------------------
 2 files changed, 74 insertions(+), 183 deletions(-)

-- 
2.25.1

[igt-dev] [PATCH i-g-t 1/2] i915/gem_mmap_gtt: added description for test case

[priyanka.dandamudi]

From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>

Added global description and subtest descriptions.

v2:Minor corrections.

v3: Added descriptions to copy subtests.

Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
---
 tests/i915/gem_mmap_gtt.c | 81 +++++++++++++++++++++++++++++++++++----
 1 file changed, 73 insertions(+), 8 deletions(-)

diff --git a/tests/i915/gem_mmap_gtt.c b/tests/i915/gem_mmap_gtt.c
index 6db82229..e39b9047 100644
--- a/tests/i915/gem_mmap_gtt.c
+++ b/tests/i915/gem_mmap_gtt.c
@@ -54,6 +54,8 @@
 
 #define abs(x) ((x) >= 0 ? (x) : -(x))
 
+IGT_TEST_DESCRIPTION("Ensure that all operations around MMAP_GTT ioctl works.");
+
 static int OBJECT_SIZE = 16*1024*1024;
 
 static void
@@ -1272,6 +1274,7 @@ igt_main
 		gem_require_mappable_ggtt(fd);
 	}
 
+	igt_describe("Verify mapping to invalid gem objects fails.");
 	igt_subtest("bad-object") {
 		uint32_t real_handle = gem_create(fd, 4096);
 		uint32_t handles[20];
@@ -1293,77 +1296,126 @@ igt_main
 		gem_close(fd, real_handle);
 	}
 
+	igt_describe("Basic checks of GEM_MMAP_GTT ioctl.");
 	igt_subtest("basic")
 		test_access(fd);
+	igt_describe("Test mmaping less than the full object.");
 	igt_subtest("basic-short")
 		test_short(fd);
+	igt_describe("Test copy between two GTT mmappings.");
 	igt_subtest("basic-copy")
 		test_copy(fd);
+	igt_describe("Test to read content from GTT mmapped object.");
 	igt_subtest("basic-read")
 		test_read(fd);
+	igt_describe("Test to write content to GTT mmapped object.");
 	igt_subtest("basic-write")
 		test_write(fd);
+	igt_describe("Test creates a prefault object into GTT and "
+		     "writes into it from another GTT mmapped.");
 	igt_subtest("basic-write-gtt")
 		test_write_gtt(fd);
+	igt_describe("Inspect a GTT mmap using ptrace().");
 	igt_subtest("ptrace")
 		test_ptrace(fd);
+	igt_describe("Check whether a write through the GTT is immediately visible to the CPU.");
 	igt_subtest("coherency")
 		test_coherency(fd);
+	igt_describe("Check the userspace clflushing of the GTT mmap.");
 	igt_subtest("clflush")
 		test_clflush(fd);
+	igt_describe("Check read/writes across a GPU reset.");
 	igt_subtest("hang")
 		test_hang(fd);
+	igt_describe("Exercise the GTT mmap revocation for a reset on a busy object.");
 	igt_subtest("hang-busy")
 		test_hang_busy(fd);
+	igt_describe("Mix a busy hang with GTT and userptr.");
 	igt_subtest("hang-user")
 		test_hang_user(fd);
+	igt_describe("Check basic read->write order of a GTT mmapped bo.");
 	igt_subtest("basic-read-write")
 		test_read_write(fd, READ_BEFORE_WRITE);
+	igt_describe("Check basic write->read order of a GTT mmapped bo.");
 	igt_subtest("basic-write-read")
 		test_read_write(fd, READ_AFTER_WRITE);
+	igt_describe("Check distinct read->write order of a GTT mmapped bo.");
 	igt_subtest("basic-read-write-distinct")
 		test_read_write2(fd, READ_BEFORE_WRITE);
+	igt_describe("Check distinct write->read order of a GTT mmapped bo.");
 	igt_subtest("basic-write-read-distinct")
 		test_read_write2(fd, READ_AFTER_WRITE);
+	igt_describe("Excercise concurrent pagefaulting of a GTT mmaped bo.");
 	igt_subtest("fault-concurrent")
 		test_fault_concurrent(fd, I915_TILING_NONE);
+	igt_describe("Excercise concurrent pagefaulting of a X-tiled GTT mmaped bo.");
 	igt_subtest("fault-concurrent-X")
 		test_fault_concurrent(fd, I915_TILING_X);
+	igt_describe("Excercise concurrent pagefaulting of a Y-tiled GTT mmaped bo.");
 	igt_subtest("fault-concurrent-Y")
 		test_fault_concurrent(fd, I915_TILING_Y);
+	igt_describe("Check coherency between GTT and CPU mmappings with LLC.");
 	igt_subtest("basic-write-cpu-read-gtt")
 		test_write_cpu_read_gtt(fd);
+	igt_describe("Check the performance of WC writes with WC reads of GTT "
+		     "and WC writes of GTT with WB writes of CPU.");
 	igt_subtest("basic-wc")
 		test_wc(fd);
+	igt_describe("Test mmap_offset lifetime, closing the object on"
+		     " another file should not affect the local mmap_offset.");
 	igt_subtest("isolation")
 		test_isolation(fd);
+	igt_describe("Test MMAP_GTT extension validity.");
 	igt_subtest("zero-extend")
 		test_zero_extend(fd);
+	igt_describe("Test to check that a few threads opening and closing handles"
+		     " cause explosion in other threads in the process of mmaping that handle.");
 	igt_subtest("close-race")
 		test_close_race(fd);
+	igt_describe("Test to check that a few threads opening and closing flink handles"
+		     " cause explosion in other threads in the process of mmaping that handle.");
 	igt_subtest("flink-race")
 		test_flink_race(fd);
+	igt_describe("Check that the initial pagefault is non-blocking.");
 	igt_subtest("pf-nonblock")
 		test_pf_nonblock(fd);
 
+	igt_describe("Check mmap access to a small buffer object by CPU directly"
+		     " and through GTT in sequence.");
 	igt_subtest("basic-small-bo")
 		test_huge_bo(fd, -1, I915_TILING_NONE);
+	igt_describe("Check mmap access to a small X-tiled buffer object by CPU "
+		     "directly and through GTT in sequence.");
 	igt_subtest("basic-small-bo-tiledX")
 		test_huge_bo(fd, -1, I915_TILING_X);
+	igt_describe("Check mmap access to a small Y-tiled buffer object by CPU "
+		     "directly and through GTT in sequence.");
 	igt_subtest("basic-small-bo-tiledY")
 		test_huge_bo(fd, -1, I915_TILING_Y);
 
+	igt_describe("Check mmap access to a big buffer object by CPU directly "
+		     "and through GTT in sequence.");
 	igt_subtest("big-bo")
 		test_huge_bo(fd, 0, I915_TILING_NONE);
+	igt_describe("Check mmap access to a big X-tiled buffer object by CPU "
+		     "directly and through GTT in sequence.");
 	igt_subtest("big-bo-tiledX")
 		test_huge_bo(fd, 0, I915_TILING_X);
+	igt_describe("Check mmap access to a big Y-tiled buffer object by CPU "
+		     "directly and through GTT in sequence.");
 	igt_subtest("big-bo-tiledY")
 		test_huge_bo(fd, 0, I915_TILING_Y);
 
+	igt_describe("Check mmap access to a huge buffer object by CPU directly "
+		     "and through GTT in sequence.");
 	igt_subtest("huge-bo")
 		test_huge_bo(fd, 1, I915_TILING_NONE);
+	igt_describe("Check mmap access to a huge X-tiled buffer object by CPU "
+		     "directly and through GTT in sequence.");
 	igt_subtest("huge-bo-tiledX")
 		test_huge_bo(fd, 1, I915_TILING_X);
+	igt_describe("Check mmap access to a huge Y-tiled buffer object by CPU "
+		     "directly and through GTT in sequence.");
 	igt_subtest("huge-bo-tiledY")
 		test_huge_bo(fd, 1, I915_TILING_Y);
 
@@ -1371,27 +1423,33 @@ igt_main
 		const struct copy_size {
 			const char *prefix;
 			int size;
+			const char *description;
 		} copy_sizes[] = {
-			{ "basic-small", -2 },
-			{ "medium", -1 },
-			{ "big", 0 },
-			{ "huge", 1 },
-			{ "swap", 2 },
+			{ "basic-small", -2, "small bo's." },
+			{ "medium", -1, "medium bo's." },
+			{ "big", 0, "big bo's." },
+			{ "huge", 1, "huge bo's." },
+			{ "swap", 2, "huge bo's larger than physical memory"
+				     " and resulting in thrashing of swap space." },
 			{ }
 		};
 		const struct copy_mode {
 			const char *suffix;
 			int tiling_x, tiling_y;
+			const char *description;
 		} copy_modes[] = {
-			{ "", I915_TILING_NONE, I915_TILING_NONE},
-			{ "-XY", I915_TILING_X, I915_TILING_Y},
-			{ "-odd", -I915_TILING_X, -I915_TILING_Y},
+			{ "", I915_TILING_NONE, I915_TILING_NONE, "normal"},
+			{ "-XY", I915_TILING_X, I915_TILING_Y, "tiled"},
+			{ "-odd", -I915_TILING_X, -I915_TILING_Y, "odd tiled"},
 			{}
 		};
 		const int ncpus = sysconf(_SC_NPROCESSORS_ONLN);
 
 		for (const struct copy_size *s = copy_sizes; s->prefix; s++)
 			for (const struct copy_mode *m = copy_modes; m->suffix; m++) {
+				igt_describe_f("Check page by page copying between two GTT"
+					       " mmapped %s-%s", m->description,
+					       s->description);
 				igt_subtest_f("%s-copy%s", s->prefix, m->suffix)
 					test_huge_copy(fd,
 						       s->size,
@@ -1399,6 +1457,10 @@ igt_main
 						       m->tiling_y,
 						       1);
 
+				igt_describe_f("Add forked contention with lighter variant"
+					       " (single cpu) and check page by page copying"
+					       " between two GTT mmapped %s-%s",
+					       m->description, s->description);
 				igt_subtest_f("cpuset-%s-copy%s", s->prefix, m->suffix) {
 					cpu_set_t cpu, old;
 
@@ -1416,6 +1478,9 @@ igt_main
 					igt_assert(sched_setaffinity(0, sizeof(old), &old) == 0);
 				}
 
+				igt_describe_f("Add forked contention and check page by page"
+					       " copying between two GTT mmapped %s-%s",
+					       m->description, s->description);
 				igt_subtest_f("forked-%s-copy%s", s->prefix, m->suffix)
 					test_huge_copy(fd,
 						       s->size,
-- 
2.25.1

[igt-dev] [PATCH i-g-t 2/2] HAX: don't do full run

[priyanka.dandamudi]

From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>

Just for test description, no full run is necessary.

Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
---
 tests/intel-ci/fast-feedback.testlist | 176 +-------------------------
 1 file changed, 1 insertion(+), 175 deletions(-)

diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index bd5538a0..1d57372d 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -1,177 +1,3 @@
-# Try to load the driver if it's not available yet.
-igt@i915_module_load@load
-
 # Keep alphabetically sorted by default
-igt@core_auth@basic-auth
-igt@debugfs_test@read_all_entries
-igt@fbdev@eof
-igt@fbdev@info
-igt@fbdev@nullptr
-igt@fbdev@read
-igt@fbdev@write
-igt@gem_basic@bad-close
-igt@gem_basic@create-close
-igt@gem_basic@create-fd-close
-igt@gem_busy@busy@all
-igt@gem_close_race@basic-process
-igt@gem_close_race@basic-threads
-igt@gem_ctx_create@basic
-igt@gem_ctx_create@basic-files
-igt@gem_ctx_exec@basic
-igt@gem_exec_basic@basic
-igt@gem_exec_create@basic
-igt@gem_exec_fence@basic-busy
-igt@gem_exec_fence@basic-wait
-igt@gem_exec_fence@basic-await
-igt@gem_exec_fence@nb-await
-igt@gem_exec_gttfill@basic
-igt@gem_exec_parallel@engines
-igt@gem_exec_store@basic
-igt@gem_flink_basic@bad-flink
-igt@gem_flink_basic@bad-open
-igt@gem_flink_basic@basic
-igt@gem_flink_basic@double-flink
-igt@gem_flink_basic@flink-lifetime
-igt@gem_huc_copy@huc-copy
-igt@gem_linear_blits@basic
-igt@gem_mmap@basic
-igt@gem_mmap_gtt@basic
-igt@gem_render_linear_blits@basic
-igt@gem_render_tiled_blits@basic
-igt@gem_ringfill@basic-all
-igt@gem_softpin@allocator-basic
-igt@gem_softpin@allocator-basic-reserve
-igt@gem_softpin@safe-alignment
-igt@gem_sync@basic-all
-igt@gem_sync@basic-each
-igt@gem_tiled_blits@basic
-igt@gem_tiled_fence_blits@basic
-igt@gem_tiled_pread_basic
-igt@gem_wait@busy@all
-igt@gem_wait@wait@all
-igt@i915_getparams_basic@basic-eu-total
-igt@i915_getparams_basic@basic-subslice-total
-igt@i915_hangman@error-state-basic
-igt@i915_pciid
-igt@kms_addfb_basic@addfb25-bad-modifier
-igt@kms_addfb_basic@addfb25-framebuffer-vs-set-tiling
-igt@kms_addfb_basic@addfb25-modifier-no-flag
-igt@kms_addfb_basic@addfb25-x-tiled-legacy
-igt@kms_addfb_basic@addfb25-x-tiled-mismatch-legacy
-igt@kms_addfb_basic@addfb25-yf-tiled-legacy
-igt@kms_addfb_basic@addfb25-y-tiled-legacy
-igt@kms_addfb_basic@addfb25-y-tiled-small-legacy
-igt@kms_addfb_basic@bad-pitch-0
-igt@kms_addfb_basic@bad-pitch-1024
-igt@kms_addfb_basic@bad-pitch-128
-igt@kms_addfb_basic@bad-pitch-256
-igt@kms_addfb_basic@bad-pitch-32
-igt@kms_addfb_basic@bad-pitch-63
-igt@kms_addfb_basic@bad-pitch-65536
-igt@kms_addfb_basic@bad-pitch-999
-igt@kms_addfb_basic@basic
-igt@kms_addfb_basic@basic-x-tiled-legacy
-igt@kms_addfb_basic@basic-y-tiled-legacy
-igt@kms_addfb_basic@bo-too-small
-igt@kms_addfb_basic@bo-too-small-due-to-tiling
-igt@kms_addfb_basic@clobberred-modifier
-igt@kms_addfb_basic@framebuffer-vs-set-tiling
-igt@kms_addfb_basic@invalid-get-prop
-igt@kms_addfb_basic@invalid-get-prop-any
-igt@kms_addfb_basic@invalid-set-prop
-igt@kms_addfb_basic@invalid-set-prop-any
-igt@kms_addfb_basic@no-handle
-igt@kms_addfb_basic@size-max
-igt@kms_addfb_basic@small-bo
-igt@kms_addfb_basic@tile-pitch-mismatch
-igt@kms_addfb_basic@too-high
-igt@kms_addfb_basic@too-wide
-igt@kms_addfb_basic@unused-handle
-igt@kms_addfb_basic@unused-modifier
-igt@kms_addfb_basic@unused-offsets
-igt@kms_addfb_basic@unused-pitches
-igt@kms_busy@basic
-igt@kms_chamelium@dp-hpd-fast
-igt@kms_chamelium@dp-edid-read
-igt@kms_chamelium@dp-crc-fast
-igt@kms_chamelium@hdmi-hpd-fast
-igt@kms_chamelium@hdmi-edid-read
-igt@kms_chamelium@hdmi-crc-fast
-igt@kms_chamelium@vga-hpd-fast
-igt@kms_chamelium@vga-edid-read
-igt@kms_prop_blob@basic
-igt@kms_cursor_legacy@basic-busy-flip-before-cursor
-igt@kms_cursor_legacy@basic-flip-after-cursor
-igt@kms_cursor_legacy@basic-flip-before-cursor
-igt@kms_flip@basic-flip-vs-dpms
-igt@kms_flip@basic-flip-vs-modeset
-igt@kms_flip@basic-flip-vs-wf_vblank
-igt@kms_flip@basic-plain-flip
-igt@kms_force_connector_basic@force-connector-state
-igt@kms_force_connector_basic@force-edid
-igt@kms_force_connector_basic@force-load-detect
-igt@kms_force_connector_basic@prune-stale-modes
-igt@kms_frontbuffer_tracking@basic
-igt@kms_pipe_crc_basic@compare-crc-sanitycheck
-igt@kms_pipe_crc_basic@hang-read-crc
-igt@kms_pipe_crc_basic@nonblocking-crc
-igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence
-igt@kms_pipe_crc_basic@read-crc
-igt@kms_pipe_crc_basic@read-crc-frame-sequence
-igt@kms_psr@primary_page_flip
-igt@kms_psr@cursor_plane_move
-igt@kms_psr@sprite_plane_onoff
-igt@kms_psr@primary_mmap_gtt
-igt@kms_setmode@basic-clone-single-crtc
-igt@i915_pm_backlight@basic-brightness
-igt@i915_pm_rpm@basic-pci-d3-state
-igt@i915_pm_rpm@basic-rte
-igt@i915_pm_rps@basic-api
-igt@prime_self_import@basic-llseek-bad
-igt@prime_self_import@basic-llseek-size
-igt@prime_self_import@basic-with_fd_dup
-igt@prime_self_import@basic-with_one_bo
-igt@prime_self_import@basic-with_one_bo_two_files
-igt@prime_self_import@basic-with_two_bos
-igt@prime_vgem@basic-fence-flip
-igt@prime_vgem@basic-fence-mmap
-igt@prime_vgem@basic-fence-read
-igt@prime_vgem@basic-gtt
-igt@prime_vgem@basic-read
-igt@prime_vgem@basic-write
-igt@prime_vgem@basic-userptr
-igt@vgem_basic@setversion
-igt@vgem_basic@create
-igt@vgem_basic@debugfs
-igt@vgem_basic@dmabuf-export
-igt@vgem_basic@dmabuf-fence
-igt@vgem_basic@dmabuf-fence-before
-igt@vgem_basic@dmabuf-mmap
-igt@vgem_basic@mmap
-igt@vgem_basic@second-client
-igt@vgem_basic@sysfs
-
-# All tests that do module unloading and reloading are executed last.
-# They will sometimes reveal issues of earlier tests leaving the
-# driver in a broken state that is not otherwise noticed in that test.
-
-igt@core_hotunplug@unbind-rebind
-igt@vgem_basic@unload
-igt@i915_module_load@reload
-igt@gem_lmem_swapping@basic
-igt@gem_lmem_swapping@parallel-random-engines
-igt@gem_lmem_swapping@random-engines
-igt@gem_lmem_swapping@verify-random
-igt@i915_pm_rpm@module-reload
-
-# Kernel selftests
-igt@i915_selftest@live
-igt@dmabuf@all
 
-# System wide suspend tests
-igt@i915_suspend@basic-s2idle-without-i915
-igt@i915_suspend@basic-s3-without-i915
-igt@gem_exec_suspend@basic-s0
-igt@gem_exec_suspend@basic-s3
-igt@kms_chamelium@common-hpd-after-suspend
-igt@kms_pipe_crc_basic@suspend-read-crc
+igt@meta_test@fail-result
-- 
2.25.1

[igt-dev] ✗ Fi.CI.BAT: failure for HAX add description to gem_mmap_gtt

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 8378 bytes --]

== Series Details ==

Series: HAX add description to gem_mmap_gtt
URL   : https://patchwork.freedesktop.org/series/105714/
State : failure

== Summary ==

CI Bug Log - changes from IGT_6544 -> IGTPW_7414
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_7414 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_7414, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/index.html

Participating hosts (40 -> 43)
------------------------------

  Additional (4): bat-adlm-1 bat-adls-5 bat-adlp-4 bat-dg1-5 
  Missing    (1): fi-bdw-samus 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_7414:

### IGT changes ###

#### Possible regressions ####

  * igt@meta_test@fail-result (NEW):
    - fi-ilk-650:         NOTRUN -> [FAIL][1]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/fi-ilk-650/igt@meta_test@fail-result.html
    - fi-tgl-u2:          NOTRUN -> [FAIL][2]
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/fi-tgl-u2/igt@meta_test@fail-result.html
    - {bat-jsl-1}:        NOTRUN -> [FAIL][3]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/bat-jsl-1/igt@meta_test@fail-result.html
    - fi-bxt-dsi:         NOTRUN -> [FAIL][4]
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/fi-bxt-dsi/igt@meta_test@fail-result.html
    - {fi-jsl-1}:         NOTRUN -> [FAIL][5]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/fi-jsl-1/igt@meta_test@fail-result.html
    - fi-blb-e6850:       NOTRUN -> [FAIL][6]
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/fi-blb-e6850/igt@meta_test@fail-result.html
    - {bat-adlp-6}:       NOTRUN -> [FAIL][7]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/bat-adlp-6/igt@meta_test@fail-result.html
    - fi-skl-6600u:       NOTRUN -> [FAIL][8]
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/fi-skl-6600u/igt@meta_test@fail-result.html
    - fi-glk-dsi:         NOTRUN -> [FAIL][9]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/fi-glk-dsi/igt@meta_test@fail-result.html
    - {fi-ehl-2}:         NOTRUN -> [FAIL][10]
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/fi-ehl-2/igt@meta_test@fail-result.html
    - fi-icl-u2:          NOTRUN -> [FAIL][11]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/fi-icl-u2/igt@meta_test@fail-result.html
    - fi-apl-guc:         NOTRUN -> [FAIL][12]
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/fi-apl-guc/igt@meta_test@fail-result.html
    - bat-dg1-5:          NOTRUN -> [FAIL][13]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/bat-dg1-5/igt@meta_test@fail-result.html
    - fi-pnv-d510:        NOTRUN -> [FAIL][14]
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/fi-pnv-d510/igt@meta_test@fail-result.html
    - fi-bdw-5557u:       NOTRUN -> [FAIL][15]
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/fi-bdw-5557u/igt@meta_test@fail-result.html
    - fi-snb-2520m:       NOTRUN -> [FAIL][16]
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/fi-snb-2520m/igt@meta_test@fail-result.html
    - fi-glk-j4005:       NOTRUN -> [FAIL][17]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/fi-glk-j4005/igt@meta_test@fail-result.html
    - fi-rkl-guc:         NOTRUN -> [FAIL][18]
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/fi-rkl-guc/igt@meta_test@fail-result.html
    - fi-skl-guc:         NOTRUN -> [FAIL][19]
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/fi-skl-guc/igt@meta_test@fail-result.html
    - fi-kbl-soraka:      NOTRUN -> [FAIL][20]
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/fi-kbl-soraka/igt@meta_test@fail-result.html
    - bat-dg1-6:          NOTRUN -> [FAIL][21]
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/bat-dg1-6/igt@meta_test@fail-result.html
    - fi-kbl-7567u:       NOTRUN -> [FAIL][22]
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/fi-kbl-7567u/igt@meta_test@fail-result.html
    - fi-cfl-8700k:       NOTRUN -> [FAIL][23]
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/fi-cfl-8700k/igt@meta_test@fail-result.html
    - {fi-tgl-dsi}:       NOTRUN -> [FAIL][24]
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/fi-tgl-dsi/igt@meta_test@fail-result.html
    - fi-bsw-nick:        NOTRUN -> [FAIL][25]
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/fi-bsw-nick/igt@meta_test@fail-result.html
    - fi-hsw-g3258:       NOTRUN -> [FAIL][26]
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/fi-hsw-g3258/igt@meta_test@fail-result.html
    - {bat-adls-5}:       NOTRUN -> [FAIL][27]
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/bat-adls-5/igt@meta_test@fail-result.html
    - fi-bdw-gvtdvm:      NOTRUN -> [FAIL][28]
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/fi-bdw-gvtdvm/igt@meta_test@fail-result.html
    - fi-bsw-kefka:       NOTRUN -> [FAIL][29]
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/fi-bsw-kefka/igt@meta_test@fail-result.html
    - fi-adl-ddr5:        NOTRUN -> [FAIL][30]
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/fi-adl-ddr5/igt@meta_test@fail-result.html
    - {bat-dg2-9}:        NOTRUN -> [FAIL][31]
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/bat-dg2-9/igt@meta_test@fail-result.html
    - fi-hsw-4770:        NOTRUN -> [FAIL][32]
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/fi-hsw-4770/igt@meta_test@fail-result.html
    - fi-skl-6700k2:      NOTRUN -> [FAIL][33]
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/fi-skl-6700k2/igt@meta_test@fail-result.html
    - fi-cfl-8109u:       NOTRUN -> [FAIL][34]
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/fi-cfl-8109u/igt@meta_test@fail-result.html
    - bat-adlp-4:         NOTRUN -> [FAIL][35]
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/bat-adlp-4/igt@meta_test@fail-result.html
    - {bat-adln-1}:       NOTRUN -> [FAIL][36]
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/bat-adln-1/igt@meta_test@fail-result.html
    - fi-kbl-8809g:       NOTRUN -> [FAIL][37]
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/fi-kbl-8809g/igt@meta_test@fail-result.html
    - fi-ivb-3770:        NOTRUN -> [FAIL][38]
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/fi-ivb-3770/igt@meta_test@fail-result.html
    - fi-elk-e7500:       NOTRUN -> [FAIL][39]
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/fi-elk-e7500/igt@meta_test@fail-result.html
    - {bat-dg2-8}:        NOTRUN -> [FAIL][40]
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/bat-dg2-8/igt@meta_test@fail-result.html
    - fi-kbl-guc:         NOTRUN -> [FAIL][41]
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/fi-kbl-guc/igt@meta_test@fail-result.html
    - fi-snb-2600:        NOTRUN -> [FAIL][42]
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/fi-snb-2600/igt@meta_test@fail-result.html
    - {bat-adlm-1}:       NOTRUN -> [FAIL][43]
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/bat-adlm-1/igt@meta_test@fail-result.html

  
New tests
---------

  New tests have been introduced between IGT_6544 and IGTPW_7414:

### New IGT tests (1) ###

  * igt@meta_test@fail-result:
    - Statuses : 43 fail(s)
    - Exec time: [0.00, 0.34] s

  

  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).



Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_6544 -> IGTPW_7414

  CI-20190529: 20190529
  CI_DRM_11817: 001d43f0d51677c2f8a45e95dcaf63a95c3934e9 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_7414: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/index.html
  IGT_6544: 7043ebd7313dbceb3d931aa2dbc0d67288982d40 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7414/index.html

[-- Attachment #2: Type: text/html, Size: 9647 bytes --]

Re: [igt-dev] [PATCH i-g-t 1/2] i915/gem_mmap_gtt: added description for test case

[Kamil Konieczny]

On 2022-06-28 at 13:30:53 +0530, priyanka.dandamudi@intel.com wrote:
> From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> 
> Added global description and subtest descriptions.
> 
> v2:Minor corrections.
> 
> v3: Added descriptions to copy subtests.
> 
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>

Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

> ---
>  tests/i915/gem_mmap_gtt.c | 81 +++++++++++++++++++++++++++++++++++----
>  1 file changed, 73 insertions(+), 8 deletions(-)
> 
> diff --git a/tests/i915/gem_mmap_gtt.c b/tests/i915/gem_mmap_gtt.c
> index 6db82229..e39b9047 100644
> --- a/tests/i915/gem_mmap_gtt.c
> +++ b/tests/i915/gem_mmap_gtt.c
> @@ -54,6 +54,8 @@
>  
>  #define abs(x) ((x) >= 0 ? (x) : -(x))
>  
> +IGT_TEST_DESCRIPTION("Ensure that all operations around MMAP_GTT ioctl works.");
> +
>  static int OBJECT_SIZE = 16*1024*1024;
>  
>  static void
> @@ -1272,6 +1274,7 @@ igt_main
>  		gem_require_mappable_ggtt(fd);
>  	}
>  
> +	igt_describe("Verify mapping to invalid gem objects fails.");
>  	igt_subtest("bad-object") {
>  		uint32_t real_handle = gem_create(fd, 4096);
>  		uint32_t handles[20];
> @@ -1293,77 +1296,126 @@ igt_main
>  		gem_close(fd, real_handle);
>  	}
>  
> +	igt_describe("Basic checks of GEM_MMAP_GTT ioctl.");
>  	igt_subtest("basic")
>  		test_access(fd);
> +	igt_describe("Test mmaping less than the full object.");
>  	igt_subtest("basic-short")
>  		test_short(fd);
> +	igt_describe("Test copy between two GTT mmappings.");
>  	igt_subtest("basic-copy")
>  		test_copy(fd);
> +	igt_describe("Test to read content from GTT mmapped object.");
>  	igt_subtest("basic-read")
>  		test_read(fd);
> +	igt_describe("Test to write content to GTT mmapped object.");
>  	igt_subtest("basic-write")
>  		test_write(fd);
> +	igt_describe("Test creates a prefault object into GTT and "
> +		     "writes into it from another GTT mmapped.");
>  	igt_subtest("basic-write-gtt")
>  		test_write_gtt(fd);
> +	igt_describe("Inspect a GTT mmap using ptrace().");
>  	igt_subtest("ptrace")
>  		test_ptrace(fd);
> +	igt_describe("Check whether a write through the GTT is immediately visible to the CPU.");
>  	igt_subtest("coherency")
>  		test_coherency(fd);
> +	igt_describe("Check the userspace clflushing of the GTT mmap.");
>  	igt_subtest("clflush")
>  		test_clflush(fd);
> +	igt_describe("Check read/writes across a GPU reset.");
>  	igt_subtest("hang")
>  		test_hang(fd);
> +	igt_describe("Exercise the GTT mmap revocation for a reset on a busy object.");
>  	igt_subtest("hang-busy")
>  		test_hang_busy(fd);
> +	igt_describe("Mix a busy hang with GTT and userptr.");
>  	igt_subtest("hang-user")
>  		test_hang_user(fd);
> +	igt_describe("Check basic read->write order of a GTT mmapped bo.");
>  	igt_subtest("basic-read-write")
>  		test_read_write(fd, READ_BEFORE_WRITE);
> +	igt_describe("Check basic write->read order of a GTT mmapped bo.");
>  	igt_subtest("basic-write-read")
>  		test_read_write(fd, READ_AFTER_WRITE);
> +	igt_describe("Check distinct read->write order of a GTT mmapped bo.");
>  	igt_subtest("basic-read-write-distinct")
>  		test_read_write2(fd, READ_BEFORE_WRITE);
> +	igt_describe("Check distinct write->read order of a GTT mmapped bo.");
>  	igt_subtest("basic-write-read-distinct")
>  		test_read_write2(fd, READ_AFTER_WRITE);
> +	igt_describe("Excercise concurrent pagefaulting of a GTT mmaped bo.");
>  	igt_subtest("fault-concurrent")
>  		test_fault_concurrent(fd, I915_TILING_NONE);
> +	igt_describe("Excercise concurrent pagefaulting of a X-tiled GTT mmaped bo.");
>  	igt_subtest("fault-concurrent-X")
>  		test_fault_concurrent(fd, I915_TILING_X);
> +	igt_describe("Excercise concurrent pagefaulting of a Y-tiled GTT mmaped bo.");
>  	igt_subtest("fault-concurrent-Y")
>  		test_fault_concurrent(fd, I915_TILING_Y);
> +	igt_describe("Check coherency between GTT and CPU mmappings with LLC.");
>  	igt_subtest("basic-write-cpu-read-gtt")
>  		test_write_cpu_read_gtt(fd);
> +	igt_describe("Check the performance of WC writes with WC reads of GTT "
> +		     "and WC writes of GTT with WB writes of CPU.");
>  	igt_subtest("basic-wc")
>  		test_wc(fd);
> +	igt_describe("Test mmap_offset lifetime, closing the object on"
> +		     " another file should not affect the local mmap_offset.");
>  	igt_subtest("isolation")
>  		test_isolation(fd);
> +	igt_describe("Test MMAP_GTT extension validity.");
>  	igt_subtest("zero-extend")
>  		test_zero_extend(fd);
> +	igt_describe("Test to check that a few threads opening and closing handles"
> +		     " cause explosion in other threads in the process of mmaping that handle.");
>  	igt_subtest("close-race")
>  		test_close_race(fd);
> +	igt_describe("Test to check that a few threads opening and closing flink handles"
> +		     " cause explosion in other threads in the process of mmaping that handle.");
>  	igt_subtest("flink-race")
>  		test_flink_race(fd);
> +	igt_describe("Check that the initial pagefault is non-blocking.");
>  	igt_subtest("pf-nonblock")
>  		test_pf_nonblock(fd);
>  
> +	igt_describe("Check mmap access to a small buffer object by CPU directly"
> +		     " and through GTT in sequence.");
>  	igt_subtest("basic-small-bo")
>  		test_huge_bo(fd, -1, I915_TILING_NONE);
> +	igt_describe("Check mmap access to a small X-tiled buffer object by CPU "
> +		     "directly and through GTT in sequence.");
>  	igt_subtest("basic-small-bo-tiledX")
>  		test_huge_bo(fd, -1, I915_TILING_X);
> +	igt_describe("Check mmap access to a small Y-tiled buffer object by CPU "
> +		     "directly and through GTT in sequence.");
>  	igt_subtest("basic-small-bo-tiledY")
>  		test_huge_bo(fd, -1, I915_TILING_Y);
>  
> +	igt_describe("Check mmap access to a big buffer object by CPU directly "
> +		     "and through GTT in sequence.");
>  	igt_subtest("big-bo")
>  		test_huge_bo(fd, 0, I915_TILING_NONE);
> +	igt_describe("Check mmap access to a big X-tiled buffer object by CPU "
> +		     "directly and through GTT in sequence.");
>  	igt_subtest("big-bo-tiledX")
>  		test_huge_bo(fd, 0, I915_TILING_X);
> +	igt_describe("Check mmap access to a big Y-tiled buffer object by CPU "
> +		     "directly and through GTT in sequence.");
>  	igt_subtest("big-bo-tiledY")
>  		test_huge_bo(fd, 0, I915_TILING_Y);
>  
> +	igt_describe("Check mmap access to a huge buffer object by CPU directly "
> +		     "and through GTT in sequence.");
>  	igt_subtest("huge-bo")
>  		test_huge_bo(fd, 1, I915_TILING_NONE);
> +	igt_describe("Check mmap access to a huge X-tiled buffer object by CPU "
> +		     "directly and through GTT in sequence.");
>  	igt_subtest("huge-bo-tiledX")
>  		test_huge_bo(fd, 1, I915_TILING_X);
> +	igt_describe("Check mmap access to a huge Y-tiled buffer object by CPU "
> +		     "directly and through GTT in sequence.");
>  	igt_subtest("huge-bo-tiledY")
>  		test_huge_bo(fd, 1, I915_TILING_Y);
>  
> @@ -1371,27 +1423,33 @@ igt_main
>  		const struct copy_size {
>  			const char *prefix;
>  			int size;
> +			const char *description;
>  		} copy_sizes[] = {
> -			{ "basic-small", -2 },
> -			{ "medium", -1 },
> -			{ "big", 0 },
> -			{ "huge", 1 },
> -			{ "swap", 2 },
> +			{ "basic-small", -2, "small bo's." },
> +			{ "medium", -1, "medium bo's." },
> +			{ "big", 0, "big bo's." },
> +			{ "huge", 1, "huge bo's." },
> +			{ "swap", 2, "huge bo's larger than physical memory"
> +				     " and resulting in thrashing of swap space." },
>  			{ }
>  		};
>  		const struct copy_mode {
>  			const char *suffix;
>  			int tiling_x, tiling_y;
> +			const char *description;
>  		} copy_modes[] = {
> -			{ "", I915_TILING_NONE, I915_TILING_NONE},
> -			{ "-XY", I915_TILING_X, I915_TILING_Y},
> -			{ "-odd", -I915_TILING_X, -I915_TILING_Y},
> +			{ "", I915_TILING_NONE, I915_TILING_NONE, "normal"},
> +			{ "-XY", I915_TILING_X, I915_TILING_Y, "tiled"},
> +			{ "-odd", -I915_TILING_X, -I915_TILING_Y, "odd tiled"},
>  			{}
>  		};
>  		const int ncpus = sysconf(_SC_NPROCESSORS_ONLN);
>  
>  		for (const struct copy_size *s = copy_sizes; s->prefix; s++)
>  			for (const struct copy_mode *m = copy_modes; m->suffix; m++) {
> +				igt_describe_f("Check page by page copying between two GTT"
> +					       " mmapped %s-%s", m->description,
> +					       s->description);
>  				igt_subtest_f("%s-copy%s", s->prefix, m->suffix)
>  					test_huge_copy(fd,
>  						       s->size,
> @@ -1399,6 +1457,10 @@ igt_main
>  						       m->tiling_y,
>  						       1);
>  
> +				igt_describe_f("Add forked contention with lighter variant"
> +					       " (single cpu) and check page by page copying"
> +					       " between two GTT mmapped %s-%s",
> +					       m->description, s->description);
>  				igt_subtest_f("cpuset-%s-copy%s", s->prefix, m->suffix) {
>  					cpu_set_t cpu, old;
>  
> @@ -1416,6 +1478,9 @@ igt_main
>  					igt_assert(sched_setaffinity(0, sizeof(old), &old) == 0);
>  				}
>  
> +				igt_describe_f("Add forked contention and check page by page"
> +					       " copying between two GTT mmapped %s-%s",
> +					       m->description, s->description);
>  				igt_subtest_f("forked-%s-copy%s", s->prefix, m->suffix)
>  					test_huge_copy(fd,
>  						       s->size,
> -- 
> 2.25.1
> 

Re: [igt-dev] [PATCH i-g-t 1/2] i915/gem_mmap_gtt: added description for test case

[Kamil Konieczny]

Hi Priyanka,

I will wait for the rest of descriptions before adding r-b tag.
I have small nits, see below.

On 2022-06-25 at 09:55:27 +0530, priyanka.dandamudi@intel.com wrote:
> From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> 
> Added global description and subtest descriptions.
> 
> v2:Minor corrections.
> 
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> ---
>  tests/i915/gem_mmap_gtt.c | 52 +++++++++++++++++++++++++++++++++++++++
>  1 file changed, 52 insertions(+)
> 
> diff --git a/tests/i915/gem_mmap_gtt.c b/tests/i915/gem_mmap_gtt.c
> index 6db82229..1453e9a5 100644
> --- a/tests/i915/gem_mmap_gtt.c
> +++ b/tests/i915/gem_mmap_gtt.c
> @@ -54,6 +54,8 @@
>  
>  #define abs(x) ((x) >= 0 ? (x) : -(x))
>  
> +IGT_TEST_DESCRIPTION("Ensure that all operations around MMAP_GTT ioctl works.");
> +
>  static int OBJECT_SIZE = 16*1024*1024;
>  
>  static void
> @@ -1272,6 +1274,7 @@ igt_main
>  		gem_require_mappable_ggtt(fd);
>  	}
>  
> +	igt_describe("Verify mapping to invalid gem objects fails.");
>  	igt_subtest("bad-object") {
>  		uint32_t real_handle = gem_create(fd, 4096);
>  		uint32_t handles[20];
> @@ -1293,77 +1296,126 @@ igt_main
>  		gem_close(fd, real_handle);
>  	}
>  
> +	igt_describe("Basic checks of GEM_MMAP_GTT ioctl.");
>  	igt_subtest("basic")
>  		test_access(fd);
> +	igt_describe("Test mmaping less than the full object.");
>  	igt_subtest("basic-short")
>  		test_short(fd);
> +	igt_describe("Test copy between two GTT mmappings.");
>  	igt_subtest("basic-copy")
>  		test_copy(fd);
> +	igt_describe("Test to read content from GTT mmapped object.");
>  	igt_subtest("basic-read")
>  		test_read(fd);
> +	igt_describe("Test to write content to GTT mmapped object.");
>  	igt_subtest("basic-write")
>  		test_write(fd);
> +	igt_describe("Test creates a prefault object into GTT and "
-------------------- ^
> +			"writes into it from another GTT mmapped.");
----------------------- ^

Please align this string to that above.

>  	igt_subtest("basic-write-gtt")
>  		test_write_gtt(fd);
> +	igt_describe("Inspect a GTT mmap using ptrace().");
>  	igt_subtest("ptrace")
>  		test_ptrace(fd);
> +	igt_describe("Check whether a write through the GTT is immediately visible to the CPU.");
>  	igt_subtest("coherency")
>  		test_coherency(fd);
> +	igt_describe("Check the userspace clflushing of the GTT mmap.");
>  	igt_subtest("clflush")
>  		test_clflush(fd);
> +	igt_describe("Check read/writes across a GPU reset.");
>  	igt_subtest("hang")
>  		test_hang(fd);
> +	igt_describe("Exercise the GTT mmap revocation for a reset on a busy object.");
>  	igt_subtest("hang-busy")
>  		test_hang_busy(fd);
> +	igt_describe("Mix a busy hang with GTT and userptr.");
>  	igt_subtest("hang-user")
>  		test_hang_user(fd);
> +	igt_describe("Check basic read->write orderof a GTT mmapped bo.");
--------------------------------------------- ^
s/orderof/order of/

>  	igt_subtest("basic-read-write")
>  		test_read_write(fd, READ_BEFORE_WRITE);
> +	igt_describe("Check basic write->read order of a GTT mmapped bo.");
>  	igt_subtest("basic-write-read")
>  		test_read_write(fd, READ_AFTER_WRITE);
> +	igt_describe("Check distinct read->write order of a GTT mmapped bo.");
>  	igt_subtest("basic-read-write-distinct")
>  		test_read_write2(fd, READ_BEFORE_WRITE);
> +	igt_describe("Check distinct write->read order of a GTT mmapped bo.");
>  	igt_subtest("basic-write-read-distinct")
>  		test_read_write2(fd, READ_AFTER_WRITE);
> +	igt_describe("Excercise concurrent pagefaulting of a GTT mmaped bo.");
>  	igt_subtest("fault-concurrent")
>  		test_fault_concurrent(fd, I915_TILING_NONE);
> +	igt_describe("Excercise concurrent pagefaulting of a X-tiled GTT mmaped bo.");
>  	igt_subtest("fault-concurrent-X")
>  		test_fault_concurrent(fd, I915_TILING_X);
> +	igt_describe("Excercise concurrent pagefaulting of a Y-tiled GTT mmaped bo.");
>  	igt_subtest("fault-concurrent-Y")
>  		test_fault_concurrent(fd, I915_TILING_Y);
> +	igt_describe("Check coherency between GTT and CPU mmappings with LLC.");
>  	igt_subtest("basic-write-cpu-read-gtt")
>  		test_write_cpu_read_gtt(fd);
> +	igt_describe("Check the performance of WC writes with WC reads of GTT "
> +			"and WC writes of GTT with WB writes of CPU.");

Align here.

>  	igt_subtest("basic-wc")
>  		test_wc(fd);
> +	igt_describe("Test mmap_offset lifetime, closing the object on"
> +			" another file should not affect the local mmap_offset.");

Same here.

>  	igt_subtest("isolation")
>  		test_isolation(fd);
> +	igt_describe("Test MMAP_GTT extension validity.");
>  	igt_subtest("zero-extend")
>  		test_zero_extend(fd);
> +	igt_describe("Test to check that a few threads opening and closing handles"
> +			" cause explosion in other threads in the process of mmaping that handle.");

Same here.

>  	igt_subtest("close-race")
>  		test_close_race(fd);
> +	igt_describe("Test to check that a few threads opening and closing flink handles"
> +			" cause explosion in other threads in the process of mmaping that handle.");

Same here.

>  	igt_subtest("flink-race")
>  		test_flink_race(fd);
> +	igt_describe("Check that the initial pagefault is non-blocking.");
>  	igt_subtest("pf-nonblock")
>  		test_pf_nonblock(fd);
>  
> +	igt_describe("Check mmap access to a small buffer object by CPU directly"
> +		       " and through GTT in sequence.");

Same here.

>  	igt_subtest("basic-small-bo")
>  		test_huge_bo(fd, -1, I915_TILING_NONE);
> +	igt_describe("Check mmap access to a small X-tiled buffer object by CPU "
> +			"directly and through GTT in sequence.");

Same here.

>  	igt_subtest("basic-small-bo-tiledX")
>  		test_huge_bo(fd, -1, I915_TILING_X);
> +	igt_describe("Check mmap access to a small Y-tiled buffer object by CPU "
> +			"directly and through GTT in sequence.");

Same here.

>  	igt_subtest("basic-small-bo-tiledY")
>  		test_huge_bo(fd, -1, I915_TILING_Y);
>  
> +	igt_describe("Check mmap access to a big buffer object by CPU directly "
> +			"and through GTT in sequence.");

Same here.

>  	igt_subtest("big-bo")
>  		test_huge_bo(fd, 0, I915_TILING_NONE);
> +	igt_describe("Check mmap access to a big X-tiled buffer object by CPU "
> +			"directly and through GTT in sequence.");

Same here.

>  	igt_subtest("big-bo-tiledX")
>  		test_huge_bo(fd, 0, I915_TILING_X);
> +	igt_describe("Check mmap access to a big Y-tiled buffer object by CPU "
> +			"directly and through GTT in sequence.");

Same here.

>  	igt_subtest("big-bo-tiledY")
>  		test_huge_bo(fd, 0, I915_TILING_Y);
>  
> +	igt_describe("Check mmap access to a huge buffer object by CPU directly "
> +			"and through GTT in sequence.");

Same here.

>  	igt_subtest("huge-bo")
>  		test_huge_bo(fd, 1, I915_TILING_NONE);
> +	igt_describe("Check mmap access to a huge X-tiled buffer object by CPU "
> +			"directly and through GTT in sequence.");

Same here.

>  	igt_subtest("huge-bo-tiledX")
>  		test_huge_bo(fd, 1, I915_TILING_X);
> +	igt_describe("Check mmap access to a huge Y-tiled buffer object by CPU "
> +			"directly and through GTT in sequence.");

Same here.


Regards,
Kamil

>  	igt_subtest("huge-bo-tiledY")
>  		test_huge_bo(fd, 1, I915_TILING_Y);
>  
> -- 
> 2.25.1
> 

[igt-dev] [PATCH i-g-t 1/2] i915/gem_mmap_gtt: added description for test case

[priyanka.dandamudi]

From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>

Added global description and subtest descriptions.

v2:Minor corrections.

Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
---
 tests/i915/gem_mmap_gtt.c | 52 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 52 insertions(+)

diff --git a/tests/i915/gem_mmap_gtt.c b/tests/i915/gem_mmap_gtt.c
index 6db82229..1453e9a5 100644
--- a/tests/i915/gem_mmap_gtt.c
+++ b/tests/i915/gem_mmap_gtt.c
@@ -54,6 +54,8 @@
 
 #define abs(x) ((x) >= 0 ? (x) : -(x))
 
+IGT_TEST_DESCRIPTION("Ensure that all operations around MMAP_GTT ioctl works.");
+
 static int OBJECT_SIZE = 16*1024*1024;
 
 static void
@@ -1272,6 +1274,7 @@ igt_main
 		gem_require_mappable_ggtt(fd);
 	}
 
+	igt_describe("Verify mapping to invalid gem objects fails.");
 	igt_subtest("bad-object") {
 		uint32_t real_handle = gem_create(fd, 4096);
 		uint32_t handles[20];
@@ -1293,77 +1296,126 @@ igt_main
 		gem_close(fd, real_handle);
 	}
 
+	igt_describe("Basic checks of GEM_MMAP_GTT ioctl.");
 	igt_subtest("basic")
 		test_access(fd);
+	igt_describe("Test mmaping less than the full object.");
 	igt_subtest("basic-short")
 		test_short(fd);
+	igt_describe("Test copy between two GTT mmappings.");
 	igt_subtest("basic-copy")
 		test_copy(fd);
+	igt_describe("Test to read content from GTT mmapped object.");
 	igt_subtest("basic-read")
 		test_read(fd);
+	igt_describe("Test to write content to GTT mmapped object.");
 	igt_subtest("basic-write")
 		test_write(fd);
+	igt_describe("Test creates a prefault object into GTT and "
+			"writes into it from another GTT mmapped.");
 	igt_subtest("basic-write-gtt")
 		test_write_gtt(fd);
+	igt_describe("Inspect a GTT mmap using ptrace().");
 	igt_subtest("ptrace")
 		test_ptrace(fd);
+	igt_describe("Check whether a write through the GTT is immediately visible to the CPU.");
 	igt_subtest("coherency")
 		test_coherency(fd);
+	igt_describe("Check the userspace clflushing of the GTT mmap.");
 	igt_subtest("clflush")
 		test_clflush(fd);
+	igt_describe("Check read/writes across a GPU reset.");
 	igt_subtest("hang")
 		test_hang(fd);
+	igt_describe("Exercise the GTT mmap revocation for a reset on a busy object.");
 	igt_subtest("hang-busy")
 		test_hang_busy(fd);
+	igt_describe("Mix a busy hang with GTT and userptr.");
 	igt_subtest("hang-user")
 		test_hang_user(fd);
+	igt_describe("Check basic read->write orderof a GTT mmapped bo.");
 	igt_subtest("basic-read-write")
 		test_read_write(fd, READ_BEFORE_WRITE);
+	igt_describe("Check basic write->read order of a GTT mmapped bo.");
 	igt_subtest("basic-write-read")
 		test_read_write(fd, READ_AFTER_WRITE);
+	igt_describe("Check distinct read->write order of a GTT mmapped bo.");
 	igt_subtest("basic-read-write-distinct")
 		test_read_write2(fd, READ_BEFORE_WRITE);
+	igt_describe("Check distinct write->read order of a GTT mmapped bo.");
 	igt_subtest("basic-write-read-distinct")
 		test_read_write2(fd, READ_AFTER_WRITE);
+	igt_describe("Excercise concurrent pagefaulting of a GTT mmaped bo.");
 	igt_subtest("fault-concurrent")
 		test_fault_concurrent(fd, I915_TILING_NONE);
+	igt_describe("Excercise concurrent pagefaulting of a X-tiled GTT mmaped bo.");
 	igt_subtest("fault-concurrent-X")
 		test_fault_concurrent(fd, I915_TILING_X);
+	igt_describe("Excercise concurrent pagefaulting of a Y-tiled GTT mmaped bo.");
 	igt_subtest("fault-concurrent-Y")
 		test_fault_concurrent(fd, I915_TILING_Y);
+	igt_describe("Check coherency between GTT and CPU mmappings with LLC.");
 	igt_subtest("basic-write-cpu-read-gtt")
 		test_write_cpu_read_gtt(fd);
+	igt_describe("Check the performance of WC writes with WC reads of GTT "
+			"and WC writes of GTT with WB writes of CPU.");
 	igt_subtest("basic-wc")
 		test_wc(fd);
+	igt_describe("Test mmap_offset lifetime, closing the object on"
+			" another file should not affect the local mmap_offset.");
 	igt_subtest("isolation")
 		test_isolation(fd);
+	igt_describe("Test MMAP_GTT extension validity.");
 	igt_subtest("zero-extend")
 		test_zero_extend(fd);
+	igt_describe("Test to check that a few threads opening and closing handles"
+			" cause explosion in other threads in the process of mmaping that handle.");
 	igt_subtest("close-race")
 		test_close_race(fd);
+	igt_describe("Test to check that a few threads opening and closing flink handles"
+			" cause explosion in other threads in the process of mmaping that handle.");
 	igt_subtest("flink-race")
 		test_flink_race(fd);
+	igt_describe("Check that the initial pagefault is non-blocking.");
 	igt_subtest("pf-nonblock")
 		test_pf_nonblock(fd);
 
+	igt_describe("Check mmap access to a small buffer object by CPU directly"
+		       " and through GTT in sequence.");
 	igt_subtest("basic-small-bo")
 		test_huge_bo(fd, -1, I915_TILING_NONE);
+	igt_describe("Check mmap access to a small X-tiled buffer object by CPU "
+			"directly and through GTT in sequence.");
 	igt_subtest("basic-small-bo-tiledX")
 		test_huge_bo(fd, -1, I915_TILING_X);
+	igt_describe("Check mmap access to a small Y-tiled buffer object by CPU "
+			"directly and through GTT in sequence.");
 	igt_subtest("basic-small-bo-tiledY")
 		test_huge_bo(fd, -1, I915_TILING_Y);
 
+	igt_describe("Check mmap access to a big buffer object by CPU directly "
+			"and through GTT in sequence.");
 	igt_subtest("big-bo")
 		test_huge_bo(fd, 0, I915_TILING_NONE);
+	igt_describe("Check mmap access to a big X-tiled buffer object by CPU "
+			"directly and through GTT in sequence.");
 	igt_subtest("big-bo-tiledX")
 		test_huge_bo(fd, 0, I915_TILING_X);
+	igt_describe("Check mmap access to a big Y-tiled buffer object by CPU "
+			"directly and through GTT in sequence.");
 	igt_subtest("big-bo-tiledY")
 		test_huge_bo(fd, 0, I915_TILING_Y);
 
+	igt_describe("Check mmap access to a huge buffer object by CPU directly "
+			"and through GTT in sequence.");
 	igt_subtest("huge-bo")
 		test_huge_bo(fd, 1, I915_TILING_NONE);
+	igt_describe("Check mmap access to a huge X-tiled buffer object by CPU "
+			"directly and through GTT in sequence.");
 	igt_subtest("huge-bo-tiledX")
 		test_huge_bo(fd, 1, I915_TILING_X);
+	igt_describe("Check mmap access to a huge Y-tiled buffer object by CPU "
+			"directly and through GTT in sequence.");
 	igt_subtest("huge-bo-tiledY")
 		test_huge_bo(fd, 1, I915_TILING_Y);
 
-- 
2.25.1

[igt-dev] [PATCH i-g-t 1/2] i915/gem_mmap_gtt: added description for test case

[priyanka.dandamudi]

From: Priyanka Dandamudi <priyanka.dandamudi@intel.com>

Added global description and subtest description.

Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
---
 tests/i915/gem_mmap_gtt.c | 52 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 52 insertions(+)

diff --git a/tests/i915/gem_mmap_gtt.c b/tests/i915/gem_mmap_gtt.c
index 6db82229..dab06ef0 100644
--- a/tests/i915/gem_mmap_gtt.c
+++ b/tests/i915/gem_mmap_gtt.c
@@ -54,6 +54,8 @@
 
 #define abs(x) ((x) >= 0 ? (x) : -(x))
 
+IGT_TEST_DESCRIPTION("Ensure that all operations around MMAP_GTT IOCTL works.");
+
 static int OBJECT_SIZE = 16*1024*1024;
 
 static void
@@ -1272,6 +1274,7 @@ igt_main
 		gem_require_mappable_ggtt(fd);
 	}
 
+	igt_describe("Verify mapping to invalid gem objects.");
 	igt_subtest("bad-object") {
 		uint32_t real_handle = gem_create(fd, 4096);
 		uint32_t handles[20];
@@ -1293,77 +1296,126 @@ igt_main
 		gem_close(fd, real_handle);
 	}
 
+	igt_describe("Test basic working of GEM_MMAP_GTT ioctl.");
 	igt_subtest("basic")
 		test_access(fd);
+	igt_describe("Test mmaping less than the full object.");
 	igt_subtest("basic-short")
 		test_short(fd);
+	igt_describe("Test copying between 2 GTT mmappings.");
 	igt_subtest("basic-copy")
 		test_copy(fd);
+	igt_describe("Test to read content from GTT mmapped.");
 	igt_subtest("basic-read")
 		test_read(fd);
+	igt_describe("Test to write content to GTT mmapped.");
 	igt_subtest("basic-write")
 		test_write(fd);
+	igt_describe("Test creates a prefault object into GTT and "
+			"writes into it from another GTT mmapped.");
 	igt_subtest("basic-write-gtt")
 		test_write_gtt(fd);
+	igt_describe("Inspect a GTT mmap using ptrace().");
 	igt_subtest("ptrace")
 		test_ptrace(fd);
+	igt_describe("Check whether a write through the GTT is immediately visible to the CPU.");
 	igt_subtest("coherency")
 		test_coherency(fd);
+	igt_describe("Check the userspace clflushing of the GTT mmap.");
 	igt_subtest("clflush")
 		test_clflush(fd);
+	igt_describe("Check read/writes across a GPU reset.");
 	igt_subtest("hang")
 		test_hang(fd);
+	igt_describe("Exercise the GTT mmap revocation for a reset on a busy object.");
 	igt_subtest("hang-busy")
 		test_hang_busy(fd);
+	igt_describe("Mix a busy hang with GTT and userptr.");
 	igt_subtest("hang-user")
 		test_hang_user(fd);
+	igt_describe("Check basic read->write orderof a GTT mmapped buffer object.");
 	igt_subtest("basic-read-write")
 		test_read_write(fd, READ_BEFORE_WRITE);
+	igt_describe("Check basic write->read order of a GTT mmapped buffer object.");
 	igt_subtest("basic-write-read")
 		test_read_write(fd, READ_AFTER_WRITE);
+	igt_describe("Check distinct read->write order of a GTT mmapped buffer object.");
 	igt_subtest("basic-read-write-distinct")
 		test_read_write2(fd, READ_BEFORE_WRITE);
+	igt_describe("Check distinct write->read order of a GTT mmapped buffer object.");
 	igt_subtest("basic-write-read-distinct")
 		test_read_write2(fd, READ_AFTER_WRITE);
+	igt_describe("Excercise concurrent pagefaulting of a gtt mmaped object.");
 	igt_subtest("fault-concurrent")
 		test_fault_concurrent(fd, I915_TILING_NONE);
+	igt_describe("Excercise concurrent pagefaulting of a X-tiled gtt mmaped object.");
 	igt_subtest("fault-concurrent-X")
 		test_fault_concurrent(fd, I915_TILING_X);
+	igt_describe("Excercise concurrent pagefaulting of a Y-tiled gtt mmaped object.");
 	igt_subtest("fault-concurrent-Y")
 		test_fault_concurrent(fd, I915_TILING_Y);
+	igt_describe("Check coherency between GTT and CPU mmappings with LLC.");
 	igt_subtest("basic-write-cpu-read-gtt")
 		test_write_cpu_read_gtt(fd);
+	igt_describe("Check the performance of WC writes with WC reads of GTT "
+			"and WC writes of GTT with WB writes of CPU.");
 	igt_subtest("basic-wc")
 		test_wc(fd);
+	igt_describe("Test mmap_offset lifetime, closing the object on"
+			" another file should not affect the local mmap_offset.");
 	igt_subtest("isolation")
 		test_isolation(fd);
+	igt_describe("Test mmap_gtt extension validity.");
 	igt_subtest("zero-extend")
 		test_zero_extend(fd);
+	igt_describe("Test to check that a few threads opening and closing handles"
+			" cause explosion in other threads in the process of mmaping that handle.");
 	igt_subtest("close-race")
 		test_close_race(fd);
+	igt_describe("Test to check that a few threads opening and closing flink handles"
+			" cause explosion in other threads in the process of mmaping that handle.");
 	igt_subtest("flink-race")
 		test_flink_race(fd);
+	igt_describe("Check that the initial pagefault is non-blocking.");
 	igt_subtest("pf-nonblock")
 		test_pf_nonblock(fd);
 
+	igt_describe("Check mmap access to a small buffer object by CPU directly"
+		       " and through GTT in sequence.");
 	igt_subtest("basic-small-bo")
 		test_huge_bo(fd, -1, I915_TILING_NONE);
+	igt_describe("Check mmap access to a small X-tiled buffer object by CPU "
+			"directly and through GTT in sequence.");
 	igt_subtest("basic-small-bo-tiledX")
 		test_huge_bo(fd, -1, I915_TILING_X);
+	igt_describe("Check mmap access to a small Y-tiled buffer object by CPU "
+			"directly and through GTT in sequence.");
 	igt_subtest("basic-small-bo-tiledY")
 		test_huge_bo(fd, -1, I915_TILING_Y);
 
+	igt_describe("Check mmap access to a big buffer object by CPU directly "
+			"and through GTT in sequence.");
 	igt_subtest("big-bo")
 		test_huge_bo(fd, 0, I915_TILING_NONE);
+	igt_describe("Check mmap access to a big X-tiled buffer object by CPU "
+			"directly and through GTT in sequence.");
 	igt_subtest("big-bo-tiledX")
 		test_huge_bo(fd, 0, I915_TILING_X);
+	igt_describe("Check mmap access to a big Y-tiled buffer object by CPU "
+			"directly and through GTT in sequence.");
 	igt_subtest("big-bo-tiledY")
 		test_huge_bo(fd, 0, I915_TILING_Y);
 
+	igt_describe("Check mmap access to a huge buffer object by CPU directly "
+			"and through GTT in sequence.");
 	igt_subtest("huge-bo")
 		test_huge_bo(fd, 1, I915_TILING_NONE);
+	igt_describe("Check mmap access to a huge X-tiled buffer object by CPU "
+			"directly and through GTT in sequence.");
 	igt_subtest("huge-bo-tiledX")
 		test_huge_bo(fd, 1, I915_TILING_X);
+	igt_describe("Check mmap access to a big Y-tiled buffer object by CPU "
+			"directly and through GTT in sequence.");
 	igt_subtest("huge-bo-tiledY")
 		test_huge_bo(fd, 1, I915_TILING_Y);
 
-- 
2.25.1