* [PATCH] riscv: Fix vdso_install target with CONFIG_COMPAT=y
@ 2022-07-14 11:21 Ben Hutchings
2022-07-17 14:31 ` Guo Ren
0 siblings, 1 reply; 11+ messages in thread
From: Ben Hutchings @ 2022-07-14 11:21 UTC (permalink / raw)
To: linux-riscv; +Cc: Guo Ren
[-- Attachment #1.1: Type: text/plain, Size: 923 bytes --]
The recipe for vdso_install in arch/riscv/Makefile invokes targets of
the same name in arch/riscv/kernel/vdso and .../compat_vdso, but the
target in the latter is called compat_vdso_install. Change the
recipe to use the right target name.
Fixes: 0715372a06ce ("riscv: compat: vdso: Add COMPAT_VDSO base code ...")
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
arch/riscv/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/riscv/Makefile b/arch/riscv/Makefile
index 34cf8a598617..ee763562895c 100644
--- a/arch/riscv/Makefile
+++ b/arch/riscv/Makefile
@@ -110,7 +110,7 @@ PHONY += vdso_install
vdso_install:
$(Q)$(MAKE) $(build)=arch/riscv/kernel/vdso $@
$(if $(CONFIG_COMPAT),$(Q)$(MAKE) \
- $(build)=arch/riscv/kernel/compat_vdso $@)
+ $(build)=arch/riscv/kernel/compat_vdso compat_vdso_install)
ifeq ($(KBUILD_EXTMOD),)
ifeq ($(CONFIG_MMU),y)
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] riscv: Fix vdso_install target with CONFIG_COMPAT=y
2022-07-14 11:21 [PATCH] riscv: Fix vdso_install target with CONFIG_COMPAT=y Ben Hutchings
@ 2022-07-17 14:31 ` Guo Ren
2022-07-17 15:26 ` Ben Hutchings
0 siblings, 1 reply; 11+ messages in thread
From: Guo Ren @ 2022-07-17 14:31 UTC (permalink / raw)
To: Ben Hutchings; +Cc: linux-riscv
On Thu, Jul 14, 2022 at 7:21 PM Ben Hutchings <ben@decadent.org.uk> wrote:
>
> The recipe for vdso_install in arch/riscv/Makefile invokes targets of
> the same name in arch/riscv/kernel/vdso and .../compat_vdso, but the
> target in the latter is called compat_vdso_install. Change the
> recipe to use the right target name.
>
> Fixes: 0715372a06ce ("riscv: compat: vdso: Add COMPAT_VDSO base code ...")
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> ---
> arch/riscv/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/Makefile b/arch/riscv/Makefile
> index 34cf8a598617..ee763562895c 100644
> --- a/arch/riscv/Makefile
> +++ b/arch/riscv/Makefile
> @@ -110,7 +110,7 @@ PHONY += vdso_install
> vdso_install:
> $(Q)$(MAKE) $(build)=arch/riscv/kernel/vdso $@
> $(if $(CONFIG_COMPAT),$(Q)$(MAKE) \
> - $(build)=arch/riscv/kernel/compat_vdso $@)
> + $(build)=arch/riscv/kernel/compat_vdso compat_vdso_install)
Good catch, but what's the problem you've met?
>
> ifeq ($(KBUILD_EXTMOD),)
> ifeq ($(CONFIG_MMU),y)
--
Best Regards
Guo Ren
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] riscv: Fix vdso_install target with CONFIG_COMPAT=y
2022-07-17 14:31 ` Guo Ren
@ 2022-07-17 15:26 ` Ben Hutchings
2022-07-17 23:29 ` Guo Ren
0 siblings, 1 reply; 11+ messages in thread
From: Ben Hutchings @ 2022-07-17 15:26 UTC (permalink / raw)
To: Guo Ren; +Cc: linux-riscv
[-- Attachment #1.1: Type: text/plain, Size: 7610 bytes --]
On Sun, 2022-07-17 at 22:31 +0800, Guo Ren wrote:
> On Thu, Jul 14, 2022 at 7:21 PM Ben Hutchings <ben@decadent.org.uk> wrote:
> >
> > The recipe for vdso_install in arch/riscv/Makefile invokes targets of
> > the same name in arch/riscv/kernel/vdso and .../compat_vdso, but the
> > target in the latter is called compat_vdso_install. Change the
> > recipe to use the right target name.
> >
> > Fixes: 0715372a06ce ("riscv: compat: vdso: Add COMPAT_VDSO base code ...")
> > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> > ---
> > arch/riscv/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/riscv/Makefile b/arch/riscv/Makefile
> > index 34cf8a598617..ee763562895c 100644
> > --- a/arch/riscv/Makefile
> > +++ b/arch/riscv/Makefile
> > @@ -110,7 +110,7 @@ PHONY += vdso_install
> > vdso_install:
> > $(Q)$(MAKE) $(build)=arch/riscv/kernel/vdso $@
> > $(if $(CONFIG_COMPAT),$(Q)$(MAKE) \
> > - $(build)=arch/riscv/kernel/compat_vdso $@)
> > + $(build)=arch/riscv/kernel/compat_vdso compat_vdso_install)
> Good catch, but what's the problem you've met?
It broke the Debian package build
<https://buildd.debian.org/status/fetch.php?pkg=linux&arch=riscv64&ver=5.19%7Erc6-1%7Eexp1&stamp=1657777338&raw=0>:
[...] /usr/bin/make [...] -C debian/build/build_riscv64_none_riscv64 vdso_install INSTALL_MOD_PATH='/<<PKGBUILDDIR>>'/debian/linux-image-5.19.0-rc6-riscv64-dbg/usr/lib/debug
make[3]: Entering directory '/<<PKGBUILDDIR>>/debian/build/build_riscv64_none_riscv64'
[...]
/usr/bin/make -f /<<PKGBUILDDIR>>/scripts/Makefile.build obj=arch/riscv/kernel/vdso vdso_install
[...]
gcc-11 -Wp,-MMD,arch/riscv/kernel/vdso/.vgettimeofday.o.d -nostdinc -I/<<PKGBUILDDIR>>/arch/riscv/include -I./arch/riscv/include/generated -I/<<PKGBUILDDIR>>/include -I./include -I/<<PKGBUILDDIR>>/arch/riscv/include/uapi -I./arch/riscv/include/generated/uapi -I/<<PKGBUILDDIR>>/include/uapi -I./include/generated/uapi -include /<<PKGBUILDDIR>>/include/linux/compiler-version.h -include /<<PKGBUILDDIR>>/include/linux/kconfig.h -include /<<PKGBUILDDIR>>/include/linux/compiler_types.h -D__KERNEL__ -DCC_USING_PATCHABLE_FUNCTION_ENTRY -fmacro-prefix-map=/<<PKGBUILDDIR>>/= -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE -Werror=implicit-function-declaration -Werror=implicit-int -Werror=return-type -Wno-format-security -std=gnu11 -mabi=lp64 -march=rv64imac_zicsr_zifencei -mno-save-restore -DCONFIG_PAGE_OFFSET=0xff60000000000000 -mcmodel=medany -fno-omit-frame-pointer -mstrict-align -fno-delete-null-pointer-checks -Wno-frame-address -Wno-format-truncation -Wno-format-overflow -Wno-address-of-packed-member -O2 -fno-allow-store-data-races -Wframe-larger-than=2048 -fstack-protector-strong -Wimplicit-fallthrough=5 -Wno-main -Wno-unused-but-set-variable -Wno-unused-const-variable -fno-omit-frame-pointer -fno-optimize-sibling-calls -fno-stack-clash-protection -Wdeclaration-after-statement -Wvla -Wno-pointer-sign -Wcast-function-type -Wno-stringop-truncation -Wno-stringop-overflow -Wno-restrict -Wno-maybe-uninitialized -Wno-alloc-size-larger-than -fno-strict-overflow -fno-stack-check -fconserve-stack -Werror=date-time -Werror=incompatible-pointer-types -Werror=designated-init -Wno-packed-not-aligned -g -fdebug-prefix-map=/<<PKGBUILDDIR>>/= -fno-stack-protector -fPIC -include /<<PKGBUILDDIR>>/lib/vdso/gettimeofday.c -I /<<PKGBUILDDIR>>/arch/riscv/kernel/vdso -I ./arch/riscv/kernel/vdso -DKBUILD_MODFILE='"arch/riscv/kernel/vdso/vgettimeofday"' -DKBUILD_BASENAME='"vgettimeofday"' -DKBUILD_MODNAME='"vgettimeofday"' -D__KBUILD_MODNAME=kmod_vgettimeofday -c -o arch/riscv/kernel/vdso/vgettimeofday.o /<<PKGBUILDDIR>>/arch/riscv/kernel/vdso/vgettimeofday.c
[...]
/<<PKGBUILDDIR>>/scripts/check-local-export arch/riscv/kernel/vdso/vgettimeofday.o
if nm arch/riscv/kernel/vdso/vgettimeofday.o 2>/dev/null | grep -q __ksymtab; then gcc-11 -E -D__GENKSYMS__ -Wp,-MMD,arch/riscv/kernel/vdso/.vgettimeofday.o.d -nostdinc -I/<<PKGBUILDDIR>>/arch/riscv/include -I./arch/riscv/include/generated -I/<<PKGBUILDDIR>>/include -I./include -I/<<PKGBUILDDIR>>/arch/riscv/include/uapi -I./arch/riscv/include/generated/uapi -I/<<PKGBUILDDIR>>/include/uapi -I./include/generated/uapi -include /<<PKGBUILDDIR>>/include/linux/compiler-version.h -include /<<PKGBUILDDIR>>/include/linux/kconfig.h -include /<<PKGBUILDDIR>>/include/linux/compiler_types.h -D__KERNEL__ -DCC_USING_PATCHABLE_FUNCTION_ENTRY -fmacro-prefix-map=/<<PKGBUILDDIR>>/= -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE -Werror=implicit-function-declaration -Werror=implicit-int -Werror=return-type -Wno-format-security -std=gnu11 -mabi=lp64 -march=rv64imac_zicsr_zifencei -mno-save-restore -DCONFIG_PAGE_OFFSET=0xff60000000000000 -mcmodel=medany -fno-omit-frame-pointer -mstrict-align -fno-delete-null-pointer-checks -Wno-frame-address -Wno-format-truncation -Wno-format-overflow -Wno-address-of-packed-member -O2 -fno-allow-store-data-races -Wframe-larger-than=2048 -fstack-protector-strong -Wimplicit-fallthrough=5 -Wno-main -Wno-unused-but-set-variable -Wno-unused-const-variable -fno-omit-frame-pointer -fno-optimize-sibling-calls -fno-stack-clash-protection -Wdeclaration-after-statement -Wvla -Wno-pointer-sign -Wcast-function-type -Wno-stringop-truncation -Wno-stringop-overflow -Wno-restrict -Wno-maybe-uninitialized -Wno-alloc-size-larger-than -fno-strict-overflow -fno-stack-check -fconserve-stack -Werror=date-time -Werror=incompatible-pointer-types -Werror=designated-init -Wno-packed-not-aligned -g -fdebug-prefix-map=/<<PKGBUILDDIR>>/= -fno-stack-protector -fPIC -include /<<PKGBUILDDIR>>/lib/vdso/gettimeofday.c -I /<<PKGBUILDDIR>>/arch/riscv/kernel/vdso -I ./arch/riscv/kernel/vdso -DKBUILD_MODFILE='"arch/riscv/kernel/vdso/vgettimeofday"' -DKBUILD_BASENAME='"vgettimeofday"' -DKBUILD_MODNAME='"vgettimeofday"' -D__KBUILD_MODNAME=kmod_vgettimeofday /<<PKGBUILDDIR>>/arch/riscv/kernel/vdso/vgettimeofday.c | scripts/genksyms/genksyms -r /dev/null >> arch/riscv/kernel/vdso/.vgettimeofday.o.cmd; fi
ld -melf64lriscv -shared -S -soname=linux-vdso.so.1 --build-id=sha1 --hash-style=both --eh-frame-hdr -T arch/riscv/kernel/vdso/vdso.lds arch/riscv/kernel/vdso/rt_sigreturn.o arch/riscv/kernel/vdso/vgettimeofday.o arch/riscv/kernel/vdso/getcpu.o arch/riscv/kernel/vdso/flush_icache.o arch/riscv/kernel/vdso/note.o -o arch/riscv/kernel/vdso/vdso.so.dbg.tmp && objcopy -G __vdso_rt_sigreturn -G __vdso_vgettimeofday -G __vdso_getcpu -G __vdso_flush_icache arch/riscv/kernel/vdso/vdso.so.dbg.tmp arch/riscv/kernel/vdso/vdso.so.dbg && rm arch/riscv/kernel/vdso/vdso.so.dbg.tmp
cp arch/riscv/kernel/vdso/vdso.so.dbg /<<PKGBUILDDIR>>/debian/linux-image-5.19.0-rc6-riscv64-dbg/usr/lib/debug/lib/modules/5.19.0-rc6-riscv64/vdso/vdso.so
:
/usr/bin/make -f /<<PKGBUILDDIR>>/scripts/Makefile.build obj=arch/riscv/kernel/compat_vdso vdso_install
[...]
make[4]: *** No rule to make target 'vdso_install'. Stop.
make[3]: *** [/<<PKGBUILDDIR>>/arch/riscv/Makefile:112: vdso_install] Error 2
make[3]: Leaving directory '/<<PKGBUILDDIR>>/debian/build/build_riscv64_none_riscv64'
make[2]: *** [debian/rules.real:513: install-image-dbg_riscv64_none_riscv64] Error 2
make[2]: *** Waiting for unfinished jobs....
Ben.
>
> >
> > ifeq ($(KBUILD_EXTMOD),)
> > ifeq ($(CONFIG_MMU),y)
>
>
>
--
Ben Hutchings
This sentence contradicts itself - no actually it doesn't.
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] riscv: Fix vdso_install target with CONFIG_COMPAT=y
2022-07-17 15:26 ` Ben Hutchings
@ 2022-07-17 23:29 ` Guo Ren
2022-07-19 9:50 ` Emil Renner Berthing
0 siblings, 1 reply; 11+ messages in thread
From: Guo Ren @ 2022-07-17 23:29 UTC (permalink / raw)
To: Ben Hutchings; +Cc: linux-riscv
I'm just curious who is using vdso_install, thx. Would you mind put
below into the commit log?
It broke the Debian package build
/usr/bin/make [...] -C debian/build/build_riscv64_none_riscv64
vdso_install INSTALL_MOD_PATH='/<<PKGBUILDDIR>>'/debian/linux-image-5.19.0-rc6-riscv64-dbg/usr/lib/debug
make[3]: Entering directory
'/<<PKGBUILDDIR>>/debian/build/build_riscv64_none_riscv64'
[...]
make[4]: *** No rule to make target 'vdso_install'. Stop.
Reviewed-by: Guo Ren <guoren@kernel.org>
On Sun, Jul 17, 2022 at 11:26 PM Ben Hutchings <ben@decadent.org.uk> wrote:
>
> On Sun, 2022-07-17 at 22:31 +0800, Guo Ren wrote:
> > On Thu, Jul 14, 2022 at 7:21 PM Ben Hutchings <ben@decadent.org.uk> wrote:
> > >
> > > The recipe for vdso_install in arch/riscv/Makefile invokes targets of
> > > the same name in arch/riscv/kernel/vdso and .../compat_vdso, but the
> > > target in the latter is called compat_vdso_install. Change the
> > > recipe to use the right target name.
> > >
> > > Fixes: 0715372a06ce ("riscv: compat: vdso: Add COMPAT_VDSO base code ...")
> > > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> > > ---
> > > arch/riscv/Makefile | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/riscv/Makefile b/arch/riscv/Makefile
> > > index 34cf8a598617..ee763562895c 100644
> > > --- a/arch/riscv/Makefile
> > > +++ b/arch/riscv/Makefile
> > > @@ -110,7 +110,7 @@ PHONY += vdso_install
> > > vdso_install:
> > > $(Q)$(MAKE) $(build)=arch/riscv/kernel/vdso $@
> > > $(if $(CONFIG_COMPAT),$(Q)$(MAKE) \
> > > - $(build)=arch/riscv/kernel/compat_vdso $@)
> > > + $(build)=arch/riscv/kernel/compat_vdso compat_vdso_install)
> > Good catch, but what's the problem you've met?
>
> It broke the Debian package build
> <https://buildd.debian.org/status/fetch.php?pkg=linux&arch=riscv64&ver=5.19%7Erc6-1%7Eexp1&stamp=1657777338&raw=0>:
>
> [...] /usr/bin/make [...] -C debian/build/build_riscv64_none_riscv64 vdso_install INSTALL_MOD_PATH='/<<PKGBUILDDIR>>'/debian/linux-image-5.19.0-rc6-riscv64-dbg/usr/lib/debug
> make[3]: Entering directory '/<<PKGBUILDDIR>>/debian/build/build_riscv64_none_riscv64'
> [...]
> /usr/bin/make -f /<<PKGBUILDDIR>>/scripts/Makefile.build obj=arch/riscv/kernel/vdso vdso_install
> [...]
> gcc-11 -Wp,-MMD,arch/riscv/kernel/vdso/.vgettimeofday.o.d -nostdinc -I/<<PKGBUILDDIR>>/arch/riscv/include -I./arch/riscv/include/generated -I/<<PKGBUILDDIR>>/include -I./include -I/<<PKGBUILDDIR>>/arch/riscv/include/uapi -I./arch/riscv/include/generated/uapi -I/<<PKGBUILDDIR>>/include/uapi -I./include/generated/uapi -include /<<PKGBUILDDIR>>/include/linux/compiler-version.h -include /<<PKGBUILDDIR>>/include/linux/kconfig.h -include /<<PKGBUILDDIR>>/include/linux/compiler_types.h -D__KERNEL__ -DCC_USING_PATCHABLE_FUNCTION_ENTRY -fmacro-prefix-map=/<<PKGBUILDDIR>>/= -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE -Werror=implicit-function-declaration -Werror=implicit-int -Werror=return-type -Wno-format-security -std=gnu11 -mabi=lp64 -march=rv64imac_zicsr_zifencei -mno-save-restore -DCONFIG_PAGE_OFFSET=0xff60000000000000 -mcmodel=medany -fno-omit-frame-pointer -mstrict-align -fno-delete-null-pointer-checks -Wno-frame-address -Wno-format-truncation -Wno-format-overflow -Wno-address-of-packed-member -O2 -fno-allow-store-data-races -Wframe-larger-than=2048 -fstack-protector-strong -Wimplicit-fallthrough=5 -Wno-main -Wno-unused-but-set-variable -Wno-unused-const-variable -fno-omit-frame-pointer -fno-optimize-sibling-calls -fno-stack-clash-protection -Wdeclaration-after-statement -Wvla -Wno-pointer-sign -Wcast-function-type -Wno-stringop-truncation -Wno-stringop-overflow -Wno-restrict -Wno-maybe-uninitialized -Wno-alloc-size-larger-than -fno-strict-overflow -fno-stack-check -fconserve-stack -Werror=date-time -Werror=incompatible-pointer-types -Werror=designated-init -Wno-packed-not-aligned -g -fdebug-prefix-map=/<<PKGBUILDDIR>>/= -fno-stack-protector -fPIC -include /<<PKGBUILDDIR>>/lib/vdso/gettimeofday.c -I /<<PKGBUILDDIR>>/arch/riscv/kernel/vdso -I ./arch/riscv/kernel/vdso -DKBUILD_MODFILE='"arch/riscv/kernel/vdso/vgettimeofday"' -DKBUILD_BASENAME='"vgettimeofday"' -DKBUILD_MODNAME='"vgettimeofday"' -D__KBUILD_MODNAME=kmod_vgettimeofday -c -o arch/riscv/kernel/vdso/vgettimeofday.o /<<PKGBUILDDIR>>/arch/riscv/kernel/vdso/vgettimeofday.c
> [...]
> /<<PKGBUILDDIR>>/scripts/check-local-export arch/riscv/kernel/vdso/vgettimeofday.o
> if nm arch/riscv/kernel/vdso/vgettimeofday.o 2>/dev/null | grep -q __ksymtab; then gcc-11 -E -D__GENKSYMS__ -Wp,-MMD,arch/riscv/kernel/vdso/.vgettimeofday.o.d -nostdinc -I/<<PKGBUILDDIR>>/arch/riscv/include -I./arch/riscv/include/generated -I/<<PKGBUILDDIR>>/include -I./include -I/<<PKGBUILDDIR>>/arch/riscv/include/uapi -I./arch/riscv/include/generated/uapi -I/<<PKGBUILDDIR>>/include/uapi -I./include/generated/uapi -include /<<PKGBUILDDIR>>/include/linux/compiler-version.h -include /<<PKGBUILDDIR>>/include/linux/kconfig.h -include /<<PKGBUILDDIR>>/include/linux/compiler_types.h -D__KERNEL__ -DCC_USING_PATCHABLE_FUNCTION_ENTRY -fmacro-prefix-map=/<<PKGBUILDDIR>>/= -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE -Werror=implicit-function-declaration -Werror=implicit-int -Werror=return-type -Wno-format-security -std=gnu11 -mabi=lp64 -march=rv64imac_zicsr_zifencei -mno-save-restore -DCONFIG_PAGE_OFFSET=0xff60000000000000 -mcmodel=medany -fno-omit-frame-pointer -mstrict-align -fno-delete-null-pointer-checks -Wno-frame-address -Wno-format-truncation -Wno-format-overflow -Wno-address-of-packed-member -O2 -fno-allow-store-data-races -Wframe-larger-than=2048 -fstack-protector-strong -Wimplicit-fallthrough=5 -Wno-main -Wno-unused-but-set-variable -Wno-unused-const-variable -fno-omit-frame-pointer -fno-optimize-sibling-calls -fno-stack-clash-protection -Wdeclaration-after-statement -Wvla -Wno-pointer-sign -Wcast-function-type -Wno-stringop-truncation -Wno-stringop-overflow -Wno-restrict -Wno-maybe-uninitialized -Wno-alloc-size-larger-than -fno-strict-overflow -fno-stack-check -fconserve-stack -Werror=date-time -Werror=incompatible-pointer-types -Werror=designated-init -Wno-packed-not-aligned -g -fdebug-prefix-map=/<<PKGBUILDDIR>>/= -fno-stack-protector -fPIC -include /<<PKGBUILDDIR>>/lib/vdso/gettimeofday.c -I /<<PKGBUILDDIR>>/arch/riscv/kernel/vdso -I ./arch/riscv/kernel/vdso -DKBUILD_MODFILE='"arch/riscv/kernel/vdso/vgettimeofday"' -DKBUILD_BASENAME='"vgettimeofday"' -DKBUILD_MODNAME='"vgettimeofday"' -D__KBUILD_MODNAME=kmod_vgettimeofday /<<PKGBUILDDIR>>/arch/riscv/kernel/vdso/vgettimeofday.c | scripts/genksyms/genksyms -r /dev/null >> arch/riscv/kernel/vdso/.vgettimeofday.o.cmd; fi
> ld -melf64lriscv -shared -S -soname=linux-vdso.so.1 --build-id=sha1 --hash-style=both --eh-frame-hdr -T arch/riscv/kernel/vdso/vdso.lds arch/riscv/kernel/vdso/rt_sigreturn.o arch/riscv/kernel/vdso/vgettimeofday.o arch/riscv/kernel/vdso/getcpu.o arch/riscv/kernel/vdso/flush_icache.o arch/riscv/kernel/vdso/note.o -o arch/riscv/kernel/vdso/vdso.so.dbg.tmp && objcopy -G __vdso_rt_sigreturn -G __vdso_vgettimeofday -G __vdso_getcpu -G __vdso_flush_icache arch/riscv/kernel/vdso/vdso.so.dbg.tmp arch/riscv/kernel/vdso/vdso.so.dbg && rm arch/riscv/kernel/vdso/vdso.so.dbg.tmp
> cp arch/riscv/kernel/vdso/vdso.so.dbg /<<PKGBUILDDIR>>/debian/linux-image-5.19.0-rc6-riscv64-dbg/usr/lib/debug/lib/modules/5.19.0-rc6-riscv64/vdso/vdso.so
> :
> /usr/bin/make -f /<<PKGBUILDDIR>>/scripts/Makefile.build obj=arch/riscv/kernel/compat_vdso vdso_install
> [...]
> make[4]: *** No rule to make target 'vdso_install'. Stop.
> make[3]: *** [/<<PKGBUILDDIR>>/arch/riscv/Makefile:112: vdso_install] Error 2
> make[3]: Leaving directory '/<<PKGBUILDDIR>>/debian/build/build_riscv64_none_riscv64'
> make[2]: *** [debian/rules.real:513: install-image-dbg_riscv64_none_riscv64] Error 2
> make[2]: *** Waiting for unfinished jobs....
>
> Ben.
>
> >
> > >
> > > ifeq ($(KBUILD_EXTMOD),)
> > > ifeq ($(CONFIG_MMU),y)
> >
> >
> >
>
> --
> Ben Hutchings
> This sentence contradicts itself - no actually it doesn't.
--
Best Regards
Guo Ren
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] riscv: Fix vdso_install target with CONFIG_COMPAT=y
2022-07-17 23:29 ` Guo Ren
@ 2022-07-19 9:50 ` Emil Renner Berthing
2022-07-19 10:15 ` Guo Ren
0 siblings, 1 reply; 11+ messages in thread
From: Emil Renner Berthing @ 2022-07-19 9:50 UTC (permalink / raw)
To: Guo Ren; +Cc: Ben Hutchings, linux-riscv
On Mon, 18 Jul 2022 at 01:32, Guo Ren <guoren@kernel.org> wrote:
>
> I'm just curious who is using vdso_install, thx. Would you mind put
> below into the commit log?
>
> It broke the Debian package build
> /usr/bin/make [...] -C debian/build/build_riscv64_none_riscv64
> vdso_install INSTALL_MOD_PATH='/<<PKGBUILDDIR>>'/debian/linux-image-5.19.0-rc6-riscv64-dbg/usr/lib/debug
> make[3]: Entering directory
> '/<<PKGBUILDDIR>>/debian/build/build_riscv64_none_riscv64'
> [...]
> make[4]: *** No rule to make target 'vdso_install'. Stop.
>
> Reviewed-by: Guo Ren <guoren@kernel.org>
I don't mind which version goes in, but just for reference there is
already this patch on the mailing list:
https://lore.kernel.org/linux-riscv/20220625154207.80972-1-emil.renner.berthing@canonical.com/
/Emil
> On Sun, Jul 17, 2022 at 11:26 PM Ben Hutchings <ben@decadent.org.uk> wrote:
> >
> > On Sun, 2022-07-17 at 22:31 +0800, Guo Ren wrote:
> > > On Thu, Jul 14, 2022 at 7:21 PM Ben Hutchings <ben@decadent.org.uk> wrote:
> > > >
> > > > The recipe for vdso_install in arch/riscv/Makefile invokes targets of
> > > > the same name in arch/riscv/kernel/vdso and .../compat_vdso, but the
> > > > target in the latter is called compat_vdso_install. Change the
> > > > recipe to use the right target name.
> > > >
> > > > Fixes: 0715372a06ce ("riscv: compat: vdso: Add COMPAT_VDSO base code ...")
> > > > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> > > > ---
> > > > arch/riscv/Makefile | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/arch/riscv/Makefile b/arch/riscv/Makefile
> > > > index 34cf8a598617..ee763562895c 100644
> > > > --- a/arch/riscv/Makefile
> > > > +++ b/arch/riscv/Makefile
> > > > @@ -110,7 +110,7 @@ PHONY += vdso_install
> > > > vdso_install:
> > > > $(Q)$(MAKE) $(build)=arch/riscv/kernel/vdso $@
> > > > $(if $(CONFIG_COMPAT),$(Q)$(MAKE) \
> > > > - $(build)=arch/riscv/kernel/compat_vdso $@)
> > > > + $(build)=arch/riscv/kernel/compat_vdso compat_vdso_install)
> > > Good catch, but what's the problem you've met?
> >
> > It broke the Debian package build
> > <https://buildd.debian.org/status/fetch.php?pkg=linux&arch=riscv64&ver=5.19%7Erc6-1%7Eexp1&stamp=1657777338&raw=0>:
> >
> > [...] /usr/bin/make [...] -C debian/build/build_riscv64_none_riscv64 vdso_install INSTALL_MOD_PATH='/<<PKGBUILDDIR>>'/debian/linux-image-5.19.0-rc6-riscv64-dbg/usr/lib/debug
> > make[3]: Entering directory '/<<PKGBUILDDIR>>/debian/build/build_riscv64_none_riscv64'
> > [...]
> > /usr/bin/make -f /<<PKGBUILDDIR>>/scripts/Makefile.build obj=arch/riscv/kernel/vdso vdso_install
> > [...]
> > gcc-11 -Wp,-MMD,arch/riscv/kernel/vdso/.vgettimeofday.o.d -nostdinc -I/<<PKGBUILDDIR>>/arch/riscv/include -I./arch/riscv/include/generated -I/<<PKGBUILDDIR>>/include -I./include -I/<<PKGBUILDDIR>>/arch/riscv/include/uapi -I./arch/riscv/include/generated/uapi -I/<<PKGBUILDDIR>>/include/uapi -I./include/generated/uapi -include /<<PKGBUILDDIR>>/include/linux/compiler-version.h -include /<<PKGBUILDDIR>>/include/linux/kconfig.h -include /<<PKGBUILDDIR>>/include/linux/compiler_types.h -D__KERNEL__ -DCC_USING_PATCHABLE_FUNCTION_ENTRY -fmacro-prefix-map=/<<PKGBUILDDIR>>/= -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE -Werror=implicit-function-declaration -Werror=implicit-int -Werror=return-type -Wno-format-security -std=gnu11 -mabi=lp64 -march=rv64imac_zicsr_zifencei -mno-save-restore -DCONFIG_PAGE_OFFSET=0xff60000000000000 -mcmodel=medany -fno-omit-frame-pointer -mstrict-align -fno-delete-null-pointer-checks -Wno-frame-ad
> dress -Wno-format-truncation -Wno-format-overflow -Wno-address-of-packed-member -O2 -fno-allow-store-data-races -Wframe-larger-than=2048 -fstack-protector-strong -Wimplicit-fallthrough=5 -Wno-main -Wno-unused-but-set-variable -Wno-unused-const-variable -fno-omit-frame-pointer -fno-optimize-sibling-calls -fno-stack-clash-protection -Wdeclaration-after-statement -Wvla -Wno-pointer-sign -Wcast-function-type -Wno-stringop-truncation -Wno-stringop-overflow -Wno-restrict -Wno-maybe-uninitialized -Wno-alloc-size-larger-than -fno-strict-overflow -fno-stack-check -fconserve-stack -Werror=date-time -Werror=incompatible-pointer-types -Werror=designated-init -Wno-packed-not-aligned -g -fdebug-prefix-map=/<<PKGBUILDDIR>>/= -fno-stack-protector -fPIC -include /<<PKGBUILDDIR>>/lib/vdso/gettimeofday.c -I /<<PKGBUILDDIR>>/arch/riscv/kernel/vdso -I ./arch/riscv/kernel/vdso -DKBUILD_MODFILE='"arch/riscv/kernel/vdso/vgettimeofday"' -DKBUILD_BASENAME='"vgettimeofday"' -DKBUILD_MODNAME='"vgettimeofday
> "' -D__KBUILD_MODNAME=kmod_vgettimeofday -c -o arch/riscv/kernel/vdso/vgettimeofday.o /<<PKGBUILDDIR>>/arch/riscv/kernel/vdso/vgettimeofday.c
> > [...]
> > /<<PKGBUILDDIR>>/scripts/check-local-export arch/riscv/kernel/vdso/vgettimeofday.o
> > if nm arch/riscv/kernel/vdso/vgettimeofday.o 2>/dev/null | grep -q __ksymtab; then gcc-11 -E -D__GENKSYMS__ -Wp,-MMD,arch/riscv/kernel/vdso/.vgettimeofday.o.d -nostdinc -I/<<PKGBUILDDIR>>/arch/riscv/include -I./arch/riscv/include/generated -I/<<PKGBUILDDIR>>/include -I./include -I/<<PKGBUILDDIR>>/arch/riscv/include/uapi -I./arch/riscv/include/generated/uapi -I/<<PKGBUILDDIR>>/include/uapi -I./include/generated/uapi -include /<<PKGBUILDDIR>>/include/linux/compiler-version.h -include /<<PKGBUILDDIR>>/include/linux/kconfig.h -include /<<PKGBUILDDIR>>/include/linux/compiler_types.h -D__KERNEL__ -DCC_USING_PATCHABLE_FUNCTION_ENTRY -fmacro-prefix-map=/<<PKGBUILDDIR>>/= -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE -Werror=implicit-function-declaration -Werror=implicit-int -Werror=return-type -Wno-format-security -std=gnu11 -mabi=lp64 -march=rv64imac_zicsr_zifencei -mno-save-restore -DCONFIG_PAGE_OFFSET=0xff60000000000000
> -mcmodel=medany -fno-omit-frame-pointer -mstrict-align -fno-delete-null-pointer-checks -Wno-frame-address -Wno-format-truncation -Wno-format-overflow -Wno-address-of-packed-member -O2 -fno-allow-store-data-races -Wframe-larger-than=2048 -fstack-protector-strong -Wimplicit-fallthrough=5 -Wno-main -Wno-unused-but-set-variable -Wno-unused-const-variable -fno-omit-frame-pointer -fno-optimize-sibling-calls -fno-stack-clash-protection -Wdeclaration-after-statement -Wvla -Wno-pointer-sign -Wcast-function-type -Wno-stringop-truncation -Wno-stringop-overflow -Wno-restrict -Wno-maybe-uninitialized -Wno-alloc-size-larger-than -fno-strict-overflow -fno-stack-check -fconserve-stack -Werror=date-time -Werror=incompatible-pointer-types -Werror=designated-init -Wno-packed-not-aligned -g -fdebug-prefix-map=/<<PKGBUILDDIR>>/= -fno-stack-protector -fPIC -include /<<PKGBUILDDIR>>/lib/vdso/gettimeofday.c -I /<<PKGBUILDDIR>>/arch/riscv/kernel/vdso -I ./arch/riscv/kernel/vdso -DKBUILD_MODFILE='"arch/r
> iscv/kernel/vdso/vgettimeofday"' -DKBUILD_BASENAME='"vgettimeofday"' -DKBUILD_MODNAME='"vgettimeofday"' -D__KBUILD_MODNAME=kmod_vgettimeofday /<<PKGBUILDDIR>>/arch/riscv/kernel/vdso/vgettimeofday.c | scripts/genksyms/genksyms -r /dev/null >> arch/riscv/kernel/vdso/.vgettimeofday.o.cmd; fi
> > ld -melf64lriscv -shared -S -soname=linux-vdso.so.1 --build-id=sha1 --hash-style=both --eh-frame-hdr -T arch/riscv/kernel/vdso/vdso.lds arch/riscv/kernel/vdso/rt_sigreturn.o arch/riscv/kernel/vdso/vgettimeofday.o arch/riscv/kernel/vdso/getcpu.o arch/riscv/kernel/vdso/flush_icache.o arch/riscv/kernel/vdso/note.o -o arch/riscv/kernel/vdso/vdso.so.dbg.tmp && objcopy -G __vdso_rt_sigreturn -G __vdso_vgettimeofday -G __vdso_getcpu -G __vdso_flush_icache arch/riscv/kernel/vdso/vdso.so.dbg.tmp arch/riscv/kernel/vdso/vdso.so.dbg && rm arch/riscv/kernel/vdso/vdso.so.dbg.tmp
> > cp arch/riscv/kernel/vdso/vdso.so.dbg /<<PKGBUILDDIR>>/debian/linux-image-5.19.0-rc6-riscv64-dbg/usr/lib/debug/lib/modules/5.19.0-rc6-riscv64/vdso/vdso.so
> > :
> > /usr/bin/make -f /<<PKGBUILDDIR>>/scripts/Makefile.build obj=arch/riscv/kernel/compat_vdso vdso_install
> > [...]
> > make[4]: *** No rule to make target 'vdso_install'. Stop.
> > make[3]: *** [/<<PKGBUILDDIR>>/arch/riscv/Makefile:112: vdso_install] Error 2
> > make[3]: Leaving directory '/<<PKGBUILDDIR>>/debian/build/build_riscv64_none_riscv64'
> > make[2]: *** [debian/rules.real:513: install-image-dbg_riscv64_none_riscv64] Error 2
> > make[2]: *** Waiting for unfinished jobs....
> >
> > Ben.
> >
> > >
> > > >
> > > > ifeq ($(KBUILD_EXTMOD),)
> > > > ifeq ($(CONFIG_MMU),y)
> > >
> > >
> > >
> >
> > --
> > Ben Hutchings
> > This sentence contradicts itself - no actually it doesn't.
>
>
>
> --
> Best Regards
> Guo Ren
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] riscv: Fix vdso_install target with CONFIG_COMPAT=y
2022-07-19 9:50 ` Emil Renner Berthing
@ 2022-07-19 10:15 ` Guo Ren
2022-07-19 10:28 ` Conor.Dooley
0 siblings, 1 reply; 11+ messages in thread
From: Guo Ren @ 2022-07-19 10:15 UTC (permalink / raw)
To: Emil Renner Berthing; +Cc: Ben Hutchings, linux-riscv
Sorry, I missed your patch. You are the first person to catch that.
+ $(build)=arch/riscv/kernel/compat_vdso compat_$@)
The above is also good for me.
For that one, Could you add "Fixes: 0715372a06ce ("riscv: compat:
vdso: Add COMPAT_VDSO base code ...")" in your next version of the
patch from Ben's and add "Ben Hutchings as Co-developed-by:"?
On Tue, Jul 19, 2022 at 5:50 PM Emil Renner Berthing
<emil.renner.berthing@canonical.com> wrote:
>
> On Mon, 18 Jul 2022 at 01:32, Guo Ren <guoren@kernel.org> wrote:
> >
> > I'm just curious who is using vdso_install, thx. Would you mind put
> > below into the commit log?
> >
> > It broke the Debian package build
> > /usr/bin/make [...] -C debian/build/build_riscv64_none_riscv64
> > vdso_install INSTALL_MOD_PATH='/<<PKGBUILDDIR>>'/debian/linux-image-5.19.0-rc6-riscv64-dbg/usr/lib/debug
> > make[3]: Entering directory
> > '/<<PKGBUILDDIR>>/debian/build/build_riscv64_none_riscv64'
> > [...]
> > make[4]: *** No rule to make target 'vdso_install'. Stop.
> >
> > Reviewed-by: Guo Ren <guoren@kernel.org>
>
> I don't mind which version goes in, but just for reference there is
> already this patch on the mailing list:
> https://lore.kernel.org/linux-riscv/20220625154207.80972-1-emil.renner.berthing@canonical.com/
>
> /Emil
>
> > On Sun, Jul 17, 2022 at 11:26 PM Ben Hutchings <ben@decadent.org.uk> wrote:
> > >
> > > On Sun, 2022-07-17 at 22:31 +0800, Guo Ren wrote:
> > > > On Thu, Jul 14, 2022 at 7:21 PM Ben Hutchings <ben@decadent.org.uk> wrote:
> > > > >
> > > > > The recipe for vdso_install in arch/riscv/Makefile invokes targets of
> > > > > the same name in arch/riscv/kernel/vdso and .../compat_vdso, but the
> > > > > target in the latter is called compat_vdso_install. Change the
> > > > > recipe to use the right target name.
> > > > >
> > > > > Fixes: 0715372a06ce ("riscv: compat: vdso: Add COMPAT_VDSO base code ...")
> > > > > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> > > > > ---
> > > > > arch/riscv/Makefile | 2 +-
> > > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/arch/riscv/Makefile b/arch/riscv/Makefile
> > > > > index 34cf8a598617..ee763562895c 100644
> > > > > --- a/arch/riscv/Makefile
> > > > > +++ b/arch/riscv/Makefile
> > > > > @@ -110,7 +110,7 @@ PHONY += vdso_install
> > > > > vdso_install:
> > > > > $(Q)$(MAKE) $(build)=arch/riscv/kernel/vdso $@
> > > > > $(if $(CONFIG_COMPAT),$(Q)$(MAKE) \
> > > > > - $(build)=arch/riscv/kernel/compat_vdso $@)
> > > > > + $(build)=arch/riscv/kernel/compat_vdso compat_vdso_install)
> > > > Good catch, but what's the problem you've met?
> > >
> > > It broke the Debian package build
> > > <https://buildd.debian.org/status/fetch.php?pkg=linux&arch=riscv64&ver=5.19%7Erc6-1%7Eexp1&stamp=1657777338&raw=0>:
> > >
> > > [...] /usr/bin/make [...] -C debian/build/build_riscv64_none_riscv64 vdso_install INSTALL_MOD_PATH='/<<PKGBUILDDIR>>'/debian/linux-image-5.19.0-rc6-riscv64-dbg/usr/lib/debug
> > > make[3]: Entering directory '/<<PKGBUILDDIR>>/debian/build/build_riscv64_none_riscv64'
> > > [...]
> > > /usr/bin/make -f /<<PKGBUILDDIR>>/scripts/Makefile.build obj=arch/riscv/kernel/vdso vdso_install
> > > [...]
> > > gcc-11 -Wp,-MMD,arch/riscv/kernel/vdso/.vgettimeofday.o.d -nostdinc -I/<<PKGBUILDDIR>>/arch/riscv/include -I./arch/riscv/include/generated -I/<<PKGBUILDDIR>>/include -I./include -I/<<PKGBUILDDIR>>/arch/riscv/include/uapi -I./arch/riscv/include/generated/uapi -I/<<PKGBUILDDIR>>/include/uapi -I./include/generated/uapi -include /<<PKGBUILDDIR>>/include/linux/compiler-version.h -include /<<PKGBUILDDIR>>/include/linux/kconfig.h -include /<<PKGBUILDDIR>>/include/linux/compiler_types.h -D__KERNEL__ -DCC_USING_PATCHABLE_FUNCTION_ENTRY -fmacro-prefix-map=/<<PKGBUILDDIR>>/= -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE -Werror=implicit-function-declaration -Werror=implicit-int -Werror=return-type -Wno-format-security -std=gnu11 -mabi=lp64 -march=rv64imac_zicsr_zifencei -mno-save-restore -DCONFIG_PAGE_OFFSET=0xff60000000000000 -mcmodel=medany -fno-omit-frame-pointer -mstrict-align -fno-delete-null-pointer-checks -Wno-frame-ad
> > dress -Wno-format-truncation -Wno-format-overflow -Wno-address-of-packed-member -O2 -fno-allow-store-data-races -Wframe-larger-than=2048 -fstack-protector-strong -Wimplicit-fallthrough=5 -Wno-main -Wno-unused-but-set-variable -Wno-unused-const-variable -fno-omit-frame-pointer -fno-optimize-sibling-calls -fno-stack-clash-protection -Wdeclaration-after-statement -Wvla -Wno-pointer-sign -Wcast-function-type -Wno-stringop-truncation -Wno-stringop-overflow -Wno-restrict -Wno-maybe-uninitialized -Wno-alloc-size-larger-than -fno-strict-overflow -fno-stack-check -fconserve-stack -Werror=date-time -Werror=incompatible-pointer-types -Werror=designated-init -Wno-packed-not-aligned -g -fdebug-prefix-map=/<<PKGBUILDDIR>>/= -fno-stack-protector -fPIC -include /<<PKGBUILDDIR>>/lib/vdso/gettimeofday.c -I /<<PKGBUILDDIR>>/arch/riscv/kernel/vdso -I ./arch/riscv/kernel/vdso -DKBUILD_MODFILE='"arch/riscv/kernel/vdso/vgettimeofday"' -DKBUILD_BASENAME='"vgettimeofday"' -DKBUILD_MODNAME='"vgettimeofday
> > "' -D__KBUILD_MODNAME=kmod_vgettimeofday -c -o arch/riscv/kernel/vdso/vgettimeofday.o /<<PKGBUILDDIR>>/arch/riscv/kernel/vdso/vgettimeofday.c
> > > [...]
> > > /<<PKGBUILDDIR>>/scripts/check-local-export arch/riscv/kernel/vdso/vgettimeofday.o
> > > if nm arch/riscv/kernel/vdso/vgettimeofday.o 2>/dev/null | grep -q __ksymtab; then gcc-11 -E -D__GENKSYMS__ -Wp,-MMD,arch/riscv/kernel/vdso/.vgettimeofday.o.d -nostdinc -I/<<PKGBUILDDIR>>/arch/riscv/include -I./arch/riscv/include/generated -I/<<PKGBUILDDIR>>/include -I./include -I/<<PKGBUILDDIR>>/arch/riscv/include/uapi -I./arch/riscv/include/generated/uapi -I/<<PKGBUILDDIR>>/include/uapi -I./include/generated/uapi -include /<<PKGBUILDDIR>>/include/linux/compiler-version.h -include /<<PKGBUILDDIR>>/include/linux/kconfig.h -include /<<PKGBUILDDIR>>/include/linux/compiler_types.h -D__KERNEL__ -DCC_USING_PATCHABLE_FUNCTION_ENTRY -fmacro-prefix-map=/<<PKGBUILDDIR>>/= -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE -Werror=implicit-function-declaration -Werror=implicit-int -Werror=return-type -Wno-format-security -std=gnu11 -mabi=lp64 -march=rv64imac_zicsr_zifencei -mno-save-restore -DCONFIG_PAGE_OFFSET=0xff60000000000000
> > -mcmodel=medany -fno-omit-frame-pointer -mstrict-align -fno-delete-null-pointer-checks -Wno-frame-address -Wno-format-truncation -Wno-format-overflow -Wno-address-of-packed-member -O2 -fno-allow-store-data-races -Wframe-larger-than=2048 -fstack-protector-strong -Wimplicit-fallthrough=5 -Wno-main -Wno-unused-but-set-variable -Wno-unused-const-variable -fno-omit-frame-pointer -fno-optimize-sibling-calls -fno-stack-clash-protection -Wdeclaration-after-statement -Wvla -Wno-pointer-sign -Wcast-function-type -Wno-stringop-truncation -Wno-stringop-overflow -Wno-restrict -Wno-maybe-uninitialized -Wno-alloc-size-larger-than -fno-strict-overflow -fno-stack-check -fconserve-stack -Werror=date-time -Werror=incompatible-pointer-types -Werror=designated-init -Wno-packed-not-aligned -g -fdebug-prefix-map=/<<PKGBUILDDIR>>/= -fno-stack-protector -fPIC -include /<<PKGBUILDDIR>>/lib/vdso/gettimeofday.c -I /<<PKGBUILDDIR>>/arch/riscv/kernel/vdso -I ./arch/riscv/kernel/vdso -DKBUILD_MODFILE='"arch/r
> > iscv/kernel/vdso/vgettimeofday"' -DKBUILD_BASENAME='"vgettimeofday"' -DKBUILD_MODNAME='"vgettimeofday"' -D__KBUILD_MODNAME=kmod_vgettimeofday /<<PKGBUILDDIR>>/arch/riscv/kernel/vdso/vgettimeofday.c | scripts/genksyms/genksyms -r /dev/null >> arch/riscv/kernel/vdso/.vgettimeofday.o.cmd; fi
> > > ld -melf64lriscv -shared -S -soname=linux-vdso.so.1 --build-id=sha1 --hash-style=both --eh-frame-hdr -T arch/riscv/kernel/vdso/vdso.lds arch/riscv/kernel/vdso/rt_sigreturn.o arch/riscv/kernel/vdso/vgettimeofday.o arch/riscv/kernel/vdso/getcpu.o arch/riscv/kernel/vdso/flush_icache.o arch/riscv/kernel/vdso/note.o -o arch/riscv/kernel/vdso/vdso.so.dbg.tmp && objcopy -G __vdso_rt_sigreturn -G __vdso_vgettimeofday -G __vdso_getcpu -G __vdso_flush_icache arch/riscv/kernel/vdso/vdso.so.dbg.tmp arch/riscv/kernel/vdso/vdso.so.dbg && rm arch/riscv/kernel/vdso/vdso.so.dbg.tmp
> > > cp arch/riscv/kernel/vdso/vdso.so.dbg /<<PKGBUILDDIR>>/debian/linux-image-5.19.0-rc6-riscv64-dbg/usr/lib/debug/lib/modules/5.19.0-rc6-riscv64/vdso/vdso.so
> > > :
> > > /usr/bin/make -f /<<PKGBUILDDIR>>/scripts/Makefile.build obj=arch/riscv/kernel/compat_vdso vdso_install
> > > [...]
> > > make[4]: *** No rule to make target 'vdso_install'. Stop.
> > > make[3]: *** [/<<PKGBUILDDIR>>/arch/riscv/Makefile:112: vdso_install] Error 2
> > > make[3]: Leaving directory '/<<PKGBUILDDIR>>/debian/build/build_riscv64_none_riscv64'
> > > make[2]: *** [debian/rules.real:513: install-image-dbg_riscv64_none_riscv64] Error 2
> > > make[2]: *** Waiting for unfinished jobs....
> > >
> > > Ben.
> > >
> > > >
> > > > >
> > > > > ifeq ($(KBUILD_EXTMOD),)
> > > > > ifeq ($(CONFIG_MMU),y)
> > > >
> > > >
> > > >
> > >
> > > --
> > > Ben Hutchings
> > > This sentence contradicts itself - no actually it doesn't.
> >
> >
> >
> > --
> > Best Regards
> > Guo Ren
> >
> > _______________________________________________
> > linux-riscv mailing list
> > linux-riscv@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-riscv
--
Best Regards
Guo Ren
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] riscv: Fix vdso_install target with CONFIG_COMPAT=y
2022-07-19 10:15 ` Guo Ren
@ 2022-07-19 10:28 ` Conor.Dooley
2022-07-19 10:35 ` Guo Ren
0 siblings, 1 reply; 11+ messages in thread
From: Conor.Dooley @ 2022-07-19 10:28 UTC (permalink / raw)
To: guoren, emil.renner.berthing; +Cc: ben, linux-riscv
On 19/07/2022 11:15, Guo Ren wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Sorry, I missed your patch. You are the first person to catch that.
>
> + $(build)=arch/riscv/kernel/compat_vdso compat_$@)
>
> The above is also good for me.
>
> For that one, Could you add "Fixes: 0715372a06ce ("riscv: compat:
> vdso: Add COMPAT_VDSO base code ...")" in your next version of the
> patch from Ben's and add "Ben Hutchings as Co-developed-by:"?
>
>
Why would Ben get a Co-developed-by?
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] riscv: Fix vdso_install target with CONFIG_COMPAT=y
2022-07-19 10:28 ` Conor.Dooley
@ 2022-07-19 10:35 ` Guo Ren
2022-07-19 10:38 ` Conor.Dooley
2022-07-19 13:55 ` Ben Hutchings
0 siblings, 2 replies; 11+ messages in thread
From: Guo Ren @ 2022-07-19 10:35 UTC (permalink / raw)
To: Conor Dooley; +Cc: emil.renner.berthing, Ben Hutchings, linux-riscv
On Tue, Jul 19, 2022 at 6:29 PM <Conor.Dooley@microchip.com> wrote:
>
> On 19/07/2022 11:15, Guo Ren wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> >
> > Sorry, I missed your patch. You are the first person to catch that.
> >
> > + $(build)=arch/riscv/kernel/compat_vdso compat_$@)
> >
> > The above is also good for me.
> >
> > For that one, Could you add "Fixes: 0715372a06ce ("riscv: compat:
> > vdso: Add COMPAT_VDSO base code ...")" in your next version of the
> > patch from Ben's and add "Ben Hutchings as Co-developed-by:"?
> >
> >
>
> Why would Ben get a Co-developed-by?
Just a suggestion to "Emil Renner Berthing".
My reason is:
1. I think the "Fixes:" is also necessary, and Emil could directly use
it from Ben's patch.
2. He also found that problem and shared the information with us. The
key effect is to make Emil's patch quickly reviewed (Although I missed
that patch).
--
Best Regards
Guo Ren
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] riscv: Fix vdso_install target with CONFIG_COMPAT=y
2022-07-19 10:35 ` Guo Ren
@ 2022-07-19 10:38 ` Conor.Dooley
2022-07-19 13:55 ` Ben Hutchings
1 sibling, 0 replies; 11+ messages in thread
From: Conor.Dooley @ 2022-07-19 10:38 UTC (permalink / raw)
To: guoren, Conor.Dooley; +Cc: emil.renner.berthing, ben, linux-riscv
On 19/07/2022 11:35, Guo Ren wrote:
> On Tue, Jul 19, 2022 at 6:29 PM <Conor.Dooley@microchip.com> wrote:
>>
>> On 19/07/2022 11:15, Guo Ren wrote:
>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>>
>>> Sorry, I missed your patch. You are the first person to catch that.
>>>
>>> + $(build)=arch/riscv/kernel/compat_vdso compat_$@)
>>>
>>> The above is also good for me.
>>>
>>> For that one, Could you add "Fixes: 0715372a06ce ("riscv: compat:
>>> vdso: Add COMPAT_VDSO base code ...")" in your next version of the
>>> patch from Ben's and add "Ben Hutchings as Co-developed-by:"?
>>>
>>>
>>
>> Why would Ben get a Co-developed-by?
>
> Just a suggestion to "Emil Renner Berthing".
>
> My reason is:
> 1. I think the "Fixes:" is also necessary, and Emil could directly use
> it from Ben's patch.
> 2. He also found that problem and shared the information with us. The
> key effect is to make Emil's patch quickly reviewed (Although I missed
> that patch).
Tbh, I don't think either of those would result in a Co-developed-by.
Reported-by: would be more accurate, no?
Thanks,
Conor.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] riscv: Fix vdso_install target with CONFIG_COMPAT=y
2022-07-19 10:35 ` Guo Ren
2022-07-19 10:38 ` Conor.Dooley
@ 2022-07-19 13:55 ` Ben Hutchings
2022-07-19 14:38 ` Conor Dooley
1 sibling, 1 reply; 11+ messages in thread
From: Ben Hutchings @ 2022-07-19 13:55 UTC (permalink / raw)
To: Guo Ren, Conor Dooley; +Cc: emil.renner.berthing, linux-riscv
On 19 July 2022 12:35:55 CEST, Guo Ren <guoren@kernel.org> wrote:
>On Tue, Jul 19, 2022 at 6:29 PM <Conor.Dooley@microchip.com> wrote:
>>
>> On 19/07/2022 11:15, Guo Ren wrote:
>> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>> >
>> > Sorry, I missed your patch. You are the first person to catch that.
>> >
>> > + $(build)=arch/riscv/kernel/compat_vdso compat_$@)
>> >
>> > The above is also good for me.
>> >
>> > For that one, Could you add "Fixes: 0715372a06ce ("riscv: compat:
>> > vdso: Add COMPAT_VDSO base code ...")" in your next version of the
>> > patch from Ben's and add "Ben Hutchings as Co-developed-by:"?
>> >
>> >
>>
>> Why would Ben get a Co-developed-by?
>
>Just a suggestion to "Emil Renner Berthing".
>
>My reason is:
>1. I think the "Fixes:" is also necessary, and Emil could directly use
>it from Ben's patch.
>2. He also found that problem and shared the information with us. The
>key effect is to make Emil's patch quickly reviewed (Although I missed
>that patch).
Please just let's get this applied. I don't need credit for a trivial fix or commit id.
Ben.
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] riscv: Fix vdso_install target with CONFIG_COMPAT=y
2022-07-19 13:55 ` Ben Hutchings
@ 2022-07-19 14:38 ` Conor Dooley
0 siblings, 0 replies; 11+ messages in thread
From: Conor Dooley @ 2022-07-19 14:38 UTC (permalink / raw)
To: Ben Hutchings, Guo Ren, Conor Dooley; +Cc: emil.renner.berthing, linux-riscv
On 19/07/2022 14:55, Ben Hutchings wrote:
> On 19 July 2022 12:35:55 CEST, Guo Ren <guoren@kernel.org> wrote:
>> On Tue, Jul 19, 2022 at 6:29 PM <Conor.Dooley@microchip.com> wrote:
>>>
>>> On 19/07/2022 11:15, Guo Ren wrote:
>>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>>>
>>>> Sorry, I missed your patch. You are the first person to catch that.
>>>>
>>>> + $(build)=arch/riscv/kernel/compat_vdso compat_$@)
>>>>
>>>> The above is also good for me.
>>>>
>>>> For that one, Could you add "Fixes: 0715372a06ce ("riscv: compat:
>>>> vdso: Add COMPAT_VDSO base code ...")" in your next version of the
>>>> patch from Ben's and add "Ben Hutchings as Co-developed-by:"?
>>>>
>>>>
>>>
>>> Why would Ben get a Co-developed-by?
>>
>> Just a suggestion to "Emil Renner Berthing".
>>
>> My reason is:
>> 1. I think the "Fixes:" is also necessary, and Emil could directly use
>> it from Ben's patch.
>> 2. He also found that problem and shared the information with us. The
>> key effect is to make Emil's patch quickly reviewed (Although I missed
>> that patch).
>
> Please just let's get this applied.
That's always the goal :)
> I don't need credit for a trivial fix or commit id.
I was more curious as to whether Guo knew something I didn't!
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2022-07-19 14:39 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-14 11:21 [PATCH] riscv: Fix vdso_install target with CONFIG_COMPAT=y Ben Hutchings
2022-07-17 14:31 ` Guo Ren
2022-07-17 15:26 ` Ben Hutchings
2022-07-17 23:29 ` Guo Ren
2022-07-19 9:50 ` Emil Renner Berthing
2022-07-19 10:15 ` Guo Ren
2022-07-19 10:28 ` Conor.Dooley
2022-07-19 10:35 ` Guo Ren
2022-07-19 10:38 ` Conor.Dooley
2022-07-19 13:55 ` Ben Hutchings
2022-07-19 14:38 ` Conor Dooley
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.