All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Richard Fitzgerald <rf@opensource.cirrus.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	alsa-devel@alsa-project.org, patches@opensource.cirrus.com,
	linux-kernel@vger.kernel.org,
	Charles Keepax <ckeepax@opensource.cirrus.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH v1 1/1] ASoC: madera: Replace kernel.h with the necessary inclusions
Date: Mon, 4 Jul 2022 11:36:49 +0100	[thread overview]
Message-ID: <YsLCwQM0gbhFhSke@sirena.org.uk> (raw)
In-Reply-To: <YsG3kKwmoqF2MxU2@smile.fi.intel.com>

[-- Attachment #1: Type: text/plain, Size: 1806 bytes --]

On Sun, Jul 03, 2022 at 06:36:48PM +0300, Andy Shevchenko wrote:
> On Mon, Jun 06, 2022 at 10:29:59AM +0100, Richard Fitzgerald wrote:
> > On 03/06/2022 18:07, Andy Shevchenko wrote:

> > > When kernel.h is used in the headers it adds a lot into dependency hell,
> > > especially when there are circular dependencies are involved.

> > > Replace kernel.h inclusion with the list of what is really being used.

> > Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>

> Thanks!

> It's a month passed without any other news about this patch.
> Is this a problem in the MAINTAINERS database?

> Who should take this?

> +Cc: Liam, Mark

If you needed to add me to the CC I've not seen the patch...

As documented in submitting-patches.rst please send patches to the 
maintainers for the code you would like to change.  The normal kernel
workflow is that people apply patches from their inboxes, if they aren't
copied they are likely to not see the patch at all and it is much more
difficult to apply patches.

Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so 
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  If there have been
review comments then people may be waiting for those to be addressed.

Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, so sending again is generally a better approach though there are
some other maintainers who like them - if in doubt look at how patches
for the subsystem are normally handled.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: alsa-devel@alsa-project.org,
	Charles Keepax <ckeepax@opensource.cirrus.com>,
	patches@opensource.cirrus.com, Takashi Iwai <tiwai@suse.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	linux-kernel@vger.kernel.org,
	Richard Fitzgerald <rf@opensource.cirrus.com>
Subject: Re: [PATCH v1 1/1] ASoC: madera: Replace kernel.h with the necessary inclusions
Date: Mon, 4 Jul 2022 11:36:49 +0100	[thread overview]
Message-ID: <YsLCwQM0gbhFhSke@sirena.org.uk> (raw)
In-Reply-To: <YsG3kKwmoqF2MxU2@smile.fi.intel.com>

[-- Attachment #1: Type: text/plain, Size: 1806 bytes --]

On Sun, Jul 03, 2022 at 06:36:48PM +0300, Andy Shevchenko wrote:
> On Mon, Jun 06, 2022 at 10:29:59AM +0100, Richard Fitzgerald wrote:
> > On 03/06/2022 18:07, Andy Shevchenko wrote:

> > > When kernel.h is used in the headers it adds a lot into dependency hell,
> > > especially when there are circular dependencies are involved.

> > > Replace kernel.h inclusion with the list of what is really being used.

> > Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>

> Thanks!

> It's a month passed without any other news about this patch.
> Is this a problem in the MAINTAINERS database?

> Who should take this?

> +Cc: Liam, Mark

If you needed to add me to the CC I've not seen the patch...

As documented in submitting-patches.rst please send patches to the 
maintainers for the code you would like to change.  The normal kernel
workflow is that people apply patches from their inboxes, if they aren't
copied they are likely to not see the patch at all and it is much more
difficult to apply patches.

Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so 
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  If there have been
review comments then people may be waiting for those to be addressed.

Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, so sending again is generally a better approach though there are
some other maintainers who like them - if in doubt look at how patches
for the subsystem are normally handled.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2022-07-04 10:36 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-03 17:07 [PATCH v1 1/1] ASoC: madera: Replace kernel.h with the necessary inclusions Andy Shevchenko
2022-06-03 17:07 ` Andy Shevchenko
2022-06-06  9:29 ` Richard Fitzgerald
2022-06-06  9:29   ` Richard Fitzgerald
2022-07-03 15:36   ` Andy Shevchenko
2022-07-03 15:36     ` Andy Shevchenko
2022-07-04 10:36     ` Mark Brown [this message]
2022-07-04 10:36       ` Mark Brown
2022-07-04 15:30       ` Andy Shevchenko
2022-07-04 15:30         ` Andy Shevchenko
2022-07-04 15:35         ` Mark Brown
2022-07-04 15:35           ` Mark Brown
2022-07-04 15:51           ` Andy Shevchenko
2022-07-04 15:51             ` Andy Shevchenko
2022-07-04 16:24             ` Mark Brown
2022-07-04 16:24               ` Mark Brown
2022-07-05 18:52 ` Mark Brown
2022-07-05 18:52   ` Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2021-12-22 16:45 Andy Shevchenko
2021-12-22 16:45 ` Andy Shevchenko
2021-12-29  9:53 ` Charles Keepax
2021-12-29  9:53   ` Charles Keepax
2022-01-24 16:22   ` Andy Shevchenko
2022-01-24 16:22     ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YsLCwQM0gbhFhSke@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=perex@perex.cz \
    --cc=rf@opensource.cirrus.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.