* [man-pages PATCH RESEND] statx.2: correctly document STATX_ALL
@ 2022-07-05 18:36 Eric Biggers
2022-07-05 18:48 ` Andreas Dilger
2022-07-05 22:23 ` Darrick J. Wong
0 siblings, 2 replies; 4+ messages in thread
From: Eric Biggers @ 2022-07-05 18:36 UTC (permalink / raw)
To: linux-man, Alejandro Colomar; +Cc: linux-fsdevel
From: Eric Biggers <ebiggers@google.com>
Since kernel commit 581701b7efd6 ("uapi: deprecate STATX_ALL"),
STATX_ALL is deprecated. It doesn't include STATX_MNT_ID, and it won't
include any future flags. Update the man page accordingly.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
man2/statx.2 | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/man2/statx.2 b/man2/statx.2
index a8620be6f..561e64f7b 100644
--- a/man2/statx.2
+++ b/man2/statx.2
@@ -244,8 +244,9 @@ STATX_SIZE Want stx_size
STATX_BLOCKS Want stx_blocks
STATX_BASIC_STATS [All of the above]
STATX_BTIME Want stx_btime
+STATX_ALL The same as STATX_BASIC_STATS | STATX_BTIME.
+ This is deprecated and should not be used.
STATX_MNT_ID Want stx_mnt_id (since Linux 5.8)
-STATX_ALL [All currently available fields]
.TE
.in
.PP
base-commit: 88646725187456fad6f17552e96c50c93bd361dc
--
2.37.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [man-pages PATCH RESEND] statx.2: correctly document STATX_ALL
2022-07-05 18:36 [man-pages PATCH RESEND] statx.2: correctly document STATX_ALL Eric Biggers
@ 2022-07-05 18:48 ` Andreas Dilger
2022-07-05 22:23 ` Darrick J. Wong
1 sibling, 0 replies; 4+ messages in thread
From: Andreas Dilger @ 2022-07-05 18:48 UTC (permalink / raw)
To: Eric Biggers; +Cc: linux-man, Alejandro Colomar, linux-fsdevel
[-- Attachment #1: Type: text/plain, Size: 1101 bytes --]
On Jul 5, 2022, at 12:36 PM, Eric Biggers <ebiggers@kernel.org> wrote:
>
> From: Eric Biggers <ebiggers@google.com>
>
> Since kernel commit 581701b7efd6 ("uapi: deprecate STATX_ALL"),
> STATX_ALL is deprecated. It doesn't include STATX_MNT_ID, and it won't
> include any future flags. Update the man page accordingly.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
> ---
> man2/statx.2 | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/man2/statx.2 b/man2/statx.2
> index a8620be6f..561e64f7b 100644
> --- a/man2/statx.2
> +++ b/man2/statx.2
> @@ -244,8 +244,9 @@ STATX_SIZE Want stx_size
> STATX_BLOCKS Want stx_blocks
> STATX_BASIC_STATS [All of the above]
> STATX_BTIME Want stx_btime
> +STATX_ALL The same as STATX_BASIC_STATS | STATX_BTIME.
> + This is deprecated and should not be used.
> STATX_MNT_ID Want stx_mnt_id (since Linux 5.8)
> -STATX_ALL [All currently available fields]
> .TE
> .in
> .PP
>
> base-commit: 88646725187456fad6f17552e96c50c93bd361dc
> --
> 2.37.0
>
Cheers, Andreas
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 873 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [man-pages PATCH RESEND] statx.2: correctly document STATX_ALL
2022-07-05 18:36 [man-pages PATCH RESEND] statx.2: correctly document STATX_ALL Eric Biggers
2022-07-05 18:48 ` Andreas Dilger
@ 2022-07-05 22:23 ` Darrick J. Wong
2022-07-06 23:33 ` Alejandro Colomar
1 sibling, 1 reply; 4+ messages in thread
From: Darrick J. Wong @ 2022-07-05 22:23 UTC (permalink / raw)
To: Eric Biggers; +Cc: linux-man, Alejandro Colomar, linux-fsdevel
On Tue, Jul 05, 2022 at 11:36:14AM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Since kernel commit 581701b7efd6 ("uapi: deprecate STATX_ALL"),
> STATX_ALL is deprecated. It doesn't include STATX_MNT_ID, and it won't
> include any future flags. Update the man page accordingly.
>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
As the last idiot to trip over this,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> man2/statx.2 | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/man2/statx.2 b/man2/statx.2
> index a8620be6f..561e64f7b 100644
> --- a/man2/statx.2
> +++ b/man2/statx.2
> @@ -244,8 +244,9 @@ STATX_SIZE Want stx_size
> STATX_BLOCKS Want stx_blocks
> STATX_BASIC_STATS [All of the above]
> STATX_BTIME Want stx_btime
> +STATX_ALL The same as STATX_BASIC_STATS | STATX_BTIME.
> + This is deprecated and should not be used.
> STATX_MNT_ID Want stx_mnt_id (since Linux 5.8)
> -STATX_ALL [All currently available fields]
> .TE
> .in
> .PP
>
> base-commit: 88646725187456fad6f17552e96c50c93bd361dc
> --
> 2.37.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [man-pages PATCH RESEND] statx.2: correctly document STATX_ALL
2022-07-05 22:23 ` Darrick J. Wong
@ 2022-07-06 23:33 ` Alejandro Colomar
0 siblings, 0 replies; 4+ messages in thread
From: Alejandro Colomar @ 2022-07-06 23:33 UTC (permalink / raw)
To: Eric Biggers; +Cc: linux-man, linux-fsdevel, Darrick J. Wong, Andreas Dilger
[-- Attachment #1.1: Type: text/plain, Size: 1451 bytes --]
Hi,
On 7/6/22 00:23, Darrick J. Wong wrote:
> On Tue, Jul 05, 2022 at 11:36:14AM -0700, Eric Biggers wrote:
>> From: Eric Biggers <ebiggers@google.com>
>>
>> Since kernel commit 581701b7efd6 ("uapi: deprecate STATX_ALL"),
>> STATX_ALL is deprecated. It doesn't include STATX_MNT_ID, and it won't
>> include any future flags. Update the man page accordingly.
>>
>> Signed-off-by: Eric Biggers <ebiggers@google.com>
Thanks for the patch! Applied.
>
> As the last idiot to trip over this,
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>
And thanks for the reviews, Andreas and Darrick, I added both of your tags.
Cheers,
Alex
>
> --D
>
>> ---
>> man2/statx.2 | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/man2/statx.2 b/man2/statx.2
>> index a8620be6f..561e64f7b 100644
>> --- a/man2/statx.2
>> +++ b/man2/statx.2
>> @@ -244,8 +244,9 @@ STATX_SIZE Want stx_size
>> STATX_BLOCKS Want stx_blocks
>> STATX_BASIC_STATS [All of the above]
>> STATX_BTIME Want stx_btime
>> +STATX_ALL The same as STATX_BASIC_STATS | STATX_BTIME.
>> + This is deprecated and should not be used.
>> STATX_MNT_ID Want stx_mnt_id (since Linux 5.8)
>> -STATX_ALL [All currently available fields]
>> .TE
>> .in
>> .PP
>>
>> base-commit: 88646725187456fad6f17552e96c50c93bd361dc
>> --
>> 2.37.0
>>
--
Alejandro Colomar
<http://www.alejandro-colomar.es/>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-06 23:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-05 18:36 [man-pages PATCH RESEND] statx.2: correctly document STATX_ALL Eric Biggers
2022-07-05 18:48 ` Andreas Dilger
2022-07-05 22:23 ` Darrick J. Wong
2022-07-06 23:33 ` Alejandro Colomar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.