All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] dmaengine: xilinx_dpdma: Omit superfluous error message in xilinx_dpdma_probe()
@ 2022-05-19 13:08 ` Tang Bin
  0 siblings, 0 replies; 4+ messages in thread
From: Tang Bin @ 2022-05-19 13:08 UTC (permalink / raw)
  To: hyun.kwon, laurent.pinchart, vkoul, michal.simek
  Cc: dmaengine, linux-arm-kernel, linux-kernel, Tang Bin

In the function xilinx_dpdma_probe(), when get irq failed,
the function platform_get_irq() logs an error message,
so remove redundant message here.

Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
 drivers/dma/xilinx/xilinx_dpdma.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/dma/xilinx/xilinx_dpdma.c b/drivers/dma/xilinx/xilinx_dpdma.c
index b0f4948b0..f708808d7 100644
--- a/drivers/dma/xilinx/xilinx_dpdma.c
+++ b/drivers/dma/xilinx/xilinx_dpdma.c
@@ -1652,10 +1652,8 @@ static int xilinx_dpdma_probe(struct platform_device *pdev)
 	dpdma_hw_init(xdev);
 
 	xdev->irq = platform_get_irq(pdev, 0);
-	if (xdev->irq < 0) {
-		dev_err(xdev->dev, "failed to get platform irq\n");
+	if (xdev->irq < 0)
 		return xdev->irq;
-	}
 
 	ret = request_irq(xdev->irq, xilinx_dpdma_irq_handler, IRQF_SHARED,
 			  dev_name(xdev->dev), xdev);
-- 
2.20.1.windows.1




^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] dmaengine: xilinx_dpdma: Omit superfluous error message in xilinx_dpdma_probe()
@ 2022-05-19 13:08 ` Tang Bin
  0 siblings, 0 replies; 4+ messages in thread
From: Tang Bin @ 2022-05-19 13:08 UTC (permalink / raw)
  To: hyun.kwon, laurent.pinchart, vkoul, michal.simek
  Cc: dmaengine, linux-arm-kernel, linux-kernel, Tang Bin

In the function xilinx_dpdma_probe(), when get irq failed,
the function platform_get_irq() logs an error message,
so remove redundant message here.

Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
 drivers/dma/xilinx/xilinx_dpdma.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/dma/xilinx/xilinx_dpdma.c b/drivers/dma/xilinx/xilinx_dpdma.c
index b0f4948b0..f708808d7 100644
--- a/drivers/dma/xilinx/xilinx_dpdma.c
+++ b/drivers/dma/xilinx/xilinx_dpdma.c
@@ -1652,10 +1652,8 @@ static int xilinx_dpdma_probe(struct platform_device *pdev)
 	dpdma_hw_init(xdev);
 
 	xdev->irq = platform_get_irq(pdev, 0);
-	if (xdev->irq < 0) {
-		dev_err(xdev->dev, "failed to get platform irq\n");
+	if (xdev->irq < 0)
 		return xdev->irq;
-	}
 
 	ret = request_irq(xdev->irq, xilinx_dpdma_irq_handler, IRQF_SHARED,
 			  dev_name(xdev->dev), xdev);
-- 
2.20.1.windows.1




_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] dmaengine: xilinx_dpdma: Omit superfluous error message in xilinx_dpdma_probe()
  2022-05-19 13:08 ` Tang Bin
@ 2022-07-06  5:18   ` Vinod Koul
  -1 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2022-07-06  5:18 UTC (permalink / raw)
  To: Tang Bin
  Cc: hyun.kwon, laurent.pinchart, michal.simek, dmaengine,
	linux-arm-kernel, linux-kernel

On 19-05-22, 21:08, Tang Bin wrote:
> In the function xilinx_dpdma_probe(), when get irq failed,
> the function platform_get_irq() logs an error message,
> so remove redundant message here.

Applied, thanks

-- 
~Vinod

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] dmaengine: xilinx_dpdma: Omit superfluous error message in xilinx_dpdma_probe()
@ 2022-07-06  5:18   ` Vinod Koul
  0 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2022-07-06  5:18 UTC (permalink / raw)
  To: Tang Bin
  Cc: hyun.kwon, laurent.pinchart, michal.simek, dmaengine,
	linux-arm-kernel, linux-kernel

On 19-05-22, 21:08, Tang Bin wrote:
> In the function xilinx_dpdma_probe(), when get irq failed,
> the function platform_get_irq() logs an error message,
> so remove redundant message here.

Applied, thanks

-- 
~Vinod

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-07-06  5:19 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-19 13:08 [PATCH] dmaengine: xilinx_dpdma: Omit superfluous error message in xilinx_dpdma_probe() Tang Bin
2022-05-19 13:08 ` Tang Bin
2022-07-06  5:18 ` Vinod Koul
2022-07-06  5:18   ` Vinod Koul

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.