From: Kamil Konieczny <kamil.konieczny@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [igt-dev] [PATCH i-g-t v2 2/2] tests/gem_exec_fence: Coordinate sleep with the start of the request
Date: Tue, 26 Jul 2022 16:28:49 +0200 [thread overview]
Message-ID: <Yt/6IT31FRnW3vSs@kamilkon-desk1> (raw)
In-Reply-To: <8e33260c9fdfbc3d4508d71903063ebb1a2dcc6c.1658826356.git.karolina.drobnik@intel.com>
On 2022-07-26 at 12:13:12 +0200, Karolina Drobnik wrote:
> From: Chris Wilson <chris@chris-wilson.co.uk>
>
> Wait until we know the request is running on the GPU before sleeping
> and giving a chance for other fences to run ahead.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Karolina Drobnik <karolina.drobnik@intel.com>
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
--
Kamil
> ---
> tests/i915/gem_exec_fence.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_exec_fence.c b/tests/i915/gem_exec_fence.c
> index 260aa82c..7ff7614d 100644
> --- a/tests/i915/gem_exec_fence.c
> +++ b/tests/i915/gem_exec_fence.c
> @@ -324,7 +324,9 @@ static void test_fence_await(int fd, const intel_ctx_t *ctx,
> .ahnd = ahnd,
> .ctx = ctx,
> .engine = e->flags,
> - .flags = IGT_SPIN_FENCE_OUT | spin_hang(flags));
> + .flags = IGT_SPIN_FENCE_OUT |
> + IGT_SPIN_POLL_RUN |
> + spin_hang(flags));
> igt_assert(spin->out_fence != -1);
>
> i = 0;
> @@ -347,6 +349,7 @@ static void test_fence_await(int fd, const intel_ctx_t *ctx,
> i++;
> }
>
> + igt_spin_busywait_until_started(spin);
> /* Long, but not too long to anger preemption disable checks */
> usleep(50 * 1000); /* 50 ms, typical preempt reset is 150+ms */
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2022-07-26 14:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 10:13 [igt-dev] [PATCH i-g-t v2 0/2] tests/gem_exec_fence: Fix test_fence_await for hanging workloads Karolina Drobnik
2022-07-26 10:13 ` [igt-dev] [PATCH i-g-t v2 1/2] tests/gem_exec_fence: Check stored values only for valid workloads Karolina Drobnik
2022-07-26 14:27 ` Kamil Konieczny
2022-07-28 16:56 ` Janusz Krzysztofik
2022-07-29 7:38 ` Karolina Drobnik
2022-07-29 8:24 ` Janusz Krzysztofik
2022-07-29 11:32 ` Karolina Drobnik
2022-07-29 15:23 ` Janusz Krzysztofik
2022-07-26 10:13 ` [igt-dev] [PATCH i-g-t v2 2/2] tests/gem_exec_fence: Coordinate sleep with the start of the request Karolina Drobnik
2022-07-26 14:28 ` Kamil Konieczny [this message]
2022-07-26 10:54 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/gem_exec_fence: Fix test_fence_await for hanging workloads (rev2) Patchwork
2022-07-26 11:06 ` Karolina Drobnik
2022-07-28 15:17 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2022-07-28 21:20 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
[not found] ` <6459819.4vTCxPXJkl@jkrzyszt-mobl1.ger.corp.intel.com>
[not found] ` <fb564118-4afb-6f4a-03cc-34e255b871ef@intel.com>
2022-08-01 11:54 ` [igt-dev] [PATCH i-g-t v2 1/2] tests/gem_exec_fence: Check stored values only for valid workloads Janusz Krzysztofik
2022-08-01 13:39 ` Karolina Drobnik
2022-08-01 14:43 ` Janusz Krzysztofik
2022-08-02 10:20 ` Karolina Drobnik
2022-08-03 7:21 ` Janusz Krzysztofik
2022-08-03 7:45 ` Karolina Drobnik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yt/6IT31FRnW3vSs@kamilkon-desk1 \
--to=kamil.konieczny@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.