From: Karolina Drobnik <karolina.drobnik@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>,
Chris Wilson <chris@chris-wilson.co.uk>
Subject: [igt-dev] [PATCH i-g-t v2 0/2] tests/gem_exec_fence: Fix test_fence_await for hanging workloads
Date: Tue, 26 Jul 2022 12:13:10 +0200 [thread overview]
Message-ID: <cover.1658826356.git.karolina.drobnik@intel.com> (raw)
This patch series fixes test_fence_await for failing gem_exec_fence
subtests that inject GPU hangs (await-hang and nb-await-hang). The test
assumed that the error notification happens after a hang is declared,
which would be enough for the next set of fences to be submitted,
making this test pass. But as we use the error-interrupt, we get immediate
reset for the invalid command stream. This means that when the test checks
for active fences, none can be found, leading to the test failure.
To address this problem, the active fences check is only done for valid
workloads. In addition to the fix, the series adds spinning before
usleep() call to coordinate sleep with the start of the request.
v2:
No functional changes, fixed styling issues pointed out by Kamil:
- Moved comment for fence_busy(spin->out_fence) assertion
- Fixed formatting for flags assignment in spin definition
Chris Wilson (2):
tests/gem_exec_fence: Check stored values only for valid workloads
tests/gem_exec_fence: Coordinate sleep with the start of the request
tests/i915/gem_exec_fence.c | 19 ++++++++++++-------
1 file changed, 12 insertions(+), 7 deletions(-)
--
2.25.1
next reply other threads:[~2022-07-26 10:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 10:13 Karolina Drobnik [this message]
2022-07-26 10:13 ` [igt-dev] [PATCH i-g-t v2 1/2] tests/gem_exec_fence: Check stored values only for valid workloads Karolina Drobnik
2022-07-26 14:27 ` Kamil Konieczny
2022-07-28 16:56 ` Janusz Krzysztofik
2022-07-29 7:38 ` Karolina Drobnik
2022-07-29 8:24 ` Janusz Krzysztofik
2022-07-29 11:32 ` Karolina Drobnik
2022-07-29 15:23 ` Janusz Krzysztofik
2022-07-26 10:13 ` [igt-dev] [PATCH i-g-t v2 2/2] tests/gem_exec_fence: Coordinate sleep with the start of the request Karolina Drobnik
2022-07-26 14:28 ` Kamil Konieczny
2022-07-26 10:54 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/gem_exec_fence: Fix test_fence_await for hanging workloads (rev2) Patchwork
2022-07-26 11:06 ` Karolina Drobnik
2022-07-28 15:17 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2022-07-28 21:20 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
[not found] ` <6459819.4vTCxPXJkl@jkrzyszt-mobl1.ger.corp.intel.com>
[not found] ` <fb564118-4afb-6f4a-03cc-34e255b871ef@intel.com>
2022-08-01 11:54 ` [igt-dev] [PATCH i-g-t v2 1/2] tests/gem_exec_fence: Check stored values only for valid workloads Janusz Krzysztofik
2022-08-01 13:39 ` Karolina Drobnik
2022-08-01 14:43 ` Janusz Krzysztofik
2022-08-02 10:20 ` Karolina Drobnik
2022-08-03 7:21 ` Janusz Krzysztofik
2022-08-03 7:45 ` Karolina Drobnik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1658826356.git.karolina.drobnik@intel.com \
--to=karolina.drobnik@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=tvrtko.ursulin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.