From: Eric Biggers <ebiggers@kernel.org> To: Mike Snitzer <snitzer@redhat.com> Cc: Nathan Huckleberry <nhuck@google.com>, linux-kernel@vger.kernel.org, dm-devel@redhat.com, Alasdair Kergon <agk@redhat.com>, Mike Snitzer <snitzer@kernel.org>, Sami Tolvanen <samitolvanen@google.com> Subject: Re: [PATCH 3/3] dm-verity: Add try_verify_in_tasklet Date: Mon, 25 Jul 2022 20:06:01 -0700 [thread overview] Message-ID: <Yt9aGRXNNPGZFvld@sol.localdomain> (raw) In-Reply-To: <Yt9KTzXUeA8xAiGv@redhat.com> On Mon, Jul 25, 2022 at 09:58:39PM -0400, Mike Snitzer wrote: > > > @@ -1156,7 +1217,7 @@ static int verity_ctr(struct dm_target *ti, unsigned argc, char **argv) > > goto bad; > > } > > > > - v->tfm = crypto_alloc_ahash(v->alg_name, 0, 0); > > + v->tfm = crypto_alloc_ahash(v->alg_name, 0, CRYPTO_ALG_ASYNC); > > if (IS_ERR(v->tfm)) { > > ti->error = "Cannot initialize hash function"; > > r = PTR_ERR(v->tfm); > > This hunk that adds the CRYPTO_ALG_ASYNC flag _seems_ unrelated. I believe it's needed to ensure that only a synchronous algorithm is allocated, so that verity_hash_update() doesn't have to sleep during the tasklet. It should be conditional on v->use_tasklet, though. > @@ -321,14 +320,12 @@ static int verity_verify_level(struct dm_verity *v, struct dm_verity_io *io, > if (likely(memcmp(verity_io_real_digest(v, io), want_digest, > v->digest_size) == 0)) > aux->hash_verified = 1; > - else if (io->in_tasklet) { > + else if (io->in_tasklet) > /* > * FEC code cannot be run in a tasklet since it may > - * sleep. We need to resume execution in a work-queue > - * to handle FEC. > + * sleep, so fallback to using a work-queue. > */ > return -EAGAIN; > - } Doesn't this need to be: r = -EAGAIN; goto release_ret_r; - Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org> To: Mike Snitzer <snitzer@redhat.com> Cc: Mike Snitzer <snitzer@kernel.org>, linux-kernel@vger.kernel.org, Nathan Huckleberry <nhuck@google.com>, dm-devel@redhat.com, Sami Tolvanen <samitolvanen@google.com>, Alasdair Kergon <agk@redhat.com> Subject: Re: [dm-devel] [PATCH 3/3] dm-verity: Add try_verify_in_tasklet Date: Mon, 25 Jul 2022 20:06:01 -0700 [thread overview] Message-ID: <Yt9aGRXNNPGZFvld@sol.localdomain> (raw) In-Reply-To: <Yt9KTzXUeA8xAiGv@redhat.com> On Mon, Jul 25, 2022 at 09:58:39PM -0400, Mike Snitzer wrote: > > > @@ -1156,7 +1217,7 @@ static int verity_ctr(struct dm_target *ti, unsigned argc, char **argv) > > goto bad; > > } > > > > - v->tfm = crypto_alloc_ahash(v->alg_name, 0, 0); > > + v->tfm = crypto_alloc_ahash(v->alg_name, 0, CRYPTO_ALG_ASYNC); > > if (IS_ERR(v->tfm)) { > > ti->error = "Cannot initialize hash function"; > > r = PTR_ERR(v->tfm); > > This hunk that adds the CRYPTO_ALG_ASYNC flag _seems_ unrelated. I believe it's needed to ensure that only a synchronous algorithm is allocated, so that verity_hash_update() doesn't have to sleep during the tasklet. It should be conditional on v->use_tasklet, though. > @@ -321,14 +320,12 @@ static int verity_verify_level(struct dm_verity *v, struct dm_verity_io *io, > if (likely(memcmp(verity_io_real_digest(v, io), want_digest, > v->digest_size) == 0)) > aux->hash_verified = 1; > - else if (io->in_tasklet) { > + else if (io->in_tasklet) > /* > * FEC code cannot be run in a tasklet since it may > - * sleep. We need to resume execution in a work-queue > - * to handle FEC. > + * sleep, so fallback to using a work-queue. > */ > return -EAGAIN; > - } Doesn't this need to be: r = -EAGAIN; goto release_ret_r; - Eric -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2022-07-26 3:06 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-07-22 9:38 [PATCH 0/3] dm-verity: optionally use tasklets in dm-verity Nathan Huckleberry 2022-07-22 9:38 ` [dm-devel] " Nathan Huckleberry 2022-07-22 9:38 ` [PATCH 1/3] dm-bufio: Add flags for dm_bufio_client_create Nathan Huckleberry 2022-07-22 9:38 ` [dm-devel] " Nathan Huckleberry 2022-07-22 9:38 ` [PATCH 2/3] dm-bufio: Add DM_BUFIO_GET_CANT_SLEEP Nathan Huckleberry 2022-07-22 9:38 ` [dm-devel] " Nathan Huckleberry 2022-07-22 9:38 ` [PATCH 3/3] dm-verity: Add try_verify_in_tasklet Nathan Huckleberry 2022-07-22 9:38 ` [dm-devel] " Nathan Huckleberry 2022-07-26 1:58 ` Mike Snitzer 2022-07-26 1:58 ` [dm-devel] " Mike Snitzer 2022-07-26 3:06 ` Eric Biggers [this message] 2022-07-26 3:06 ` Eric Biggers 2022-07-26 4:13 ` Mike Snitzer 2022-07-26 4:13 ` [dm-devel] " Mike Snitzer 2022-07-22 16:41 ` [PATCH 0/3] dm-verity: optionally use tasklets in dm-verity Christoph Hellwig 2022-07-22 16:41 ` [dm-devel] " Christoph Hellwig 2022-07-22 17:12 ` Mike Snitzer 2022-07-22 17:12 ` [dm-devel] " Mike Snitzer 2022-08-15 11:35 ` Sebastian Andrzej Siewior 2022-07-22 18:12 ` [dm-devel] " Bart Van Assche 2022-07-22 18:12 ` Bart Van Assche 2022-07-22 18:33 ` Mike Snitzer 2022-07-22 18:33 ` [dm-devel] " Mike Snitzer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=Yt9aGRXNNPGZFvld@sol.localdomain \ --to=ebiggers@kernel.org \ --cc=agk@redhat.com \ --cc=dm-devel@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=nhuck@google.com \ --cc=samitolvanen@google.com \ --cc=snitzer@kernel.org \ --cc=snitzer@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.