All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@iki.fi>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: devicetree@vger.kernel.org, linux-media@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	Rob Herring <robh+dt@kernel.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Jacopo Mondi <jacopo@jmondi.org>,
	Eugen Hristev <eugen.hristev@microchip.com>,
	Hugues Fruchet <hugues.fruchet@foss.st.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	Fabio Estevam <festevam@gmail.com>,
	Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH v3 2/6] dt-bindings: Use new video interface bus type macros in examples
Date: Sat, 16 Jul 2022 12:28:45 +0300	[thread overview]
Message-ID: <YtKEzS6j0/45E7tP@valkosipuli.retiisi.eu> (raw)
In-Reply-To: <20220615221410.27459-3-laurent.pinchart@ideasonboard.com>

Hi Laurent,

On Thu, Jun 16, 2022 at 01:14:06AM +0300, Laurent Pinchart wrote:
> Now that a header exists with macros for the media interface bus-type
> values, replace hardcoding numerical constants with the corresponding
> macros in the DT binding examples.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Changes since v2:
> 
> - Go back to PARALLEL
> 
> Changes since v1:
> 
> - Rename PARALLEL to BT601
> ---
>  .../devicetree/bindings/display/bridge/analogix,anx7625.yaml  | 1 +
>  Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml     | 3 ++-
>  Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml  | 3 ++-
>  .../devicetree/bindings/media/marvell,mmp2-ccic.yaml          | 3 ++-
>  Documentation/devicetree/bindings/media/microchip,xisc.yaml   | 3 ++-
>  Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml    | 4 +++-
>  6 files changed, 12 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> index 35a48515836e..b0e5585f93e2 100644
> --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> @@ -118,6 +118,7 @@ additionalProperties: false
>  examples:
>    - |
>      #include <dt-bindings/gpio/gpio.h>
> +    #include <dt-bindings/media/video-interfaces.h>
>  
>      i2c0 {
>          #address-cells = <1>;

The definition doesn't seem to be used here. Is there a need to include
this?

I could drop this chunk while applying. There's just one trivial change
elsewhere in this patch to make.

-- 
Kind regards,

Sakari Ailus

WARNING: multiple messages have this Message-ID (diff)
From: Sakari Ailus <sakari.ailus@iki.fi>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: devicetree@vger.kernel.org, linux-media@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	Rob Herring <robh+dt@kernel.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Jacopo Mondi <jacopo@jmondi.org>,
	Eugen Hristev <eugen.hristev@microchip.com>,
	Hugues Fruchet <hugues.fruchet@foss.st.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	Fabio Estevam <festevam@gmail.com>,
	Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH v3 2/6] dt-bindings: Use new video interface bus type macros in examples
Date: Sat, 16 Jul 2022 12:28:45 +0300	[thread overview]
Message-ID: <YtKEzS6j0/45E7tP@valkosipuli.retiisi.eu> (raw)
In-Reply-To: <20220615221410.27459-3-laurent.pinchart@ideasonboard.com>

Hi Laurent,

On Thu, Jun 16, 2022 at 01:14:06AM +0300, Laurent Pinchart wrote:
> Now that a header exists with macros for the media interface bus-type
> values, replace hardcoding numerical constants with the corresponding
> macros in the DT binding examples.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Changes since v2:
> 
> - Go back to PARALLEL
> 
> Changes since v1:
> 
> - Rename PARALLEL to BT601
> ---
>  .../devicetree/bindings/display/bridge/analogix,anx7625.yaml  | 1 +
>  Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml     | 3 ++-
>  Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml  | 3 ++-
>  .../devicetree/bindings/media/marvell,mmp2-ccic.yaml          | 3 ++-
>  Documentation/devicetree/bindings/media/microchip,xisc.yaml   | 3 ++-
>  Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml    | 4 +++-
>  6 files changed, 12 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> index 35a48515836e..b0e5585f93e2 100644
> --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> @@ -118,6 +118,7 @@ additionalProperties: false
>  examples:
>    - |
>      #include <dt-bindings/gpio/gpio.h>
> +    #include <dt-bindings/media/video-interfaces.h>
>  
>      i2c0 {
>          #address-cells = <1>;

The definition doesn't seem to be used here. Is there a need to include
this?

I could drop this chunk while applying. There's just one trivial change
elsewhere in this patch to make.

-- 
Kind regards,

Sakari Ailus

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Sakari Ailus <sakari.ailus@iki.fi>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: devicetree@vger.kernel.org, Jacopo Mondi <jacopo@jmondi.org>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Hugues Fruchet <hugues.fruchet@foss.st.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	dri-devel@lists.freedesktop.org,
	Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	Rob Herring <robh+dt@kernel.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Eugen Hristev <eugen.hristev@microchip.com>,
	Shawn Guo <shawnguo@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org
Subject: Re: [PATCH v3 2/6] dt-bindings: Use new video interface bus type macros in examples
Date: Sat, 16 Jul 2022 12:28:45 +0300	[thread overview]
Message-ID: <YtKEzS6j0/45E7tP@valkosipuli.retiisi.eu> (raw)
In-Reply-To: <20220615221410.27459-3-laurent.pinchart@ideasonboard.com>

Hi Laurent,

On Thu, Jun 16, 2022 at 01:14:06AM +0300, Laurent Pinchart wrote:
> Now that a header exists with macros for the media interface bus-type
> values, replace hardcoding numerical constants with the corresponding
> macros in the DT binding examples.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Changes since v2:
> 
> - Go back to PARALLEL
> 
> Changes since v1:
> 
> - Rename PARALLEL to BT601
> ---
>  .../devicetree/bindings/display/bridge/analogix,anx7625.yaml  | 1 +
>  Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml     | 3 ++-
>  Documentation/devicetree/bindings/media/i2c/ovti,ov772x.yaml  | 3 ++-
>  .../devicetree/bindings/media/marvell,mmp2-ccic.yaml          | 3 ++-
>  Documentation/devicetree/bindings/media/microchip,xisc.yaml   | 3 ++-
>  Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml    | 4 +++-
>  6 files changed, 12 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> index 35a48515836e..b0e5585f93e2 100644
> --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml
> @@ -118,6 +118,7 @@ additionalProperties: false
>  examples:
>    - |
>      #include <dt-bindings/gpio/gpio.h>
> +    #include <dt-bindings/media/video-interfaces.h>
>  
>      i2c0 {
>          #address-cells = <1>;

The definition doesn't seem to be used here. Is there a need to include
this?

I could drop this chunk while applying. There's just one trivial change
elsewhere in this patch to make.

-- 
Kind regards,

Sakari Ailus

  parent reply	other threads:[~2022-07-16  9:28 UTC|newest]

Thread overview: 102+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-15 22:14 [PATCH v3 0/6] dt-bindings: Add macros for video interface bus types Laurent Pinchart
2022-06-15 22:14 ` Laurent Pinchart
2022-06-15 22:14 ` Laurent Pinchart
2022-06-15 22:14 ` [PATCH v3 1/6] dt-bindings: media: " Laurent Pinchart
2022-06-15 22:14   ` Laurent Pinchart
2022-06-15 22:14   ` Laurent Pinchart
2022-06-27 22:14   ` Rob Herring
2022-06-27 22:14     ` Rob Herring
2022-06-27 22:14     ` Rob Herring
2022-06-28 10:46   ` Jacopo Mondi
2022-06-28 10:46     ` Jacopo Mondi
2022-06-28 10:46     ` Jacopo Mondi
2022-11-17 10:02   ` Paul Elder
2022-11-17 10:02     ` Paul Elder
2022-11-17 10:02     ` Paul Elder
2022-06-15 22:14 ` [PATCH v3 2/6] dt-bindings: Use new video interface bus type macros in examples Laurent Pinchart
2022-06-15 22:14   ` Laurent Pinchart
2022-06-15 22:14   ` Laurent Pinchart
2022-06-27 22:16   ` Rob Herring
2022-06-27 22:16     ` Rob Herring
2022-06-27 22:16     ` Rob Herring
2022-06-27 23:40     ` Laurent Pinchart
2022-06-27 23:40       ` Laurent Pinchart
2022-06-27 23:40       ` Laurent Pinchart
2022-07-16  9:28   ` Sakari Ailus [this message]
2022-07-16  9:28     ` Sakari Ailus
2022-07-16  9:28     ` Sakari Ailus
2022-07-16 15:12     ` Laurent Pinchart
2022-07-16 15:12       ` Laurent Pinchart
2022-07-16 15:12       ` Laurent Pinchart
2022-11-21 21:10       ` Sakari Ailus
2022-11-21 21:10         ` Sakari Ailus
2022-11-21 21:10         ` Sakari Ailus
2022-06-15 22:14 ` [PATCH v3 3/6] ARM: dts: freescale: Use new media bus type macros Laurent Pinchart
2022-06-15 22:14   ` Laurent Pinchart
2022-06-15 22:14   ` Laurent Pinchart
2023-01-14 15:30   ` Laurent Pinchart
2023-01-14 15:30     ` Laurent Pinchart
2023-01-14 15:30     ` Laurent Pinchart
2023-01-25  2:16   ` Shawn Guo
2023-01-25  2:16     ` Shawn Guo
2023-01-25  2:16     ` Shawn Guo
2022-06-15 22:14 ` [PATCH v3 4/6] ARM: dts: omap: " Laurent Pinchart
2022-06-15 22:14   ` Laurent Pinchart
2022-06-15 22:14   ` Laurent Pinchart
2023-01-14 15:37   ` Laurent Pinchart
2023-01-14 15:37     ` Laurent Pinchart
2023-01-14 15:37     ` Laurent Pinchart
2023-01-19  7:59     ` Tony Lindgren
2023-01-19  7:59       ` Tony Lindgren
2023-01-19  7:59       ` Tony Lindgren
2022-06-15 22:14 ` [PATCH v3 5/6] ARM: dts: renesas: " Laurent Pinchart
2022-06-15 22:14   ` Laurent Pinchart
2022-06-15 22:14   ` Laurent Pinchart
2022-11-18  9:27   ` Lad, Prabhakar
2022-11-18  9:27     ` Lad, Prabhakar
2022-11-18  9:27     ` Lad, Prabhakar
2023-01-14 15:26   ` Laurent Pinchart
2023-01-14 15:26     ` Laurent Pinchart
2023-01-14 15:26     ` Laurent Pinchart
2023-01-16 10:24     ` Geert Uytterhoeven
2023-01-16 10:24       ` Geert Uytterhoeven
2023-01-16 10:24       ` Geert Uytterhoeven
2023-01-16 10:38       ` Laurent Pinchart
2023-01-16 10:38         ` Laurent Pinchart
2023-01-16 10:38         ` Laurent Pinchart
2023-01-16 10:44         ` Geert Uytterhoeven
2023-01-16 10:44           ` Geert Uytterhoeven
2023-01-16 10:44           ` Geert Uytterhoeven
2023-01-16 10:49           ` Laurent Pinchart
2023-01-16 10:49             ` Laurent Pinchart
2023-01-16 10:49             ` Laurent Pinchart
2023-01-16 11:23             ` Geert Uytterhoeven
2023-01-16 11:23               ` Geert Uytterhoeven
2023-01-16 11:23               ` Geert Uytterhoeven
2022-06-15 22:14 ` [PATCH v3 6/6] ARM: dts: stm32: " Laurent Pinchart
2022-06-15 22:14   ` Laurent Pinchart
2022-06-15 22:14   ` Laurent Pinchart
2023-01-14 15:36   ` Laurent Pinchart
2023-01-14 15:36     ` Laurent Pinchart
2023-01-14 15:36     ` Laurent Pinchart
2023-01-17 10:44     ` Alexandre TORGUE
2023-01-17 10:44       ` Alexandre TORGUE
2023-01-17 10:44       ` Alexandre TORGUE
2023-01-17 11:24   ` Alexandre TORGUE
2023-01-17 11:24     ` Alexandre TORGUE
2023-01-17 11:24     ` Alexandre TORGUE
2022-07-17  6:54 ` [PATCH v3 0/6] dt-bindings: Add macros for video interface bus types Sakari Ailus
2022-07-17  6:54   ` Sakari Ailus
2022-07-17  6:54   ` Sakari Ailus
2022-11-18  9:23   ` Paul Elder
2022-11-18  9:23     ` Paul Elder
2022-11-18  9:23     ` Paul Elder
2022-11-19 19:15     ` Laurent Pinchart
2022-11-19 19:15       ` Laurent Pinchart
2022-11-19 19:15       ` Laurent Pinchart
2022-11-21 10:54       ` Sakari Ailus
2022-11-21 10:54         ` Sakari Ailus
2022-11-21 10:54         ` Sakari Ailus
2022-11-21 11:06         ` Laurent Pinchart
2022-11-21 11:06           ` Laurent Pinchart
2022-11-21 11:06           ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YtKEzS6j0/45E7tP@valkosipuli.retiisi.eu \
    --to=sakari.ailus@iki.fi \
    --cc=alexandre.torgue@foss.st.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eugen.hristev@microchip.com \
    --cc=festevam@gmail.com \
    --cc=hugues.fruchet@foss.st.com \
    --cc=jacopo@jmondi.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh+dt@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.