FAIL: alsa/Makefile dependency check

FAIL: alsa/Makefile dependency check

[li_jessen2016@gmail.com li]

Dear Mark Brown,

Sorry to bother you. I posted this issue on stackoverflow but didn't get
any correct answer yet. So I try to reach you.

I'm using Ubuntu 20.04 and the kernel is *5.19.0-rc3+*.  When I run
*./kselftest_deps.sh
gcc* in .*/tools/testing/selftests*, it shows the following:

FAIL: alsa/Makefile dependency check: $(shell
FAIL: alsa/Makefile dependency check: pkg-config
FAIL: alsa/Makefile dependency check: --libs
FAIL: alsa/Makefile dependency check: alsa)
FAIL: alsa/Makefile dependency check: $(shell
FAIL: alsa/Makefile dependency check: pkg-config
FAIL: alsa/Makefile dependency check: --libs
FAIL: alsa/Makefile dependency check: alsa)

In alsa/Makefile, it is:

LDLIBS += $(shell pkg-config --libs alsa)

ifeq ($(LDLIBS),)
LDLIBS += -lasound
endif

But in ./alsa directory, when I run *$pkg-config --libs alsa, *it
returns *-lasound**.*

And when I change  *$(shell pkg-config --libs alsa)* to *-lasound* in
alsa/Makefile, there is no FAIL info for it.

So I wonder why the FAIL info appears in the presence of *$(shell
pkg-config --libs alsa) *in alsa/Makefile. Is it some sort of bug or
did I miss something?

Looking forward to your answer.

Best Regards.

Jessen

Re: FAIL: alsa/Makefile dependency check

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 598 bytes --]

On Fri, Jul 15, 2022 at 10:47:16PM +0800, li_jessen2016@gmail.com li wrote:

> FAIL: alsa/Makefile dependency check: $(shell
> FAIL: alsa/Makefile dependency check: pkg-config

..

> So I wonder why the FAIL info appears in the presence of *$(shell
> pkg-config --libs alsa) *in alsa/Makefile. Is it some sort of bug or
> did I miss something?

I think that's a bug in this tool you're running - it's not
understanding the $(shell ...) and generating false positives, not 100%
sure what it's trying to do but it's fairly clearly parsing every
element in the statement as a dependency of some kind.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: FAIL: alsa/Makefile dependency check

[li_jessen2016@gmail.com li]

Thanks for your kind reply. Then what should I do? To officially raise a
bug to all the relevant persons in the kernel community?

Jessen

On Fri, Jul 15, 2022 at 11:33 PM Mark Brown <broonie@kernel.org> wrote:

> On Fri, Jul 15, 2022 at 10:47:16PM +0800, li_jessen2016@gmail.com li
> wrote:
>
> > FAIL: alsa/Makefile dependency check: $(shell
> > FAIL: alsa/Makefile dependency check: pkg-config
>
> ..
>
> > So I wonder why the FAIL info appears in the presence of *$(shell
> > pkg-config --libs alsa) *in alsa/Makefile. Is it some sort of bug or
> > did I miss something?
>
> I think that's a bug in this tool you're running - it's not
> understanding the $(shell ...) and generating false positives, not 100%
> sure what it's trying to do but it's fairly clearly parsing every
> element in the statement as a dependency of some kind.
>

Re: FAIL: alsa/Makefile dependency check

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

On Sat, Jul 16, 2022 at 09:14:08AM +0800, li_jessen2016@gmail.com li wrote:

> Thanks for your kind reply. Then what should I do? To officially raise a
> bug to all the relevant persons in the kernel community?

Yeah, I'd figure out who works on the script and mail them about it (or
develop a patch if you feel up to it!).

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]