[patch v3] random.4: Update description about O_NONBLOCK flag

[patch v3] random.4: Update description about O_NONBLOCK flag

[GUO Zihua]

The O_NONBLOCK flag has been ignored since Linux 5.6 and this patch
states this change in man page.

The commit that introduce this change in the Linux kernel is
30c08efec888 ("random: make /dev/random be almost like /dev/urandom")

Signed-off-by: GUO Zihua <guozihua@huawei.com>
Reviewed-by: Petr Vorel <pvorel@suse.cz>
---

v3:
-Replaced "removed" with "ignored" as suggested by Florian. Added
Reviewed-by by Petr

v2:
-Fix formating issue.
---
 man4/random.4 | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/man4/random.4 b/man4/random.4
index bea860e7f0d7..3227a483d4a9 100644
--- a/man4/random.4
+++ b/man4/random.4
@@ -68,7 +68,12 @@ high quality randomness, and can afford indeterminate delays.
 .PP
 When the entropy pool is empty, reads from \fI/dev/random\fP will block
 until additional environmental noise is gathered.
-If
+Since Linux 5.6, the
+.B O_NONBLOCK
+flag is ignored as
+.I /dev/random
+will no longer block except during early boot process.
+In eariler versions, if
 .BR open (2)
 is called for
 .I /dev/random
-- 
2.36.0

Re: [patch v3] random.4: Update description about O_NONBLOCK flag

[Alejandro Colomar]

[-- Attachment #1.1: Type: text/plain, Size: 1324 bytes --]

Hi,

On 8/3/22 09:45, GUO Zihua wrote:
> The O_NONBLOCK flag has been ignored since Linux 5.6 and this patch
> states this change in man page.
> 
> The commit that introduce this change in the Linux kernel is
> 30c08efec888 ("random: make /dev/random be almost like /dev/urandom")
> 
> Signed-off-by: GUO Zihua <guozihua@huawei.com>
> Reviewed-by: Petr Vorel <pvorel@suse.cz>

Patch applied.

Thanks,

Alex

> ---
> 
> v3:
> -Replaced "removed" with "ignored" as suggested by Florian. Added
> Reviewed-by by Petr
> 
> v2:
> -Fix formating issue.
> ---
>   man4/random.4 | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/man4/random.4 b/man4/random.4
> index bea860e7f0d7..3227a483d4a9 100644
> --- a/man4/random.4
> +++ b/man4/random.4
> @@ -68,7 +68,12 @@ high quality randomness, and can afford indeterminate delays.
>   .PP
>   When the entropy pool is empty, reads from \fI/dev/random\fP will block
>   until additional environmental noise is gathered.
> -If
> +Since Linux 5.6, the
> +.B O_NONBLOCK
> +flag is ignored as
> +.I /dev/random
> +will no longer block except during early boot process.
> +In eariler versions, if
>   .BR open (2)
>   is called for
>   .I /dev/random

-- 
Alejandro Colomar
<http://www.alejandro-colomar.es/>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [patch v3] random.4: Update description about O_NONBLOCK flag

[Eric Biggers]

On Fri, Aug 05, 2022 at 08:36:02PM +0200, Alejandro Colomar wrote:
> > +In eariler versions, if

Typo: eariler => earlier

- Eric

Re: [patch v3] random.4: Update description about O_NONBLOCK flag

[Guozihua (Scott)]

On 2022/8/6 2:45, Eric Biggers wrote:
> On Fri, Aug 05, 2022 at 08:36:02PM +0200, Alejandro Colomar wrote:
>>> +In eariler versions, if
> 
> Typo: eariler => earlier
> 
> - Eric
> .

Good catch Eric!

Am I still able to fix this?

-- 
Best
GUO Zihua

Re: [patch v3] random.4: Update description about O_NONBLOCK flag

[Alejandro Colomar]

[-- Attachment #1.1: Type: text/plain, Size: 599 bytes --]

Hi.

On 8/8/22 03:20, Guozihua (Scott) wrote:
> On 2022/8/6 2:45, Eric Biggers wrote:
>> On Fri, Aug 05, 2022 at 08:36:02PM +0200, Alejandro Colomar wrote:
>>>> +In eariler versions, if
>>
>> Typo: eariler => earlier
>>
>> - Eric
>> .
> 
> Good catch Eric!
> 
> Am I still able to fix this?

Heh, sorry but I pushed already.  I forgot to fix it, so I fixed it in a 
separate commit:

<https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/commit/?id=226cd95d78c24dee169bb96913721221fb8f656a>

Cheers,

Alex

-- 
Alejandro Colomar
<http://www.alejandro-colomar.es/>

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [patch v3] random.4: Update description about O_NONBLOCK flag

[Guozihua (Scott)]

On 2022/8/9 2:28, Alejandro Colomar wrote:
> Hi.
> 
> On 8/8/22 03:20, Guozihua (Scott) wrote:
>> On 2022/8/6 2:45, Eric Biggers wrote:
>>> On Fri, Aug 05, 2022 at 08:36:02PM +0200, Alejandro Colomar wrote:
>>>>> +In eariler versions, if
>>>
>>> Typo: eariler => earlier
>>>
>>> - Eric
>>> .
>>
>> Good catch Eric!
>>
>> Am I still able to fix this?
> 
> Heh, sorry but I pushed already.  I forgot to fix it, so I fixed it in a 
> separate commit:
> 
> <https://git.kernel.org/pub/scm/docs/man-pages/man-pages.git/commit/?id=226cd95d78c24dee169bb96913721221fb8f656a> 
> 
> 
> Cheers,
> 
> Alex
> 

Thanks Alex, no problem.

-- 
Best
GUO Zihua