From: Greg KH <gregkh@linuxfoundation.org>
To: Jim Lin <jilin@nvidia.com>
Cc: jckuo@nvidia.com, thierry.reding@gmail.com, jonathanh@nvidia.com,
linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org,
linux-phy@lists.infradead.org, balbi@kernel.org,
vkoul@kernel.org, mathias.nyman@intel.com,
Allie Liu <alliel@nvidia.com>
Subject: Re: [PATCH] xhci: tegra: USB2 pad power controls
Date: Wed, 27 Jul 2022 12:58:00 +0200 [thread overview]
Message-ID: <YuEaOGP/AaUKimFg@kroah.com> (raw)
In-Reply-To: <20220727105314.14681-1-jilin@nvidia.com>
On Wed, Jul 27, 2022 at 06:53:14PM +0800, Jim Lin wrote:
> Program USB2 pad PD controls during port
> connect/disconnect, port suspend/resume etc
> as suggested by HW to reduce power consumption.
You do have a full 72 columns to use :)
And this does not explain what this commit does at all, or why we would
want to take it. Please read the kernel documentation for how to write
a good changelog commit.
> Squash following fixes from local kernel 4.9 to this commit:
> ce4e7e5 usb: host: tegra: Power on utmi pads
> 3a10c61 usb: tegra: Program USB2 pad PD controls
> 4e62fbb xhci: tegra: move pad power on to non-atomic place
> ed0fb0a usb: xhci: tegra: don't use hs_pls in xhci-iov
> 401801a usb: xhci: add USB2 pad PD control for Test Mode
This makes no sense, as these commits are not in our kernel tree at all.
Also they are not even in the correct format, if we were to take them
(hint, you need to fix your development process to not take lines like
this.)
>
> Signed-off-by: Allie Liu <alliel@nvidia.com>
> Signed-off-by: Jim Lin <jilin@nvidia.com>
> ---
> drivers/phy/tegra/xusb-tegra186.c | 27 +++--
> drivers/phy/tegra/xusb.c | 32 +++++-
> drivers/phy/tegra/xusb.h | 4 +-
> drivers/usb/gadget/udc/tegra-xudc.c | 8 +-
> drivers/usb/host/xhci-hub.c | 2 +
> drivers/usb/host/xhci-tegra.c | 146 +++++++++++++++++++++++++++-
> include/linux/phy/tegra/xusb.h | 4 +-
> 7 files changed, 209 insertions(+), 14 deletions(-)
Are you sure you want to touch all of these files in a single commit?
Why not submit a patch series?
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Jim Lin <jilin@nvidia.com>
Cc: jckuo@nvidia.com, thierry.reding@gmail.com, jonathanh@nvidia.com,
linux-tegra@vger.kernel.org, linux-usb@vger.kernel.org,
linux-phy@lists.infradead.org, balbi@kernel.org,
vkoul@kernel.org, mathias.nyman@intel.com,
Allie Liu <alliel@nvidia.com>
Subject: Re: [PATCH] xhci: tegra: USB2 pad power controls
Date: Wed, 27 Jul 2022 12:58:00 +0200 [thread overview]
Message-ID: <YuEaOGP/AaUKimFg@kroah.com> (raw)
In-Reply-To: <20220727105314.14681-1-jilin@nvidia.com>
On Wed, Jul 27, 2022 at 06:53:14PM +0800, Jim Lin wrote:
> Program USB2 pad PD controls during port
> connect/disconnect, port suspend/resume etc
> as suggested by HW to reduce power consumption.
You do have a full 72 columns to use :)
And this does not explain what this commit does at all, or why we would
want to take it. Please read the kernel documentation for how to write
a good changelog commit.
> Squash following fixes from local kernel 4.9 to this commit:
> ce4e7e5 usb: host: tegra: Power on utmi pads
> 3a10c61 usb: tegra: Program USB2 pad PD controls
> 4e62fbb xhci: tegra: move pad power on to non-atomic place
> ed0fb0a usb: xhci: tegra: don't use hs_pls in xhci-iov
> 401801a usb: xhci: add USB2 pad PD control for Test Mode
This makes no sense, as these commits are not in our kernel tree at all.
Also they are not even in the correct format, if we were to take them
(hint, you need to fix your development process to not take lines like
this.)
>
> Signed-off-by: Allie Liu <alliel@nvidia.com>
> Signed-off-by: Jim Lin <jilin@nvidia.com>
> ---
> drivers/phy/tegra/xusb-tegra186.c | 27 +++--
> drivers/phy/tegra/xusb.c | 32 +++++-
> drivers/phy/tegra/xusb.h | 4 +-
> drivers/usb/gadget/udc/tegra-xudc.c | 8 +-
> drivers/usb/host/xhci-hub.c | 2 +
> drivers/usb/host/xhci-tegra.c | 146 +++++++++++++++++++++++++++-
> include/linux/phy/tegra/xusb.h | 4 +-
> 7 files changed, 209 insertions(+), 14 deletions(-)
Are you sure you want to touch all of these files in a single commit?
Why not submit a patch series?
thanks,
greg k-h
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
next prev parent reply other threads:[~2022-07-27 10:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-27 10:53 [PATCH] xhci: tegra: USB2 pad power controls Jim Lin
2022-07-27 10:53 ` Jim Lin
2022-07-27 10:58 ` Greg KH [this message]
2022-07-27 10:58 ` Greg KH
[not found] ` <IA1PR12MB66038FF5370F31870ED62BA9C0969@IA1PR12MB6603.namprd12.prod.outlook.com>
2022-07-28 8:56 ` Greg KH
2022-07-28 8:56 ` Greg KH
2022-07-27 14:17 ` Thierry Reding
2022-07-27 14:17 ` Thierry Reding
2022-09-22 9:24 Jim Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuEaOGP/AaUKimFg@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alliel@nvidia.com \
--cc=balbi@kernel.org \
--cc=jckuo@nvidia.com \
--cc=jilin@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=linux-phy@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=thierry.reding@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.