* [PATCH] usb: typec: anx7411: Fix error code in anx7411_register_partner()
@ 2022-07-28 7:13 Dan Carpenter
2022-07-28 7:22 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2022-07-28 7:13 UTC (permalink / raw)
To: Heikki Krogerus, Xin Ji; +Cc: Greg Kroah-Hartman, linux-usb, kernel-janitors
This code accidentally return success instead of a negative error code.
Fixes: fe6d8a9c8e64 ("usb: typec: anx7411: Add Analogix PD ANX7411 support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/usb/typec/anx7411.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/typec/anx7411.c b/drivers/usb/typec/anx7411.c
index b990376991f8..96a3bf96f35e 100644
--- a/drivers/usb/typec/anx7411.c
+++ b/drivers/usb/typec/anx7411.c
@@ -374,6 +374,7 @@ static int anx7411_register_partner(struct anx7411_data *ctx,
int pd, int accessory)
{
struct typec_partner_desc desc;
+ int ret;
if (ctx->typec.partner)
return 0;
@@ -383,8 +384,9 @@ static int anx7411_register_partner(struct anx7411_data *ctx,
desc.identity = NULL;
ctx->typec.partner = typec_register_partner(ctx->typec.port, &desc);
if (IS_ERR(ctx->typec.partner)) {
+ ret = PTR_ERR(ctx->typec.partner);
ctx->typec.partner = NULL;
- return PTR_ERR(ctx->typec.partner);
+ return ret;
}
return 0;
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: typec: anx7411: Fix error code in anx7411_register_partner()
2022-07-28 7:13 [PATCH] usb: typec: anx7411: Fix error code in anx7411_register_partner() Dan Carpenter
@ 2022-07-28 7:22 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2022-07-28 7:22 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Heikki Krogerus, Xin Ji, linux-usb, kernel-janitors
On Thu, Jul 28, 2022 at 10:13:16AM +0300, Dan Carpenter wrote:
> This code accidentally return success instead of a negative error code.
>
> Fixes: fe6d8a9c8e64 ("usb: typec: anx7411: Add Analogix PD ANX7411 support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/usb/typec/anx7411.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Doesn't apply to my tree anymore, I think this is already fixed. Let me
push it out so it shows up in linux-next tomorrow.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-28 7:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-28 7:13 [PATCH] usb: typec: anx7411: Fix error code in anx7411_register_partner() Dan Carpenter
2022-07-28 7:22 ` Greg Kroah-Hartman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.