* Re: [PATCH] xfs/191: Add missing xfsprogs commit
2022-07-28 4:36 [PATCH] xfs/191: Add missing xfsprogs commit Yang Xu
@ 2022-07-28 3:54 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2022-07-28 3:54 UTC (permalink / raw)
To: Yang Xu; +Cc: fstests
On Thu, Jul 28, 2022 at 12:36:31PM +0800, Yang Xu wrote:
> xfs_repair also needs to think empty xattr leaf block isn't corruption, so
> case can pass.
>
> Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
Yep, thanks.
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
--D
> ---
> tests/xfs/191 | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/tests/xfs/191 b/tests/xfs/191
> index c568f90e..a10077fe 100755
> --- a/tests/xfs/191
> +++ b/tests/xfs/191
> @@ -11,9 +11,11 @@
> # operations don't stumble over them, and that xfs_repair will offer to remove
> # the entire xattr fork if the root xattr leaf block is empty.
> #
> -# Regression test for kernel commit:
> -#
> +# Regression test for
> +# kernel commit:
> # 7be3bd8856fb ("xfs: empty xattr leaf header blocks are not corruption")
> +# xfsprogs commit:
> +# f50d3462c654 ("xfs_repair: ignore empty xattr leaf blocks")
> #
> . ./common/preamble
> _begin_fstest auto quick attr
> @@ -28,6 +30,7 @@ _supported_fs xfs
> _require_scratch
> _require_scratch_xfs_crc # V4 is deprecated
> _fixed_by_kernel_commit 7be3bd8856fb "xfs: empty xattr leaf header blocks are not corruption"
> +_fixed_by_git_commit xfsprogs f50d3462c654 "xfs_repair: ignore empty xattr leaf blocks"
>
> _scratch_mkfs_xfs | _filter_mkfs >$seqres.full 2>$tmp.mkfs
> cat $tmp.mkfs >> $seqres.full
> --
> 2.23.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] xfs/191: Add missing xfsprogs commit
@ 2022-07-28 4:36 Yang Xu
2022-07-28 3:54 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: Yang Xu @ 2022-07-28 4:36 UTC (permalink / raw)
To: fstests; +Cc: djwong, Yang Xu
xfs_repair also needs to think empty xattr leaf block isn't corruption, so
case can pass.
Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
---
tests/xfs/191 | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/tests/xfs/191 b/tests/xfs/191
index c568f90e..a10077fe 100755
--- a/tests/xfs/191
+++ b/tests/xfs/191
@@ -11,9 +11,11 @@
# operations don't stumble over them, and that xfs_repair will offer to remove
# the entire xattr fork if the root xattr leaf block is empty.
#
-# Regression test for kernel commit:
-#
+# Regression test for
+# kernel commit:
# 7be3bd8856fb ("xfs: empty xattr leaf header blocks are not corruption")
+# xfsprogs commit:
+# f50d3462c654 ("xfs_repair: ignore empty xattr leaf blocks")
#
. ./common/preamble
_begin_fstest auto quick attr
@@ -28,6 +30,7 @@ _supported_fs xfs
_require_scratch
_require_scratch_xfs_crc # V4 is deprecated
_fixed_by_kernel_commit 7be3bd8856fb "xfs: empty xattr leaf header blocks are not corruption"
+_fixed_by_git_commit xfsprogs f50d3462c654 "xfs_repair: ignore empty xattr leaf blocks"
_scratch_mkfs_xfs | _filter_mkfs >$seqres.full 2>$tmp.mkfs
cat $tmp.mkfs >> $seqres.full
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-28 3:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-28 4:36 [PATCH] xfs/191: Add missing xfsprogs commit Yang Xu
2022-07-28 3:54 ` Darrick J. Wong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.