* [PATCH 1/1] usb: misc: onboard_usb_hub: Remove duplicated power_on delay
@ 2022-07-28 6:49 Alexander Stein
2022-07-28 14:00 ` Matthias Kaehlcke
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Stein @ 2022-07-28 6:49 UTC (permalink / raw)
To: Greg Kroah-Hartman, Matthias Kaehlcke; +Cc: Alexander Stein, linux-usb
onboard_hub_power_on() already ensures the reset pulse width delay, so
there is no need to wait right after requesting GPIO as well.
Fixes: 40758e493f4d ("usb: misc: onboard_usb_hub: Add reset-gpio support")
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
drivers/usb/misc/onboard_usb_hub.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/usb/misc/onboard_usb_hub.c b/drivers/usb/misc/onboard_usb_hub.c
index eb8aef25a22d..d1df153e7f5a 100644
--- a/drivers/usb/misc/onboard_usb_hub.c
+++ b/drivers/usb/misc/onboard_usb_hub.c
@@ -256,9 +256,6 @@ static int onboard_hub_probe(struct platform_device *pdev)
if (IS_ERR(hub->reset_gpio))
return dev_err_probe(dev, PTR_ERR(hub->reset_gpio), "failed to get reset GPIO\n");
- if (hub->reset_gpio)
- fsleep(hub->pdata->reset_us);
-
hub->dev = dev;
mutex_init(&hub->lock);
INIT_LIST_HEAD(&hub->udev_list);
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] usb: misc: onboard_usb_hub: Remove duplicated power_on delay
2022-07-28 6:49 [PATCH 1/1] usb: misc: onboard_usb_hub: Remove duplicated power_on delay Alexander Stein
@ 2022-07-28 14:00 ` Matthias Kaehlcke
0 siblings, 0 replies; 2+ messages in thread
From: Matthias Kaehlcke @ 2022-07-28 14:00 UTC (permalink / raw)
To: Alexander Stein; +Cc: Greg Kroah-Hartman, linux-usb
On Thu, Jul 28, 2022 at 08:49:37AM +0200, Alexander Stein wrote:
> onboard_hub_power_on() already ensures the reset pulse width delay, so
> there is no need to wait right after requesting GPIO as well.
>
> Fixes: 40758e493f4d ("usb: misc: onboard_usb_hub: Add reset-gpio support")
That shouldn't be needed, since it's not an actual bug.
Anyway, I see Greg already landed it.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-28 14:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-28 6:49 [PATCH 1/1] usb: misc: onboard_usb_hub: Remove duplicated power_on delay Alexander Stein
2022-07-28 14:00 ` Matthias Kaehlcke
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.