* [net PATCH] octeontx2-pf: Reduce minimum mtu size to 60
@ 2022-07-28 12:38 Naveen Mamindlapalli
2022-07-28 21:57 ` Andrew Lunn
0 siblings, 1 reply; 3+ messages in thread
From: Naveen Mamindlapalli @ 2022-07-28 12:38 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni, netdev, linux-kernel, sgoutham
Cc: Subbaraya Sundeep
From: Subbaraya Sundeep <sbhatta@marvell.com>
PTP messages like SYNC, FOLLOW_UP, DELAY_REQ are of size 58 bytes.
Using a minimum packet length as 64 makes NIX to pad 6 bytes of
zeroes while transmission. This is causing latest ptp4l application to
emit errors since length in PTP header and received packet are not same.
Padding upto 3 bytes is fine but more than that makes ptp4l to assume
the pad bytes as a TLV. Hence reduce the size to 60 from 64.
Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com>
Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>
---
drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.h b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.h
index c88e8a436029..fbe62bbfb789 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.h
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.h
@@ -21,7 +21,7 @@
#define OTX2_HEAD_ROOM OTX2_ALIGN
#define OTX2_ETH_HLEN (VLAN_ETH_HLEN + VLAN_HLEN)
-#define OTX2_MIN_MTU 64
+#define OTX2_MIN_MTU 60
#define OTX2_MAX_GSO_SEGS 255
#define OTX2_MAX_FRAGS_IN_SQE 9
--
2.16.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [net PATCH] octeontx2-pf: Reduce minimum mtu size to 60
2022-07-28 12:38 [net PATCH] octeontx2-pf: Reduce minimum mtu size to 60 Naveen Mamindlapalli
@ 2022-07-28 21:57 ` Andrew Lunn
2022-07-29 9:33 ` Subbaraya Sundeep Bhatta
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Lunn @ 2022-07-28 21:57 UTC (permalink / raw)
To: Naveen Mamindlapalli
Cc: davem, edumazet, kuba, pabeni, netdev, linux-kernel, sgoutham,
Subbaraya Sundeep
On Thu, Jul 28, 2022 at 06:08:12PM +0530, Naveen Mamindlapalli wrote:
> From: Subbaraya Sundeep <sbhatta@marvell.com>
>
> PTP messages like SYNC, FOLLOW_UP, DELAY_REQ are of size 58 bytes.
> Using a minimum packet length as 64 makes NIX to pad 6 bytes of
> zeroes while transmission. This is causing latest ptp4l application to
> emit errors since length in PTP header and received packet are not same.
> Padding upto 3 bytes is fine but more than that makes ptp4l to assume
> the pad bytes as a TLV. Hence reduce the size to 60 from 64.
Please Cc: the PTP maintainer for changes like this.
I also don't follow your explanation. At least for the original 802.3,
you had to pad packets shorter than 64 bytes, otherwise CSMA/CD did
not work. So i would expect PTP messages should be padded to 64?
Or is you hardware doing the padding wrong, and this is a workaround
for that bug?
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [net PATCH] octeontx2-pf: Reduce minimum mtu size to 60
2022-07-28 21:57 ` Andrew Lunn
@ 2022-07-29 9:33 ` Subbaraya Sundeep Bhatta
0 siblings, 0 replies; 3+ messages in thread
From: Subbaraya Sundeep Bhatta @ 2022-07-29 9:33 UTC (permalink / raw)
To: Andrew Lunn, Naveen Mamindlapalli, richardcochran
Cc: davem, edumazet, kuba, pabeni, netdev, linux-kernel,
Sunil Kovvuri Goutham
Hi Andrew,
Added PTP maintainer also in v2. We fixed this to work with latest ptp4l since after debugging we found
ptp4l complains bad message for Sync packets.
Lets hear from Richard.
Thanks,
Sundeep
________________________________________
From: Andrew Lunn <andrew@lunn.ch>
Sent: Friday, July 29, 2022 3:27 AM
To: Naveen Mamindlapalli
Cc: davem@davemloft.net; edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Sunil Kovvuri Goutham; Subbaraya Sundeep Bhatta
Re: [net PATCH] octeontx2-pf: Reduce minimum mtu size to 60
----------------------------------------------------------------------
On Thu, Jul 28, 2022 at 06:08:12PM +0530, Naveen Mamindlapalli wrote:
> From: Subbaraya Sundeep <sbhatta@marvell.com>
>
> PTP messages like SYNC, FOLLOW_UP, DELAY_REQ are of size 58 bytes.
> Using a minimum packet length as 64 makes NIX to pad 6 bytes of
> zeroes while transmission. This is causing latest ptp4l application to
> emit errors since length in PTP header and received packet are not same.
> Padding upto 3 bytes is fine but more than that makes ptp4l to assume
> the pad bytes as a TLV. Hence reduce the size to 60 from 64.
Please Cc: the PTP maintainer for changes like this.
I also don't follow your explanation. At least for the original 802.3,
you had to pad packets shorter than 64 bytes, otherwise CSMA/CD did
not work. So i would expect PTP messages should be padded to 64?
Or is you hardware doing the padding wrong, and this is a workaround
for that bug?
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-29 9:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-28 12:38 [net PATCH] octeontx2-pf: Reduce minimum mtu size to 60 Naveen Mamindlapalli
2022-07-28 21:57 ` Andrew Lunn
2022-07-29 9:33 ` Subbaraya Sundeep Bhatta
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.