* [PATCH] docs/about/removed-features: Move the -soundhw into the right section
@ 2022-08-02 7:56 Thomas Huth
2022-08-02 9:53 ` Daniel P. Berrangé
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Thomas Huth @ 2022-08-02 7:56 UTC (permalink / raw)
To: Paolo Bonzini, kraxel, qemu-devel; +Cc: qemu-trivial, Christian Schoenebeck
The note about the removal of '-soundhw' has been accidentally added
to the section of removed "linux-user mode CPUs" ... it should reside
in the section about removed "System emulator command line arguments"
instead.
Fixes: 039a68373c ("introduce -audio as a replacement for -soundhw")
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
docs/about/removed-features.rst | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.rst
index c7b9dadd5d..925e22016f 100644
--- a/docs/about/removed-features.rst
+++ b/docs/about/removed-features.rst
@@ -396,6 +396,13 @@ Use ``-display sdl`` instead.
Use ``-display curses`` instead.
+Creating sound card devices using ``-soundhw`` (removed in 7.1)
+'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
+
+Sound card devices should be created using ``-device`` or ``-audio``.
+The exception is ``pcspk`` which can be activated using ``-machine
+pcspk-audiodev=<name>``.
+
QEMU Machine Protocol (QMP) commands
------------------------------------
@@ -681,13 +688,6 @@ tripped up the CI testing and was suspected to be quite broken. For that
reason the maintainers strongly suspected no one actually used it.
-Creating sound card devices using ``-soundhw`` (removed in 7.1)
-'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
-
-Sound card devices should be created using ``-device`` or ``-audio``.
-The exception is ``pcspk`` which can be activated using ``-machine
-pcspk-audiodev=<name>``.
-
TCG introspection features
--------------------------
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] docs/about/removed-features: Move the -soundhw into the right section
2022-08-02 7:56 [PATCH] docs/about/removed-features: Move the -soundhw into the right section Thomas Huth
@ 2022-08-02 9:53 ` Daniel P. Berrangé
2022-08-02 11:34 ` Christian Schoenebeck
2022-08-04 11:47 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Daniel P. Berrangé @ 2022-08-02 9:53 UTC (permalink / raw)
To: Thomas Huth
Cc: Paolo Bonzini, kraxel, qemu-devel, qemu-trivial, Christian Schoenebeck
On Tue, Aug 02, 2022 at 09:56:11AM +0200, Thomas Huth wrote:
> The note about the removal of '-soundhw' has been accidentally added
> to the section of removed "linux-user mode CPUs" ... it should reside
> in the section about removed "System emulator command line arguments"
> instead.
>
> Fixes: 039a68373c ("introduce -audio as a replacement for -soundhw")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> docs/about/removed-features.rst | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] docs/about/removed-features: Move the -soundhw into the right section
2022-08-02 7:56 [PATCH] docs/about/removed-features: Move the -soundhw into the right section Thomas Huth
2022-08-02 9:53 ` Daniel P. Berrangé
@ 2022-08-02 11:34 ` Christian Schoenebeck
2022-08-04 11:47 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Christian Schoenebeck @ 2022-08-02 11:34 UTC (permalink / raw)
To: Paolo Bonzini, kraxel, qemu-devel; +Cc: qemu-trivial, Thomas Huth
On Dienstag, 2. August 2022 09:56:11 CEST Thomas Huth wrote:
> The note about the removal of '-soundhw' has been accidentally added
> to the section of removed "linux-user mode CPUs" ... it should reside
> in the section about removed "System emulator command line arguments"
> instead.
>
> Fixes: 039a68373c ("introduce -audio as a replacement for -soundhw")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
That can easily happen unfortunately, as the hierarchy syntax here, like in
MAINTAINERS BTW, is not exactly perfect for the human eye.
> docs/about/removed-features.rst | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/docs/about/removed-features.rst
> b/docs/about/removed-features.rst index c7b9dadd5d..925e22016f 100644
> --- a/docs/about/removed-features.rst
> +++ b/docs/about/removed-features.rst
> @@ -396,6 +396,13 @@ Use ``-display sdl`` instead.
>
> Use ``-display curses`` instead.
>
> +Creating sound card devices using ``-soundhw`` (removed in 7.1)
> +'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
> +
> +Sound card devices should be created using ``-device`` or ``-audio``.
> +The exception is ``pcspk`` which can be activated using ``-machine
> +pcspk-audiodev=<name>``.
> +
>
> QEMU Machine Protocol (QMP) commands
> ------------------------------------
> @@ -681,13 +688,6 @@ tripped up the CI testing and was suspected to be quite
> broken. For that reason the maintainers strongly suspected no one actually
> used it.
>
>
> -Creating sound card devices using ``-soundhw`` (removed in 7.1)
> -'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
> -
> -Sound card devices should be created using ``-device`` or ``-audio``.
> -The exception is ``pcspk`` which can be activated using ``-machine
> -pcspk-audiodev=<name>``.
> -
> TCG introspection features
> --------------------------
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] docs/about/removed-features: Move the -soundhw into the right section
2022-08-02 7:56 [PATCH] docs/about/removed-features: Move the -soundhw into the right section Thomas Huth
2022-08-02 9:53 ` Daniel P. Berrangé
2022-08-02 11:34 ` Christian Schoenebeck
@ 2022-08-04 11:47 ` Laurent Vivier
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2022-08-04 11:47 UTC (permalink / raw)
To: Thomas Huth, Paolo Bonzini, kraxel, qemu-devel
Cc: qemu-trivial, Christian Schoenebeck
Le 02/08/2022 à 09:56, Thomas Huth a écrit :
> The note about the removal of '-soundhw' has been accidentally added
> to the section of removed "linux-user mode CPUs" ... it should reside
> in the section about removed "System emulator command line arguments"
> instead.
>
> Fixes: 039a68373c ("introduce -audio as a replacement for -soundhw")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> docs/about/removed-features.rst | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/docs/about/removed-features.rst b/docs/about/removed-features.rst
> index c7b9dadd5d..925e22016f 100644
> --- a/docs/about/removed-features.rst
> +++ b/docs/about/removed-features.rst
> @@ -396,6 +396,13 @@ Use ``-display sdl`` instead.
>
> Use ``-display curses`` instead.
>
> +Creating sound card devices using ``-soundhw`` (removed in 7.1)
> +'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
> +
> +Sound card devices should be created using ``-device`` or ``-audio``.
> +The exception is ``pcspk`` which can be activated using ``-machine
> +pcspk-audiodev=<name>``.
> +
>
> QEMU Machine Protocol (QMP) commands
> ------------------------------------
> @@ -681,13 +688,6 @@ tripped up the CI testing and was suspected to be quite broken. For that
> reason the maintainers strongly suspected no one actually used it.
>
>
> -Creating sound card devices using ``-soundhw`` (removed in 7.1)
> -'''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''''
> -
> -Sound card devices should be created using ``-device`` or ``-audio``.
> -The exception is ``pcspk`` which can be activated using ``-machine
> -pcspk-audiodev=<name>``.
> -
> TCG introspection features
> --------------------------
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-04 11:51 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-02 7:56 [PATCH] docs/about/removed-features: Move the -soundhw into the right section Thomas Huth
2022-08-02 9:53 ` Daniel P. Berrangé
2022-08-02 11:34 ` Christian Schoenebeck
2022-08-04 11:47 ` Laurent Vivier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.