All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [git pull] vfs.git pile 3 - dcache
Date: Thu, 4 Aug 2022 01:42:25 +0100	[thread overview]
Message-ID: <YusV8cr382PeBNLM@casper.infradead.org> (raw)
In-Reply-To: <CAHk-=wh6VSqsnANHkQpw=yD-Hkt90Y1LX=ad9+r+SusfriUOfA@mail.gmail.com>

On Wed, Aug 03, 2022 at 04:42:43PM -0700, Linus Torvalds wrote:
> On Wed, Aug 3, 2022 at 4:24 PM Matthew Wilcox <willy@infradead.org> wrote:
> >
> > On Wed, Aug 03, 2022 at 06:59:36PM -0400, Steven Rostedt wrote:
> > >
> > >       preempt_disable_inlock() ?
> >
> > preempt_disable_locked()?
> 
> Heh. Shed painting in full glory.
> 
> Let's try just "preempt_enable_under_spinlock()" and see.
> 
> It's a bit long, but it's still shorter than the existing usage pattern.
> 
> And we don't have "inlock" anywhere else, and while "locked" is a real
> pattern we have, it tends to be about other things (ie "I hold the
> lock that you need, so don't take it").
> 
> And this is _explicitly_ only about spinning locks, because sleeping
> locks don't do the preemption disable even without RT.
> 
> So let's make it verbose and clear and unambiguous. It's not like I
> expect to see a _lot_ of those. Knock wood.

Should we have it take a spinlock_t pointer?  We could have lockdep
check it is actually held.

  reply	other threads:[~2022-08-04  0:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-03 18:39 [git pull] vfs.git pile 3 - dcache Al Viro
2022-08-03 18:57 ` Linus Torvalds
2022-08-03 19:49   ` Al Viro
2022-08-03 21:54   ` Steven Rostedt
2022-08-03 22:09     ` Linus Torvalds
2022-08-03 22:59       ` Steven Rostedt
2022-08-03 23:24         ` Matthew Wilcox
2022-08-03 23:42           ` Linus Torvalds
2022-08-04  0:42             ` Matthew Wilcox [this message]
2022-08-04  1:32               ` Steven Rostedt
2022-08-04  2:16                 ` Linus Torvalds
2022-08-04 10:52                   ` Steven Rostedt
2022-08-08 22:06             ` Thomas Gleixner
2022-08-08 22:43               ` Linus Torvalds
2022-08-09 16:00                 ` Thomas Gleixner
2022-08-09 16:15                   ` Matthew Wilcox
2022-08-09 17:58                     ` Thomas Gleixner
2022-08-03 19:00 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YusV8cr382PeBNLM@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=bigeasy@linutronix.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.