* [PATCH stable 4.14 0/1] Backport "printk: Export is_console_locked"
@ 2022-08-04 7:00 Chen Jun
2022-08-04 7:00 ` [PATCH stable 4.14 1/1] printk: Export is_console_locked Chen Jun
0 siblings, 1 reply; 3+ messages in thread
From: Chen Jun @ 2022-08-04 7:00 UTC (permalink / raw)
To: stable, gregkh; +Cc: xuqiang36
https://lore.kernel.org/stable/20220729031140.21806-1-chenjun102@huawei.com/
will make build failed if CONFIG_FB = M.
The error is:
ERROR: "is_console_locked" [drivers/video/fbdev/core/fb.ko] undefined!
To fix it, backport d48de54a9dab ("printk: Export is_console_locked").
Hans de Goede (1):
printk: Export is_console_locked
kernel/printk/printk.c | 1 +
1 file changed, 1 insertion(+)
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH stable 4.14 1/1] printk: Export is_console_locked
2022-08-04 7:00 [PATCH stable 4.14 0/1] Backport "printk: Export is_console_locked" Chen Jun
@ 2022-08-04 7:00 ` Chen Jun
2022-08-04 8:20 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Chen Jun @ 2022-08-04 7:00 UTC (permalink / raw)
To: stable, gregkh; +Cc: xuqiang36
From: Hans de Goede <hdegoede@redhat.com>
commit d48de54a9dab5370edd2e991f78cc7996cf5483e upstream
This is a preparation patch for adding a number of WARN_CONSOLE_UNLOCKED()
calls to the fbcon code, which may be built as a module (event though
usually it is not).
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Acked-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Acked-by: Petr Mladek <pmladek@suse.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Chen Jun <chenjun102@huawei.com>
---
kernel/printk/printk.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
index 11173d0b51bc..ad4772869d48 100644
--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -2259,6 +2259,7 @@ int is_console_locked(void)
{
return console_locked;
}
+EXPORT_SYMBOL(is_console_locked);
/*
* Check if we have any console that is capable of printing while cpu is
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH stable 4.14 1/1] printk: Export is_console_locked
2022-08-04 7:00 ` [PATCH stable 4.14 1/1] printk: Export is_console_locked Chen Jun
@ 2022-08-04 8:20 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2022-08-04 8:20 UTC (permalink / raw)
To: Chen Jun; +Cc: stable, xuqiang36
On Thu, Aug 04, 2022 at 07:00:25AM +0000, Chen Jun wrote:
> From: Hans de Goede <hdegoede@redhat.com>
>
> commit d48de54a9dab5370edd2e991f78cc7996cf5483e upstream
>
> This is a preparation patch for adding a number of WARN_CONSOLE_UNLOCKED()
> calls to the fbcon code, which may be built as a module (event though
> usually it is not).
>
> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> Acked-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Acked-by: Petr Mladek <pmladek@suse.com>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Signed-off-by: Chen Jun <chenjun102@huawei.com>
> ---
> kernel/printk/printk.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
> index 11173d0b51bc..ad4772869d48 100644
> --- a/kernel/printk/printk.c
> +++ b/kernel/printk/printk.c
> @@ -2259,6 +2259,7 @@ int is_console_locked(void)
> {
> return console_locked;
> }
> +EXPORT_SYMBOL(is_console_locked);
>
> /*
> * Check if we have any console that is capable of printing while cpu is
> --
> 2.17.1
>
This patch makes no sense on it's own, please make it part of a larger
series that requires it.
Also, for some reason you didn't cc: all of the people involved in the
change, which is a bit odd.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-04 8:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-04 7:00 [PATCH stable 4.14 0/1] Backport "printk: Export is_console_locked" Chen Jun
2022-08-04 7:00 ` [PATCH stable 4.14 1/1] printk: Export is_console_locked Chen Jun
2022-08-04 8:20 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.