From: Arnaldo Carvalho de Melo <acme@kernel.org> To: Ian Rogers <irogers@google.com> Cc: John Garry <john.garry@huawei.com>, Will Deacon <will@kernel.org>, James Clark <james.clark@arm.com>, Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linaro.org>, Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, Mark Rutland <mark.rutland@arm.com>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>, Andi Kleen <ak@linux.intel.com>, Zhengjun Xing <zhengjun.xing@linux.intel.com>, Ravi Bangoria <ravi.bangoria@amd.com>, Kan Liang <kan.liang@linux.intel.com>, Adrian Hunter <adrian.hunter@intel.com>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, Stephane Eranian <eranian@google.com> Subject: Re: [PATCH v4 01/17] perf jevents: Clean up pytype warnings Date: Tue, 9 Aug 2022 16:36:57 -0300 [thread overview] Message-ID: <YvK3WZ5UVrlW1mwe@kernel.org> (raw) In-Reply-To: <20220804221816.1802790-2-irogers@google.com> Em Thu, Aug 04, 2022 at 03:18:00PM -0700, Ian Rogers escreveu: > Improve type hints to clean up pytype warnings. Thanks, applied. - Arnaldo > Signed-off-by: Ian Rogers <irogers@google.com> > --- > tools/perf/pmu-events/jevents.py | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/tools/perf/pmu-events/jevents.py b/tools/perf/pmu-events/jevents.py > index 83e0dcbeac9a..5b72048d50da 100755 > --- a/tools/perf/pmu-events/jevents.py > +++ b/tools/perf/pmu-events/jevents.py > @@ -6,8 +6,7 @@ import csv > import json > import os > import sys > -from typing import Callable > -from typing import Sequence > +from typing import (Callable, Optional, Sequence) > > # Global command line arguments. > _args = None > @@ -57,7 +56,7 @@ class JsonEvent: > '. '), '.').replace('\n', '\\n').replace( > '\"', '\\"').replace('\r', '\\r') > > - def convert_aggr_mode(aggr_mode: str) -> str: > + def convert_aggr_mode(aggr_mode: str) -> Optional[str]: > """Returns the aggr_mode_class enum value associated with the JSON string.""" > if not aggr_mode: > return None > @@ -67,7 +66,7 @@ class JsonEvent: > } > return aggr_mode_to_enum[aggr_mode] > > - def lookup_msr(num: str) -> str: > + def lookup_msr(num: str) -> Optional[str]: > """Converts the msr number, or first in a list to the appropriate event field.""" > if not num: > return None > @@ -79,7 +78,7 @@ class JsonEvent: > } > return msrmap[int(num.split(',', 1)[0], 0)] > > - def real_event(name: str, event: str) -> str: > + def real_event(name: str, event: str) -> Optional[str]: > """Convert well known event names to an event string otherwise use the event argument.""" > fixed = { > 'inst_retired.any': 'event=0xc0,period=2000003', > @@ -95,7 +94,7 @@ class JsonEvent: > return fixed[name.lower()] > return event > > - def unit_to_pmu(unit: str) -> str: > + def unit_to_pmu(unit: str) -> Optional[str]: > """Convert a JSON Unit to Linux PMU name.""" > if not unit: > return None > @@ -154,7 +153,7 @@ class JsonEvent: > if self.metric_expr: > self.metric_expr = self.metric_expr.replace('\\', '\\\\') > arch_std = jd.get('ArchStdEvent') > - if precise and self.desc and not '(Precise Event)' in self.desc: > + if precise and self.desc and '(Precise Event)' not in self.desc: > extra_desc += ' (Must be precise)' if precise == '2' else (' (Precise ' > 'event)') > event = f'config={llx(configcode)}' if configcode is not None else f'event={llx(eventcode)}' > -- > 2.37.1.559.g78731f0fdb-goog -- - Arnaldo
WARNING: multiple messages have this Message-ID (diff)
From: Arnaldo Carvalho de Melo <acme@kernel.org> To: Ian Rogers <irogers@google.com> Cc: John Garry <john.garry@huawei.com>, Will Deacon <will@kernel.org>, James Clark <james.clark@arm.com>, Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linaro.org>, Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, Mark Rutland <mark.rutland@arm.com>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>, Andi Kleen <ak@linux.intel.com>, Zhengjun Xing <zhengjun.xing@linux.intel.com>, Ravi Bangoria <ravi.bangoria@amd.com>, Kan Liang <kan.liang@linux.intel.com>, Adrian Hunter <adrian.hunter@intel.com>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, Stephane Eranian <eranian@google.com> Subject: Re: [PATCH v4 01/17] perf jevents: Clean up pytype warnings Date: Tue, 9 Aug 2022 16:36:57 -0300 [thread overview] Message-ID: <YvK3WZ5UVrlW1mwe@kernel.org> (raw) In-Reply-To: <20220804221816.1802790-2-irogers@google.com> Em Thu, Aug 04, 2022 at 03:18:00PM -0700, Ian Rogers escreveu: > Improve type hints to clean up pytype warnings. Thanks, applied. - Arnaldo > Signed-off-by: Ian Rogers <irogers@google.com> > --- > tools/perf/pmu-events/jevents.py | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/tools/perf/pmu-events/jevents.py b/tools/perf/pmu-events/jevents.py > index 83e0dcbeac9a..5b72048d50da 100755 > --- a/tools/perf/pmu-events/jevents.py > +++ b/tools/perf/pmu-events/jevents.py > @@ -6,8 +6,7 @@ import csv > import json > import os > import sys > -from typing import Callable > -from typing import Sequence > +from typing import (Callable, Optional, Sequence) > > # Global command line arguments. > _args = None > @@ -57,7 +56,7 @@ class JsonEvent: > '. '), '.').replace('\n', '\\n').replace( > '\"', '\\"').replace('\r', '\\r') > > - def convert_aggr_mode(aggr_mode: str) -> str: > + def convert_aggr_mode(aggr_mode: str) -> Optional[str]: > """Returns the aggr_mode_class enum value associated with the JSON string.""" > if not aggr_mode: > return None > @@ -67,7 +66,7 @@ class JsonEvent: > } > return aggr_mode_to_enum[aggr_mode] > > - def lookup_msr(num: str) -> str: > + def lookup_msr(num: str) -> Optional[str]: > """Converts the msr number, or first in a list to the appropriate event field.""" > if not num: > return None > @@ -79,7 +78,7 @@ class JsonEvent: > } > return msrmap[int(num.split(',', 1)[0], 0)] > > - def real_event(name: str, event: str) -> str: > + def real_event(name: str, event: str) -> Optional[str]: > """Convert well known event names to an event string otherwise use the event argument.""" > fixed = { > 'inst_retired.any': 'event=0xc0,period=2000003', > @@ -95,7 +94,7 @@ class JsonEvent: > return fixed[name.lower()] > return event > > - def unit_to_pmu(unit: str) -> str: > + def unit_to_pmu(unit: str) -> Optional[str]: > """Convert a JSON Unit to Linux PMU name.""" > if not unit: > return None > @@ -154,7 +153,7 @@ class JsonEvent: > if self.metric_expr: > self.metric_expr = self.metric_expr.replace('\\', '\\\\') > arch_std = jd.get('ArchStdEvent') > - if precise and self.desc and not '(Precise Event)' in self.desc: > + if precise and self.desc and '(Precise Event)' not in self.desc: > extra_desc += ' (Must be precise)' if precise == '2' else (' (Precise ' > 'event)') > event = f'config={llx(configcode)}' if configcode is not None else f'event={llx(eventcode)}' > -- > 2.37.1.559.g78731f0fdb-goog -- - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-09 19:37 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-08-04 22:17 [PATCH v4 00/17] Compress the pmu_event tables Ian Rogers 2022-08-04 22:17 ` Ian Rogers 2022-08-04 22:18 ` [PATCH v4 01/17] perf jevents: Clean up pytype warnings Ian Rogers 2022-08-04 22:18 ` Ian Rogers 2022-08-09 19:36 ` Arnaldo Carvalho de Melo [this message] 2022-08-09 19:36 ` Arnaldo Carvalho de Melo 2022-08-04 22:18 ` [PATCH v4 02/17] perf jevents: Simplify generation of C-string Ian Rogers 2022-08-04 22:18 ` Ian Rogers 2022-08-09 19:37 ` Arnaldo Carvalho de Melo 2022-08-09 19:37 ` Arnaldo Carvalho de Melo 2022-08-04 22:18 ` [PATCH v4 03/17] perf jevents: Add JEVENTS_ARCH make option Ian Rogers 2022-08-04 22:18 ` Ian Rogers 2022-08-05 9:55 ` John Garry 2022-08-05 9:55 ` John Garry 2022-08-09 19:38 ` Arnaldo Carvalho de Melo 2022-08-09 19:38 ` Arnaldo Carvalho de Melo 2022-08-04 22:18 ` [PATCH v4 04/17] perf jevent: Add an 'all' architecture argument Ian Rogers 2022-08-04 22:18 ` Ian Rogers 2022-08-05 10:34 ` John Garry 2022-08-05 10:34 ` John Garry 2022-08-04 22:18 ` [PATCH v4 05/17] perf jevents: Remove the type/version variables Ian Rogers 2022-08-04 22:18 ` Ian Rogers 2022-08-05 10:35 ` John Garry 2022-08-05 10:35 ` John Garry 2022-08-04 22:18 ` [PATCH v4 06/17] perf jevents: Provide path to json file on error Ian Rogers 2022-08-04 22:18 ` Ian Rogers 2022-08-04 22:18 ` [PATCH v4 07/17] perf jevents: Sort json files entries Ian Rogers 2022-08-04 22:18 ` Ian Rogers 2022-08-05 10:49 ` John Garry 2022-08-05 10:49 ` John Garry 2022-08-10 14:23 ` Ian Rogers 2022-08-10 14:23 ` Ian Rogers 2022-08-10 15:53 ` John Garry 2022-08-10 15:53 ` John Garry 2022-08-04 22:18 ` [PATCH v4 08/17] perf pmu-events: Hide pmu_sys_event_tables Ian Rogers 2022-08-04 22:18 ` Ian Rogers 2022-08-05 11:15 ` John Garry 2022-08-05 11:15 ` John Garry 2022-08-10 14:25 ` Ian Rogers 2022-08-10 14:25 ` Ian Rogers 2022-08-04 22:18 ` [PATCH v4 09/17] perf pmu-events: Avoid passing pmu_events_map Ian Rogers 2022-08-04 22:18 ` Ian Rogers 2022-08-05 11:28 ` John Garry 2022-08-05 11:28 ` John Garry 2022-08-10 15:23 ` Ian Rogers 2022-08-10 15:23 ` Ian Rogers 2022-08-04 22:18 ` [PATCH v4 10/17] perf pmu-events: Hide pmu_events_map Ian Rogers 2022-08-04 22:18 ` Ian Rogers 2022-08-05 12:31 ` John Garry 2022-08-05 12:31 ` John Garry 2022-08-10 14:29 ` Ian Rogers 2022-08-10 14:29 ` Ian Rogers 2022-08-11 14:47 ` John Garry 2022-08-11 14:47 ` John Garry 2022-08-04 22:18 ` [PATCH v4 11/17] perf test: Use full metric resolution Ian Rogers 2022-08-04 22:18 ` Ian Rogers 2022-08-04 22:18 ` [PATCH v4 12/17] perf pmu-events: Move test events/metrics to json Ian Rogers 2022-08-04 22:18 ` Ian Rogers 2022-08-05 12:34 ` John Garry 2022-08-05 12:34 ` John Garry 2022-08-04 22:18 ` [PATCH v4 13/17] perf pmu-events: Don't assume pmu_event is an array Ian Rogers 2022-08-04 22:18 ` Ian Rogers 2022-08-05 12:56 ` John Garry 2022-08-05 12:56 ` John Garry 2022-08-04 22:18 ` [PATCH v4 14/17] perf pmu-events: Hide the pmu_events Ian Rogers 2022-08-04 22:18 ` Ian Rogers 2022-08-04 22:18 ` [PATCH v4 15/17] perf metrics: Copy entire pmu_event in find metric Ian Rogers 2022-08-04 22:18 ` Ian Rogers 2022-08-04 22:18 ` [PATCH v4 16/17] perf jevents: Compress the pmu_events_table Ian Rogers 2022-08-04 22:18 ` Ian Rogers 2022-08-05 14:02 ` John Garry 2022-08-05 14:02 ` John Garry 2022-08-10 14:35 ` Ian Rogers 2022-08-10 14:35 ` Ian Rogers 2022-08-04 22:18 ` [PATCH v4 17/17] perf jevents: Fold strings optimization Ian Rogers 2022-08-04 22:18 ` Ian Rogers 2022-08-09 19:40 ` [PATCH v4 00/17] Compress the pmu_event tables Arnaldo Carvalho de Melo 2022-08-09 19:40 ` Arnaldo Carvalho de Melo 2022-08-09 19:41 ` Arnaldo Carvalho de Melo 2022-08-09 19:41 ` Arnaldo Carvalho de Melo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YvK3WZ5UVrlW1mwe@kernel.org \ --to=acme@kernel.org \ --cc=adrian.hunter@intel.com \ --cc=ak@linux.intel.com \ --cc=alexander.shishkin@linux.intel.com \ --cc=eranian@google.com \ --cc=irogers@google.com \ --cc=james.clark@arm.com \ --cc=john.garry@huawei.com \ --cc=jolsa@kernel.org \ --cc=kan.liang@linux.intel.com \ --cc=leo.yan@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-perf-users@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mike.leach@linaro.org \ --cc=mingo@redhat.com \ --cc=namhyung@kernel.org \ --cc=peterz@infradead.org \ --cc=ravi.bangoria@amd.com \ --cc=will@kernel.org \ --cc=zhengjun.xing@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.