[PATCH] selftests: add missing ')' in lib.mk

[PATCH] selftests: add missing ')' in lib.mk

[Guillaume Tucker]

Add missing closing ')' in lib.mk in a call to $error().  This only
affects LLVM / Clang builds.

Fixes: 795285ef2425 ("selftests: Fix clang cross compilation")
Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
---
 tools/testing/selftests/lib.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
index 947fc72413e9..a87f60873e5b 100644
--- a/tools/testing/selftests/lib.mk
+++ b/tools/testing/selftests/lib.mk
@@ -20,7 +20,7 @@ CLANG_TARGET_FLAGS              := $(CLANG_TARGET_FLAGS_$(ARCH))
 
 ifeq ($(CROSS_COMPILE),)
 ifeq ($(CLANG_TARGET_FLAGS),)
-$(error Specify CROSS_COMPILE or add '--target=' option to lib.mk
+$(error Specify CROSS_COMPILE or add '--target=' option to lib.mk)
 else
 CLANG_FLAGS     += --target=$(CLANG_TARGET_FLAGS)
 endif # CLANG_TARGET_FLAGS
-- 
2.30.2

Re: [PATCH] selftests: add missing ')' in lib.mk

[Nathan Chancellor]

On Tue, Aug 09, 2022 at 03:20:46PM +0200, Guillaume Tucker wrote:
> Add missing closing ')' in lib.mk in a call to $error().  This only
> affects LLVM / Clang builds.
> 
> Fixes: 795285ef2425 ("selftests: Fix clang cross compilation")
> Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>

Reviewed-by: Nathan Chancellor <nathan@kernel.org>

> ---
>  tools/testing/selftests/lib.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk
> index 947fc72413e9..a87f60873e5b 100644
> --- a/tools/testing/selftests/lib.mk
> +++ b/tools/testing/selftests/lib.mk
> @@ -20,7 +20,7 @@ CLANG_TARGET_FLAGS              := $(CLANG_TARGET_FLAGS_$(ARCH))
>  
>  ifeq ($(CROSS_COMPILE),)
>  ifeq ($(CLANG_TARGET_FLAGS),)
> -$(error Specify CROSS_COMPILE or add '--target=' option to lib.mk
> +$(error Specify CROSS_COMPILE or add '--target=' option to lib.mk)
>  else
>  CLANG_FLAGS     += --target=$(CLANG_TARGET_FLAGS)
>  endif # CLANG_TARGET_FLAGS
> -- 
> 2.30.2
> 

Re: [PATCH] selftests: add missing ')' in lib.mk

[Guillaume Tucker]

On 09/08/2022 18:36, Nathan Chancellor wrote:
> On Tue, Aug 09, 2022 at 03:20:46PM +0200, Guillaume Tucker wrote:
>> Add missing closing ')' in lib.mk in a call to $error().  This only
>> affects LLVM / Clang builds.
>>
>> Fixes: 795285ef2425 ("selftests: Fix clang cross compilation")
>> Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
> 
> Reviewed-by: Nathan Chancellor <nathan@kernel.org>

Ha, I see Mark just came up with the same fix many months later :)
Shame this wasn't applied back then, for some reason...

Guillaume

Re: [PATCH] selftests: add missing ')' in lib.mk

[Shuah Khan]

On 2/3/23 08:40, Guillaume Tucker wrote:
> On 09/08/2022 18:36, Nathan Chancellor wrote:
>> On Tue, Aug 09, 2022 at 03:20:46PM +0200, Guillaume Tucker wrote:
>>> Add missing closing ')' in lib.mk in a call to $error().  This only
>>> affects LLVM / Clang builds.
>>>
>>> Fixes: 795285ef2425 ("selftests: Fix clang cross compilation")
>>> Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
>>
>> Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> 
> Ha, I see Mark just came up with the same fix many months later :)
> Shame this wasn't applied back then, for some reason...
> 

It might have gotten lost in my Inbox (looking at the dates - must have
been while I was away on vacation). Sorry about that.

It is fixed now.

thanks,
-- Shuah