* [PATCH v2 0/6] i2c: Make remove callback return void
@ 2022-08-15 8:02 ` Uwe Kleine-König
0 siblings, 0 replies; 22+ messages in thread
From: Uwe Kleine-König @ 2022-08-15 8:02 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-i2c, kernel, David Airlie, Daniel Vetter, dri-devel,
Pavel Machek, linux-leds, Bartosz Golaszewski, Sekhar Nori,
Andy Shevchenko, Matt Johnston, Peter Senna Tschudin,
Benjamin Mugnier, Crt Mori, Jeremy Kerr,
Javier Martinez Canillas, Christophe Leroy, Greg Kroah-Hartman,
Marek Behún, Petr Machata, Andrey Ryabinin, Maximilian Luz,
Srinivas Pandruvada, Hans Verkuil, Miguel Ojeda, Luca Ceresoli,
Luca Ceresoli, Heikki Krogerus, Ajay Gupta, Jonathan Cameron,
Peter Rosin, Adrien Grassein, Jean Delvare, Corey Minyard,
Vladimir Oltean, Dmitry Torokhov, Sebastian Reichel,
Krzysztof Hałasa
Hello,
as promised there comes the series that does
- int (*remove)(struct i2c_client *client);
+ void (*remove)(struct i2c_client *client);
in struct i2c_driver. Returning an error code has no (relevant) effect,
as in the Linux device model removal cannot be stopped. So the
possibility to return a value is prone to trouble because driver authors
might assume it does stop the process and .remove is called again at a
later point again. A few errors like these were fixed preparing this
change. See commit bbc126ae381c ("usb: typec: tcpci: Don't skip cleanup
in .remove() on error") for an example.
To prevent such errors in the future, .remove() is changed to return
void which leaves no doubt about its semantics.
This series is build-tested on arm64, m68k, powerpc, riscv, s390, sparc64 and
x86_64 using allmodconfig.
As some conflicts are expected I sent this early after -rc1 such that it
can be included early into next and be put on an immutable branch for
subsystems to resolve merge conflicts.
The first 5 patches in this series are preparatory work with the goal
that the final patch just drops "return 0" (or changes them to a plain
"return"). The three led patches got an Ack by Pavel (= led maintainer),
the other two didn't get final maintainer feedback. See
https://lore.kernel.org/dri-devel/20220526202538.1723142-1-u.kleine-koenig@pengutronix.de
https://lore.kernel.org/linux-gpio/20220502170555.51183-1-u.kleine-koenig@pengutronix.de
for the "discussions" about these two.
The changes since the first submission were already summarized in
https://lore.kernel.org/r/20220811124029.usxahk5nvfgqsm42@pengutronix.de
in detail, the only change since then is that the changes to
drivers/input/keyboard/adp5588-keys.c were merged, so additionally to
the changes described before, the change to that driver was adapted
accordingly. To summarize it's just:
- The preparing patches (#1 - #5) are unchanged
- Remove a comment form drivers/net/mctp/mctp-i2c.c that doesn't match
any more in #6. (Noticed by Matt Johnston and independently by Jeremy Kerr)
- Removed a stray change to lib/Kconfig.kasan that I needed for build
testing but that wasn't ment to be included; also in patch #6.
(Noticed by Andrey Ryabinin).
- Rebase v5.19-rc4 -> 6.0-rc1 and adapt for dropped and new drivers.
The patches are also available at
https://git.pengutronix.de/git/ukl/linux i2c-remove-void
Thanks
Uwe
Uwe Kleine-König (6):
drm/i2c/sil164: Drop no-op remove function
leds: lm3697: Remove duplicated error reporting in .remove()
leds: lm3601x: Don't use mutex after it was destroyed
leds: lm3601x: Improve error reporting for problems during .remove()
gpio: pca953x: Make platform teardown callback return void
i2c: Make remove callback return void
Documentation/i2c/writing-clients.rst | 2 +-
arch/arm/mach-davinci/board-da850-evm.c | 12 ++++--------
arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c | 3 +--
drivers/auxdisplay/ht16k33.c | 4 +---
drivers/auxdisplay/lcd2s.c | 3 +--
drivers/char/ipmi/ipmb_dev_int.c | 4 +---
drivers/char/ipmi/ipmi_ipmb.c | 4 +---
drivers/char/ipmi/ipmi_ssif.c | 6 ++----
drivers/char/tpm/st33zp24/i2c.c | 4 +---
drivers/char/tpm/tpm_i2c_atmel.c | 3 +--
drivers/char/tpm/tpm_i2c_infineon.c | 4 +---
drivers/char/tpm/tpm_i2c_nuvoton.c | 3 +--
drivers/char/tpm/tpm_tis_i2c.c | 3 +--
drivers/char/tpm/tpm_tis_i2c_cr50.c | 6 ++----
drivers/clk/clk-cdce706.c | 3 +--
drivers/clk/clk-cs2000-cp.c | 4 +---
drivers/clk/clk-si514.c | 3 +--
drivers/clk/clk-si5341.c | 4 +---
drivers/clk/clk-si5351.c | 4 +---
drivers/clk/clk-si570.c | 3 +--
drivers/clk/clk-versaclock5.c | 4 +---
drivers/crypto/atmel-ecc.c | 6 ++----
drivers/crypto/atmel-sha204a.c | 6 ++----
drivers/extcon/extcon-rt8973a.c | 4 +---
drivers/gpio/gpio-adp5588.c | 4 +---
drivers/gpio/gpio-max7300.c | 4 +---
drivers/gpio/gpio-pca953x.c | 13 +++----------
drivers/gpio/gpio-pcf857x.c | 4 +---
drivers/gpio/gpio-tpic2810.c | 4 +---
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 4 +---
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 4 +---
drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 4 +---
drivers/gpu/drm/bridge/analogix/anx7625.c | 4 +---
drivers/gpu/drm/bridge/chrontel-ch7033.c | 4 +---
drivers/gpu/drm/bridge/cros-ec-anx7688.c | 4 +---
drivers/gpu/drm/bridge/ite-it6505.c | 4 +---
drivers/gpu/drm/bridge/ite-it66121.c | 4 +---
drivers/gpu/drm/bridge/lontium-lt8912b.c | 3 +--
drivers/gpu/drm/bridge/lontium-lt9211.c | 4 +---
drivers/gpu/drm/bridge/lontium-lt9611.c | 4 +---
drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 4 +---
.../drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c | 8 ++------
drivers/gpu/drm/bridge/nxp-ptn3460.c | 4 +---
drivers/gpu/drm/bridge/parade-ps8622.c | 4 +---
drivers/gpu/drm/bridge/sii902x.c | 4 +---
drivers/gpu/drm/bridge/sii9234.c | 4 +---
drivers/gpu/drm/bridge/sil-sii8620.c | 4 +---
drivers/gpu/drm/bridge/tc358767.c | 4 +---
drivers/gpu/drm/bridge/tc358768.c | 4 +---
drivers/gpu/drm/bridge/tc358775.c | 4 +---
drivers/gpu/drm/bridge/ti-dlpc3433.c | 4 +---
drivers/gpu/drm/bridge/ti-sn65dsi83.c | 4 +---
drivers/gpu/drm/bridge/ti-tfp410.c | 4 +---
drivers/gpu/drm/i2c/ch7006_drv.c | 4 +---
drivers/gpu/drm/i2c/sil164_drv.c | 7 -------
drivers/gpu/drm/i2c/tda9950.c | 4 +---
drivers/gpu/drm/i2c/tda998x_drv.c | 3 +--
drivers/gpu/drm/panel/panel-olimex-lcd-olinuxino.c | 4 +---
.../gpu/drm/panel/panel-raspberrypi-touchscreen.c | 4 +---
drivers/gpu/drm/solomon/ssd130x-i2c.c | 4 +---
drivers/hid/i2c-hid/i2c-hid-core.c | 4 +---
drivers/hid/i2c-hid/i2c-hid.h | 2 +-
drivers/hwmon/adc128d818.c | 4 +---
drivers/hwmon/adt7470.c | 3 +--
drivers/hwmon/asb100.c | 6 ++----
drivers/hwmon/asc7621.c | 4 +---
drivers/hwmon/dme1737.c | 4 +---
drivers/hwmon/f75375s.c | 5 ++---
drivers/hwmon/fschmd.c | 6 ++----
drivers/hwmon/ftsteutates.c | 3 +--
drivers/hwmon/ina209.c | 4 +---
drivers/hwmon/ina3221.c | 4 +---
drivers/hwmon/jc42.c | 3 +--
drivers/hwmon/occ/p8_i2c.c | 4 +---
drivers/hwmon/pcf8591.c | 3 +--
drivers/hwmon/smm665.c | 3 +--
drivers/hwmon/tps23861.c | 4 +---
drivers/hwmon/w83781d.c | 4 +---
drivers/hwmon/w83791d.c | 6 ++----
drivers/hwmon/w83792d.c | 6 ++----
drivers/hwmon/w83793.c | 6 ++----
drivers/hwmon/w83795.c | 4 +---
drivers/hwmon/w83l785ts.c | 6 ++----
drivers/i2c/i2c-core-base.c | 6 +-----
drivers/i2c/i2c-slave-eeprom.c | 4 +---
drivers/i2c/i2c-slave-testunit.c | 3 +--
drivers/i2c/i2c-smbus.c | 3 +--
drivers/i2c/muxes/i2c-mux-ltc4306.c | 4 +---
drivers/i2c/muxes/i2c-mux-pca9541.c | 3 +--
drivers/i2c/muxes/i2c-mux-pca954x.c | 3 +--
drivers/iio/accel/bma180.c | 4 +---
drivers/iio/accel/bmc150-accel-i2c.c | 4 +---
drivers/iio/accel/kxcjk-1013.c | 4 +---
drivers/iio/accel/kxsd9-i2c.c | 4 +---
drivers/iio/accel/mc3230.c | 4 +---
drivers/iio/accel/mma7455_i2c.c | 4 +---
drivers/iio/accel/mma7660.c | 4 +---
drivers/iio/accel/mma8452.c | 4 +---
drivers/iio/accel/mma9551.c | 4 +---
drivers/iio/accel/mma9553.c | 4 +---
drivers/iio/accel/stk8312.c | 4 +---
drivers/iio/accel/stk8ba50.c | 4 +---
drivers/iio/adc/ad799x.c | 4 +---
drivers/iio/adc/ina2xx-adc.c | 4 +---
drivers/iio/adc/ltc2497.c | 4 +---
drivers/iio/adc/ti-ads1015.c | 4 +---
drivers/iio/chemical/atlas-sensor.c | 4 +---
drivers/iio/chemical/ccs811.c | 4 +---
drivers/iio/chemical/sgp30.c | 4 +---
drivers/iio/dac/ad5380.c | 4 +---
drivers/iio/dac/ad5446.c | 4 +---
drivers/iio/dac/ad5593r.c | 4 +---
drivers/iio/dac/ad5696-i2c.c | 4 +---
drivers/iio/dac/ds4424.c | 4 +---
drivers/iio/dac/m62332.c | 4 +---
drivers/iio/dac/mcp4725.c | 4 +---
drivers/iio/dac/ti-dac5571.c | 4 +---
drivers/iio/gyro/bmg160_i2c.c | 4 +---
drivers/iio/gyro/fxas21002c_i2c.c | 4 +---
drivers/iio/gyro/itg3200_core.c | 4 +---
drivers/iio/gyro/mpu3050-i2c.c | 4 +---
drivers/iio/health/afe4404.c | 4 +---
drivers/iio/health/max30100.c | 4 +---
drivers/iio/health/max30102.c | 4 +---
drivers/iio/humidity/hdc2010.c | 4 +---
drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c | 4 +---
drivers/iio/imu/kmx61.c | 4 +---
drivers/iio/light/apds9300.c | 4 +---
drivers/iio/light/apds9960.c | 4 +---
drivers/iio/light/bh1750.c | 4 +---
drivers/iio/light/bh1780.c | 4 +---
drivers/iio/light/cm3232.c | 4 +---
drivers/iio/light/cm36651.c | 4 +---
drivers/iio/light/gp2ap002.c | 4 +---
drivers/iio/light/gp2ap020a00f.c | 4 +---
drivers/iio/light/isl29028.c | 4 +---
drivers/iio/light/isl29125.c | 4 +---
drivers/iio/light/jsa1212.c | 4 +---
drivers/iio/light/ltr501.c | 4 +---
drivers/iio/light/opt3001.c | 6 ++----
drivers/iio/light/pa12203001.c | 4 +---
drivers/iio/light/rpr0521.c | 4 +---
drivers/iio/light/stk3310.c | 4 +---
drivers/iio/light/tcs3472.c | 4 +---
drivers/iio/light/tsl2563.c | 4 +---
drivers/iio/light/tsl2583.c | 4 +---
drivers/iio/light/tsl4531.c | 4 +---
drivers/iio/light/us5182d.c | 4 +---
drivers/iio/light/vcnl4000.c | 4 +---
drivers/iio/light/vcnl4035.c | 4 +---
drivers/iio/light/veml6070.c | 4 +---
drivers/iio/magnetometer/ak8974.c | 4 +---
drivers/iio/magnetometer/ak8975.c | 4 +---
drivers/iio/magnetometer/bmc150_magn_i2c.c | 4 +---
drivers/iio/magnetometer/hmc5843_i2c.c | 4 +---
drivers/iio/magnetometer/mag3110.c | 4 +---
drivers/iio/magnetometer/yamaha-yas530.c | 4 +---
drivers/iio/potentiostat/lmp91000.c | 4 +---
drivers/iio/pressure/mpl3115.c | 4 +---
drivers/iio/pressure/ms5611_i2c.c | 4 +---
drivers/iio/pressure/zpa2326_i2c.c | 4 +---
drivers/iio/proximity/pulsedlight-lidar-lite-v2.c | 4 +---
drivers/iio/proximity/sx9500.c | 4 +---
drivers/iio/temperature/mlx90614.c | 4 +---
drivers/iio/temperature/mlx90632.c | 4 +---
drivers/input/joystick/as5011.c | 4 +---
drivers/input/keyboard/adp5588-keys.c | 3 +--
drivers/input/keyboard/lm8323.c | 4 +---
drivers/input/keyboard/lm8333.c | 4 +---
drivers/input/keyboard/mcs_touchkey.c | 4 +---
drivers/input/keyboard/qt1070.c | 4 +---
drivers/input/keyboard/qt2160.c | 4 +---
drivers/input/keyboard/tca6416-keypad.c | 4 +---
drivers/input/misc/adxl34x-i2c.c | 4 +---
drivers/input/misc/bma150.c | 4 +---
drivers/input/misc/cma3000_d0x_i2c.c | 4 +---
drivers/input/misc/pcf8574_keypad.c | 4 +---
drivers/input/mouse/synaptics_i2c.c | 4 +---
drivers/input/rmi4/rmi_smbus.c | 4 +---
drivers/input/touchscreen/atmel_mxt_ts.c | 4 +---
drivers/input/touchscreen/bu21013_ts.c | 4 +---
drivers/input/touchscreen/cyttsp4_i2c.c | 4 +---
drivers/input/touchscreen/edt-ft5x06.c | 4 +---
drivers/input/touchscreen/goodix.c | 4 +---
drivers/input/touchscreen/migor_ts.c | 4 +---
drivers/input/touchscreen/s6sy761.c | 4 +---
drivers/input/touchscreen/stmfts.c | 4 +---
drivers/input/touchscreen/tsc2004.c | 4 +---
drivers/leds/flash/leds-as3645a.c | 4 +---
drivers/leds/flash/leds-lm3601x.c | 13 +++++++------
drivers/leds/flash/leds-rt4505.c | 3 +--
drivers/leds/leds-an30259a.c | 4 +---
drivers/leds/leds-aw2013.c | 4 +---
drivers/leds/leds-bd2802.c | 4 +---
drivers/leds/leds-blinkm.c | 3 +--
drivers/leds/leds-is31fl32xx.c | 4 +---
drivers/leds/leds-lm3530.c | 3 +--
drivers/leds/leds-lm3532.c | 4 +---
drivers/leds/leds-lm355x.c | 4 +---
drivers/leds/leds-lm3642.c | 3 +--
drivers/leds/leds-lm3692x.c | 4 +---
drivers/leds/leds-lm3697.c | 8 ++------
drivers/leds/leds-lp3944.c | 4 +---
drivers/leds/leds-lp3952.c | 4 +---
drivers/leds/leds-lp50xx.c | 4 +---
drivers/leds/leds-lp5521.c | 4 +---
drivers/leds/leds-lp5523.c | 4 +---
drivers/leds/leds-lp5562.c | 4 +---
drivers/leds/leds-lp8501.c | 4 +---
drivers/leds/leds-lp8860.c | 4 +---
drivers/leds/leds-pca9532.c | 6 ++----
drivers/leds/leds-tca6507.c | 4 +---
drivers/leds/leds-turris-omnia.c | 4 +---
drivers/macintosh/ams/ams-i2c.c | 4 +---
drivers/macintosh/therm_adt746x.c | 4 +---
drivers/macintosh/therm_windtunnel.c | 4 +---
drivers/macintosh/windfarm_ad7417_sensor.c | 4 +---
drivers/macintosh/windfarm_fcu_controls.c | 3 +--
drivers/macintosh/windfarm_lm75_sensor.c | 4 +---
drivers/macintosh/windfarm_lm87_sensor.c | 4 +---
drivers/macintosh/windfarm_max6690_sensor.c | 4 +---
drivers/macintosh/windfarm_smu_sat.c | 4 +---
drivers/media/cec/i2c/ch7322.c | 4 +---
drivers/media/dvb-frontends/a8293.c | 3 +--
drivers/media/dvb-frontends/af9013.c | 4 +---
drivers/media/dvb-frontends/af9033.c | 4 +---
drivers/media/dvb-frontends/au8522_decoder.c | 3 +--
drivers/media/dvb-frontends/cxd2099.c | 4 +---
drivers/media/dvb-frontends/cxd2820r_core.c | 4 +---
drivers/media/dvb-frontends/dvb-pll.c | 3 +--
drivers/media/dvb-frontends/lgdt3306a.c | 4 +---
drivers/media/dvb-frontends/lgdt330x.c | 4 +---
drivers/media/dvb-frontends/m88ds3103.c | 3 +--
drivers/media/dvb-frontends/mn88443x.c | 4 +---
drivers/media/dvb-frontends/mn88472.c | 4 +---
drivers/media/dvb-frontends/mn88473.c | 4 +---
drivers/media/dvb-frontends/mxl692.c | 4 +---
drivers/media/dvb-frontends/rtl2830.c | 4 +---
drivers/media/dvb-frontends/rtl2832.c | 4 +---
drivers/media/dvb-frontends/si2165.c | 3 +--
drivers/media/dvb-frontends/si2168.c | 4 +---
drivers/media/dvb-frontends/sp2.c | 3 +--
drivers/media/dvb-frontends/stv090x.c | 3 +--
drivers/media/dvb-frontends/stv6110x.c | 3 +--
drivers/media/dvb-frontends/tc90522.c | 3 +--
drivers/media/dvb-frontends/tda10071.c | 3 +--
drivers/media/dvb-frontends/ts2020.c | 3 +--
drivers/media/i2c/ad5820.c | 3 +--
drivers/media/i2c/ad9389b.c | 3 +--
drivers/media/i2c/adp1653.c | 4 +---
drivers/media/i2c/adv7170.c | 3 +--
drivers/media/i2c/adv7175.c | 3 +--
drivers/media/i2c/adv7180.c | 4 +---
drivers/media/i2c/adv7183.c | 3 +--
drivers/media/i2c/adv7343.c | 4 +---
drivers/media/i2c/adv7393.c | 4 +---
drivers/media/i2c/adv748x/adv748x-core.c | 4 +---
drivers/media/i2c/adv7511-v4l2.c | 3 +--
drivers/media/i2c/adv7604.c | 3 +--
drivers/media/i2c/adv7842.c | 3 +--
drivers/media/i2c/ak7375.c | 4 +---
drivers/media/i2c/ak881x.c | 4 +---
drivers/media/i2c/ar0521.c | 3 +--
drivers/media/i2c/bt819.c | 3 +--
drivers/media/i2c/bt856.c | 3 +--
drivers/media/i2c/bt866.c | 3 +--
drivers/media/i2c/ccs/ccs-core.c | 4 +---
drivers/media/i2c/cs3308.c | 3 +--
drivers/media/i2c/cs5345.c | 3 +--
drivers/media/i2c/cs53l32a.c | 3 +--
drivers/media/i2c/cx25840/cx25840-core.c | 3 +--
drivers/media/i2c/dw9714.c | 4 +---
drivers/media/i2c/dw9768.c | 4 +---
drivers/media/i2c/dw9807-vcm.c | 4 +---
drivers/media/i2c/et8ek8/et8ek8_driver.c | 4 +---
drivers/media/i2c/hi556.c | 4 +---
drivers/media/i2c/hi846.c | 4 +---
drivers/media/i2c/hi847.c | 4 +---
drivers/media/i2c/imx208.c | 4 +---
drivers/media/i2c/imx214.c | 4 +---
drivers/media/i2c/imx219.c | 4 +---
drivers/media/i2c/imx258.c | 4 +---
drivers/media/i2c/imx274.c | 3 +--
drivers/media/i2c/imx290.c | 4 +---
drivers/media/i2c/imx319.c | 4 +---
drivers/media/i2c/imx334.c | 4 +---
drivers/media/i2c/imx335.c | 4 +---
drivers/media/i2c/imx355.c | 4 +---
drivers/media/i2c/imx412.c | 4 +---
drivers/media/i2c/ir-kbd-i2c.c | 4 +---
drivers/media/i2c/isl7998x.c | 4 +---
drivers/media/i2c/ks0127.c | 3 +--
drivers/media/i2c/lm3560.c | 4 +---
drivers/media/i2c/lm3646.c | 4 +---
drivers/media/i2c/m52790.c | 3 +--
drivers/media/i2c/m5mols/m5mols_core.c | 4 +---
drivers/media/i2c/max2175.c | 4 +---
drivers/media/i2c/max9286.c | 4 +---
drivers/media/i2c/ml86v7667.c | 4 +---
drivers/media/i2c/msp3400-driver.c | 3 +--
drivers/media/i2c/mt9m001.c | 4 +---
drivers/media/i2c/mt9m032.c | 3 +--
drivers/media/i2c/mt9m111.c | 4 +---
drivers/media/i2c/mt9p031.c | 4 +---
drivers/media/i2c/mt9t001.c | 3 +--
drivers/media/i2c/mt9t112.c | 4 +---
drivers/media/i2c/mt9v011.c | 4 +---
drivers/media/i2c/mt9v032.c | 4 +---
drivers/media/i2c/mt9v111.c | 4 +---
drivers/media/i2c/noon010pc30.c | 4 +---
drivers/media/i2c/og01a1b.c | 4 +---
drivers/media/i2c/ov02a10.c | 4 +---
drivers/media/i2c/ov08d10.c | 4 +---
drivers/media/i2c/ov13858.c | 4 +---
drivers/media/i2c/ov13b10.c | 4 +---
drivers/media/i2c/ov2640.c | 3 +--
drivers/media/i2c/ov2659.c | 4 +---
drivers/media/i2c/ov2680.c | 4 +---
drivers/media/i2c/ov2685.c | 4 +---
drivers/media/i2c/ov2740.c | 4 +---
drivers/media/i2c/ov5640.c | 4 +---
drivers/media/i2c/ov5645.c | 4 +---
drivers/media/i2c/ov5647.c | 4 +---
drivers/media/i2c/ov5648.c | 4 +---
drivers/media/i2c/ov5670.c | 4 +---
drivers/media/i2c/ov5675.c | 4 +---
drivers/media/i2c/ov5693.c | 4 +---
drivers/media/i2c/ov5695.c | 4 +---
drivers/media/i2c/ov6650.c | 3 +--
drivers/media/i2c/ov7251.c | 4 +---
drivers/media/i2c/ov7640.c | 4 +---
drivers/media/i2c/ov7670.c | 3 +--
drivers/media/i2c/ov772x.c | 4 +---
drivers/media/i2c/ov7740.c | 3 +--
drivers/media/i2c/ov8856.c | 4 +---
drivers/media/i2c/ov8865.c | 4 +---
drivers/media/i2c/ov9282.c | 4 +---
drivers/media/i2c/ov9640.c | 4 +---
drivers/media/i2c/ov9650.c | 4 +---
drivers/media/i2c/ov9734.c | 4 +---
drivers/media/i2c/rdacm20.c | 4 +---
drivers/media/i2c/rdacm21.c | 4 +---
drivers/media/i2c/rj54n1cb0c.c | 4 +---
drivers/media/i2c/s5c73m3/s5c73m3-core.c | 4 +---
drivers/media/i2c/s5k4ecgx.c | 4 +---
drivers/media/i2c/s5k5baf.c | 4 +---
drivers/media/i2c/s5k6a3.c | 3 +--
drivers/media/i2c/s5k6aa.c | 4 +---
drivers/media/i2c/saa6588.c | 4 +---
drivers/media/i2c/saa6752hs.c | 3 +--
drivers/media/i2c/saa7110.c | 3 +--
drivers/media/i2c/saa7115.c | 3 +--
drivers/media/i2c/saa7127.c | 3 +--
drivers/media/i2c/saa717x.c | 3 +--
drivers/media/i2c/saa7185.c | 3 +--
drivers/media/i2c/sony-btf-mpx.c | 4 +---
drivers/media/i2c/sr030pc30.c | 3 +--
drivers/media/i2c/st-mipid02.c | 4 +---
drivers/media/i2c/tc358743.c | 4 +---
drivers/media/i2c/tda1997x.c | 4 +---
drivers/media/i2c/tda7432.c | 3 +--
drivers/media/i2c/tda9840.c | 3 +--
drivers/media/i2c/tea6415c.c | 3 +--
drivers/media/i2c/tea6420.c | 3 +--
drivers/media/i2c/ths7303.c | 4 +---
drivers/media/i2c/ths8200.c | 4 +---
drivers/media/i2c/tlv320aic23b.c | 3 +--
drivers/media/i2c/tvaudio.c | 3 +--
drivers/media/i2c/tvp514x.c | 3 +--
drivers/media/i2c/tvp5150.c | 4 +---
drivers/media/i2c/tvp7002.c | 3 +--
drivers/media/i2c/tw2804.c | 3 +--
drivers/media/i2c/tw9903.c | 3 +--
drivers/media/i2c/tw9906.c | 3 +--
drivers/media/i2c/tw9910.c | 4 +---
drivers/media/i2c/uda1342.c | 3 +--
drivers/media/i2c/upd64031a.c | 3 +--
drivers/media/i2c/upd64083.c | 3 +--
drivers/media/i2c/video-i2c.c | 4 +---
drivers/media/i2c/vp27smpx.c | 3 +--
drivers/media/i2c/vpx3220.c | 4 +---
drivers/media/i2c/vs6624.c | 3 +--
drivers/media/i2c/wm8739.c | 3 +--
drivers/media/i2c/wm8775.c | 3 +--
drivers/media/radio/radio-tea5764.c | 3 +--
drivers/media/radio/saa7706h.c | 3 +--
drivers/media/radio/si470x/radio-si470x-i2c.c | 3 +--
drivers/media/radio/si4713/si4713.c | 4 +---
drivers/media/radio/tef6862.c | 3 +--
drivers/media/test-drivers/vidtv/vidtv_demod.c | 4 +---
drivers/media/test-drivers/vidtv/vidtv_tuner.c | 4 +---
drivers/media/tuners/e4000.c | 4 +---
drivers/media/tuners/fc2580.c | 3 +--
drivers/media/tuners/m88rs6000t.c | 4 +---
drivers/media/tuners/mt2060.c | 4 +---
drivers/media/tuners/mxl301rf.c | 3 +--
drivers/media/tuners/qm1d1b0004.c | 3 +--
drivers/media/tuners/qm1d1c0042.c | 3 +--
drivers/media/tuners/si2157.c | 4 +---
drivers/media/tuners/tda18212.c | 4 +---
drivers/media/tuners/tda18250.c | 4 +---
drivers/media/tuners/tua9001.c | 3 +--
drivers/media/usb/go7007/s2250-board.c | 3 +--
drivers/media/v4l2-core/tuner-core.c | 3 +--
drivers/mfd/88pm800.c | 4 +---
drivers/mfd/88pm805.c | 4 +---
drivers/mfd/88pm860x-core.c | 3 +--
drivers/mfd/acer-ec-a500.c | 4 +---
drivers/mfd/arizona-i2c.c | 4 +---
drivers/mfd/axp20x-i2c.c | 4 +---
drivers/mfd/da903x.c | 3 +--
drivers/mfd/da9052-i2c.c | 3 +--
drivers/mfd/da9055-i2c.c | 4 +---
drivers/mfd/da9062-core.c | 4 +---
drivers/mfd/da9150-core.c | 4 +---
drivers/mfd/dm355evm_msp.c | 3 +--
drivers/mfd/ene-kb3930.c | 4 +---
drivers/mfd/gateworks-gsc.c | 4 +---
drivers/mfd/intel_soc_pmic_core.c | 4 +---
drivers/mfd/iqs62x.c | 4 +---
drivers/mfd/lm3533-core.c | 4 +---
drivers/mfd/lp8788.c | 3 +--
drivers/mfd/madera-i2c.c | 4 +---
drivers/mfd/max14577.c | 4 +---
drivers/mfd/max77693.c | 4 +---
drivers/mfd/max8907.c | 4 +---
drivers/mfd/max8925-i2c.c | 3 +--
drivers/mfd/mc13xxx-i2c.c | 3 +--
drivers/mfd/menelaus.c | 3 +--
drivers/mfd/ntxec.c | 4 +---
drivers/mfd/palmas.c | 4 +---
drivers/mfd/pcf50633-core.c | 4 +---
drivers/mfd/retu-mfd.c | 4 +---
drivers/mfd/rk808.c | 4 +---
drivers/mfd/rn5t618.c | 4 +---
drivers/mfd/rsmu_i2c.c | 4 +---
drivers/mfd/rt4831.c | 4 +---
drivers/mfd/si476x-i2c.c | 4 +---
drivers/mfd/stmfx.c | 4 +---
drivers/mfd/stmpe-i2c.c | 4 +---
drivers/mfd/tc3589x.c | 4 +---
drivers/mfd/tps6105x.c | 4 +---
drivers/mfd/tps65010.c | 3 +--
drivers/mfd/tps65086.c | 4 +---
drivers/mfd/tps65217.c | 4 +---
drivers/mfd/tps6586x.c | 3 +--
drivers/mfd/tps65912-i2c.c | 4 +---
drivers/mfd/twl-core.c | 3 +--
drivers/mfd/twl6040.c | 4 +---
drivers/mfd/wm8994-core.c | 4 +---
drivers/misc/ad525x_dpot-i2c.c | 3 +--
drivers/misc/apds9802als.c | 3 +--
drivers/misc/apds990x.c | 3 +--
drivers/misc/bh1770glc.c | 4 +---
drivers/misc/ds1682.c | 3 +--
drivers/misc/eeprom/at24.c | 4 +---
drivers/misc/eeprom/ee1004.c | 4 +---
drivers/misc/eeprom/eeprom.c | 4 +---
drivers/misc/eeprom/idt_89hpesx.c | 4 +---
drivers/misc/eeprom/max6875.c | 4 +---
drivers/misc/hmc6352.c | 3 +--
drivers/misc/ics932s401.c | 5 ++---
drivers/misc/isl29003.c | 3 +--
drivers/misc/isl29020.c | 3 +--
drivers/misc/lis3lv02d/lis3lv02d_i2c.c | 3 +--
drivers/misc/tsl2550.c | 4 +---
drivers/mtd/maps/pismo.c | 4 +---
drivers/net/dsa/lan9303_i2c.c | 6 ++----
drivers/net/dsa/microchip/ksz9477_i2c.c | 4 +---
drivers/net/dsa/xrs700x/xrs700x_i2c.c | 6 ++----
drivers/net/ethernet/mellanox/mlxsw/i2c.c | 4 +---
drivers/net/mctp/mctp-i2c.c | 4 +---
drivers/nfc/fdp/i2c.c | 4 +---
drivers/nfc/microread/i2c.c | 4 +---
drivers/nfc/nfcmrvl/i2c.c | 4 +---
drivers/nfc/nxp-nci/i2c.c | 4 +---
drivers/nfc/pn533/i2c.c | 4 +---
drivers/nfc/pn544/i2c.c | 4 +---
drivers/nfc/s3fwrn5/i2c.c | 4 +---
drivers/nfc/st-nci/i2c.c | 4 +---
drivers/nfc/st21nfca/i2c.c | 4 +---
drivers/of/unittest.c | 6 ++----
drivers/platform/chrome/cros_ec_i2c.c | 4 +---
drivers/platform/surface/surface3_power.c | 4 +---
drivers/platform/x86/asus-tf103c-dock.c | 4 +---
drivers/platform/x86/intel/int3472/tps68470.c | 4 +---
drivers/power/supply/bq2415x_charger.c | 4 +---
drivers/power/supply/bq24190_charger.c | 4 +---
drivers/power/supply/bq24257_charger.c | 4 +---
drivers/power/supply/bq25890_charger.c | 4 +---
drivers/power/supply/bq27xxx_battery_i2c.c | 4 +---
drivers/power/supply/cw2015_battery.c | 3 +--
drivers/power/supply/ds2782_battery.c | 4 +---
drivers/power/supply/lp8727_charger.c | 3 +--
drivers/power/supply/rt5033_battery.c | 4 +---
drivers/power/supply/rt9455_charger.c | 4 +---
drivers/power/supply/smb347-charger.c | 4 +---
drivers/power/supply/z2_battery.c | 4 +---
drivers/pwm/pwm-pca9685.c | 4 +---
drivers/regulator/da9121-regulator.c | 3 +--
drivers/regulator/lp8755.c | 4 +---
drivers/regulator/rpi-panel-attiny-regulator.c | 4 +---
drivers/rtc/rtc-bq32k.c | 4 +---
drivers/rtc/rtc-ds1374.c | 4 +---
drivers/rtc/rtc-isl12026.c | 3 +--
drivers/rtc/rtc-m41t80.c | 4 +---
drivers/rtc/rtc-rs5c372.c | 3 +--
drivers/rtc/rtc-x1205.c | 3 +--
drivers/staging/media/atomisp/i2c/atomisp-gc0310.c | 4 +---
drivers/staging/media/atomisp/i2c/atomisp-gc2235.c | 4 +---
drivers/staging/media/atomisp/i2c/atomisp-lm3554.c | 4 +---
drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c | 3 +--
drivers/staging/media/atomisp/i2c/atomisp-ov2680.c | 4 +---
drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 4 +---
.../media/atomisp/i2c/ov5693/atomisp-ov5693.c | 4 +---
drivers/staging/media/max96712/max96712.c | 4 +---
drivers/staging/most/i2c/i2c.c | 4 +---
drivers/staging/olpc_dcon/olpc_dcon.c | 4 +---
drivers/tty/serial/max310x.c | 4 +---
drivers/tty/serial/sc16is7xx.c | 4 +---
drivers/usb/misc/usb3503.c | 4 +---
drivers/usb/phy/phy-isp1301-omap.c | 4 +---
drivers/usb/phy/phy-isp1301.c | 4 +---
drivers/usb/typec/anx7411.c | 4 +---
drivers/usb/typec/hd3ss3220.c | 4 +---
drivers/usb/typec/mux/fsa4480.c | 4 +---
drivers/usb/typec/mux/pi3usb30532.c | 3 +--
drivers/usb/typec/rt1719.c | 4 +---
drivers/usb/typec/stusb160x.c | 4 +---
drivers/usb/typec/tcpm/fusb302.c | 4 +---
drivers/usb/typec/tcpm/tcpci.c | 4 +---
drivers/usb/typec/tcpm/tcpci_maxim.c | 4 +---
drivers/usb/typec/tcpm/tcpci_rt1711h.c | 3 +--
drivers/usb/typec/tipd/core.c | 4 +---
drivers/usb/typec/ucsi/ucsi_ccg.c | 4 +---
drivers/usb/typec/ucsi/ucsi_stm32g0.c | 4 +---
drivers/usb/typec/wusb3801.c | 4 +---
drivers/video/backlight/adp8860_bl.c | 4 +---
drivers/video/backlight/adp8870_bl.c | 4 +---
drivers/video/backlight/arcxcnn_bl.c | 4 +---
drivers/video/backlight/bd6107.c | 4 +---
drivers/video/backlight/lm3630a_bl.c | 3 +--
drivers/video/backlight/lm3639_bl.c | 3 +--
drivers/video/backlight/lp855x_bl.c | 4 +---
drivers/video/backlight/lv5207lp.c | 4 +---
drivers/video/backlight/tosa_bl.c | 3 +--
drivers/video/fbdev/matrox/matroxfb_maven.c | 3 +--
drivers/video/fbdev/ssd1307fb.c | 4 +---
drivers/w1/masters/ds2482.c | 3 +--
drivers/watchdog/ziirave_wdt.c | 4 +---
include/linux/i2c.h | 2 +-
include/linux/platform_data/pca953x.h | 2 +-
sound/aoa/codecs/onyx.c | 3 +--
sound/aoa/codecs/tas.c | 3 +--
sound/pci/hda/cs35l41_hda_i2c.c | 4 +---
sound/ppc/keywest.c | 6 ++----
sound/soc/codecs/adau1761-i2c.c | 3 +--
sound/soc/codecs/adau1781-i2c.c | 3 +--
sound/soc/codecs/ak4375.c | 4 +---
sound/soc/codecs/ak4458.c | 4 +---
sound/soc/codecs/ak4641.c | 4 +---
sound/soc/codecs/ak5558.c | 4 +---
sound/soc/codecs/cs35l32.c | 4 +---
sound/soc/codecs/cs35l33.c | 4 +---
sound/soc/codecs/cs35l34.c | 4 +---
sound/soc/codecs/cs35l35.c | 4 +---
sound/soc/codecs/cs35l36.c | 4 +---
sound/soc/codecs/cs35l41-i2c.c | 4 +---
sound/soc/codecs/cs35l45-i2c.c | 4 +---
sound/soc/codecs/cs4234.c | 4 +---
sound/soc/codecs/cs4265.c | 4 +---
sound/soc/codecs/cs4270.c | 4 +---
sound/soc/codecs/cs42l42.c | 4 +---
sound/soc/codecs/cs42l51-i2c.c | 4 +---
sound/soc/codecs/cs42l56.c | 3 +--
sound/soc/codecs/cs42xx8-i2c.c | 4 +---
sound/soc/codecs/cs43130.c | 4 +---
sound/soc/codecs/cs4349.c | 4 +---
sound/soc/codecs/cs53l30.c | 4 +---
sound/soc/codecs/cx2072x.c | 3 +--
sound/soc/codecs/max98090.c | 4 +---
sound/soc/codecs/max9860.c | 3 +--
sound/soc/codecs/max98927.c | 4 +---
sound/soc/codecs/mt6660.c | 3 +--
sound/soc/codecs/nau8825.c | 6 ++----
sound/soc/codecs/pcm1789-i2c.c | 4 +---
sound/soc/codecs/pcm3168a-i2c.c | 4 +---
sound/soc/codecs/pcm512x-i2c.c | 3 +--
sound/soc/codecs/rt274.c | 4 +---
sound/soc/codecs/rt286.c | 4 +---
sound/soc/codecs/rt298.c | 4 +---
sound/soc/codecs/rt5616.c | 6 ++----
sound/soc/codecs/rt5631.c | 6 ++----
sound/soc/codecs/rt5645.c | 4 +---
sound/soc/codecs/rt5663.c | 4 +---
sound/soc/codecs/rt5670.c | 4 +---
sound/soc/codecs/rt5677.c | 4 +---
sound/soc/codecs/rt5682-i2c.c | 4 +---
sound/soc/codecs/rt5682s.c | 4 +---
sound/soc/codecs/rt9120.c | 3 +--
sound/soc/codecs/sgtl5000.c | 4 +---
sound/soc/codecs/sta350.c | 6 ++----
sound/soc/codecs/tas2552.c | 3 +--
sound/soc/codecs/tas5086.c | 6 ++----
sound/soc/codecs/tas571x.c | 4 +---
sound/soc/codecs/tas5805m.c | 3 +--
sound/soc/codecs/tas6424.c | 4 +---
sound/soc/codecs/tlv320adc3xxx.c | 3 +--
sound/soc/codecs/tlv320aic32x4-i2c.c | 4 +---
sound/soc/codecs/tlv320aic3x-i2c.c | 4 +---
sound/soc/codecs/tlv320dac33.c | 4 +---
sound/soc/codecs/wm1250-ev1.c | 4 +---
sound/soc/codecs/wm2200.c | 4 +---
sound/soc/codecs/wm5100.c | 4 +---
sound/soc/codecs/wm8804-i2c.c | 3 +--
sound/soc/codecs/wm8900.c | 6 ++----
sound/soc/codecs/wm8903.c | 4 +---
sound/soc/codecs/wm8960.c | 6 ++----
sound/soc/codecs/wm8962.c | 3 +--
sound/soc/codecs/wm8993.c | 4 +---
sound/soc/codecs/wm8996.c | 4 +---
sound/soc/codecs/wm9081.c | 6 ++----
622 files changed, 660 insertions(+), 1762 deletions(-)
base-commit: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868
--
2.36.1
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH v2 0/6] i2c: Make remove callback return void
@ 2022-08-15 8:02 ` Uwe Kleine-König
0 siblings, 0 replies; 22+ messages in thread
From: Uwe Kleine-König @ 2022-08-15 8:02 UTC (permalink / raw)
To: Wolfram Sang
Cc: Benjamin Mugnier, Heikki Krogerus, Crt Mori, Ajay Gupta,
David Airlie, Peter Senna Tschudin, Sekhar Nori, dri-devel,
Sebastian Reichel, Andrey Ryabinin, linux-i2c, Pavel Machek,
Srinivas Pandruvada, Jeremy Kerr, Matt Johnston, Corey Minyard,
linux-leds, Marek Behún, Bartosz Golaszewski,
Javier Martinez Canillas, Christophe Leroy, Andy Shevchenko,
Adrien Grassein, Luca Ceresoli, kernel, Jean Delvare,
Luca Ceresoli, Krzysztof Hałasa, Jonathan Cameron,
Petr Machata, Greg Kroah-Hartman, Dmitry Torokhov, Miguel Ojeda,
Hans Verkuil, Vladimir Oltean, Maximilian Luz, Peter Rosin
Hello,
as promised there comes the series that does
- int (*remove)(struct i2c_client *client);
+ void (*remove)(struct i2c_client *client);
in struct i2c_driver. Returning an error code has no (relevant) effect,
as in the Linux device model removal cannot be stopped. So the
possibility to return a value is prone to trouble because driver authors
might assume it does stop the process and .remove is called again at a
later point again. A few errors like these were fixed preparing this
change. See commit bbc126ae381c ("usb: typec: tcpci: Don't skip cleanup
in .remove() on error") for an example.
To prevent such errors in the future, .remove() is changed to return
void which leaves no doubt about its semantics.
This series is build-tested on arm64, m68k, powerpc, riscv, s390, sparc64 and
x86_64 using allmodconfig.
As some conflicts are expected I sent this early after -rc1 such that it
can be included early into next and be put on an immutable branch for
subsystems to resolve merge conflicts.
The first 5 patches in this series are preparatory work with the goal
that the final patch just drops "return 0" (or changes them to a plain
"return"). The three led patches got an Ack by Pavel (= led maintainer),
the other two didn't get final maintainer feedback. See
https://lore.kernel.org/dri-devel/20220526202538.1723142-1-u.kleine-koenig@pengutronix.de
https://lore.kernel.org/linux-gpio/20220502170555.51183-1-u.kleine-koenig@pengutronix.de
for the "discussions" about these two.
The changes since the first submission were already summarized in
https://lore.kernel.org/r/20220811124029.usxahk5nvfgqsm42@pengutronix.de
in detail, the only change since then is that the changes to
drivers/input/keyboard/adp5588-keys.c were merged, so additionally to
the changes described before, the change to that driver was adapted
accordingly. To summarize it's just:
- The preparing patches (#1 - #5) are unchanged
- Remove a comment form drivers/net/mctp/mctp-i2c.c that doesn't match
any more in #6. (Noticed by Matt Johnston and independently by Jeremy Kerr)
- Removed a stray change to lib/Kconfig.kasan that I needed for build
testing but that wasn't ment to be included; also in patch #6.
(Noticed by Andrey Ryabinin).
- Rebase v5.19-rc4 -> 6.0-rc1 and adapt for dropped and new drivers.
The patches are also available at
https://git.pengutronix.de/git/ukl/linux i2c-remove-void
Thanks
Uwe
Uwe Kleine-König (6):
drm/i2c/sil164: Drop no-op remove function
leds: lm3697: Remove duplicated error reporting in .remove()
leds: lm3601x: Don't use mutex after it was destroyed
leds: lm3601x: Improve error reporting for problems during .remove()
gpio: pca953x: Make platform teardown callback return void
i2c: Make remove callback return void
Documentation/i2c/writing-clients.rst | 2 +-
arch/arm/mach-davinci/board-da850-evm.c | 12 ++++--------
arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c | 3 +--
drivers/auxdisplay/ht16k33.c | 4 +---
drivers/auxdisplay/lcd2s.c | 3 +--
drivers/char/ipmi/ipmb_dev_int.c | 4 +---
drivers/char/ipmi/ipmi_ipmb.c | 4 +---
drivers/char/ipmi/ipmi_ssif.c | 6 ++----
drivers/char/tpm/st33zp24/i2c.c | 4 +---
drivers/char/tpm/tpm_i2c_atmel.c | 3 +--
drivers/char/tpm/tpm_i2c_infineon.c | 4 +---
drivers/char/tpm/tpm_i2c_nuvoton.c | 3 +--
drivers/char/tpm/tpm_tis_i2c.c | 3 +--
drivers/char/tpm/tpm_tis_i2c_cr50.c | 6 ++----
drivers/clk/clk-cdce706.c | 3 +--
drivers/clk/clk-cs2000-cp.c | 4 +---
drivers/clk/clk-si514.c | 3 +--
drivers/clk/clk-si5341.c | 4 +---
drivers/clk/clk-si5351.c | 4 +---
drivers/clk/clk-si570.c | 3 +--
drivers/clk/clk-versaclock5.c | 4 +---
drivers/crypto/atmel-ecc.c | 6 ++----
drivers/crypto/atmel-sha204a.c | 6 ++----
drivers/extcon/extcon-rt8973a.c | 4 +---
drivers/gpio/gpio-adp5588.c | 4 +---
drivers/gpio/gpio-max7300.c | 4 +---
drivers/gpio/gpio-pca953x.c | 13 +++----------
drivers/gpio/gpio-pcf857x.c | 4 +---
drivers/gpio/gpio-tpic2810.c | 4 +---
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 4 +---
drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 4 +---
drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 4 +---
drivers/gpu/drm/bridge/analogix/anx7625.c | 4 +---
drivers/gpu/drm/bridge/chrontel-ch7033.c | 4 +---
drivers/gpu/drm/bridge/cros-ec-anx7688.c | 4 +---
drivers/gpu/drm/bridge/ite-it6505.c | 4 +---
drivers/gpu/drm/bridge/ite-it66121.c | 4 +---
drivers/gpu/drm/bridge/lontium-lt8912b.c | 3 +--
drivers/gpu/drm/bridge/lontium-lt9211.c | 4 +---
drivers/gpu/drm/bridge/lontium-lt9611.c | 4 +---
drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 4 +---
.../drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c | 8 ++------
drivers/gpu/drm/bridge/nxp-ptn3460.c | 4 +---
drivers/gpu/drm/bridge/parade-ps8622.c | 4 +---
drivers/gpu/drm/bridge/sii902x.c | 4 +---
drivers/gpu/drm/bridge/sii9234.c | 4 +---
drivers/gpu/drm/bridge/sil-sii8620.c | 4 +---
drivers/gpu/drm/bridge/tc358767.c | 4 +---
drivers/gpu/drm/bridge/tc358768.c | 4 +---
drivers/gpu/drm/bridge/tc358775.c | 4 +---
drivers/gpu/drm/bridge/ti-dlpc3433.c | 4 +---
drivers/gpu/drm/bridge/ti-sn65dsi83.c | 4 +---
drivers/gpu/drm/bridge/ti-tfp410.c | 4 +---
drivers/gpu/drm/i2c/ch7006_drv.c | 4 +---
drivers/gpu/drm/i2c/sil164_drv.c | 7 -------
drivers/gpu/drm/i2c/tda9950.c | 4 +---
drivers/gpu/drm/i2c/tda998x_drv.c | 3 +--
drivers/gpu/drm/panel/panel-olimex-lcd-olinuxino.c | 4 +---
.../gpu/drm/panel/panel-raspberrypi-touchscreen.c | 4 +---
drivers/gpu/drm/solomon/ssd130x-i2c.c | 4 +---
drivers/hid/i2c-hid/i2c-hid-core.c | 4 +---
drivers/hid/i2c-hid/i2c-hid.h | 2 +-
drivers/hwmon/adc128d818.c | 4 +---
drivers/hwmon/adt7470.c | 3 +--
drivers/hwmon/asb100.c | 6 ++----
drivers/hwmon/asc7621.c | 4 +---
drivers/hwmon/dme1737.c | 4 +---
drivers/hwmon/f75375s.c | 5 ++---
drivers/hwmon/fschmd.c | 6 ++----
drivers/hwmon/ftsteutates.c | 3 +--
drivers/hwmon/ina209.c | 4 +---
drivers/hwmon/ina3221.c | 4 +---
drivers/hwmon/jc42.c | 3 +--
drivers/hwmon/occ/p8_i2c.c | 4 +---
drivers/hwmon/pcf8591.c | 3 +--
drivers/hwmon/smm665.c | 3 +--
drivers/hwmon/tps23861.c | 4 +---
drivers/hwmon/w83781d.c | 4 +---
drivers/hwmon/w83791d.c | 6 ++----
drivers/hwmon/w83792d.c | 6 ++----
drivers/hwmon/w83793.c | 6 ++----
drivers/hwmon/w83795.c | 4 +---
drivers/hwmon/w83l785ts.c | 6 ++----
drivers/i2c/i2c-core-base.c | 6 +-----
drivers/i2c/i2c-slave-eeprom.c | 4 +---
drivers/i2c/i2c-slave-testunit.c | 3 +--
drivers/i2c/i2c-smbus.c | 3 +--
drivers/i2c/muxes/i2c-mux-ltc4306.c | 4 +---
drivers/i2c/muxes/i2c-mux-pca9541.c | 3 +--
drivers/i2c/muxes/i2c-mux-pca954x.c | 3 +--
drivers/iio/accel/bma180.c | 4 +---
drivers/iio/accel/bmc150-accel-i2c.c | 4 +---
drivers/iio/accel/kxcjk-1013.c | 4 +---
drivers/iio/accel/kxsd9-i2c.c | 4 +---
drivers/iio/accel/mc3230.c | 4 +---
drivers/iio/accel/mma7455_i2c.c | 4 +---
drivers/iio/accel/mma7660.c | 4 +---
drivers/iio/accel/mma8452.c | 4 +---
drivers/iio/accel/mma9551.c | 4 +---
drivers/iio/accel/mma9553.c | 4 +---
drivers/iio/accel/stk8312.c | 4 +---
drivers/iio/accel/stk8ba50.c | 4 +---
drivers/iio/adc/ad799x.c | 4 +---
drivers/iio/adc/ina2xx-adc.c | 4 +---
drivers/iio/adc/ltc2497.c | 4 +---
drivers/iio/adc/ti-ads1015.c | 4 +---
drivers/iio/chemical/atlas-sensor.c | 4 +---
drivers/iio/chemical/ccs811.c | 4 +---
drivers/iio/chemical/sgp30.c | 4 +---
drivers/iio/dac/ad5380.c | 4 +---
drivers/iio/dac/ad5446.c | 4 +---
drivers/iio/dac/ad5593r.c | 4 +---
drivers/iio/dac/ad5696-i2c.c | 4 +---
drivers/iio/dac/ds4424.c | 4 +---
drivers/iio/dac/m62332.c | 4 +---
drivers/iio/dac/mcp4725.c | 4 +---
drivers/iio/dac/ti-dac5571.c | 4 +---
drivers/iio/gyro/bmg160_i2c.c | 4 +---
drivers/iio/gyro/fxas21002c_i2c.c | 4 +---
drivers/iio/gyro/itg3200_core.c | 4 +---
drivers/iio/gyro/mpu3050-i2c.c | 4 +---
drivers/iio/health/afe4404.c | 4 +---
drivers/iio/health/max30100.c | 4 +---
drivers/iio/health/max30102.c | 4 +---
drivers/iio/humidity/hdc2010.c | 4 +---
drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c | 4 +---
drivers/iio/imu/kmx61.c | 4 +---
drivers/iio/light/apds9300.c | 4 +---
drivers/iio/light/apds9960.c | 4 +---
drivers/iio/light/bh1750.c | 4 +---
drivers/iio/light/bh1780.c | 4 +---
drivers/iio/light/cm3232.c | 4 +---
drivers/iio/light/cm36651.c | 4 +---
drivers/iio/light/gp2ap002.c | 4 +---
drivers/iio/light/gp2ap020a00f.c | 4 +---
drivers/iio/light/isl29028.c | 4 +---
drivers/iio/light/isl29125.c | 4 +---
drivers/iio/light/jsa1212.c | 4 +---
drivers/iio/light/ltr501.c | 4 +---
drivers/iio/light/opt3001.c | 6 ++----
drivers/iio/light/pa12203001.c | 4 +---
drivers/iio/light/rpr0521.c | 4 +---
drivers/iio/light/stk3310.c | 4 +---
drivers/iio/light/tcs3472.c | 4 +---
drivers/iio/light/tsl2563.c | 4 +---
drivers/iio/light/tsl2583.c | 4 +---
drivers/iio/light/tsl4531.c | 4 +---
drivers/iio/light/us5182d.c | 4 +---
drivers/iio/light/vcnl4000.c | 4 +---
drivers/iio/light/vcnl4035.c | 4 +---
drivers/iio/light/veml6070.c | 4 +---
drivers/iio/magnetometer/ak8974.c | 4 +---
drivers/iio/magnetometer/ak8975.c | 4 +---
drivers/iio/magnetometer/bmc150_magn_i2c.c | 4 +---
drivers/iio/magnetometer/hmc5843_i2c.c | 4 +---
drivers/iio/magnetometer/mag3110.c | 4 +---
drivers/iio/magnetometer/yamaha-yas530.c | 4 +---
drivers/iio/potentiostat/lmp91000.c | 4 +---
drivers/iio/pressure/mpl3115.c | 4 +---
drivers/iio/pressure/ms5611_i2c.c | 4 +---
drivers/iio/pressure/zpa2326_i2c.c | 4 +---
drivers/iio/proximity/pulsedlight-lidar-lite-v2.c | 4 +---
drivers/iio/proximity/sx9500.c | 4 +---
drivers/iio/temperature/mlx90614.c | 4 +---
drivers/iio/temperature/mlx90632.c | 4 +---
drivers/input/joystick/as5011.c | 4 +---
drivers/input/keyboard/adp5588-keys.c | 3 +--
drivers/input/keyboard/lm8323.c | 4 +---
drivers/input/keyboard/lm8333.c | 4 +---
drivers/input/keyboard/mcs_touchkey.c | 4 +---
drivers/input/keyboard/qt1070.c | 4 +---
drivers/input/keyboard/qt2160.c | 4 +---
drivers/input/keyboard/tca6416-keypad.c | 4 +---
drivers/input/misc/adxl34x-i2c.c | 4 +---
drivers/input/misc/bma150.c | 4 +---
drivers/input/misc/cma3000_d0x_i2c.c | 4 +---
drivers/input/misc/pcf8574_keypad.c | 4 +---
drivers/input/mouse/synaptics_i2c.c | 4 +---
drivers/input/rmi4/rmi_smbus.c | 4 +---
drivers/input/touchscreen/atmel_mxt_ts.c | 4 +---
drivers/input/touchscreen/bu21013_ts.c | 4 +---
drivers/input/touchscreen/cyttsp4_i2c.c | 4 +---
drivers/input/touchscreen/edt-ft5x06.c | 4 +---
drivers/input/touchscreen/goodix.c | 4 +---
drivers/input/touchscreen/migor_ts.c | 4 +---
drivers/input/touchscreen/s6sy761.c | 4 +---
drivers/input/touchscreen/stmfts.c | 4 +---
drivers/input/touchscreen/tsc2004.c | 4 +---
drivers/leds/flash/leds-as3645a.c | 4 +---
drivers/leds/flash/leds-lm3601x.c | 13 +++++++------
drivers/leds/flash/leds-rt4505.c | 3 +--
drivers/leds/leds-an30259a.c | 4 +---
drivers/leds/leds-aw2013.c | 4 +---
drivers/leds/leds-bd2802.c | 4 +---
drivers/leds/leds-blinkm.c | 3 +--
drivers/leds/leds-is31fl32xx.c | 4 +---
drivers/leds/leds-lm3530.c | 3 +--
drivers/leds/leds-lm3532.c | 4 +---
drivers/leds/leds-lm355x.c | 4 +---
drivers/leds/leds-lm3642.c | 3 +--
drivers/leds/leds-lm3692x.c | 4 +---
drivers/leds/leds-lm3697.c | 8 ++------
drivers/leds/leds-lp3944.c | 4 +---
drivers/leds/leds-lp3952.c | 4 +---
drivers/leds/leds-lp50xx.c | 4 +---
drivers/leds/leds-lp5521.c | 4 +---
drivers/leds/leds-lp5523.c | 4 +---
drivers/leds/leds-lp5562.c | 4 +---
drivers/leds/leds-lp8501.c | 4 +---
drivers/leds/leds-lp8860.c | 4 +---
drivers/leds/leds-pca9532.c | 6 ++----
drivers/leds/leds-tca6507.c | 4 +---
drivers/leds/leds-turris-omnia.c | 4 +---
drivers/macintosh/ams/ams-i2c.c | 4 +---
drivers/macintosh/therm_adt746x.c | 4 +---
drivers/macintosh/therm_windtunnel.c | 4 +---
drivers/macintosh/windfarm_ad7417_sensor.c | 4 +---
drivers/macintosh/windfarm_fcu_controls.c | 3 +--
drivers/macintosh/windfarm_lm75_sensor.c | 4 +---
drivers/macintosh/windfarm_lm87_sensor.c | 4 +---
drivers/macintosh/windfarm_max6690_sensor.c | 4 +---
drivers/macintosh/windfarm_smu_sat.c | 4 +---
drivers/media/cec/i2c/ch7322.c | 4 +---
drivers/media/dvb-frontends/a8293.c | 3 +--
drivers/media/dvb-frontends/af9013.c | 4 +---
drivers/media/dvb-frontends/af9033.c | 4 +---
drivers/media/dvb-frontends/au8522_decoder.c | 3 +--
drivers/media/dvb-frontends/cxd2099.c | 4 +---
drivers/media/dvb-frontends/cxd2820r_core.c | 4 +---
drivers/media/dvb-frontends/dvb-pll.c | 3 +--
drivers/media/dvb-frontends/lgdt3306a.c | 4 +---
drivers/media/dvb-frontends/lgdt330x.c | 4 +---
drivers/media/dvb-frontends/m88ds3103.c | 3 +--
drivers/media/dvb-frontends/mn88443x.c | 4 +---
drivers/media/dvb-frontends/mn88472.c | 4 +---
drivers/media/dvb-frontends/mn88473.c | 4 +---
drivers/media/dvb-frontends/mxl692.c | 4 +---
drivers/media/dvb-frontends/rtl2830.c | 4 +---
drivers/media/dvb-frontends/rtl2832.c | 4 +---
drivers/media/dvb-frontends/si2165.c | 3 +--
drivers/media/dvb-frontends/si2168.c | 4 +---
drivers/media/dvb-frontends/sp2.c | 3 +--
drivers/media/dvb-frontends/stv090x.c | 3 +--
drivers/media/dvb-frontends/stv6110x.c | 3 +--
drivers/media/dvb-frontends/tc90522.c | 3 +--
drivers/media/dvb-frontends/tda10071.c | 3 +--
drivers/media/dvb-frontends/ts2020.c | 3 +--
drivers/media/i2c/ad5820.c | 3 +--
drivers/media/i2c/ad9389b.c | 3 +--
drivers/media/i2c/adp1653.c | 4 +---
drivers/media/i2c/adv7170.c | 3 +--
drivers/media/i2c/adv7175.c | 3 +--
drivers/media/i2c/adv7180.c | 4 +---
drivers/media/i2c/adv7183.c | 3 +--
drivers/media/i2c/adv7343.c | 4 +---
drivers/media/i2c/adv7393.c | 4 +---
drivers/media/i2c/adv748x/adv748x-core.c | 4 +---
drivers/media/i2c/adv7511-v4l2.c | 3 +--
drivers/media/i2c/adv7604.c | 3 +--
drivers/media/i2c/adv7842.c | 3 +--
drivers/media/i2c/ak7375.c | 4 +---
drivers/media/i2c/ak881x.c | 4 +---
drivers/media/i2c/ar0521.c | 3 +--
drivers/media/i2c/bt819.c | 3 +--
drivers/media/i2c/bt856.c | 3 +--
drivers/media/i2c/bt866.c | 3 +--
drivers/media/i2c/ccs/ccs-core.c | 4 +---
drivers/media/i2c/cs3308.c | 3 +--
drivers/media/i2c/cs5345.c | 3 +--
drivers/media/i2c/cs53l32a.c | 3 +--
drivers/media/i2c/cx25840/cx25840-core.c | 3 +--
drivers/media/i2c/dw9714.c | 4 +---
drivers/media/i2c/dw9768.c | 4 +---
drivers/media/i2c/dw9807-vcm.c | 4 +---
drivers/media/i2c/et8ek8/et8ek8_driver.c | 4 +---
drivers/media/i2c/hi556.c | 4 +---
drivers/media/i2c/hi846.c | 4 +---
drivers/media/i2c/hi847.c | 4 +---
drivers/media/i2c/imx208.c | 4 +---
drivers/media/i2c/imx214.c | 4 +---
drivers/media/i2c/imx219.c | 4 +---
drivers/media/i2c/imx258.c | 4 +---
drivers/media/i2c/imx274.c | 3 +--
drivers/media/i2c/imx290.c | 4 +---
drivers/media/i2c/imx319.c | 4 +---
drivers/media/i2c/imx334.c | 4 +---
drivers/media/i2c/imx335.c | 4 +---
drivers/media/i2c/imx355.c | 4 +---
drivers/media/i2c/imx412.c | 4 +---
drivers/media/i2c/ir-kbd-i2c.c | 4 +---
drivers/media/i2c/isl7998x.c | 4 +---
drivers/media/i2c/ks0127.c | 3 +--
drivers/media/i2c/lm3560.c | 4 +---
drivers/media/i2c/lm3646.c | 4 +---
drivers/media/i2c/m52790.c | 3 +--
drivers/media/i2c/m5mols/m5mols_core.c | 4 +---
drivers/media/i2c/max2175.c | 4 +---
drivers/media/i2c/max9286.c | 4 +---
drivers/media/i2c/ml86v7667.c | 4 +---
drivers/media/i2c/msp3400-driver.c | 3 +--
drivers/media/i2c/mt9m001.c | 4 +---
drivers/media/i2c/mt9m032.c | 3 +--
drivers/media/i2c/mt9m111.c | 4 +---
drivers/media/i2c/mt9p031.c | 4 +---
drivers/media/i2c/mt9t001.c | 3 +--
drivers/media/i2c/mt9t112.c | 4 +---
drivers/media/i2c/mt9v011.c | 4 +---
drivers/media/i2c/mt9v032.c | 4 +---
drivers/media/i2c/mt9v111.c | 4 +---
drivers/media/i2c/noon010pc30.c | 4 +---
drivers/media/i2c/og01a1b.c | 4 +---
drivers/media/i2c/ov02a10.c | 4 +---
drivers/media/i2c/ov08d10.c | 4 +---
drivers/media/i2c/ov13858.c | 4 +---
drivers/media/i2c/ov13b10.c | 4 +---
drivers/media/i2c/ov2640.c | 3 +--
drivers/media/i2c/ov2659.c | 4 +---
drivers/media/i2c/ov2680.c | 4 +---
drivers/media/i2c/ov2685.c | 4 +---
drivers/media/i2c/ov2740.c | 4 +---
drivers/media/i2c/ov5640.c | 4 +---
drivers/media/i2c/ov5645.c | 4 +---
drivers/media/i2c/ov5647.c | 4 +---
drivers/media/i2c/ov5648.c | 4 +---
drivers/media/i2c/ov5670.c | 4 +---
drivers/media/i2c/ov5675.c | 4 +---
drivers/media/i2c/ov5693.c | 4 +---
drivers/media/i2c/ov5695.c | 4 +---
drivers/media/i2c/ov6650.c | 3 +--
drivers/media/i2c/ov7251.c | 4 +---
drivers/media/i2c/ov7640.c | 4 +---
drivers/media/i2c/ov7670.c | 3 +--
drivers/media/i2c/ov772x.c | 4 +---
drivers/media/i2c/ov7740.c | 3 +--
drivers/media/i2c/ov8856.c | 4 +---
drivers/media/i2c/ov8865.c | 4 +---
drivers/media/i2c/ov9282.c | 4 +---
drivers/media/i2c/ov9640.c | 4 +---
drivers/media/i2c/ov9650.c | 4 +---
drivers/media/i2c/ov9734.c | 4 +---
drivers/media/i2c/rdacm20.c | 4 +---
drivers/media/i2c/rdacm21.c | 4 +---
drivers/media/i2c/rj54n1cb0c.c | 4 +---
drivers/media/i2c/s5c73m3/s5c73m3-core.c | 4 +---
drivers/media/i2c/s5k4ecgx.c | 4 +---
drivers/media/i2c/s5k5baf.c | 4 +---
drivers/media/i2c/s5k6a3.c | 3 +--
drivers/media/i2c/s5k6aa.c | 4 +---
drivers/media/i2c/saa6588.c | 4 +---
drivers/media/i2c/saa6752hs.c | 3 +--
drivers/media/i2c/saa7110.c | 3 +--
drivers/media/i2c/saa7115.c | 3 +--
drivers/media/i2c/saa7127.c | 3 +--
drivers/media/i2c/saa717x.c | 3 +--
drivers/media/i2c/saa7185.c | 3 +--
drivers/media/i2c/sony-btf-mpx.c | 4 +---
drivers/media/i2c/sr030pc30.c | 3 +--
drivers/media/i2c/st-mipid02.c | 4 +---
drivers/media/i2c/tc358743.c | 4 +---
drivers/media/i2c/tda1997x.c | 4 +---
drivers/media/i2c/tda7432.c | 3 +--
drivers/media/i2c/tda9840.c | 3 +--
drivers/media/i2c/tea6415c.c | 3 +--
drivers/media/i2c/tea6420.c | 3 +--
drivers/media/i2c/ths7303.c | 4 +---
drivers/media/i2c/ths8200.c | 4 +---
drivers/media/i2c/tlv320aic23b.c | 3 +--
drivers/media/i2c/tvaudio.c | 3 +--
drivers/media/i2c/tvp514x.c | 3 +--
drivers/media/i2c/tvp5150.c | 4 +---
drivers/media/i2c/tvp7002.c | 3 +--
drivers/media/i2c/tw2804.c | 3 +--
drivers/media/i2c/tw9903.c | 3 +--
drivers/media/i2c/tw9906.c | 3 +--
drivers/media/i2c/tw9910.c | 4 +---
drivers/media/i2c/uda1342.c | 3 +--
drivers/media/i2c/upd64031a.c | 3 +--
drivers/media/i2c/upd64083.c | 3 +--
drivers/media/i2c/video-i2c.c | 4 +---
drivers/media/i2c/vp27smpx.c | 3 +--
drivers/media/i2c/vpx3220.c | 4 +---
drivers/media/i2c/vs6624.c | 3 +--
drivers/media/i2c/wm8739.c | 3 +--
drivers/media/i2c/wm8775.c | 3 +--
drivers/media/radio/radio-tea5764.c | 3 +--
drivers/media/radio/saa7706h.c | 3 +--
drivers/media/radio/si470x/radio-si470x-i2c.c | 3 +--
drivers/media/radio/si4713/si4713.c | 4 +---
drivers/media/radio/tef6862.c | 3 +--
drivers/media/test-drivers/vidtv/vidtv_demod.c | 4 +---
drivers/media/test-drivers/vidtv/vidtv_tuner.c | 4 +---
drivers/media/tuners/e4000.c | 4 +---
drivers/media/tuners/fc2580.c | 3 +--
drivers/media/tuners/m88rs6000t.c | 4 +---
drivers/media/tuners/mt2060.c | 4 +---
drivers/media/tuners/mxl301rf.c | 3 +--
drivers/media/tuners/qm1d1b0004.c | 3 +--
drivers/media/tuners/qm1d1c0042.c | 3 +--
drivers/media/tuners/si2157.c | 4 +---
drivers/media/tuners/tda18212.c | 4 +---
drivers/media/tuners/tda18250.c | 4 +---
drivers/media/tuners/tua9001.c | 3 +--
drivers/media/usb/go7007/s2250-board.c | 3 +--
drivers/media/v4l2-core/tuner-core.c | 3 +--
drivers/mfd/88pm800.c | 4 +---
drivers/mfd/88pm805.c | 4 +---
drivers/mfd/88pm860x-core.c | 3 +--
drivers/mfd/acer-ec-a500.c | 4 +---
drivers/mfd/arizona-i2c.c | 4 +---
drivers/mfd/axp20x-i2c.c | 4 +---
drivers/mfd/da903x.c | 3 +--
drivers/mfd/da9052-i2c.c | 3 +--
drivers/mfd/da9055-i2c.c | 4 +---
drivers/mfd/da9062-core.c | 4 +---
drivers/mfd/da9150-core.c | 4 +---
drivers/mfd/dm355evm_msp.c | 3 +--
drivers/mfd/ene-kb3930.c | 4 +---
drivers/mfd/gateworks-gsc.c | 4 +---
drivers/mfd/intel_soc_pmic_core.c | 4 +---
drivers/mfd/iqs62x.c | 4 +---
drivers/mfd/lm3533-core.c | 4 +---
drivers/mfd/lp8788.c | 3 +--
drivers/mfd/madera-i2c.c | 4 +---
drivers/mfd/max14577.c | 4 +---
drivers/mfd/max77693.c | 4 +---
drivers/mfd/max8907.c | 4 +---
drivers/mfd/max8925-i2c.c | 3 +--
drivers/mfd/mc13xxx-i2c.c | 3 +--
drivers/mfd/menelaus.c | 3 +--
drivers/mfd/ntxec.c | 4 +---
drivers/mfd/palmas.c | 4 +---
drivers/mfd/pcf50633-core.c | 4 +---
drivers/mfd/retu-mfd.c | 4 +---
drivers/mfd/rk808.c | 4 +---
drivers/mfd/rn5t618.c | 4 +---
drivers/mfd/rsmu_i2c.c | 4 +---
drivers/mfd/rt4831.c | 4 +---
drivers/mfd/si476x-i2c.c | 4 +---
drivers/mfd/stmfx.c | 4 +---
drivers/mfd/stmpe-i2c.c | 4 +---
drivers/mfd/tc3589x.c | 4 +---
drivers/mfd/tps6105x.c | 4 +---
drivers/mfd/tps65010.c | 3 +--
drivers/mfd/tps65086.c | 4 +---
drivers/mfd/tps65217.c | 4 +---
drivers/mfd/tps6586x.c | 3 +--
drivers/mfd/tps65912-i2c.c | 4 +---
drivers/mfd/twl-core.c | 3 +--
drivers/mfd/twl6040.c | 4 +---
drivers/mfd/wm8994-core.c | 4 +---
drivers/misc/ad525x_dpot-i2c.c | 3 +--
drivers/misc/apds9802als.c | 3 +--
drivers/misc/apds990x.c | 3 +--
drivers/misc/bh1770glc.c | 4 +---
drivers/misc/ds1682.c | 3 +--
drivers/misc/eeprom/at24.c | 4 +---
drivers/misc/eeprom/ee1004.c | 4 +---
drivers/misc/eeprom/eeprom.c | 4 +---
drivers/misc/eeprom/idt_89hpesx.c | 4 +---
drivers/misc/eeprom/max6875.c | 4 +---
drivers/misc/hmc6352.c | 3 +--
drivers/misc/ics932s401.c | 5 ++---
drivers/misc/isl29003.c | 3 +--
drivers/misc/isl29020.c | 3 +--
drivers/misc/lis3lv02d/lis3lv02d_i2c.c | 3 +--
drivers/misc/tsl2550.c | 4 +---
drivers/mtd/maps/pismo.c | 4 +---
drivers/net/dsa/lan9303_i2c.c | 6 ++----
drivers/net/dsa/microchip/ksz9477_i2c.c | 4 +---
drivers/net/dsa/xrs700x/xrs700x_i2c.c | 6 ++----
drivers/net/ethernet/mellanox/mlxsw/i2c.c | 4 +---
drivers/net/mctp/mctp-i2c.c | 4 +---
drivers/nfc/fdp/i2c.c | 4 +---
drivers/nfc/microread/i2c.c | 4 +---
drivers/nfc/nfcmrvl/i2c.c | 4 +---
drivers/nfc/nxp-nci/i2c.c | 4 +---
drivers/nfc/pn533/i2c.c | 4 +---
drivers/nfc/pn544/i2c.c | 4 +---
drivers/nfc/s3fwrn5/i2c.c | 4 +---
drivers/nfc/st-nci/i2c.c | 4 +---
drivers/nfc/st21nfca/i2c.c | 4 +---
drivers/of/unittest.c | 6 ++----
drivers/platform/chrome/cros_ec_i2c.c | 4 +---
drivers/platform/surface/surface3_power.c | 4 +---
drivers/platform/x86/asus-tf103c-dock.c | 4 +---
drivers/platform/x86/intel/int3472/tps68470.c | 4 +---
drivers/power/supply/bq2415x_charger.c | 4 +---
drivers/power/supply/bq24190_charger.c | 4 +---
drivers/power/supply/bq24257_charger.c | 4 +---
drivers/power/supply/bq25890_charger.c | 4 +---
drivers/power/supply/bq27xxx_battery_i2c.c | 4 +---
drivers/power/supply/cw2015_battery.c | 3 +--
drivers/power/supply/ds2782_battery.c | 4 +---
drivers/power/supply/lp8727_charger.c | 3 +--
drivers/power/supply/rt5033_battery.c | 4 +---
drivers/power/supply/rt9455_charger.c | 4 +---
drivers/power/supply/smb347-charger.c | 4 +---
drivers/power/supply/z2_battery.c | 4 +---
drivers/pwm/pwm-pca9685.c | 4 +---
drivers/regulator/da9121-regulator.c | 3 +--
drivers/regulator/lp8755.c | 4 +---
drivers/regulator/rpi-panel-attiny-regulator.c | 4 +---
drivers/rtc/rtc-bq32k.c | 4 +---
drivers/rtc/rtc-ds1374.c | 4 +---
drivers/rtc/rtc-isl12026.c | 3 +--
drivers/rtc/rtc-m41t80.c | 4 +---
drivers/rtc/rtc-rs5c372.c | 3 +--
drivers/rtc/rtc-x1205.c | 3 +--
drivers/staging/media/atomisp/i2c/atomisp-gc0310.c | 4 +---
drivers/staging/media/atomisp/i2c/atomisp-gc2235.c | 4 +---
drivers/staging/media/atomisp/i2c/atomisp-lm3554.c | 4 +---
drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c | 3 +--
drivers/staging/media/atomisp/i2c/atomisp-ov2680.c | 4 +---
drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 4 +---
.../media/atomisp/i2c/ov5693/atomisp-ov5693.c | 4 +---
drivers/staging/media/max96712/max96712.c | 4 +---
drivers/staging/most/i2c/i2c.c | 4 +---
drivers/staging/olpc_dcon/olpc_dcon.c | 4 +---
drivers/tty/serial/max310x.c | 4 +---
drivers/tty/serial/sc16is7xx.c | 4 +---
drivers/usb/misc/usb3503.c | 4 +---
drivers/usb/phy/phy-isp1301-omap.c | 4 +---
drivers/usb/phy/phy-isp1301.c | 4 +---
drivers/usb/typec/anx7411.c | 4 +---
drivers/usb/typec/hd3ss3220.c | 4 +---
drivers/usb/typec/mux/fsa4480.c | 4 +---
drivers/usb/typec/mux/pi3usb30532.c | 3 +--
drivers/usb/typec/rt1719.c | 4 +---
drivers/usb/typec/stusb160x.c | 4 +---
drivers/usb/typec/tcpm/fusb302.c | 4 +---
drivers/usb/typec/tcpm/tcpci.c | 4 +---
drivers/usb/typec/tcpm/tcpci_maxim.c | 4 +---
drivers/usb/typec/tcpm/tcpci_rt1711h.c | 3 +--
drivers/usb/typec/tipd/core.c | 4 +---
drivers/usb/typec/ucsi/ucsi_ccg.c | 4 +---
drivers/usb/typec/ucsi/ucsi_stm32g0.c | 4 +---
drivers/usb/typec/wusb3801.c | 4 +---
drivers/video/backlight/adp8860_bl.c | 4 +---
drivers/video/backlight/adp8870_bl.c | 4 +---
drivers/video/backlight/arcxcnn_bl.c | 4 +---
drivers/video/backlight/bd6107.c | 4 +---
drivers/video/backlight/lm3630a_bl.c | 3 +--
drivers/video/backlight/lm3639_bl.c | 3 +--
drivers/video/backlight/lp855x_bl.c | 4 +---
drivers/video/backlight/lv5207lp.c | 4 +---
drivers/video/backlight/tosa_bl.c | 3 +--
drivers/video/fbdev/matrox/matroxfb_maven.c | 3 +--
drivers/video/fbdev/ssd1307fb.c | 4 +---
drivers/w1/masters/ds2482.c | 3 +--
drivers/watchdog/ziirave_wdt.c | 4 +---
include/linux/i2c.h | 2 +-
include/linux/platform_data/pca953x.h | 2 +-
sound/aoa/codecs/onyx.c | 3 +--
sound/aoa/codecs/tas.c | 3 +--
sound/pci/hda/cs35l41_hda_i2c.c | 4 +---
sound/ppc/keywest.c | 6 ++----
sound/soc/codecs/adau1761-i2c.c | 3 +--
sound/soc/codecs/adau1781-i2c.c | 3 +--
sound/soc/codecs/ak4375.c | 4 +---
sound/soc/codecs/ak4458.c | 4 +---
sound/soc/codecs/ak4641.c | 4 +---
sound/soc/codecs/ak5558.c | 4 +---
sound/soc/codecs/cs35l32.c | 4 +---
sound/soc/codecs/cs35l33.c | 4 +---
sound/soc/codecs/cs35l34.c | 4 +---
sound/soc/codecs/cs35l35.c | 4 +---
sound/soc/codecs/cs35l36.c | 4 +---
sound/soc/codecs/cs35l41-i2c.c | 4 +---
sound/soc/codecs/cs35l45-i2c.c | 4 +---
sound/soc/codecs/cs4234.c | 4 +---
sound/soc/codecs/cs4265.c | 4 +---
sound/soc/codecs/cs4270.c | 4 +---
sound/soc/codecs/cs42l42.c | 4 +---
sound/soc/codecs/cs42l51-i2c.c | 4 +---
sound/soc/codecs/cs42l56.c | 3 +--
sound/soc/codecs/cs42xx8-i2c.c | 4 +---
sound/soc/codecs/cs43130.c | 4 +---
sound/soc/codecs/cs4349.c | 4 +---
sound/soc/codecs/cs53l30.c | 4 +---
sound/soc/codecs/cx2072x.c | 3 +--
sound/soc/codecs/max98090.c | 4 +---
sound/soc/codecs/max9860.c | 3 +--
sound/soc/codecs/max98927.c | 4 +---
sound/soc/codecs/mt6660.c | 3 +--
sound/soc/codecs/nau8825.c | 6 ++----
sound/soc/codecs/pcm1789-i2c.c | 4 +---
sound/soc/codecs/pcm3168a-i2c.c | 4 +---
sound/soc/codecs/pcm512x-i2c.c | 3 +--
sound/soc/codecs/rt274.c | 4 +---
sound/soc/codecs/rt286.c | 4 +---
sound/soc/codecs/rt298.c | 4 +---
sound/soc/codecs/rt5616.c | 6 ++----
sound/soc/codecs/rt5631.c | 6 ++----
sound/soc/codecs/rt5645.c | 4 +---
sound/soc/codecs/rt5663.c | 4 +---
sound/soc/codecs/rt5670.c | 4 +---
sound/soc/codecs/rt5677.c | 4 +---
sound/soc/codecs/rt5682-i2c.c | 4 +---
sound/soc/codecs/rt5682s.c | 4 +---
sound/soc/codecs/rt9120.c | 3 +--
sound/soc/codecs/sgtl5000.c | 4 +---
sound/soc/codecs/sta350.c | 6 ++----
sound/soc/codecs/tas2552.c | 3 +--
sound/soc/codecs/tas5086.c | 6 ++----
sound/soc/codecs/tas571x.c | 4 +---
sound/soc/codecs/tas5805m.c | 3 +--
sound/soc/codecs/tas6424.c | 4 +---
sound/soc/codecs/tlv320adc3xxx.c | 3 +--
sound/soc/codecs/tlv320aic32x4-i2c.c | 4 +---
sound/soc/codecs/tlv320aic3x-i2c.c | 4 +---
sound/soc/codecs/tlv320dac33.c | 4 +---
sound/soc/codecs/wm1250-ev1.c | 4 +---
sound/soc/codecs/wm2200.c | 4 +---
sound/soc/codecs/wm5100.c | 4 +---
sound/soc/codecs/wm8804-i2c.c | 3 +--
sound/soc/codecs/wm8900.c | 6 ++----
sound/soc/codecs/wm8903.c | 4 +---
sound/soc/codecs/wm8960.c | 6 ++----
sound/soc/codecs/wm8962.c | 3 +--
sound/soc/codecs/wm8993.c | 4 +---
sound/soc/codecs/wm8996.c | 4 +---
sound/soc/codecs/wm9081.c | 6 ++----
622 files changed, 660 insertions(+), 1762 deletions(-)
base-commit: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868
--
2.36.1
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH v2 1/6] drm/i2c/sil164: Drop no-op remove function
2022-08-15 8:02 ` Uwe Kleine-König
@ 2022-08-15 8:02 ` Uwe Kleine-König
-1 siblings, 0 replies; 22+ messages in thread
From: Uwe Kleine-König @ 2022-08-15 8:02 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-i2c, kernel, David Airlie, Daniel Vetter, dri-devel
A remove callback that just returns 0 is equivalent to no callback at all
as can be seen in i2c_device_remove(). So simplify accordingly.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/gpu/drm/i2c/sil164_drv.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/gpu/drm/i2c/sil164_drv.c b/drivers/gpu/drm/i2c/sil164_drv.c
index 741886b54419..1bc0b5de4499 100644
--- a/drivers/gpu/drm/i2c/sil164_drv.c
+++ b/drivers/gpu/drm/i2c/sil164_drv.c
@@ -370,12 +370,6 @@ sil164_probe(struct i2c_client *client, const struct i2c_device_id *id)
return 0;
}
-static int
-sil164_remove(struct i2c_client *client)
-{
- return 0;
-}
-
static struct i2c_client *
sil164_detect_slave(struct i2c_client *client)
{
@@ -427,7 +421,6 @@ MODULE_DEVICE_TABLE(i2c, sil164_ids);
static struct drm_i2c_encoder_driver sil164_driver = {
.i2c_driver = {
.probe = sil164_probe,
- .remove = sil164_remove,
.driver = {
.name = "sil164",
},
--
2.36.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v2 1/6] drm/i2c/sil164: Drop no-op remove function
@ 2022-08-15 8:02 ` Uwe Kleine-König
0 siblings, 0 replies; 22+ messages in thread
From: Uwe Kleine-König @ 2022-08-15 8:02 UTC (permalink / raw)
To: Wolfram Sang; +Cc: David Airlie, dri-devel, linux-i2c, kernel
A remove callback that just returns 0 is equivalent to no callback at all
as can be seen in i2c_device_remove(). So simplify accordingly.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/gpu/drm/i2c/sil164_drv.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/gpu/drm/i2c/sil164_drv.c b/drivers/gpu/drm/i2c/sil164_drv.c
index 741886b54419..1bc0b5de4499 100644
--- a/drivers/gpu/drm/i2c/sil164_drv.c
+++ b/drivers/gpu/drm/i2c/sil164_drv.c
@@ -370,12 +370,6 @@ sil164_probe(struct i2c_client *client, const struct i2c_device_id *id)
return 0;
}
-static int
-sil164_remove(struct i2c_client *client)
-{
- return 0;
-}
-
static struct i2c_client *
sil164_detect_slave(struct i2c_client *client)
{
@@ -427,7 +421,6 @@ MODULE_DEVICE_TABLE(i2c, sil164_ids);
static struct drm_i2c_encoder_driver sil164_driver = {
.i2c_driver = {
.probe = sil164_probe,
- .remove = sil164_remove,
.driver = {
.name = "sil164",
},
--
2.36.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v2 2/6] leds: lm3697: Remove duplicated error reporting in .remove()
2022-08-15 8:02 ` Uwe Kleine-König
(?)
(?)
@ 2022-08-15 8:02 ` Uwe Kleine-König
2022-08-16 10:37 ` Wolfram Sang
-1 siblings, 1 reply; 22+ messages in thread
From: Uwe Kleine-König @ 2022-08-15 8:02 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-i2c, kernel, Pavel Machek, linux-leds
Returning an error value from an i2c remove callback results in an error
message being emitted by the i2c core, but otherwise it doesn't make a
difference. The device goes away anyhow and the devm cleanups are
called.
As lm3697_remove() already emits an error message on failure and the
additional error message by the i2c core doesn't add any useful
information, don't pass the error value up the stack. Instead continue
to clean up and return 0.
This patch is a preparation for making i2c remove callbacks return void.
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/leds/leds-lm3697.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/leds/leds-lm3697.c b/drivers/leds/leds-lm3697.c
index a8c9322558cc..3ecf90fbc06c 100644
--- a/drivers/leds/leds-lm3697.c
+++ b/drivers/leds/leds-lm3697.c
@@ -345,10 +345,8 @@ static int lm3697_remove(struct i2c_client *client)
ret = regmap_update_bits(led->regmap, LM3697_CTRL_ENABLE,
LM3697_CTRL_A_B_EN, 0);
- if (ret) {
+ if (ret)
dev_err(dev, "Failed to disable the device\n");
- return ret;
- }
if (led->enable_gpio)
gpiod_direction_output(led->enable_gpio, 0);
--
2.36.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v2 3/6] leds: lm3601x: Don't use mutex after it was destroyed
2022-08-15 8:02 ` Uwe Kleine-König
` (2 preceding siblings ...)
(?)
@ 2022-08-15 8:02 ` Uwe Kleine-König
2022-08-16 10:38 ` Wolfram Sang
-1 siblings, 1 reply; 22+ messages in thread
From: Uwe Kleine-König @ 2022-08-15 8:02 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-i2c, kernel, Pavel Machek
The mutex might still be in use until the devm cleanup callback
devm_led_classdev_flash_release() is called. This only happens some time
after lm3601x_remove() completed.
Fixes: e63a744871a3 ("leds: lm3601x: Convert class registration to device managed")
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/leds/flash/leds-lm3601x.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/leds/flash/leds-lm3601x.c b/drivers/leds/flash/leds-lm3601x.c
index d0e1d4814042..3d1272748201 100644
--- a/drivers/leds/flash/leds-lm3601x.c
+++ b/drivers/leds/flash/leds-lm3601x.c
@@ -444,8 +444,6 @@ static int lm3601x_remove(struct i2c_client *client)
{
struct lm3601x_led *led = i2c_get_clientdata(client);
- mutex_destroy(&led->lock);
-
return regmap_update_bits(led->regmap, LM3601X_ENABLE_REG,
LM3601X_ENABLE_MASK,
LM3601X_MODE_STANDBY);
--
2.36.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v2 4/6] leds: lm3601x: Improve error reporting for problems during .remove()
2022-08-15 8:02 ` Uwe Kleine-König
` (3 preceding siblings ...)
(?)
@ 2022-08-15 8:02 ` Uwe Kleine-König
2022-08-16 10:38 ` Wolfram Sang
-1 siblings, 1 reply; 22+ messages in thread
From: Uwe Kleine-König @ 2022-08-15 8:02 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-i2c, kernel, Pavel Machek
Returning an error value in an i2c remove callback results in a generic
error message being emitted by the i2c core, but otherwise it doesn't
make a difference. The device goes away anyhow and the devm cleanups are
called.
So instead of triggering the generic i2c error message, emit a more
helpful message if a problem occurs and return 0 to suppress the generic
message.
This patch is a preparation for making i2c remove callbacks return void.
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/leds/flash/leds-lm3601x.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/leds/flash/leds-lm3601x.c b/drivers/leds/flash/leds-lm3601x.c
index 3d1272748201..37e1d6e68687 100644
--- a/drivers/leds/flash/leds-lm3601x.c
+++ b/drivers/leds/flash/leds-lm3601x.c
@@ -443,10 +443,15 @@ static int lm3601x_probe(struct i2c_client *client)
static int lm3601x_remove(struct i2c_client *client)
{
struct lm3601x_led *led = i2c_get_clientdata(client);
+ int ret;
- return regmap_update_bits(led->regmap, LM3601X_ENABLE_REG,
- LM3601X_ENABLE_MASK,
- LM3601X_MODE_STANDBY);
+ ret = regmap_update_bits(led->regmap, LM3601X_ENABLE_REG,
+ LM3601X_ENABLE_MASK, LM3601X_MODE_STANDBY);
+ if (ret)
+ dev_warn(&client->dev,
+ "Failed to put into standby (%pe)\n", ERR_PTR(ret));
+
+ return 0;
}
static const struct i2c_device_id lm3601x_id[] = {
--
2.36.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* [PATCH v2 5/6] gpio: pca953x: Make platform teardown callback return void
2022-08-15 8:02 ` Uwe Kleine-König
` (4 preceding siblings ...)
(?)
@ 2022-08-15 8:02 ` Uwe Kleine-König
2022-08-15 14:21 ` Bartosz Golaszewski
` (2 more replies)
-1 siblings, 3 replies; 22+ messages in thread
From: Uwe Kleine-König @ 2022-08-15 8:02 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-i2c, kernel, Bartosz Golaszewski, Sekhar Nori, Andy Shevchenko
All platforms that provide a teardown callback return 0. New users are
supposed to not make use of platform support, so there is no
functionality lost.
This patch is a preparation for making i2c remove callbacks return void.
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
arch/arm/mach-davinci/board-da850-evm.c | 12 ++++--------
drivers/gpio/gpio-pca953x.c | 11 +++--------
include/linux/platform_data/pca953x.h | 2 +-
3 files changed, 8 insertions(+), 17 deletions(-)
diff --git a/arch/arm/mach-davinci/board-da850-evm.c b/arch/arm/mach-davinci/board-da850-evm.c
index 92d74bc71967..d752ee2b30ff 100644
--- a/arch/arm/mach-davinci/board-da850-evm.c
+++ b/arch/arm/mach-davinci/board-da850-evm.c
@@ -516,8 +516,8 @@ static int da850_evm_ui_expander_setup(struct i2c_client *client, unsigned gpio,
return ret;
}
-static int da850_evm_ui_expander_teardown(struct i2c_client *client,
- unsigned gpio, unsigned ngpio, void *c)
+static void da850_evm_ui_expander_teardown(struct i2c_client *client,
+ unsigned gpio, unsigned ngpio, void *c)
{
platform_device_unregister(&da850_evm_ui_keys_device);
@@ -529,8 +529,6 @@ static int da850_evm_ui_expander_teardown(struct i2c_client *client,
gpio_free(gpio + DA850_EVM_UI_EXP_SEL_C);
gpio_free(gpio + DA850_EVM_UI_EXP_SEL_B);
gpio_free(gpio + DA850_EVM_UI_EXP_SEL_A);
-
- return 0;
}
/* assign the baseboard expander's GPIOs after the UI board's */
@@ -697,13 +695,11 @@ static int da850_evm_bb_expander_setup(struct i2c_client *client,
return ret;
}
-static int da850_evm_bb_expander_teardown(struct i2c_client *client,
- unsigned gpio, unsigned ngpio, void *c)
+static void da850_evm_bb_expander_teardown(struct i2c_client *client,
+ unsigned gpio, unsigned ngpio, void *c)
{
platform_device_unregister(&da850_evm_bb_leds_device);
platform_device_unregister(&da850_evm_bb_keys_device);
-
- return 0;
}
static struct pca953x_platform_data da850_evm_ui_expander_info = {
diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
index ecd7d169470b..1860e566eb94 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -1105,20 +1105,15 @@ static int pca953x_remove(struct i2c_client *client)
{
struct pca953x_platform_data *pdata = dev_get_platdata(&client->dev);
struct pca953x_chip *chip = i2c_get_clientdata(client);
- int ret;
if (pdata && pdata->teardown) {
- ret = pdata->teardown(client, chip->gpio_chip.base,
- chip->gpio_chip.ngpio, pdata->context);
- if (ret < 0)
- dev_err(&client->dev, "teardown failed, %d\n", ret);
- } else {
- ret = 0;
+ pdata->teardown(client, chip->gpio_chip.base,
+ chip->gpio_chip.ngpio, pdata->context);
}
regulator_disable(chip->regulator);
- return ret;
+ return 0;
}
#ifdef CONFIG_PM_SLEEP
diff --git a/include/linux/platform_data/pca953x.h b/include/linux/platform_data/pca953x.h
index 4eb53e023997..96c1a14ab365 100644
--- a/include/linux/platform_data/pca953x.h
+++ b/include/linux/platform_data/pca953x.h
@@ -22,7 +22,7 @@ struct pca953x_platform_data {
int (*setup)(struct i2c_client *client,
unsigned gpio, unsigned ngpio,
void *context);
- int (*teardown)(struct i2c_client *client,
+ void (*teardown)(struct i2c_client *client,
unsigned gpio, unsigned ngpio,
void *context);
const char *const *names;
--
2.36.1
^ permalink raw reply related [flat|nested] 22+ messages in thread
* Re: [PATCH v2 6/6] i2c: Make remove callback return void
[not found] ` <20220815080230.37408-7-u.kleine-koenig@pengutronix.de>
@ 2022-08-15 8:50 ` Uwe Kleine-König
2022-08-16 8:34 ` Crt Mori
2022-08-16 10:39 ` Wolfram Sang
1 sibling, 1 reply; 22+ messages in thread
From: Uwe Kleine-König @ 2022-08-15 8:50 UTC (permalink / raw)
To: Wolfram Sang
Cc: Benjamin Mugnier, Heikki Krogerus, Crt Mori, Ajay Gupta,
Peter Senna Tschudin, Sebastian Reichel, Andrey Ryabinin,
linux-i2c, Pavel Machek, Srinivas Pandruvada, Jeremy Kerr,
Matt Johnston, Corey Minyard, Jean Delvare, Marek Behún,
Javier Martinez Canillas, Christophe Leroy, Andy Shevchenko,
Adrien Grassein, Miguel Ojeda, Luca Ceresoli, Hans Verkuil,
Krzysztof Hałasa, Jonathan Cameron, Andy Shevchenko,
Petr Machata, Greg Kroah-Hartman, Dmitry Torokhov, Miguel Ojeda,
kernel, Luca Ceresoli, Vladimir Oltean, Maximilian Luz,
Peter Rosin
[-- Attachment #1: Type: text/plain, Size: 1300 bytes --]
Hello,
On Mon, Aug 15, 2022 at 10:02:30AM +0200, Uwe Kleine-König wrote:
> The value returned by an i2c driver's remove function is mostly ignored.
> (Only an error message is printed if the value is non-zero that the
> error is ignored.)
>
> So change the prototype of the remove function to return no value. This
> way driver authors are not tempted to assume that passing an error to
> the upper layer is a good idea. All drivers are adapted accordingly.
> There is no intended change of behaviour, all callbacks were prepared to
> return 0 before.
>
> [...]
> ---
> [...]
> 619 files changed, 646 insertions(+), 1733 deletions(-)
There seems to be a 300k limit for mails on vger.kernel.org, so this
patch didn't make it to the list. Please get it from
https://git.pengutronix.de/git/ukl/linux i2c-remove-void
or
https://git.pengutronix.de/cgit/ukl/linux/commit/?h=i2c-remove-void
or send me a (private) mail, then I can bounce you the message to
properly reply to it. (Or if that is enough for you: The Message-Id is
<20220815080230.37408-7-u.kleine-koenig@pengutronix.de>.)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v2 5/6] gpio: pca953x: Make platform teardown callback return void
2022-08-15 8:02 ` [PATCH v2 5/6] gpio: pca953x: Make platform teardown callback return void Uwe Kleine-König
@ 2022-08-15 14:21 ` Bartosz Golaszewski
2022-08-16 8:16 ` Andy Shevchenko
2022-08-16 10:38 ` Wolfram Sang
2 siblings, 0 replies; 22+ messages in thread
From: Bartosz Golaszewski @ 2022-08-15 14:21 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Wolfram Sang, linux-i2c, Sascha Hauer, Sekhar Nori, Andy Shevchenko
On Mon, Aug 15, 2022 at 10:02 AM Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
>
> All platforms that provide a teardown callback return 0. New users are
> supposed to not make use of platform support, so there is no
> functionality lost.
>
> This patch is a preparation for making i2c remove callbacks return void.
>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> arch/arm/mach-davinci/board-da850-evm.c | 12 ++++--------
> drivers/gpio/gpio-pca953x.c | 11 +++--------
> include/linux/platform_data/pca953x.h | 2 +-
> 3 files changed, 8 insertions(+), 17 deletions(-)
>
> diff --git a/arch/arm/mach-davinci/board-da850-evm.c b/arch/arm/mach-davinci/board-da850-evm.c
> index 92d74bc71967..d752ee2b30ff 100644
> --- a/arch/arm/mach-davinci/board-da850-evm.c
> +++ b/arch/arm/mach-davinci/board-da850-evm.c
> @@ -516,8 +516,8 @@ static int da850_evm_ui_expander_setup(struct i2c_client *client, unsigned gpio,
> return ret;
> }
>
> -static int da850_evm_ui_expander_teardown(struct i2c_client *client,
> - unsigned gpio, unsigned ngpio, void *c)
> +static void da850_evm_ui_expander_teardown(struct i2c_client *client,
> + unsigned gpio, unsigned ngpio, void *c)
> {
> platform_device_unregister(&da850_evm_ui_keys_device);
>
> @@ -529,8 +529,6 @@ static int da850_evm_ui_expander_teardown(struct i2c_client *client,
> gpio_free(gpio + DA850_EVM_UI_EXP_SEL_C);
> gpio_free(gpio + DA850_EVM_UI_EXP_SEL_B);
> gpio_free(gpio + DA850_EVM_UI_EXP_SEL_A);
> -
> - return 0;
> }
>
> /* assign the baseboard expander's GPIOs after the UI board's */
> @@ -697,13 +695,11 @@ static int da850_evm_bb_expander_setup(struct i2c_client *client,
> return ret;
> }
>
> -static int da850_evm_bb_expander_teardown(struct i2c_client *client,
> - unsigned gpio, unsigned ngpio, void *c)
> +static void da850_evm_bb_expander_teardown(struct i2c_client *client,
> + unsigned gpio, unsigned ngpio, void *c)
> {
> platform_device_unregister(&da850_evm_bb_leds_device);
> platform_device_unregister(&da850_evm_bb_keys_device);
> -
> - return 0;
> }
>
> static struct pca953x_platform_data da850_evm_ui_expander_info = {
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index ecd7d169470b..1860e566eb94 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -1105,20 +1105,15 @@ static int pca953x_remove(struct i2c_client *client)
> {
> struct pca953x_platform_data *pdata = dev_get_platdata(&client->dev);
> struct pca953x_chip *chip = i2c_get_clientdata(client);
> - int ret;
>
> if (pdata && pdata->teardown) {
> - ret = pdata->teardown(client, chip->gpio_chip.base,
> - chip->gpio_chip.ngpio, pdata->context);
> - if (ret < 0)
> - dev_err(&client->dev, "teardown failed, %d\n", ret);
> - } else {
> - ret = 0;
> + pdata->teardown(client, chip->gpio_chip.base,
> + chip->gpio_chip.ngpio, pdata->context);
> }
>
> regulator_disable(chip->regulator);
>
> - return ret;
> + return 0;
> }
>
> #ifdef CONFIG_PM_SLEEP
> diff --git a/include/linux/platform_data/pca953x.h b/include/linux/platform_data/pca953x.h
> index 4eb53e023997..96c1a14ab365 100644
> --- a/include/linux/platform_data/pca953x.h
> +++ b/include/linux/platform_data/pca953x.h
> @@ -22,7 +22,7 @@ struct pca953x_platform_data {
> int (*setup)(struct i2c_client *client,
> unsigned gpio, unsigned ngpio,
> void *context);
> - int (*teardown)(struct i2c_client *client,
> + void (*teardown)(struct i2c_client *client,
> unsigned gpio, unsigned ngpio,
> void *context);
> const char *const *names;
> --
> 2.36.1
>
Acked-by: Bartosz Golaszewski <brgl@bgdev.pl>
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v2 5/6] gpio: pca953x: Make platform teardown callback return void
2022-08-15 8:02 ` [PATCH v2 5/6] gpio: pca953x: Make platform teardown callback return void Uwe Kleine-König
2022-08-15 14:21 ` Bartosz Golaszewski
@ 2022-08-16 8:16 ` Andy Shevchenko
2022-08-16 8:18 ` Andy Shevchenko
2022-08-16 10:38 ` Wolfram Sang
2 siblings, 1 reply; 22+ messages in thread
From: Andy Shevchenko @ 2022-08-16 8:16 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Wolfram Sang, linux-i2c, Sascha Hauer, Bartosz Golaszewski, Sekhar Nori
On Mon, Aug 15, 2022 at 11:02 AM Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
>
> All platforms that provide a teardown callback return 0. New users are
> supposed to not make use of platform support, so there is no
> functionality lost.
>
> This patch is a preparation for making i2c remove callbacks return void.
In case you need to send another version, consider below...
...
> if (pdata && pdata->teardown) {
> - ret = pdata->teardown(client, chip->gpio_chip.base,
> - chip->gpio_chip.ngpio, pdata->context);
> - if (ret < 0)
> - dev_err(&client->dev, "teardown failed, %d\n", ret);
> - } else {
> - ret = 0;
> + pdata->teardown(client, chip->gpio_chip.base,
> + chip->gpio_chip.ngpio, pdata->context);
> }
First of all, after this change the {} should not be needed.
Second, with a temporary variable
struct gpio_chip *gc = &chip->gpio_chip;
this becomes a one liner like
pdata->teardown(client, gc->base, gc->ngpio, pdata->context);
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v2 5/6] gpio: pca953x: Make platform teardown callback return void
2022-08-16 8:16 ` Andy Shevchenko
@ 2022-08-16 8:18 ` Andy Shevchenko
0 siblings, 0 replies; 22+ messages in thread
From: Andy Shevchenko @ 2022-08-16 8:18 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Wolfram Sang, linux-i2c, Sascha Hauer, Bartosz Golaszewski, Sekhar Nori
On Tue, Aug 16, 2022 at 11:16 AM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Mon, Aug 15, 2022 at 11:02 AM Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
> >
> > All platforms that provide a teardown callback return 0. New users are
> > supposed to not make use of platform support, so there is no
> > functionality lost.
> >
> > This patch is a preparation for making i2c remove callbacks return void.
>
> In case you need to send another version, consider below...
(forgot to add) otherwise it can be a follow up.
> > if (pdata && pdata->teardown) {
> > - ret = pdata->teardown(client, chip->gpio_chip.base,
> > - chip->gpio_chip.ngpio, pdata->context);
> > - if (ret < 0)
> > - dev_err(&client->dev, "teardown failed, %d\n", ret);
> > - } else {
> > - ret = 0;
> > + pdata->teardown(client, chip->gpio_chip.base,
> > + chip->gpio_chip.ngpio, pdata->context);
> > }
>
> First of all, after this change the {} should not be needed.
> Second, with a temporary variable
>
> struct gpio_chip *gc = &chip->gpio_chip;
>
> this becomes a one liner like
>
> pdata->teardown(client, gc->base, gc->ngpio, pdata->context);
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v2 6/6] i2c: Make remove callback return void
2022-08-15 8:50 ` [PATCH v2 6/6] i2c: Make remove " Uwe Kleine-König
@ 2022-08-16 8:34 ` Crt Mori
0 siblings, 0 replies; 22+ messages in thread
From: Crt Mori @ 2022-08-16 8:34 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: linux-i2c, Jonathan Cameron
For mlx90614 and mlx90632:
Acked-by: Crt Mori<cmo@melexis.com>
Best regards,
Crt
On Mon, 15 Aug 2022 at 10:50, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
>
> Hello,
>
> On Mon, Aug 15, 2022 at 10:02:30AM +0200, Uwe Kleine-König wrote:
> > The value returned by an i2c driver's remove function is mostly ignored.
> > (Only an error message is printed if the value is non-zero that the
> > error is ignored.)
> >
> > So change the prototype of the remove function to return no value. This
> > way driver authors are not tempted to assume that passing an error to
> > the upper layer is a good idea. All drivers are adapted accordingly.
> > There is no intended change of behaviour, all callbacks were prepared to
> > return 0 before.
> >
> > [...]
> > ---
> > [...]
> > 619 files changed, 646 insertions(+), 1733 deletions(-)
>
> There seems to be a 300k limit for mails on vger.kernel.org, so this
> patch didn't make it to the list. Please get it from
>
> https://git.pengutronix.de/git/ukl/linux i2c-remove-void
>
> or
>
> https://git.pengutronix.de/cgit/ukl/linux/commit/?h=i2c-remove-void
>
> or send me a (private) mail, then I can bounce you the message to
> properly reply to it. (Or if that is enough for you: The Message-Id is
> <20220815080230.37408-7-u.kleine-koenig@pengutronix.de>.)
>
> Best regards
> Uwe
>
> --
> Pengutronix e.K. | Uwe Kleine-König |
> Industrial Linux Solutions | https://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v2 1/6] drm/i2c/sil164: Drop no-op remove function
2022-08-15 8:02 ` Uwe Kleine-König
@ 2022-08-16 10:37 ` Wolfram Sang
-1 siblings, 0 replies; 22+ messages in thread
From: Wolfram Sang @ 2022-08-16 10:37 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: David Airlie, dri-devel, linux-i2c, kernel
[-- Attachment #1: Type: text/plain, Size: 330 bytes --]
On Mon, Aug 15, 2022 at 10:02:25AM +0200, Uwe Kleine-König wrote:
> A remove callback that just returns 0 is equivalent to no callback at all
> as can be seen in i2c_device_remove(). So simplify accordingly.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied to an immutable branch, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v2 1/6] drm/i2c/sil164: Drop no-op remove function
@ 2022-08-16 10:37 ` Wolfram Sang
0 siblings, 0 replies; 22+ messages in thread
From: Wolfram Sang @ 2022-08-16 10:37 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: linux-i2c, kernel, David Airlie, Daniel Vetter, dri-devel
[-- Attachment #1: Type: text/plain, Size: 330 bytes --]
On Mon, Aug 15, 2022 at 10:02:25AM +0200, Uwe Kleine-König wrote:
> A remove callback that just returns 0 is equivalent to no callback at all
> as can be seen in i2c_device_remove(). So simplify accordingly.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied to an immutable branch, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v2 2/6] leds: lm3697: Remove duplicated error reporting in .remove()
2022-08-15 8:02 ` [PATCH v2 2/6] leds: lm3697: Remove duplicated error reporting in .remove() Uwe Kleine-König
@ 2022-08-16 10:37 ` Wolfram Sang
0 siblings, 0 replies; 22+ messages in thread
From: Wolfram Sang @ 2022-08-16 10:37 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: linux-i2c, kernel, Pavel Machek, linux-leds
[-- Attachment #1: Type: text/plain, Size: 781 bytes --]
On Mon, Aug 15, 2022 at 10:02:26AM +0200, Uwe Kleine-König wrote:
> Returning an error value from an i2c remove callback results in an error
> message being emitted by the i2c core, but otherwise it doesn't make a
> difference. The device goes away anyhow and the devm cleanups are
> called.
>
> As lm3697_remove() already emits an error message on failure and the
> additional error message by the i2c core doesn't add any useful
> information, don't pass the error value up the stack. Instead continue
> to clean up and return 0.
>
> This patch is a preparation for making i2c remove callbacks return void.
>
> Acked-by: Pavel Machek <pavel@ucw.cz>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied to an immutable branch, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v2 3/6] leds: lm3601x: Don't use mutex after it was destroyed
2022-08-15 8:02 ` [PATCH v2 3/6] leds: lm3601x: Don't use mutex after it was destroyed Uwe Kleine-König
@ 2022-08-16 10:38 ` Wolfram Sang
0 siblings, 0 replies; 22+ messages in thread
From: Wolfram Sang @ 2022-08-16 10:38 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: linux-i2c, kernel, Pavel Machek
[-- Attachment #1: Type: text/plain, Size: 492 bytes --]
On Mon, Aug 15, 2022 at 10:02:27AM +0200, Uwe Kleine-König wrote:
> The mutex might still be in use until the devm cleanup callback
> devm_led_classdev_flash_release() is called. This only happens some time
> after lm3601x_remove() completed.
>
> Fixes: e63a744871a3 ("leds: lm3601x: Convert class registration to device managed")
> Acked-by: Pavel Machek <pavel@ucw.cz>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied to an immutable branch, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v2 4/6] leds: lm3601x: Improve error reporting for problems during .remove()
2022-08-15 8:02 ` [PATCH v2 4/6] leds: lm3601x: Improve error reporting for problems during .remove() Uwe Kleine-König
@ 2022-08-16 10:38 ` Wolfram Sang
0 siblings, 0 replies; 22+ messages in thread
From: Wolfram Sang @ 2022-08-16 10:38 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: linux-i2c, kernel, Pavel Machek
[-- Attachment #1: Type: text/plain, Size: 703 bytes --]
On Mon, Aug 15, 2022 at 10:02:28AM +0200, Uwe Kleine-König wrote:
> Returning an error value in an i2c remove callback results in a generic
> error message being emitted by the i2c core, but otherwise it doesn't
> make a difference. The device goes away anyhow and the devm cleanups are
> called.
>
> So instead of triggering the generic i2c error message, emit a more
> helpful message if a problem occurs and return 0 to suppress the generic
> message.
>
> This patch is a preparation for making i2c remove callbacks return void.
>
> Acked-by: Pavel Machek <pavel@ucw.cz>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied to an immutable branch, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v2 5/6] gpio: pca953x: Make platform teardown callback return void
2022-08-15 8:02 ` [PATCH v2 5/6] gpio: pca953x: Make platform teardown callback return void Uwe Kleine-König
2022-08-15 14:21 ` Bartosz Golaszewski
2022-08-16 8:16 ` Andy Shevchenko
@ 2022-08-16 10:38 ` Wolfram Sang
2 siblings, 0 replies; 22+ messages in thread
From: Wolfram Sang @ 2022-08-16 10:38 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: linux-i2c, kernel, Bartosz Golaszewski, Sekhar Nori, Andy Shevchenko
[-- Attachment #1: Type: text/plain, Size: 485 bytes --]
On Mon, Aug 15, 2022 at 10:02:29AM +0200, Uwe Kleine-König wrote:
> All platforms that provide a teardown callback return 0. New users are
> supposed to not make use of platform support, so there is no
> functionality lost.
>
> This patch is a preparation for making i2c remove callbacks return void.
>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied to an immutable branch, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v2 6/6] i2c: Make remove callback return void
[not found] ` <20220815080230.37408-7-u.kleine-koenig@pengutronix.de>
2022-08-15 8:50 ` [PATCH v2 6/6] i2c: Make remove " Uwe Kleine-König
@ 2022-08-16 10:39 ` Wolfram Sang
1 sibling, 0 replies; 22+ messages in thread
From: Wolfram Sang @ 2022-08-16 10:39 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: linux-i2c, kernel, Andy Shevchenko, Matt Johnston,
Peter Senna Tschudin, Benjamin Mugnier, Crt Mori, Jeremy Kerr,
Javier Martinez Canillas, Christophe Leroy, Greg Kroah-Hartman,
Marek Behún, Petr Machata, Andrey Ryabinin, Maximilian Luz,
Srinivas Pandruvada, Hans Verkuil, Miguel Ojeda, Luca Ceresoli,
Luca Ceresoli, Heikki Krogerus, Ajay Gupta, Jonathan Cameron,
Peter Rosin, Adrien Grassein, Jean Delvare, Corey Minyard,
Vladimir Oltean, Dmitry Torokhov, Sebastian Reichel,
Pavel Machek, Krzysztof Hałasa, Andy Shevchenko,
Miguel Ojeda
[-- Attachment #1: Type: text/plain, Size: 2453 bytes --]
On Mon, Aug 15, 2022 at 10:02:30AM +0200, Uwe Kleine-König wrote:
> The value returned by an i2c driver's remove function is mostly ignored.
> (Only an error message is printed if the value is non-zero that the
> error is ignored.)
>
> So change the prototype of the remove function to return no value. This
> way driver authors are not tempted to assume that passing an error to
> the upper layer is a good idea. All drivers are adapted accordingly.
> There is no intended change of behaviour, all callbacks were prepared to
> return 0 before.
>
> Reviewed-by: Peter Senna Tschudin <peter.senna@gmail.com>
> Reviewed-by: Jeremy Kerr <jk@codeconstruct.com.au>
> Reviewed-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
> Reviewed-by: Crt Mori <cmo@melexis.com>
> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Acked-by: Marek Behún <kabel@kernel.org> # for leds-turris-omnia
> Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Petr Machata <petrm@nvidia.com> # for mlxsw
> Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com> # for surface3_power
> Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> # for bmc150-accel-i2c + kxcjk-1013
> Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> # for media/* + staging/media/*
> Acked-by: Miguel Ojeda <ojeda@kernel.org> # for auxdisplay/ht16k33 + auxdisplay/lcd2s
> Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net> # for versaclock5
> Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com> # for versaclock5
> Reviewed-by: Ajay Gupta <ajayg@nvidia.com> # for ucsi_ccg
> Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> # for iio
> Acked-by: Peter Rosin <peda@axentia.se> # for i2c-mux-*, max9860
> Acked-by: Adrien Grassein <adrien.grassein@gmail.com> # for lontium-lt8912b
> Reviewed-by: Jean Delvare <jdelvare@suse.de> # for hwmon, i2c-core and i2c/muxes
> Acked-by: Corey Minyard <cninyard@mvista.com> # for IPMI
> Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com> # for drivers/power
> Acked-by: Krzysztof Hałasa <khalasa@piap.pl>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Applied to an immutable branch, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v2 0/6] i2c: Make remove callback return void
2022-08-15 8:02 ` Uwe Kleine-König
@ 2022-08-16 10:59 ` Wolfram Sang
-1 siblings, 0 replies; 22+ messages in thread
From: Wolfram Sang @ 2022-08-16 10:59 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Benjamin Mugnier, Heikki Krogerus, Crt Mori, Ajay Gupta,
David Airlie, Peter Senna Tschudin, Sekhar Nori, dri-devel,
Sebastian Reichel, Andrey Ryabinin, linux-i2c, Pavel Machek,
Srinivas Pandruvada, Jeremy Kerr, Matt Johnston, Corey Minyard,
linux-leds, Marek Behún, Bartosz Golaszewski,
Javier Martinez Canillas, Christophe Leroy, Andy Shevchenko,
Adrien Grassein, Luca Ceresoli, kernel, Jean Delvare,
Luca Ceresoli, Krzysztof Hałasa, Jonathan Cameron,
Petr Machata, Greg Kroah-Hartman, Dmitry Torokhov, Miguel Ojeda,
Hans Verkuil, Vladimir Oltean, Maximilian Luz, Peter Rosin
[-- Attachment #1: Type: text/plain, Size: 393 bytes --]
> As some conflicts are expected I sent this early after -rc1 such that it
> can be included early into next and be put on an immutable branch for
> subsystems to resolve merge conflicts.
I pushed the series out now, so it should hit -next tomorrow.
The immutable branch is here:
git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/make_remove_callback_void-immutable
Enjoy!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH v2 0/6] i2c: Make remove callback return void
@ 2022-08-16 10:59 ` Wolfram Sang
0 siblings, 0 replies; 22+ messages in thread
From: Wolfram Sang @ 2022-08-16 10:59 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: linux-i2c, kernel, David Airlie, Daniel Vetter, dri-devel,
Pavel Machek, linux-leds, Bartosz Golaszewski, Sekhar Nori,
Andy Shevchenko, Matt Johnston, Peter Senna Tschudin,
Benjamin Mugnier, Crt Mori, Jeremy Kerr,
Javier Martinez Canillas, Christophe Leroy, Greg Kroah-Hartman,
Marek Behún, Petr Machata, Andrey Ryabinin, Maximilian Luz,
Srinivas Pandruvada, Hans Verkuil, Miguel Ojeda, Luca Ceresoli,
Luca Ceresoli, Heikki Krogerus, Ajay Gupta, Jonathan Cameron,
Peter Rosin, Adrien Grassein, Jean Delvare, Corey Minyard,
Vladimir Oltean, Dmitry Torokhov, Sebastian Reichel,
Krzysztof Hałasa
[-- Attachment #1: Type: text/plain, Size: 393 bytes --]
> As some conflicts are expected I sent this early after -rc1 such that it
> can be included early into next and be put on an immutable branch for
> subsystems to resolve merge conflicts.
I pushed the series out now, so it should hit -next tomorrow.
The immutable branch is here:
git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/make_remove_callback_void-immutable
Enjoy!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread
end of thread, other threads:[~2022-08-16 11:35 UTC | newest]
Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-15 8:02 [PATCH v2 0/6] i2c: Make remove callback return void Uwe Kleine-König
2022-08-15 8:02 ` Uwe Kleine-König
2022-08-15 8:02 ` [PATCH v2 1/6] drm/i2c/sil164: Drop no-op remove function Uwe Kleine-König
2022-08-15 8:02 ` Uwe Kleine-König
2022-08-16 10:37 ` Wolfram Sang
2022-08-16 10:37 ` Wolfram Sang
2022-08-15 8:02 ` [PATCH v2 2/6] leds: lm3697: Remove duplicated error reporting in .remove() Uwe Kleine-König
2022-08-16 10:37 ` Wolfram Sang
2022-08-15 8:02 ` [PATCH v2 3/6] leds: lm3601x: Don't use mutex after it was destroyed Uwe Kleine-König
2022-08-16 10:38 ` Wolfram Sang
2022-08-15 8:02 ` [PATCH v2 4/6] leds: lm3601x: Improve error reporting for problems during .remove() Uwe Kleine-König
2022-08-16 10:38 ` Wolfram Sang
2022-08-15 8:02 ` [PATCH v2 5/6] gpio: pca953x: Make platform teardown callback return void Uwe Kleine-König
2022-08-15 14:21 ` Bartosz Golaszewski
2022-08-16 8:16 ` Andy Shevchenko
2022-08-16 8:18 ` Andy Shevchenko
2022-08-16 10:38 ` Wolfram Sang
[not found] ` <20220815080230.37408-7-u.kleine-koenig@pengutronix.de>
2022-08-15 8:50 ` [PATCH v2 6/6] i2c: Make remove " Uwe Kleine-König
2022-08-16 8:34 ` Crt Mori
2022-08-16 10:39 ` Wolfram Sang
2022-08-16 10:59 ` [PATCH v2 0/6] " Wolfram Sang
2022-08-16 10:59 ` Wolfram Sang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.