Re: [PATCH v2] driver core: Fix bus_type.match() error handling

From: Isaac Manjarres <isaacmanjarres@google.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Tomeu Vizoso <tomeu.vizoso@collabora.com>,
	Russell King <rmk+kernel@arm.linux.org.uk>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Saravana Kannan <saravanak@google.com>,
	stable@kernel.org, kernel-team@android.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] driver core: Fix bus_type.match() error handling
Date: Tue, 16 Aug 2022 18:12:30 -0700	[thread overview]
Message-ID: <YvxAfiSOrzy7/c1J@google.com> (raw)
In-Reply-To: <20220817010559.GA1880847@roeck-us.net>

On Tue, Aug 16, 2022 at 06:05:59PM -0700, Guenter Roeck wrote:
> On Tue, Aug 16, 2022 at 10:13:28AM -0700, Isaac Manjarres wrote:
> > On Tue, Aug 16, 2022 at 04:13:11AM -0700, Guenter Roeck wrote:
> > > On Mon, Aug 15, 2022 at 10:17:23PM -0700, Isaac Manjarres wrote:
> > > > On Mon, Aug 15, 2022 at 09:25:07PM -0700, Guenter Roeck wrote:
> > > > > > v1 -> v2:
> > > > > > - Fixed the logic in __driver_attach() to allow a driver to continue
> > > > > >   attempting to match and bind with devices in case of any error, not
> > > > > >   just probe deferral.
> > > > > > 
> > > > > > Guenter,
> > > > > > 
> > > > > > Can you please give test this patch to make sure it still works for you?
> > > > > > 
> > > > > 
> > > > > Not as well as v1. I still see the clk crash with versatileab, and imx25-pdk
> > > > > emulations now stall during boot when trying to boot from usb.
> > > > > 
> > > > > Guenter
> > > > Thanks for trying the patch out. This patch isn't meant to fix the clk
> > > > crash that you mentioned on another thread. I had made the following patch for
> > > > that: https://lore.kernel.org/lkml/YvqTvuqSll30Rv2k@google.com/. Have
> > > > you been able to give that a shot yet? If not can you please test with the
> > > > patch in this e-mail and that patch?
> > > > 
> > > 
> > > No, sorry, I missed that one. It does not apply, though - it is whitespace
> > > corrupted. I tried to fix it up, but that failed.
> > 
> > When applying the patch, can you please try with
> > git apply --ignore-whitespace ? That worked for me.
> 
> Ok, that worked. With the above patch, the problems with sx1 and versatileab
> are gone.

Good to hear! Thanks for testing that patch out.
> However, imx25-pdk fails to shut down when booting from usb
> drive. I cross checked that this does not happen without the above patch.
> 
> Guenter

Can you please share the following for your imx25-pdk environment?
qemu commandline, defconfig, dtb, and baseline kernel commit you're
using for testing.

Thanks,
Isaac