* [Intel-gfx] [PATCH] drm/i915/display: clear plane color control register when turn plane off
@ 2022-08-01 15:16 Lee Shawn C
2022-08-01 21:27 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Lee Shawn C @ 2022-08-01 15:16 UTC (permalink / raw)
To: intel-gfx
Customer report abnormal display output while switch eDP off sometimes.
In current display disable flow, plane will be off at first. Then turn
eDP off and disable HW pipe line. We found the abnormal pixel comes
after turn plane off. Clear plane color ctl register when driver disable
plane can solve this symptom.
Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
Reviewed-by: Uma Shankar <uma.shankar@intel.com>
---
drivers/gpu/drm/i915/display/skl_universal_plane.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
index caa03324a733..90977cfb7ebb 100644
--- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
+++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
@@ -620,6 +620,8 @@ skl_plane_disable_arm(struct intel_plane *plane,
intel_de_write_fw(dev_priv, PLANE_CTL(pipe, plane_id), 0);
intel_de_write_fw(dev_priv, PLANE_SURF(pipe, plane_id), 0);
+ if (DISPLAY_VER(dev_priv) >= 10)
+ intel_de_write_fw(dev_priv, PLANE_COLOR_CTL(pipe, plane_id), 0);
}
static void
@@ -638,6 +640,7 @@ icl_plane_disable_arm(struct intel_plane *plane,
intel_psr2_disable_plane_sel_fetch(plane, crtc_state);
intel_de_write_fw(dev_priv, PLANE_CTL(pipe, plane_id), 0);
intel_de_write_fw(dev_priv, PLANE_SURF(pipe, plane_id), 0);
+ intel_de_write_fw(dev_priv, PLANE_COLOR_CTL(pipe, plane_id), 0);
}
static bool
--
2.17.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: clear plane color control register when turn plane off
2022-08-01 15:16 [Intel-gfx] [PATCH] drm/i915/display: clear plane color control register when turn plane off Lee Shawn C
@ 2022-08-01 21:27 ` Patchwork
2022-08-31 12:33 ` [Intel-gfx] [PATCH] " Ville Syrjälä
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2022-08-01 21:27 UTC (permalink / raw)
To: Lee Shawn C; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 14260 bytes --]
== Series Details ==
Series: drm/i915/display: clear plane color control register when turn plane off
URL : https://patchwork.freedesktop.org/series/106883/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11960 -> Patchwork_106883v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_106883v1 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_106883v1, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v1/index.html
Participating hosts (43 -> 41)
------------------------------
Additional (2): bat-rpls-1 fi-icl-u2
Missing (4): fi-ctg-p8600 fi-hsw-4770 fi-bdw-samus fi-hsw-4200u
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_106883v1:
### IGT changes ###
#### Possible regressions ####
* igt@i915_pm_rpm@module-reload:
- fi-skl-6600u: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11960/fi-skl-6600u/igt@i915_pm_rpm@module-reload.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v1/fi-skl-6600u/igt@i915_pm_rpm@module-reload.html
* igt@kms_cursor_legacy@basic-flip-after-cursor@atomic-transitions:
- fi-adl-ddr5: [PASS][3] -> [DMESG-WARN][4] +4 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11960/fi-adl-ddr5/igt@kms_cursor_legacy@basic-flip-after-cursor@atomic-transitions.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v1/fi-adl-ddr5/igt@kms_cursor_legacy@basic-flip-after-cursor@atomic-transitions.html
- fi-rkl-guc: [PASS][5] -> [DMESG-WARN][6] +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11960/fi-rkl-guc/igt@kms_cursor_legacy@basic-flip-after-cursor@atomic-transitions.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v1/fi-rkl-guc/igt@kms_cursor_legacy@basic-flip-after-cursor@atomic-transitions.html
* igt@kms_cursor_legacy@basic-flip-before-cursor@atomic-transitions:
- fi-rkl-11600: [PASS][7] -> [DMESG-WARN][8] +4 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11960/fi-rkl-11600/igt@kms_cursor_legacy@basic-flip-before-cursor@atomic-transitions.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v1/fi-rkl-11600/igt@kms_cursor_legacy@basic-flip-before-cursor@atomic-transitions.html
* igt@kms_flip@basic-plain-flip@c-hdmi-a2:
- bat-dg1-6: [PASS][9] -> [DMESG-WARN][10] +55 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11960/bat-dg1-6/igt@kms_flip@basic-plain-flip@c-hdmi-a2.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v1/bat-dg1-6/igt@kms_flip@basic-plain-flip@c-hdmi-a2.html
* {igt@kms_pipe_crc_basic@compare-crc-sanitycheck@pipe-a-dp-2} (NEW):
- {bat-rpls-1}: NOTRUN -> [DMESG-WARN][11]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v1/bat-rpls-1/igt@kms_pipe_crc_basic@compare-crc-sanitycheck@pipe-a-dp-2.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@kms_cursor_legacy@basic-flip-after-cursor@atomic-transitions:
- {fi-ehl-2}: [PASS][12] -> [DMESG-WARN][13] +4 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11960/fi-ehl-2/igt@kms_cursor_legacy@basic-flip-after-cursor@atomic-transitions.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v1/fi-ehl-2/igt@kms_cursor_legacy@basic-flip-after-cursor@atomic-transitions.html
* igt@kms_cursor_legacy@basic-flip-before-cursor@atomic-transitions:
- {bat-rplp-1}: [PASS][14] -> [DMESG-WARN][15] +3 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11960/bat-rplp-1/igt@kms_cursor_legacy@basic-flip-before-cursor@atomic-transitions.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v1/bat-rplp-1/igt@kms_cursor_legacy@basic-flip-before-cursor@atomic-transitions.html
- {bat-rpls-2}: [PASS][16] -> [DMESG-WARN][17] +8 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11960/bat-rpls-2/igt@kms_cursor_legacy@basic-flip-before-cursor@atomic-transitions.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v1/bat-rpls-2/igt@kms_cursor_legacy@basic-flip-before-cursor@atomic-transitions.html
* igt@kms_cursor_legacy@basic-flip-before-cursor@atomic-transitions-varying-size:
- {fi-jsl-1}: [PASS][18] -> [DMESG-WARN][19] +4 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11960/fi-jsl-1/igt@kms_cursor_legacy@basic-flip-before-cursor@atomic-transitions-varying-size.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v1/fi-jsl-1/igt@kms_cursor_legacy@basic-flip-before-cursor@atomic-transitions-varying-size.html
* igt@kms_force_connector_basic@force-connector-state:
- {bat-jsl-1}: [PASS][20] -> [DMESG-WARN][21] +35 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11960/bat-jsl-1/igt@kms_force_connector_basic@force-connector-state.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v1/bat-jsl-1/igt@kms_force_connector_basic@force-connector-state.html
* igt@kms_frontbuffer_tracking@basic:
- {bat-rpls-1}: NOTRUN -> [DMESG-FAIL][22]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v1/bat-rpls-1/igt@kms_frontbuffer_tracking@basic.html
- {bat-dg2-9}: [PASS][23] -> [DMESG-WARN][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11960/bat-dg2-9/igt@kms_frontbuffer_tracking@basic.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v1/bat-dg2-9/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_pipe_crc_basic@nonblocking-crc@pipe-b-dp-2:
- {bat-rpls-1}: NOTRUN -> [DMESG-WARN][25] +8 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v1/bat-rpls-1/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-b-dp-2.html
* igt@kms_pipe_crc_basic@read-crc@pipe-b-edp-1:
- {bat-jsl-1}: [PASS][26] -> [DMESG-FAIL][27] +13 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11960/bat-jsl-1/igt@kms_pipe_crc_basic@read-crc@pipe-b-edp-1.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v1/bat-jsl-1/igt@kms_pipe_crc_basic@read-crc@pipe-b-edp-1.html
New tests
---------
New tests have been introduced between CI_DRM_11960 and Patchwork_106883v1:
### New IGT tests (6) ###
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck@pipe-a-dp-2:
- Statuses : 1 dmesg-warn(s)
- Exec time: [0.74] s
* igt@kms_pipe_crc_basic@hang-read-crc@pipe-a-dp-2:
- Statuses : 1 pass(s)
- Exec time: [1.88] s
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-a-dp-2:
- Statuses : 1 pass(s)
- Exec time: [1.09] s
* igt@kms_pipe_crc_basic@nonblocking-crc@pipe-a-dp-2:
- Statuses : 1 pass(s)
- Exec time: [1.09] s
* igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-a-dp-2:
- Statuses : 1 pass(s)
- Exec time: [0.95] s
* igt@kms_pipe_crc_basic@read-crc@pipe-a-dp-2:
- Statuses : 1 pass(s)
- Exec time: [0.96] s
Known issues
------------
Here are the changes found in Patchwork_106883v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_huc_copy@huc-copy:
- fi-icl-u2: NOTRUN -> [SKIP][28] ([i915#2190])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v1/fi-icl-u2/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@random-engines:
- fi-icl-u2: NOTRUN -> [SKIP][29] ([i915#4613]) +3 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v1/fi-icl-u2/igt@gem_lmem_swapping@random-engines.html
* igt@i915_suspend@basic-s2idle-without-i915:
- fi-bdw-gvtdvm: NOTRUN -> [INCOMPLETE][30] ([i915#4817])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v1/fi-bdw-gvtdvm/igt@i915_suspend@basic-s2idle-without-i915.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-icl-u2: NOTRUN -> [SKIP][31] ([i915#5903] / [i915#6316])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v1/fi-icl-u2/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u2: NOTRUN -> [SKIP][32] ([fdo#111827] / [i915#6316]) +8 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v1/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
- fi-icl-u2: NOTRUN -> [SKIP][33] ([i915#4103])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v1/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor.html
* igt@kms_cursor_legacy@basic-flip-before-cursor@toggle:
- fi-icl-u2: NOTRUN -> [DMESG-WARN][34] ([i915#6316]) +35 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v1/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-before-cursor@toggle.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-icl-u2: NOTRUN -> [SKIP][35] ([fdo#109285])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v1/fi-icl-u2/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_pipe_crc_basic@hang-read-crc@pipe-a-edp-1:
- fi-icl-u2: NOTRUN -> [DMESG-FAIL][36] ([i915#6316]) +6 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v1/fi-icl-u2/igt@kms_pipe_crc_basic@hang-read-crc@pipe-a-edp-1.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-icl-u2: NOTRUN -> [SKIP][37] ([i915#3555] / [i915#6316])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v1/fi-icl-u2/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-userptr:
- fi-icl-u2: NOTRUN -> [SKIP][38] ([fdo#109295] / [i915#3301])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v1/fi-icl-u2/igt@prime_vgem@basic-userptr.html
#### Possible fixes ####
* igt@core_hotunplug@unbind-rebind:
- {bat-dg2-9}: [DMESG-WARN][39] ([i915#5763]) -> [PASS][40] +10 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11960/bat-dg2-9/igt@core_hotunplug@unbind-rebind.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v1/bat-dg2-9/igt@core_hotunplug@unbind-rebind.html
* igt@gem_lmem_swapping@random-engines@lmem0:
- {bat-dg2-8}: [INCOMPLETE][41] ([i915#5763]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11960/bat-dg2-8/igt@gem_lmem_swapping@random-engines@lmem0.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v1/bat-dg2-8/igt@gem_lmem_swapping@random-engines@lmem0.html
* igt@i915_selftest@live@execlists:
- fi-bdw-gvtdvm: [INCOMPLETE][43] ([i915#2940]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11960/fi-bdw-gvtdvm/igt@i915_selftest@live@execlists.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v1/fi-bdw-gvtdvm/igt@i915_selftest@live@execlists.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#3003]: https://gitlab.freedesktop.org/drm/intel/issues/3003
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#5087]: https://gitlab.freedesktop.org/drm/intel/issues/5087
[i915#5763]: https://gitlab.freedesktop.org/drm/intel/issues/5763
[i915#5903]: https://gitlab.freedesktop.org/drm/intel/issues/5903
[i915#5954]: https://gitlab.freedesktop.org/drm/intel/issues/5954
[i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257
[i915#6316]: https://gitlab.freedesktop.org/drm/intel/issues/6316
Build changes
-------------
* Linux: CI_DRM_11960 -> Patchwork_106883v1
CI-20190529: 20190529
CI_DRM_11960: 16ef7aef4dd813fae8ef0ccf50fd69f1c0e8cf11 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6605: 1596683606cafa391f5d8f6b68e0c888233c0738 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_106883v1: 16ef7aef4dd813fae8ef0ccf50fd69f1c0e8cf11 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
ef762ebf4506 drm/i915/display: clear plane color control register when turn plane off
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v1/index.html
[-- Attachment #2: Type: text/html, Size: 15103 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: clear plane color control register when turn plane off
2022-08-01 15:16 [Intel-gfx] [PATCH] drm/i915/display: clear plane color control register when turn plane off Lee Shawn C
2022-08-01 21:27 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
@ 2022-08-31 12:33 ` Ville Syrjälä
2022-08-31 13:27 ` Lee, Shawn C
2022-11-02 18:28 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/display: clear plane color control register when turn plane off (rev2) Patchwork
2022-11-02 18:50 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
3 siblings, 1 reply; 7+ messages in thread
From: Ville Syrjälä @ 2022-08-31 12:33 UTC (permalink / raw)
To: Lee Shawn C; +Cc: intel-gfx
On Mon, Aug 01, 2022 at 11:16:16PM +0800, Lee Shawn C wrote:
> Customer report abnormal display output while switch eDP off sometimes.
> In current display disable flow, plane will be off at first. Then turn
> eDP off and disable HW pipe line. We found the abnormal pixel comes
> after turn plane off. Clear plane color ctl register when driver disable
> plane can solve this symptom.
>
> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
> Reviewed-by: Uma Shankar <uma.shankar@intel.com>
> ---
> drivers/gpu/drm/i915/display/skl_universal_plane.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> index caa03324a733..90977cfb7ebb 100644
> --- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
> +++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> @@ -620,6 +620,8 @@ skl_plane_disable_arm(struct intel_plane *plane,
>
> intel_de_write_fw(dev_priv, PLANE_CTL(pipe, plane_id), 0);
> intel_de_write_fw(dev_priv, PLANE_SURF(pipe, plane_id), 0);
> + if (DISPLAY_VER(dev_priv) >= 10)
> + intel_de_write_fw(dev_priv, PLANE_COLOR_CTL(pipe, plane_id), 0);
> }
>
> static void
> @@ -638,6 +640,7 @@ icl_plane_disable_arm(struct intel_plane *plane,
> intel_psr2_disable_plane_sel_fetch(plane, crtc_state);
> intel_de_write_fw(dev_priv, PLANE_CTL(pipe, plane_id), 0);
> intel_de_write_fw(dev_priv, PLANE_SURF(pipe, plane_id), 0);
> + intel_de_write_fw(dev_priv, PLANE_COLOR_CTL(pipe, plane_id), 0);
This makes no sense. The register value shouldn't even get latched
since you wrote the arming register (PLANE_SURF) before this one.
What platform is the problematic machine?
> }
>
> static bool
> --
> 2.17.1
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: clear plane color control register when turn plane off
2022-08-31 12:33 ` [Intel-gfx] [PATCH] " Ville Syrjälä
@ 2022-08-31 13:27 ` Lee, Shawn C
2022-08-31 13:43 ` Ville Syrjälä
0 siblings, 1 reply; 7+ messages in thread
From: Lee, Shawn C @ 2022-08-31 13:27 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
On Wed, August 31, 2022 8:33 PM, Ville Syrjälä wrote:
>On Mon, Aug 01, 2022 at 11:16:16PM +0800, Lee Shawn C wrote:
>> Customer report abnormal display output while switch eDP off sometimes.
>> In current display disable flow, plane will be off at first. Then turn
>> eDP off and disable HW pipe line. We found the abnormal pixel comes
>> after turn plane off. Clear plane color ctl register when driver
>> disable plane can solve this symptom.
>>
>> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
>> Reviewed-by: Uma Shankar <uma.shankar@intel.com>
>> ---
>> drivers/gpu/drm/i915/display/skl_universal_plane.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c
>> b/drivers/gpu/drm/i915/display/skl_universal_plane.c
>> index caa03324a733..90977cfb7ebb 100644
>> --- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
>> +++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
>> @@ -620,6 +620,8 @@ skl_plane_disable_arm(struct intel_plane *plane,
>>
>> intel_de_write_fw(dev_priv, PLANE_CTL(pipe, plane_id), 0);
>> intel_de_write_fw(dev_priv, PLANE_SURF(pipe, plane_id), 0);
>> + if (DISPLAY_VER(dev_priv) >= 10)
>> + intel_de_write_fw(dev_priv, PLANE_COLOR_CTL(pipe, plane_id), 0);
>> }
>>
>> static void
>> @@ -638,6 +640,7 @@ icl_plane_disable_arm(struct intel_plane *plane,
>> intel_psr2_disable_plane_sel_fetch(plane, crtc_state);
>> intel_de_write_fw(dev_priv, PLANE_CTL(pipe, plane_id), 0);
>> intel_de_write_fw(dev_priv, PLANE_SURF(pipe, plane_id), 0);
>> + intel_de_write_fw(dev_priv, PLANE_COLOR_CTL(pipe, plane_id), 0);
>
>This makes no sense. The register value shouldn't even get latched since you wrote the arming register (PLANE_SURF) before this one.
>
>What platform is the problematic machine?
>
ADL-P
Best regards,
Shawn
>> }
>>
>> static bool
>> --
>> 2.17.1
>
>--
>Ville Syrjälä
>Intel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/display: clear plane color control register when turn plane off
2022-08-31 13:27 ` Lee, Shawn C
@ 2022-08-31 13:43 ` Ville Syrjälä
0 siblings, 0 replies; 7+ messages in thread
From: Ville Syrjälä @ 2022-08-31 13:43 UTC (permalink / raw)
To: 20220801151616.12644-1-shawn.c.lee; +Cc: intel-gfx
On Wed, Aug 31, 2022 at 01:27:24PM +0000, Lee, Shawn C wrote:
> On Wed, August 31, 2022 8:33 PM, Ville Syrjälä wrote:
> >On Mon, Aug 01, 2022 at 11:16:16PM +0800, Lee Shawn C wrote:
> >> Customer report abnormal display output while switch eDP off sometimes.
> >> In current display disable flow, plane will be off at first. Then turn
> >> eDP off and disable HW pipe line. We found the abnormal pixel comes
> >> after turn plane off. Clear plane color ctl register when driver
> >> disable plane can solve this symptom.
> >>
> >> Signed-off-by: Lee Shawn C <shawn.c.lee@intel.com>
> >> Reviewed-by: Uma Shankar <uma.shankar@intel.com>
> >> ---
> >> drivers/gpu/drm/i915/display/skl_universal_plane.c | 3 +++
> >> 1 file changed, 3 insertions(+)
> >>
> >> diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c
> >> b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> >> index caa03324a733..90977cfb7ebb 100644
> >> --- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
> >> +++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> >> @@ -620,6 +620,8 @@ skl_plane_disable_arm(struct intel_plane *plane,
> >>
> >> intel_de_write_fw(dev_priv, PLANE_CTL(pipe, plane_id), 0);
> >> intel_de_write_fw(dev_priv, PLANE_SURF(pipe, plane_id), 0);
> >> + if (DISPLAY_VER(dev_priv) >= 10)
> >> + intel_de_write_fw(dev_priv, PLANE_COLOR_CTL(pipe, plane_id), 0);
> >> }
> >>
> >> static void
> >> @@ -638,6 +640,7 @@ icl_plane_disable_arm(struct intel_plane *plane,
> >> intel_psr2_disable_plane_sel_fetch(plane, crtc_state);
> >> intel_de_write_fw(dev_priv, PLANE_CTL(pipe, plane_id), 0);
> >> intel_de_write_fw(dev_priv, PLANE_SURF(pipe, plane_id), 0);
> >> + intel_de_write_fw(dev_priv, PLANE_COLOR_CTL(pipe, plane_id), 0);
> >
> >This makes no sense. The register value shouldn't even get latched since you wrote the arming register (PLANE_SURF) before this one.
> >
> >What platform is the problematic machine?
> >
>
> ADL-P
PSR related?
Do you have commit 031a2fea0482 ("drm/i915/psr: Disable PSR before disable pipe")?
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/display: clear plane color control register when turn plane off (rev2)
2022-08-01 15:16 [Intel-gfx] [PATCH] drm/i915/display: clear plane color control register when turn plane off Lee Shawn C
2022-08-01 21:27 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2022-08-31 12:33 ` [Intel-gfx] [PATCH] " Ville Syrjälä
@ 2022-11-02 18:28 ` Patchwork
2022-11-02 18:50 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2022-11-02 18:28 UTC (permalink / raw)
To: Lee, Shawn C; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/display: clear plane color control register when turn plane off (rev2)
URL : https://patchwork.freedesktop.org/series/106883/
State : warning
== Summary ==
Error: make htmldocs had i915 warnings
./drivers/gpu/drm/i915/i915_perf_types.h:319: warning: Function parameter or member 'lock' not described in 'i915_perf_stream'
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: clear plane color control register when turn plane off (rev2)
2022-08-01 15:16 [Intel-gfx] [PATCH] drm/i915/display: clear plane color control register when turn plane off Lee Shawn C
` (2 preceding siblings ...)
2022-11-02 18:28 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/display: clear plane color control register when turn plane off (rev2) Patchwork
@ 2022-11-02 18:50 ` Patchwork
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2022-11-02 18:50 UTC (permalink / raw)
To: Lee, Shawn C; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 8833 bytes --]
== Series Details ==
Series: drm/i915/display: clear plane color control register when turn plane off (rev2)
URL : https://patchwork.freedesktop.org/series/106883/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12332 -> Patchwork_106883v2
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_106883v2 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_106883v2, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v2/index.html
Participating hosts (40 -> 29)
------------------------------
Missing (11): bat-dg2-8 bat-adlm-1 bat-dg2-9 bat-adlp-6 bat-adlp-4 bat-adln-1 bat-rplp-1 bat-rpls-1 bat-rpls-2 bat-dg2-11 bat-jsl-1
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_106883v2:
### IGT changes ###
#### Possible regressions ####
* igt@kms_cursor_legacy@basic-flip-after-cursor@atomic-transitions:
- fi-adl-ddr5: [PASS][1] -> [DMESG-WARN][2] +4 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/fi-adl-ddr5/igt@kms_cursor_legacy@basic-flip-after-cursor@atomic-transitions.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v2/fi-adl-ddr5/igt@kms_cursor_legacy@basic-flip-after-cursor@atomic-transitions.html
* igt@kms_cursor_legacy@basic-flip-before-cursor@atomic-transitions-varying-size:
- fi-rkl-guc: [PASS][3] -> [DMESG-WARN][4] +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/fi-rkl-guc/igt@kms_cursor_legacy@basic-flip-before-cursor@atomic-transitions-varying-size.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v2/fi-rkl-guc/igt@kms_cursor_legacy@basic-flip-before-cursor@atomic-transitions-varying-size.html
* igt@kms_pipe_crc_basic@hang-read-crc@pipe-a-edp-1:
- fi-icl-u2: [PASS][5] -> [DMESG-FAIL][6] +6 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/fi-icl-u2/igt@kms_pipe_crc_basic@hang-read-crc@pipe-a-edp-1.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v2/fi-icl-u2/igt@kms_pipe_crc_basic@hang-read-crc@pipe-a-edp-1.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@kms_cursor_legacy@basic-flip-before-cursor@atomic-transitions-varying-size:
- {fi-jsl-1}: [PASS][7] -> [DMESG-WARN][8] +4 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/fi-jsl-1/igt@kms_cursor_legacy@basic-flip-before-cursor@atomic-transitions-varying-size.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v2/fi-jsl-1/igt@kms_cursor_legacy@basic-flip-before-cursor@atomic-transitions-varying-size.html
- {fi-ehl-2}: [PASS][9] -> [DMESG-WARN][10] +4 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/fi-ehl-2/igt@kms_cursor_legacy@basic-flip-before-cursor@atomic-transitions-varying-size.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v2/fi-ehl-2/igt@kms_cursor_legacy@basic-flip-before-cursor@atomic-transitions-varying-size.html
Known issues
------------
Here are the changes found in Patchwork_106883v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@core_hotunplug@unbind-rebind:
- fi-icl-u2: NOTRUN -> [DMESG-WARN][11] ([i915#402] / [i915#6020])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v2/fi-icl-u2/igt@core_hotunplug@unbind-rebind.html
* igt@gem_lmem_swapping@random-engines:
- fi-icl-u2: NOTRUN -> [SKIP][12] ([i915#4613]) +3 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v2/fi-icl-u2/igt@gem_lmem_swapping@random-engines.html
* igt@i915_module_load@reload:
- fi-icl-u2: NOTRUN -> [DMESG-WARN][13] ([i915#402]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v2/fi-icl-u2/igt@i915_module_load@reload.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-bdw-5557u: [PASS][14] -> [INCOMPLETE][15] ([i915#146])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/fi-bdw-5557u/igt@i915_suspend@basic-s3-without-i915.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v2/fi-bdw-5557u/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-hsw-g3258: NOTRUN -> [SKIP][16] ([fdo#109271] / [fdo#111827])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v2/fi-hsw-g3258/igt@kms_chamelium@common-hpd-after-suspend.html
- fi-icl-u2: NOTRUN -> [SKIP][17] ([fdo#111827])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v2/fi-icl-u2/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_cursor_legacy@basic-flip-before-cursor@toggle:
- fi-icl-u2: [PASS][18] -> [DMESG-WARN][19] ([i915#402]) +36 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-before-cursor@toggle.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v2/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-before-cursor@toggle.html
* igt@prime_vgem@basic-userptr:
- fi-icl-u2: NOTRUN -> [SKIP][20] ([fdo#109295] / [i915#3301])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v2/fi-icl-u2/igt@prime_vgem@basic-userptr.html
#### Possible fixes ####
* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [DMESG-FAIL][21] ([i915#5334]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v2/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@hangcheck:
- fi-adl-ddr5: [DMESG-WARN][23] ([i915#5591]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/fi-adl-ddr5/igt@i915_selftest@live@hangcheck.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v2/fi-adl-ddr5/igt@i915_selftest@live@hangcheck.html
- fi-hsw-g3258: [INCOMPLETE][25] ([i915#3303] / [i915#4785]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/fi-hsw-g3258/igt@i915_selftest@live@hangcheck.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v2/fi-hsw-g3258/igt@i915_selftest@live@hangcheck.html
#### Warnings ####
* igt@i915_pm_rpm@basic-rte:
- fi-icl-u2: [DMESG-WARN][27] ([i915#4890]) -> [DMESG-WARN][28] ([i915#402])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12332/fi-icl-u2/igt@i915_pm_rpm@basic-rte.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v2/fi-icl-u2/igt@i915_pm_rpm@basic-rte.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4890]: https://gitlab.freedesktop.org/drm/intel/issues/4890
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5591]: https://gitlab.freedesktop.org/drm/intel/issues/5591
[i915#6020]: https://gitlab.freedesktop.org/drm/intel/issues/6020
Build changes
-------------
* Linux: CI_DRM_12332 -> Patchwork_106883v2
CI-20190529: 20190529
CI_DRM_12332: 601b2ef606e4b83d5518aa6a5011bb2b1c5954d9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7038: 5389b3f3b9b75df6bd8506e4aa3da357fd0c0ab1 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_106883v2: 601b2ef606e4b83d5518aa6a5011bb2b1c5954d9 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
32a48b44ff04 drm/i915/display: clear plane color control register when turn plane off
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_106883v2/index.html
[-- Attachment #2: Type: text/html, Size: 10153 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-11-02 18:50 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-01 15:16 [Intel-gfx] [PATCH] drm/i915/display: clear plane color control register when turn plane off Lee Shawn C
2022-08-01 21:27 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2022-08-31 12:33 ` [Intel-gfx] [PATCH] " Ville Syrjälä
2022-08-31 13:27 ` Lee, Shawn C
2022-08-31 13:43 ` Ville Syrjälä
2022-11-02 18:28 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for drm/i915/display: clear plane color control register when turn plane off (rev2) Patchwork
2022-11-02 18:50 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.