[PATCH v2] comedi: sysfs: convert sysfs snprintf to sysfs_emit

[PATCH v2] comedi: sysfs: convert sysfs snprintf to sysfs_emit

[Xuezhi Zhang]

From: zhangxuezhi1 <zhangxuezhi1@coolpad.com>

Fix up all sysfs show entries to use sysfs_emit

Signed-off-by: Xuezhi Zhang <zhangxuezhi1@coolpad.com>
---
v2: use a proper name for the Signed-off-by line.
---
 drivers/comedi/comedi_fops.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/comedi/comedi_fops.c b/drivers/comedi/comedi_fops.c
index 55a0cae04b8d..e2114bcf815a 100644
--- a/drivers/comedi/comedi_fops.c
+++ b/drivers/comedi/comedi_fops.c
@@ -396,7 +396,7 @@ static ssize_t max_read_buffer_kb_show(struct device *csdev,
 	mutex_unlock(&dev->mutex);
 
 	comedi_dev_put(dev);
-	return snprintf(buf, PAGE_SIZE, "%u\n", size);
+	return sysfs_emit(buf, "%u\n", size);
 }
 
 static ssize_t max_read_buffer_kb_store(struct device *csdev,
@@ -452,7 +452,7 @@ static ssize_t read_buffer_kb_show(struct device *csdev,
 	mutex_unlock(&dev->mutex);
 
 	comedi_dev_put(dev);
-	return snprintf(buf, PAGE_SIZE, "%u\n", size);
+	return sysfs_emit(buf, "%u\n", size);
 }
 
 static ssize_t read_buffer_kb_store(struct device *csdev,
@@ -509,7 +509,7 @@ static ssize_t max_write_buffer_kb_show(struct device *csdev,
 	mutex_unlock(&dev->mutex);
 
 	comedi_dev_put(dev);
-	return snprintf(buf, PAGE_SIZE, "%u\n", size);
+	return sysfs_emit(buf, "%u\n", size);
 }
 
 static ssize_t max_write_buffer_kb_store(struct device *csdev,
@@ -565,7 +565,7 @@ static ssize_t write_buffer_kb_show(struct device *csdev,
 	mutex_unlock(&dev->mutex);
 
 	comedi_dev_put(dev);
-	return snprintf(buf, PAGE_SIZE, "%u\n", size);
+	return sysfs_emit(buf, "%u\n", size);
 }
 
 static ssize_t write_buffer_kb_store(struct device *csdev,
-- 
2.25.1

Re: [PATCH v2] comedi: sysfs: convert sysfs snprintf to sysfs_emit

[Ian Abbott]

On 31/08/2022 13:55, Xuezhi Zhang wrote:
> From: zhangxuezhi1 <zhangxuezhi1@coolpad.com>
> 
> Fix up all sysfs show entries to use sysfs_emit
> 
> Signed-off-by: Xuezhi Zhang <zhangxuezhi1@coolpad.com>
> ---
> v2: use a proper name for the Signed-off-by line.
> ---
>   drivers/comedi/comedi_fops.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/comedi/comedi_fops.c b/drivers/comedi/comedi_fops.c
> index 55a0cae04b8d..e2114bcf815a 100644
> --- a/drivers/comedi/comedi_fops.c
> +++ b/drivers/comedi/comedi_fops.c
> @@ -396,7 +396,7 @@ static ssize_t max_read_buffer_kb_show(struct device *csdev,
>   	mutex_unlock(&dev->mutex);
>   
>   	comedi_dev_put(dev);
> -	return snprintf(buf, PAGE_SIZE, "%u\n", size);
> +	return sysfs_emit(buf, "%u\n", size);
>   }
>   
>   static ssize_t max_read_buffer_kb_store(struct device *csdev,
> @@ -452,7 +452,7 @@ static ssize_t read_buffer_kb_show(struct device *csdev,
>   	mutex_unlock(&dev->mutex);
>   
>   	comedi_dev_put(dev);
> -	return snprintf(buf, PAGE_SIZE, "%u\n", size);
> +	return sysfs_emit(buf, "%u\n", size);
>   }
>   
>   static ssize_t read_buffer_kb_store(struct device *csdev,
> @@ -509,7 +509,7 @@ static ssize_t max_write_buffer_kb_show(struct device *csdev,
>   	mutex_unlock(&dev->mutex);
>   
>   	comedi_dev_put(dev);
> -	return snprintf(buf, PAGE_SIZE, "%u\n", size);
> +	return sysfs_emit(buf, "%u\n", size);
>   }
>   
>   static ssize_t max_write_buffer_kb_store(struct device *csdev,
> @@ -565,7 +565,7 @@ static ssize_t write_buffer_kb_show(struct device *csdev,
>   	mutex_unlock(&dev->mutex);
>   
>   	comedi_dev_put(dev);
> -	return snprintf(buf, PAGE_SIZE, "%u\n", size);
> +	return sysfs_emit(buf, "%u\n", size);
>   }
>   
>   static ssize_t write_buffer_kb_store(struct device *csdev,

Looks good, thanks!

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

-- 
-=( Ian Abbott <abbotti@mev.co.uk> || MEV Ltd. is a company  )=-
-=( registered in England & Wales.  Regd. number: 02862268.  )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-

Re: [PATCH v2] comedi: sysfs: convert sysfs snprintf to sysfs_emit

[Greg KH]

On Wed, Aug 31, 2022 at 08:55:20PM +0800, Xuezhi Zhang wrote:
> From: zhangxuezhi1 <zhangxuezhi1@coolpad.com>
> 
> Fix up all sysfs show entries to use sysfs_emit

This says "what", but not "why".

Please read the kernel documentation for how to write a good changelog
text.

> 
> Signed-off-by: Xuezhi Zhang <zhangxuezhi1@coolpad.com>
> ---
> v2: use a proper name for the Signed-off-by line.

Does not match the From: line :(


thanks,

greg k-h

Re: [PATCH v2] comedi: sysfs: convert sysfs snprintf to sysfs_emit

[zhangxuezhi3]

On Wed, 31 Aug 2022 16:02:11 +0200
Greg KH <gregkh@linuxfoundation.org> wrote:

> On Wed, Aug 31, 2022 at 08:55:20PM +0800, Xuezhi Zhang wrote:
> > From: zhangxuezhi1 <zhangxuezhi1@coolpad.com>
> > 
> > Fix up all sysfs show entries to use sysfs_emit  
> 
> This says "what", but not "why".
> 
> Please read the kernel documentation for how to write a good changelog
> text.
> 
> > 
> > Signed-off-by: Xuezhi Zhang <zhangxuezhi1@coolpad.com>
> > ---
> > v2: use a proper name for the Signed-off-by line.  
> 
> Does not match the From: line :(
> 
> 
> thanks,
> 
> greg k-h

OK, I see.

Thanks.