* [PATCH] regulator: core: Remove "ramp_delay not set" debug message
@ 2022-08-20 12:24 Christian Kohlschütter
2022-08-20 13:14 ` [PATCH v2] " Christian Kohlschütter
2022-08-22 15:45 ` [PATCH] " Matthias Kaehlcke
0 siblings, 2 replies; 3+ messages in thread
From: Christian Kohlschütter @ 2022-08-20 12:24 UTC (permalink / raw)
To: Matthias Kaehlcke, Liam Girdwood, Mark Brown
Cc: Christian Kohlschütter, linux-kernel
This message shows up occasionally but in bursts (seen as up 30 times
per second on my ODROID N2+).
According to Matthias Kaehlcke's comment in 'regulator: core: silence
warning: "VDD1: ramp_delay not set"', this message should have been
removed after restructuring previous code that assumed that ramp_delay
being zero in that function was an error.
Link: https://lore.kernel.org/lkml/625675256c0d75805f088b4be17a3308dc1b7ea4.1477571498.git.hns@goldelico.com/T/
Signed-off-by: Christian Kohlschütter <christian@kohlschutter.com>
---
drivers/regulator/core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index a5033c6ba01..18fa9206ec2 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -3497,10 +3497,8 @@ static int _regulator_set_voltage_time(struct regulator_dev *rdev,
(new_uV < old_uV))
return rdev->constraints->settling_time_down;
- if (ramp_delay == 0) {
- rdev_dbg(rdev, "ramp_delay not set\n");
+ if (ramp_delay == 0)
return 0;
- }
return DIV_ROUND_UP(abs(new_uV - old_uV), ramp_delay);
}
--
2.36.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2] regulator: core: Remove "ramp_delay not set" debug message
2022-08-20 12:24 [PATCH] regulator: core: Remove "ramp_delay not set" debug message Christian Kohlschütter
@ 2022-08-20 13:14 ` Christian Kohlschütter
2022-08-22 15:45 ` [PATCH] " Matthias Kaehlcke
1 sibling, 0 replies; 3+ messages in thread
From: Christian Kohlschütter @ 2022-08-20 13:14 UTC (permalink / raw)
To: christian; +Cc: broonie, lgirdwood, linux-kernel, mka
This message shows up occasionally but in bursts (seen up to 30 times
per second on my ODROID N2+).
According to Matthias Kaehlcke's comment in 'regulator: core: silence
warning: "VDD1: ramp_delay not set"', this message should have been
removed after restructuring previous code that assumed that ramp_delay
being zero in that function was an error.
Link: https://lore.kernel.org/lkml/625675256c0d75805f088b4be17a3308dc1b7ea4.1477571498.git.hns@goldelico.com/T/
Signed-off-by: Christian Kohlschütter <christian@kohlschutter.com>
---
drivers/regulator/core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index a5033c6ba01..18fa9206ec2 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -3497,10 +3497,8 @@ static int _regulator_set_voltage_time(struct regulator_dev *rdev,
(new_uV < old_uV))
return rdev->constraints->settling_time_down;
- if (ramp_delay == 0) {
- rdev_dbg(rdev, "ramp_delay not set\n");
+ if (ramp_delay == 0)
return 0;
- }
return DIV_ROUND_UP(abs(new_uV - old_uV), ramp_delay);
}
--
2.36.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: core: Remove "ramp_delay not set" debug message
2022-08-20 12:24 [PATCH] regulator: core: Remove "ramp_delay not set" debug message Christian Kohlschütter
2022-08-20 13:14 ` [PATCH v2] " Christian Kohlschütter
@ 2022-08-22 15:45 ` Matthias Kaehlcke
1 sibling, 0 replies; 3+ messages in thread
From: Matthias Kaehlcke @ 2022-08-22 15:45 UTC (permalink / raw)
To: Christian Kohlschütter; +Cc: Liam Girdwood, Mark Brown, linux-kernel
On Sat, Aug 20, 2022 at 12:24:54PM +0000, Christian Kohlschütter wrote:
> This message shows up occasionally but in bursts (seen as up 30 times
> per second on my ODROID N2+).
>
> According to Matthias Kaehlcke's comment in 'regulator: core: silence
> warning: "VDD1: ramp_delay not set"', this message should have been
> removed after restructuring previous code that assumed that ramp_delay
> being zero in that function was an error.
>
> Link: https://lore.kernel.org/lkml/625675256c0d75805f088b4be17a3308dc1b7ea4.1477571498.git.hns@goldelico.com/T/
> Signed-off-by: Christian Kohlschütter <christian@kohlschutter.com>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-22 15:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-20 12:24 [PATCH] regulator: core: Remove "ramp_delay not set" debug message Christian Kohlschütter
2022-08-20 13:14 ` [PATCH v2] " Christian Kohlschütter
2022-08-22 15:45 ` [PATCH] " Matthias Kaehlcke
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.