From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: alsa-devel@alsa-project.org, Vinod Koul <vkoul@kernel.org>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Sanyog Kale <sanyog.r.kale@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/6] sysfs: do not create empty directories if no attributes are present
Date: Wed, 24 Aug 2022 17:22:37 +0200 [thread overview]
Message-ID: <YwZCPdPl2T+ndzjU@kroah.com> (raw)
In-Reply-To: <fb3a66c6-a8b3-02db-4170-5d5c521165e2@linux.intel.com>
On Wed, Aug 24, 2022 at 05:17:44PM +0200, Pierre-Louis Bossart wrote:
>
>
> On 8/24/22 15:59, Greg Kroah-Hartman wrote:
> > When creating an attribute group, if it is named a subdirectory is
> > created and the sysfs files are placed into that subdirectory. If no
> > files are created, normally the directory would still be present, but it
> > would be empty. Clean this up by removing the directory if no files
> > were successfully created in the group at all.
> >
> > Cc: Vinod Koul <vkoul@kernel.org>
> > Cc: Bard Liao <yung-chuan.liao@linux.intel.com>
> > Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> > Cc: Sanyog Kale <sanyog.r.kale@intel.com>
> > Cc: alsa-devel@alsa-project.org
> > Cc: linux-kernel@vger.kernel.org
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > ---
> > v2: new patch
> >
> > Note, totally untested! The following soundwire patches will need this,
> > if a soundwire developer could test this out, it would be most
> > apreciated.
>
> Not able to see the kernel boot with this first patch. The device is
> stuck with the cursor not even blinking. It seems our CI test devices
> are also stuck.
>
> This is completely beyond my comfort zone but I can run more tests to
> root cause this.
Ick, ok, so much for sending out untested patches :(
I'll test and debug this tomorrow and resend a correct version, thanks
for helping out here, sorry it didn't work.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Sanyog Kale <sanyog.r.kale@intel.com>,
alsa-devel@alsa-project.org,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Vinod Koul <vkoul@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/6] sysfs: do not create empty directories if no attributes are present
Date: Wed, 24 Aug 2022 17:22:37 +0200 [thread overview]
Message-ID: <YwZCPdPl2T+ndzjU@kroah.com> (raw)
In-Reply-To: <fb3a66c6-a8b3-02db-4170-5d5c521165e2@linux.intel.com>
On Wed, Aug 24, 2022 at 05:17:44PM +0200, Pierre-Louis Bossart wrote:
>
>
> On 8/24/22 15:59, Greg Kroah-Hartman wrote:
> > When creating an attribute group, if it is named a subdirectory is
> > created and the sysfs files are placed into that subdirectory. If no
> > files are created, normally the directory would still be present, but it
> > would be empty. Clean this up by removing the directory if no files
> > were successfully created in the group at all.
> >
> > Cc: Vinod Koul <vkoul@kernel.org>
> > Cc: Bard Liao <yung-chuan.liao@linux.intel.com>
> > Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> > Cc: Sanyog Kale <sanyog.r.kale@intel.com>
> > Cc: alsa-devel@alsa-project.org
> > Cc: linux-kernel@vger.kernel.org
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > ---
> > v2: new patch
> >
> > Note, totally untested! The following soundwire patches will need this,
> > if a soundwire developer could test this out, it would be most
> > apreciated.
>
> Not able to see the kernel boot with this first patch. The device is
> stuck with the cursor not even blinking. It seems our CI test devices
> are also stuck.
>
> This is completely beyond my comfort zone but I can run more tests to
> root cause this.
Ick, ok, so much for sending out untested patches :(
I'll test and debug this tomorrow and resend a correct version, thanks
for helping out here, sorry it didn't work.
greg k-h
next prev parent reply other threads:[~2022-08-24 15:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 13:59 [PATCH v2 1/6] sysfs: do not create empty directories if no attributes are present Greg Kroah-Hartman
2022-08-24 13:59 ` Greg Kroah-Hartman
2022-08-24 13:59 ` [PATCH v2 2/6] soundwire: sysfs: move sdw_slave_dev_attr_group into the existing list of groups Greg Kroah-Hartman
2022-08-24 13:59 ` Greg Kroah-Hartman
2022-08-24 13:59 ` [PATCH v2 3/6] soundwire: sysfs: cleanup the logic for creating the dp0 sysfs attributes Greg Kroah-Hartman
2022-08-24 13:59 ` Greg Kroah-Hartman
2022-08-24 13:59 ` [PATCH v2 4/6] soundwire: sysfs: have the driver core handle the creation of the device groups Greg Kroah-Hartman
2022-08-24 13:59 ` Greg Kroah-Hartman
2022-08-24 13:59 ` [PATCH v2 5/6] soundwire: sysfs: remove sdw_slave_sysfs_init() Greg Kroah-Hartman
2022-08-24 13:59 ` Greg Kroah-Hartman
2022-08-24 13:59 ` [PATCH v2 6/6] soundwire: sysfs: remove unneeded ATTRIBUTE_GROUPS() comments Greg Kroah-Hartman
2022-08-24 13:59 ` Greg Kroah-Hartman
2022-08-24 15:17 ` [PATCH v2 1/6] sysfs: do not create empty directories if no attributes are present Pierre-Louis Bossart
2022-08-24 15:22 ` Greg Kroah-Hartman [this message]
2022-08-24 15:22 ` Greg Kroah-Hartman
2022-08-25 7:52 ` Greg Kroah-Hartman
2022-08-25 7:52 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwZCPdPl2T+ndzjU@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.