From: "Russell King (Oracle)" <linux@armlinux.org.uk> To: Andy Shevchenko <andy.shevchenko@gmail.com> Cc: Arnd Bergmann <arnd@arndb.de>, Lee Jones <lee@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, Alyssa Rosenzweig <alyssa@rosenzweig.io>, asahi@lists.linux.dev, Bartosz Golaszewski <brgl@bgdev.pl>, Hector Martin <marcan@marcan.st>, linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>, Sven Peter <sven@svenpeter.dev> Subject: Re: [PATCH 5/6] gpio: Add new gpio-macsmc driver for Apple Macs Date: Fri, 2 Sep 2022 12:32:56 +0100 [thread overview] Message-ID: <YxHp6CNhlQ5Hx1m8@shell.armlinux.org.uk> (raw) In-Reply-To: <CAHp75VeO3gxypRTUc9Subvh+NZ7X4_RR=eFUZpPNwBeWk+_ipg@mail.gmail.com> On Fri, Sep 02, 2022 at 01:37:14PM +0300, Andy Shevchenko wrote: > On Fri, Sep 2, 2022 at 1:05 PM Russell King (Oracle) > <linux@armlinux.org.uk> wrote: > > On Thu, Sep 01, 2022 at 09:55:23PM +0300, Andy Shevchenko wrote: > > > > +static int macsmc_gpio_nr(smc_key key) > > > > +{ > > > > + int low = hex_to_bin(key & 0xff); > > > > + int high = hex_to_bin((key >> 8) & 0xff); > > > > + > > > > + if (low < 0 || high < 0) > > > > + return -1; > > > > + > > > > + return low | (high << 4); > > > > +} > > > > > > NIH hex2bin(). > > > > Is using hex2bin really better? > > Yes. > > > static int macsmc_gpio_nr(smc_key key) > > { > > char k[2]; > > u8 result; > > int ret; > > > > k[0] = key; > > k[1] = key >> 8; > > > > ret = hex2bin(&result, k, 2); > > if (ret < 0) > > return ret; > > > > return result; > > } > > > > This looks to me like it consumes more CPU cycles - because we have to > > write each "character" to the stack, then call a function, only to then > > call the hex_to_bin() function. One can't just pass "key" into hex2bin > > because that will bring with it endian issues. > > With one detail missed, why do you need all that if you can use > byteorder helpers()? What's the stack? Just replace this entire > function with the respectful calls to hex2bin(). Sorry, I don't understand what you're suggesting, because it doesn't make sense to me. The byteorder helpers do not give a char array, which is what hex2bin() wants, so we end up with something like: __le16 foo = cpu_to_le16(key); u8 result; ret = hex2bin(&result, (char *)&foo, 1); if (ret < 0) return ret; return result; This to me looks like yucky code, It still results in "foo" having to be on the stack, because the out-of-line hex2bin() requires a pointer to be passed as the second argument. Maybe you could provide an example of what you're thinking of, because I'm at a loss to understand what you're thinking this should look like. > > > > + /* First try reading the explicit pin mode register */ > > > > + ret = apple_smc_rw_u32(smcgp->smc, key, CMD_PINMODE, &val); > > > > + if (!ret) > > > > + return (val & MODE_OUTPUT) ? GPIO_LINE_DIRECTION_OUT : GPIO_LINE_DIRECTION_IN; > > > > + > > > > + /* > > > > + * Less common IRQ configs cause CMD_PINMODE to fail, and so does open drain mode. > > > > + * Fall back to reading IRQ mode, which will only succeed for inputs. > > > > + */ > > > > + ret = apple_smc_rw_u32(smcgp->smc, key, CMD_IRQ_MODE, &val); > > > > + return (!ret) ? GPIO_LINE_DIRECTION_IN : GPIO_LINE_DIRECTION_OUT; > > > > > > What is the meaning of val in this case? > > > > Reading the comment, it seems that "val" is irrelevant. I'm not sure that > > needs explaining given there's a comment that's already explaining what > > is going on here. > > OK. > Just convert then (!ret) --> ret. Already done, thanks. > > > > + pdev->dev.of_node = of_get_child_by_name(pdev->dev.parent->of_node, "gpio"); > > > > > > Can we use fwnode APIs instead? > > > Or do you really need this? > > > > Ouch, that's not nice. I can change this to: > > (Some background on why my eye caught this. We as GPIO SIG in the > kernel want to move the library to be fwnode one without looking into > the underneath property provider. This kind of lines makes driver look > a bit ugly from that perspective) I agree, I'd prefer it not to be there. > > fwnode = device_get_named_child_node(pdev->dev.parent, "gpio"); > > device_set_node(&pdev->dev, fwnode); > > > > but even that isn't _that_ nice. I'd like to hear comments from the Asahi > > folk about whether these sub-blocks of the SMC can have compatibles, so > > that the MFD layer can automatically fill in the firmware nodes on the > > struct device before the probe function gets called. > > > If not, then I think it would be reasonable to have a discussion with > > Lee about extending MFD to be able to have mfd cells name a child, so > > that MFD can do the above instead of having it littered amongst drivers. > > MFD cells can be matched by compatible strings. Yes, that's what I meant in my preceeding paragraph above, but it needs involvement and decisions from the Asahi maintainers. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk> To: Andy Shevchenko <andy.shevchenko@gmail.com> Cc: Arnd Bergmann <arnd@arndb.de>, Lee Jones <lee@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, Alyssa Rosenzweig <alyssa@rosenzweig.io>, asahi@lists.linux.dev, Bartosz Golaszewski <brgl@bgdev.pl>, Hector Martin <marcan@marcan.st>, linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>, Sven Peter <sven@svenpeter.dev> Subject: Re: [PATCH 5/6] gpio: Add new gpio-macsmc driver for Apple Macs Date: Fri, 2 Sep 2022 12:32:56 +0100 [thread overview] Message-ID: <YxHp6CNhlQ5Hx1m8@shell.armlinux.org.uk> (raw) In-Reply-To: <CAHp75VeO3gxypRTUc9Subvh+NZ7X4_RR=eFUZpPNwBeWk+_ipg@mail.gmail.com> On Fri, Sep 02, 2022 at 01:37:14PM +0300, Andy Shevchenko wrote: > On Fri, Sep 2, 2022 at 1:05 PM Russell King (Oracle) > <linux@armlinux.org.uk> wrote: > > On Thu, Sep 01, 2022 at 09:55:23PM +0300, Andy Shevchenko wrote: > > > > +static int macsmc_gpio_nr(smc_key key) > > > > +{ > > > > + int low = hex_to_bin(key & 0xff); > > > > + int high = hex_to_bin((key >> 8) & 0xff); > > > > + > > > > + if (low < 0 || high < 0) > > > > + return -1; > > > > + > > > > + return low | (high << 4); > > > > +} > > > > > > NIH hex2bin(). > > > > Is using hex2bin really better? > > Yes. > > > static int macsmc_gpio_nr(smc_key key) > > { > > char k[2]; > > u8 result; > > int ret; > > > > k[0] = key; > > k[1] = key >> 8; > > > > ret = hex2bin(&result, k, 2); > > if (ret < 0) > > return ret; > > > > return result; > > } > > > > This looks to me like it consumes more CPU cycles - because we have to > > write each "character" to the stack, then call a function, only to then > > call the hex_to_bin() function. One can't just pass "key" into hex2bin > > because that will bring with it endian issues. > > With one detail missed, why do you need all that if you can use > byteorder helpers()? What's the stack? Just replace this entire > function with the respectful calls to hex2bin(). Sorry, I don't understand what you're suggesting, because it doesn't make sense to me. The byteorder helpers do not give a char array, which is what hex2bin() wants, so we end up with something like: __le16 foo = cpu_to_le16(key); u8 result; ret = hex2bin(&result, (char *)&foo, 1); if (ret < 0) return ret; return result; This to me looks like yucky code, It still results in "foo" having to be on the stack, because the out-of-line hex2bin() requires a pointer to be passed as the second argument. Maybe you could provide an example of what you're thinking of, because I'm at a loss to understand what you're thinking this should look like. > > > > + /* First try reading the explicit pin mode register */ > > > > + ret = apple_smc_rw_u32(smcgp->smc, key, CMD_PINMODE, &val); > > > > + if (!ret) > > > > + return (val & MODE_OUTPUT) ? GPIO_LINE_DIRECTION_OUT : GPIO_LINE_DIRECTION_IN; > > > > + > > > > + /* > > > > + * Less common IRQ configs cause CMD_PINMODE to fail, and so does open drain mode. > > > > + * Fall back to reading IRQ mode, which will only succeed for inputs. > > > > + */ > > > > + ret = apple_smc_rw_u32(smcgp->smc, key, CMD_IRQ_MODE, &val); > > > > + return (!ret) ? GPIO_LINE_DIRECTION_IN : GPIO_LINE_DIRECTION_OUT; > > > > > > What is the meaning of val in this case? > > > > Reading the comment, it seems that "val" is irrelevant. I'm not sure that > > needs explaining given there's a comment that's already explaining what > > is going on here. > > OK. > Just convert then (!ret) --> ret. Already done, thanks. > > > > + pdev->dev.of_node = of_get_child_by_name(pdev->dev.parent->of_node, "gpio"); > > > > > > Can we use fwnode APIs instead? > > > Or do you really need this? > > > > Ouch, that's not nice. I can change this to: > > (Some background on why my eye caught this. We as GPIO SIG in the > kernel want to move the library to be fwnode one without looking into > the underneath property provider. This kind of lines makes driver look > a bit ugly from that perspective) I agree, I'd prefer it not to be there. > > fwnode = device_get_named_child_node(pdev->dev.parent, "gpio"); > > device_set_node(&pdev->dev, fwnode); > > > > but even that isn't _that_ nice. I'd like to hear comments from the Asahi > > folk about whether these sub-blocks of the SMC can have compatibles, so > > that the MFD layer can automatically fill in the firmware nodes on the > > struct device before the probe function gets called. > > > If not, then I think it would be reasonable to have a discussion with > > Lee about extending MFD to be able to have mfd cells name a child, so > > that MFD can do the above instead of having it littered amongst drivers. > > MFD cells can be matched by compatible strings. Yes, that's what I meant in my preceeding paragraph above, but it needs involvement and decisions from the Asahi maintainers. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-02 11:33 UTC|newest] Thread overview: 342+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-09-01 13:54 [PATCH 0/6] Add Apple Mac System Management Controller GPIOs Russell King (Oracle) 2022-09-01 13:54 ` Russell King (Oracle) 2022-09-01 13:54 ` [PATCH 1/6] dt-bindings: mfd: add binding for Apple Mac System Management Controller Russell King (Oracle) 2022-09-01 13:54 ` Russell King (Oracle) 2022-09-01 15:06 ` Krzysztof Kozlowski 2022-09-01 15:06 ` Krzysztof Kozlowski 2022-09-01 15:12 ` Russell King (Oracle) 2022-09-01 15:12 ` Russell King (Oracle) 2022-09-01 15:15 ` Krzysztof Kozlowski 2022-09-01 15:15 ` Krzysztof Kozlowski 2022-09-01 15:24 ` Russell King (Oracle) 2022-09-01 15:24 ` Russell King (Oracle) 2022-09-01 15:45 ` Krzysztof Kozlowski 2022-09-01 15:45 ` Krzysztof Kozlowski 2022-09-01 15:56 ` Russell King (Oracle) 2022-09-01 15:56 ` Russell King (Oracle) 2022-09-01 16:25 ` Krzysztof Kozlowski 2022-09-01 16:25 ` Krzysztof Kozlowski 2022-09-01 16:47 ` Russell King (Oracle) 2022-09-01 16:47 ` Russell King (Oracle) 2022-09-01 22:33 ` Rob Herring 2022-09-01 22:33 ` Rob Herring 2022-09-02 15:06 ` Mark Kettenis 2022-09-02 15:06 ` Mark Kettenis 2022-09-02 17:28 ` Rob Herring 2022-09-02 17:28 ` Rob Herring 2022-09-05 10:24 ` Russell King (Oracle) 2022-09-05 10:24 ` Russell King (Oracle) 2022-09-06 9:04 ` Russell King (Oracle) 2022-09-06 9:04 ` Russell King (Oracle) 2022-09-06 9:31 ` Mark Kettenis 2022-09-06 9:31 ` Mark Kettenis 2022-09-06 11:22 ` Linus Walleij 2022-09-06 11:22 ` Linus Walleij 2022-09-06 11:36 ` Hector Martin 2022-09-06 11:36 ` Hector Martin 2022-09-06 11:57 ` Linus Walleij 2022-09-06 11:57 ` Linus Walleij 2022-09-06 13:28 ` Hector Martin 2022-09-06 13:28 ` Hector Martin 2022-09-06 13:43 ` Russell King (Oracle) 2022-09-06 13:43 ` Russell King (Oracle) 2022-09-06 13:53 ` Hector Martin 2022-09-06 13:53 ` Hector Martin 2022-09-06 14:25 ` Mark Kettenis 2022-09-06 14:25 ` Mark Kettenis 2022-09-06 14:54 ` Russell King (Oracle) 2022-09-06 14:54 ` Russell King (Oracle) 2022-09-06 15:38 ` Mark Kettenis 2022-09-06 15:38 ` Mark Kettenis 2022-09-06 15:55 ` Rob Herring 2022-09-06 15:55 ` Rob Herring 2022-09-06 13:46 ` Linus Walleij 2022-09-06 13:46 ` Linus Walleij 2022-09-06 15:34 ` Rob Herring 2022-09-06 15:34 ` Rob Herring 2022-09-06 16:10 ` Rob Herring 2022-09-06 16:10 ` Rob Herring 2022-09-06 17:00 ` Hector Martin 2022-09-06 17:00 ` Hector Martin 2022-09-06 17:35 ` Rob Herring 2022-09-06 17:35 ` Rob Herring 2022-09-06 17:40 ` Sven Peter 2022-09-06 17:40 ` Sven Peter 2022-09-06 18:38 ` Hector Martin 2022-09-06 18:38 ` Hector Martin 2022-09-07 9:39 ` Mark Kettenis 2022-09-07 9:39 ` Mark Kettenis 2022-09-01 22:26 ` Rob Herring 2022-09-01 22:26 ` Rob Herring 2022-09-02 14:49 ` Mark Kettenis 2022-09-02 14:49 ` Mark Kettenis 2022-09-02 17:04 ` Rob Herring 2022-09-02 17:04 ` Rob Herring 2022-09-01 19:14 ` Rob Herring 2022-09-01 19:14 ` Rob Herring 2022-09-01 13:54 ` [PATCH 2/6] dt-bindings: gpio: add binding for the GPIO block for Apple Mac SMC Russell King (Oracle) 2022-09-01 13:54 ` Russell King (Oracle) 2022-09-01 15:11 ` Krzysztof Kozlowski 2022-09-01 15:11 ` Krzysztof Kozlowski 2022-09-01 15:14 ` Russell King (Oracle) 2022-09-01 15:14 ` Russell King (Oracle) 2022-09-01 13:54 ` [PATCH 3/6] soc: apple: rtkit: Add apple_rtkit_poll Russell King 2022-09-01 13:54 ` Russell King 2022-09-01 17:00 ` Sven Peter 2022-09-01 17:00 ` Sven Peter 2022-09-01 17:25 ` Eric Curtin 2022-09-01 17:25 ` Eric Curtin 2022-09-01 13:54 ` [PATCH 4/6] platform/apple: Add new Apple Mac SMC driver Russell King 2022-09-01 13:54 ` Russell King 2022-09-01 17:50 ` Sven Peter 2022-09-01 17:50 ` Sven Peter 2022-09-05 10:55 ` Russell King (Oracle) 2022-09-05 10:55 ` Russell King (Oracle) 2022-09-05 16:53 ` Hector Martin 2022-09-05 16:53 ` Hector Martin 2022-09-01 19:26 ` Andy Shevchenko 2022-09-01 19:26 ` Andy Shevchenko 2022-09-02 6:45 ` Sven Peter 2022-09-02 6:45 ` Sven Peter 2022-09-05 14:45 ` Hector Martin 2022-09-05 14:45 ` Hector Martin 2022-09-05 15:00 ` Andy Shevchenko 2022-09-05 15:00 ` Andy Shevchenko 2022-09-08 10:58 ` Lee Jones 2022-09-08 10:58 ` Lee Jones 2022-09-08 11:28 ` Hector Martin 2022-09-08 11:28 ` Hector Martin 2022-09-08 12:31 ` Lee Jones 2022-09-08 12:31 ` Lee Jones 2022-09-08 12:58 ` Hector Martin 2022-09-08 12:58 ` Hector Martin 2022-09-08 13:29 ` Linus Walleij 2022-09-08 13:29 ` Linus Walleij 2022-09-08 13:36 ` Lee Jones 2022-09-08 13:36 ` Lee Jones 2022-09-08 13:58 ` Hector Martin 2022-09-08 13:58 ` Hector Martin 2022-09-09 7:50 ` Lee Jones 2022-09-09 7:50 ` Lee Jones 2022-09-12 10:03 ` Russell King (Oracle) 2022-09-12 10:03 ` Russell King (Oracle) 2022-09-12 10:55 ` Lee Jones 2022-09-12 10:55 ` Lee Jones 2022-10-28 15:36 ` Russell King (Oracle) 2022-10-28 15:36 ` Russell King (Oracle) 2022-10-31 8:46 ` Lee Jones 2022-10-31 8:46 ` Lee Jones 2022-10-31 9:03 ` Hector Martin 2022-10-31 9:03 ` Hector Martin 2022-10-31 9:44 ` Russell King (Oracle) 2022-10-31 9:44 ` Russell King (Oracle) 2022-10-31 17:24 ` Lee Jones 2022-10-31 17:24 ` Lee Jones 2022-10-31 19:47 ` Russell King (Oracle) 2022-10-31 19:47 ` Russell King (Oracle) 2022-11-01 9:59 ` Lee Jones 2022-11-01 9:59 ` Lee Jones 2022-10-29 6:40 ` Hector Martin 2022-10-29 6:40 ` Hector Martin 2022-10-31 8:48 ` Lee Jones 2022-10-31 8:48 ` Lee Jones 2022-10-31 8:58 ` Hector Martin 2022-10-31 8:58 ` Hector Martin 2022-10-31 9:29 ` Lee Jones 2022-10-31 9:29 ` Lee Jones 2022-10-31 9:44 ` Hector Martin 2022-10-31 9:44 ` Hector Martin 2022-10-31 17:23 ` Lee Jones 2022-10-31 17:23 ` Lee Jones 2022-10-31 19:34 ` Russell King (Oracle) 2022-10-31 19:34 ` Russell King (Oracle) 2022-11-02 13:12 ` Lee Jones 2022-11-02 13:12 ` Lee Jones 2022-11-02 15:54 ` Russell King (Oracle) 2022-11-02 15:54 ` Russell King (Oracle) 2022-09-01 13:54 ` [PATCH 5/6] gpio: Add new gpio-macsmc driver for Apple Macs Russell King 2022-09-01 13:54 ` Russell King 2022-09-01 18:55 ` Andy Shevchenko 2022-09-01 18:55 ` Andy Shevchenko 2022-09-01 21:51 ` Martin Povišer 2022-09-01 21:51 ` Martin Povišer 2022-09-02 6:31 ` Andy Shevchenko 2022-09-02 6:31 ` Andy Shevchenko [not found] ` <3B649A66-8116-432D-B88A-B5CE493EF930@cutebit.org> [not found] ` <CAHp75VeB3_sZ2vsSxMSsLeJSkyemDh9iOPHXJCN1mhodA13LNQ@mail.gmail.com> 2022-09-02 11:12 ` Martin Povišer 2022-09-02 11:12 ` Martin Povišer 2022-09-02 13:33 ` Andy Shevchenko 2022-09-02 13:33 ` Andy Shevchenko 2022-09-02 13:36 ` Andy Shevchenko 2022-09-02 13:36 ` Andy Shevchenko 2022-09-02 13:37 ` Martin Povišer 2022-09-02 13:37 ` Martin Povišer 2022-09-02 14:41 ` Andy Shevchenko 2022-09-02 14:41 ` Andy Shevchenko 2022-09-02 14:45 ` Russell King (Oracle) 2022-09-02 14:45 ` Russell King (Oracle) 2022-09-02 10:05 ` Russell King (Oracle) 2022-09-02 10:05 ` Russell King (Oracle) 2022-09-02 10:37 ` Andy Shevchenko 2022-09-02 10:37 ` Andy Shevchenko 2022-09-02 11:32 ` Russell King (Oracle) [this message] 2022-09-02 11:32 ` Russell King (Oracle) 2022-09-02 13:39 ` Andy Shevchenko 2022-09-02 13:39 ` Andy Shevchenko 2022-09-02 14:46 ` Russell King (Oracle) 2022-09-02 14:46 ` Russell King (Oracle) 2022-09-02 14:53 ` Andy Shevchenko 2022-09-02 14:53 ` Andy Shevchenko 2022-09-02 15:34 ` Russell King (Oracle) 2022-09-02 15:34 ` Russell King (Oracle) 2022-09-02 15:43 ` Andy Shevchenko 2022-09-02 15:43 ` Andy Shevchenko 2022-09-05 10:20 ` Russell King (Oracle) 2022-09-05 10:20 ` Russell King (Oracle) 2022-09-05 10:32 ` Andy Shevchenko 2022-09-05 10:32 ` Andy Shevchenko 2022-09-05 13:10 ` Russell King (Oracle) 2022-09-05 13:10 ` Russell King (Oracle) 2022-09-05 13:16 ` Andy Shevchenko 2022-09-05 13:16 ` Andy Shevchenko 2022-09-05 14:01 ` Russell King (Oracle) 2022-09-05 14:01 ` Russell King (Oracle) 2022-09-05 14:02 ` Russell King (Oracle) 2022-09-05 14:02 ` Russell King (Oracle) 2022-09-05 14:42 ` Andy Shevchenko 2022-09-05 14:42 ` Andy Shevchenko 2022-09-05 14:53 ` Russell King (Oracle) 2022-09-05 14:53 ` Russell King (Oracle) 2022-09-05 14:50 ` Andy Shevchenko 2022-09-05 14:50 ` Andy Shevchenko 2022-09-05 15:52 ` Hector Martin 2022-09-05 15:52 ` Hector Martin 2022-09-05 15:56 ` Russell King (Oracle) 2022-09-05 15:56 ` Russell King (Oracle) 2022-09-05 15:32 ` Russell King (Oracle) 2022-09-05 15:32 ` Russell King (Oracle) 2022-09-05 15:44 ` Martin Povišer 2022-09-05 15:44 ` Martin Povišer 2022-09-05 15:58 ` Hector Martin 2022-09-05 15:58 ` Hector Martin 2022-09-05 16:13 ` Russell King (Oracle) 2022-09-05 16:13 ` Russell King (Oracle) 2022-09-05 19:10 ` Linus Walleij 2022-09-05 19:10 ` Linus Walleij 2022-09-06 6:51 ` Hector Martin 2022-09-06 6:51 ` Hector Martin 2022-09-05 15:47 ` Hector Martin 2022-09-05 15:47 ` Hector Martin 2022-09-05 15:39 ` Hector Martin 2022-09-05 15:39 ` Hector Martin 2022-09-05 15:16 ` Hector Martin 2022-09-05 15:16 ` Hector Martin 2022-09-05 15:04 ` Hector Martin 2022-09-05 15:04 ` Hector Martin 2022-09-02 9:42 ` Linus Walleij 2022-09-02 9:42 ` Linus Walleij 2022-09-01 13:54 ` [PATCH 6/6] gpio: macsmc: Add IRQ support Russell King 2022-09-01 13:54 ` Russell King 2022-09-01 18:03 ` Andy Shevchenko 2022-09-01 18:03 ` Andy Shevchenko 2022-09-05 11:54 ` Russell King (Oracle) 2022-09-05 11:54 ` Russell King (Oracle) [not found] ` <CAHp75VeDGCp8J6wnmCqGpV++vs2Zur9Mfp71Dk8dVXcuHFnCrQ@mail.gmail.com> 2022-09-05 13:21 ` Andy Shevchenko 2022-09-05 13:21 ` Andy Shevchenko 2022-09-02 13:21 ` Linus Walleij 2022-09-02 13:21 ` Linus Walleij 2022-09-05 12:47 ` Russell King (Oracle) 2022-09-05 12:47 ` Russell King (Oracle) 2022-09-05 13:19 ` Fwd: " Andy Shevchenko 2022-09-05 13:19 ` Andy Shevchenko 2022-09-05 21:43 ` Russell King (Oracle) 2022-09-05 21:43 ` Russell King (Oracle) 2022-09-05 13:27 ` Linus Walleij 2022-09-05 13:27 ` Linus Walleij 2022-09-06 7:00 ` Hector Martin 2022-09-06 7:00 ` Hector Martin 2022-09-06 7:47 ` Russell King (Oracle) 2022-09-06 7:47 ` Russell King (Oracle) 2022-09-06 8:00 ` Hector Martin 2022-09-06 8:00 ` Hector Martin 2022-09-01 15:12 ` [PATCH 0/6] Add Apple Mac System Management Controller GPIOs Krzysztof Kozlowski 2022-09-01 15:12 ` Krzysztof Kozlowski 2022-10-27 15:35 ` Russell King (Oracle) 2022-10-27 15:35 ` Russell King (Oracle) 2022-11-08 16:32 ` [PATCH v3 0/7] " Russell King (Oracle) 2022-11-08 16:32 ` Russell King (Oracle) 2022-11-08 16:33 ` [PATCH v3 1/7] mfd: Add core Apple Mac SMC driver Russell King 2022-11-08 16:33 ` Russell King 2022-11-14 9:52 ` Lee Jones 2022-11-14 9:52 ` Lee Jones 2022-11-14 10:35 ` Andy Shevchenko 2022-11-14 10:35 ` Andy Shevchenko 2022-11-08 16:33 ` [PATCH v3 2/7] lib/vsprintf: Add support for generic FOURCCs by extending %p4cc Russell King 2022-11-08 16:33 ` Russell King 2022-11-14 15:34 ` Petr Mladek 2022-11-14 15:34 ` Petr Mladek 2022-11-14 15:46 ` Andy Shevchenko 2022-11-14 15:46 ` Andy Shevchenko 2022-11-14 16:18 ` Petr Mladek 2022-11-14 16:18 ` Petr Mladek 2022-11-14 16:15 ` Russell King (Oracle) 2022-11-14 16:15 ` Russell King (Oracle) 2022-11-14 16:46 ` Russell King (Oracle) 2022-11-14 16:46 ` Russell King (Oracle) 2022-11-22 12:43 ` Petr Mladek 2022-11-22 12:43 ` Petr Mladek 2022-11-22 14:49 ` Petr Mladek 2022-11-22 14:49 ` Petr Mladek 2022-11-08 16:33 ` [PATCH v3 3/7] dt-bindings: mfd: add binding for Apple Mac System Management Controller Russell King (Oracle) 2022-11-08 16:33 ` Russell King (Oracle) 2022-11-08 20:42 ` Linus Walleij 2022-11-08 20:42 ` Linus Walleij 2022-11-08 20:55 ` Krzysztof Kozlowski 2022-11-08 20:55 ` Krzysztof Kozlowski 2022-11-08 22:22 ` Russell King (Oracle) 2022-11-08 22:22 ` Russell King (Oracle) 2022-11-09 8:35 ` Krzysztof Kozlowski 2022-11-09 8:35 ` Krzysztof Kozlowski 2022-11-09 22:17 ` Rob Herring 2022-11-09 22:17 ` Rob Herring 2022-11-10 11:35 ` Hector Martin 2022-11-10 11:35 ` Hector Martin 2022-11-10 11:48 ` Russell King (Oracle) 2022-11-10 11:48 ` Russell King (Oracle) 2022-11-10 14:00 ` Krzysztof Kozlowski 2022-11-10 14:00 ` Krzysztof Kozlowski 2022-11-10 14:14 ` Russell King (Oracle) 2022-11-10 14:14 ` Russell King (Oracle) 2022-11-10 14:21 ` Krzysztof Kozlowski 2022-11-10 14:21 ` Krzysztof Kozlowski 2022-11-10 14:23 ` Russell King (Oracle) 2022-11-10 14:23 ` Russell King (Oracle) 2022-11-10 14:36 ` Krzysztof Kozlowski 2022-11-10 14:36 ` Krzysztof Kozlowski 2022-11-10 14:43 ` Russell King (Oracle) 2022-11-10 14:43 ` Russell King (Oracle) 2022-11-14 10:05 ` Lee Jones 2022-11-14 10:05 ` Lee Jones 2022-11-08 22:30 ` Rob Herring 2022-11-08 22:30 ` Rob Herring 2022-11-08 16:33 ` [PATCH v3 4/7] platform/apple: Add new Apple Mac SMC driver Russell King 2022-11-08 16:33 ` Russell King 2022-11-08 16:33 ` [PATCH v3 5/7] arm64: dts: apple: Add SMC node to t8103 devicetrees Russell King 2022-11-08 16:33 ` Russell King 2022-11-08 16:33 ` [PATCH v3 6/7] dt-bindings: gpio: add binding for the GPIO block for Apple Mac SMC Russell King (Oracle) 2022-11-08 16:33 ` Russell King (Oracle) 2022-11-08 20:56 ` Krzysztof Kozlowski 2022-11-08 20:56 ` Krzysztof Kozlowski 2022-11-08 22:09 ` Russell King (Oracle) 2022-11-08 22:09 ` Russell King (Oracle) 2022-11-09 7:31 ` Hector Martin 2022-11-09 7:31 ` Hector Martin 2022-11-09 8:36 ` Krzysztof Kozlowski 2022-11-09 8:36 ` Krzysztof Kozlowski 2022-11-09 9:12 ` Russell King (Oracle) 2022-11-09 9:12 ` Russell King (Oracle) 2022-11-09 9:19 ` Krzysztof Kozlowski 2022-11-09 9:19 ` Krzysztof Kozlowski 2022-11-08 22:30 ` Rob Herring 2022-11-08 22:30 ` Rob Herring 2022-11-08 16:33 ` [PATCH v3 7/7] gpio: Add new gpio-macsmc driver for Apple Macs Russell King 2022-11-08 16:33 ` Russell King
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YxHp6CNhlQ5Hx1m8@shell.armlinux.org.uk \ --to=linux@armlinux.org.uk \ --cc=alyssa@rosenzweig.io \ --cc=andy.shevchenko@gmail.com \ --cc=arnd@arndb.de \ --cc=asahi@lists.linux.dev \ --cc=brgl@bgdev.pl \ --cc=lee@kernel.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=marcan@marcan.st \ --cc=sven@svenpeter.dev \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.